Wednesday, 2021-02-10

*** gmann_afk is now known as gmann00:19
*** shanemcd has quit IRC00:40
*** rlandy has quit IRC02:18
*** saneax has quit IRC04:25
*** ykarel has joined #zuul04:38
*** masterpe has quit IRC04:45
*** Eighth_Doctor has quit IRC04:47
*** mordred has quit IRC04:50
*** openstackstatus has quit IRC04:58
*** openstack has joined #zuul05:01
*** ChanServ sets mode: +o openstack05:01
*** mordred has joined #zuul05:19
*** Eighth_Doctor has joined #zuul05:23
*** evrardjp has quit IRC05:33
*** evrardjp has joined #zuul05:33
*** saneax has joined #zuul05:36
*** jfoufas1 has joined #zuul05:51
*** ykarel has quit IRC05:55
*** vishalmanchanda has joined #zuul06:12
*** ykarel has joined #zuul06:12
*** piotrowskim has joined #zuul06:56
*** jcapitao has joined #zuul07:41
*** rpittau|afk is now known as rpittau07:51
*** hashar has joined #zuul07:54
*** zbr|pto is now known as zbr08:35
*** jpena|off is now known as jpena08:57
*** tosky has joined #zuul09:12
*** ykarel is now known as ykarel|lunch09:34
*** hashar is now known as hasharLunch10:45
*** ykarel|lunch is now known as ykarel10:53
*** nils has joined #zuul11:18
*** hasharLunch has quit IRC11:19
*** ianychoi__ is now known as ianychoi11:30
*** hasharLunch has joined #zuul11:42
openstackgerritOleksandr Kozachenko proposed zuul/zuul-jobs master: Update upload-logs-swift and upload-logs-gcs  https://review.opendev.org/c/zuul/zuul-jobs/+/77465011:44
*** cloudnull has quit IRC12:02
*** jcapitao is now known as jcapitao_lunch12:04
*** cloudnull has joined #zuul12:05
*** rlandy has joined #zuul12:28
*** hasharLunch is now known as hashar12:29
*** harrymichal has joined #zuul12:29
*** jpena is now known as jpena|lunch12:36
harrymichalHey folks! I have, yet again, question about the "badge" API endpoint. On softwarefactory the endpoint is still not available (despite running an update version of zuul with the supposed fix for this). Could somebody, please, look into this?12:39
*** hashar is now known as hasharAway12:39
harrymichalWhen I try to access https://softwarefactory-project.io/zuul/api/tenant/local/badge?project=containers/toolbox&pipeline=periodic&branch=master, I only get 404 response from the server.12:40
harrymichalBut when I try to access e.g., https://softwarefactory-project.io/zuul/api/tenant/local/builds, I get a valid response, therefore the URL should not be bad...12:41
avassharrymichal: could it be that you need to urlencode the slash in 'containers/toolbox' ?12:49
*** iurygregory has quit IRC12:51
*** jcapitao_lunch is now known as jcapitao13:11
tristanCharrymichal: we haven't backported the badge api fix to the stable branch, it's only available in the master version (the change is https://softwarefactory-project.io/r/#/c/20718/4/zuul.spec )13:17
tristanCharrymichal: we are waiting for a new zuul release to update sf-project.io services13:18
*** ykarel_ has joined #zuul13:24
tristanCharrymichal: it should work now13:27
harrymichalavass: You have a point there but that did not solve it.13:27
harrymichaltristanC: Oh! Let me check then.13:27
*** ykarel has quit IRC13:27
harrymichaltristanC: It works! Thank you very much!13:28
*** jpena|lunch is now known as jpena13:33
*** ykarel_ is now known as ykarel13:40
*** newbie2020 has joined #zuul13:41
newbie2020Hi guys,13:46
newbie2020I am having an issue with a Zuul intallation I do not have direct control,13:46
newbie2020and the logs I have access to are of limited use.13:46
avassharrymichal: no I checked in our setup and it wasn't needed13:46
newbie2020From the Web UI Notification I get the following error:13:46
newbie2020foo - undefined (undefined)13:46
newbie2020Zuul encountered an error while accessing the repo foo.  The13:46
newbie2020error was:13:46
newbie2020  string indices must be integers13:46
newbie2020where foo is a project apparently correctly part of the tenant.13:46
newbie2020The error seems your typical Python error,13:46
newbie2020but just looking at the logs or at a copy of the13:46
newbie2020tenant configuration I received I cannot tell the problem13:46
newbie2020Do you have by any change an hunch on what could be the issue here?13:46
tristanCnewbie2020: perhaps an issue with the foo repo configuration, could you check its definition the tenant config and in zuul.yaml?13:51
mhuyep, this error message is returned when there's a configuration exception13:51
tristanC`undefined (undefined)` seems to indicate the source_context.path and source_context.branch are not defined13:53
funginewbie2020: i want to say i've seen that problem more generally when someone incorrectly puts a string in yaml where something like an associative array is expected13:53
fungimaybe left off a :13:54
*** cloudnull has quit IRC13:56
newbie2020Thank you guys! Those are good hints that I can start looking at13:59
*** cloudnull has joined #zuul13:59
*** ianychoi has quit IRC14:09
*** newbie2020 has quit IRC14:10
*** iurygregory has joined #zuul14:13
*** hasharAway has quit IRC14:15
*** harrymichal has quit IRC14:38
*** hasharAway has joined #zuul14:46
openstackgerritGomathi Selvi Srinivasan proposed zuul/zuul-jobs master: Create a template for ssh-key and size  https://review.opendev.org/c/zuul/zuul-jobs/+/77347414:49
*** hasharAway is now known as hashar14:54
openstackgerritGomathi Selvi Srinivasan proposed zuul/zuul-jobs master: Create a template for ssh-key and size  https://review.opendev.org/c/zuul/zuul-jobs/+/77347415:08
openstackgerritSorin Sbârnea proposed zuul/zuul-jobs master: Upgrade ansible-lint to 5.0  https://review.opendev.org/c/zuul/zuul-jobs/+/77324515:38
*** hashar is now known as hasharAway15:42
*** saneax has quit IRC15:43
*** ykarel is now known as ykarel|away15:54
*** harrymichal_ has joined #zuul16:05
*** harrymichal_ is now known as harrymichal16:07
openstackgerritOleksandr Kozachenko proposed zuul/zuul-jobs master: Update upload-logs-swift and upload-logs-gcs  https://review.opendev.org/c/zuul/zuul-jobs/+/77465016:08
*** harrymichal_ has joined #zuul16:10
*** harrymichal has quit IRC16:12
*** harrymichal_ is now known as harrymichal16:12
*** harrymichal has quit IRC16:15
*** ykarel|away has quit IRC16:17
*** ianw has quit IRC16:39
*** ianw has joined #zuul16:39
*** hasharAway has quit IRC16:47
*** hasharAway has joined #zuul16:49
openstackgerritOleksandr Kozachenko proposed zuul/zuul-jobs master: Update upload-logs-swift and upload-logs-gcs  https://review.opendev.org/c/zuul/zuul-jobs/+/77465017:15
openstackgerritOleksandr Kozachenko proposed zuul/zuul-jobs master: Update upload-logs-swift and upload-logs-gcs  https://review.opendev.org/c/zuul/zuul-jobs/+/77465017:35
*** nils has quit IRC17:50
*** piotrowskim has quit IRC17:54
*** hasharAway is now known as hashar18:00
*** jpena is now known as jpena|off18:01
*** saneax has joined #zuul18:13
*** jfoufas1 has quit IRC18:15
*** rpittau is now known as rpittau|afk18:23
*** jcapitao has quit IRC18:39
Open10K8SHi tobiash. Now the zuul-storage-proxy repo created https://opendev.org/zuul/zuul-storage-proxy. Is that ok to push your swift-proxy code in this repo?18:54
Open10K8Scorvus: tobiash: can you check https://review.opendev.org/c/zuul/zuul-jobs/+/774650 also? I changed according to your comments.18:55
openstackgerritTobias Henkel proposed zuul/zuul-storage-proxy master: Initial import of zuul storage proxy  https://review.opendev.org/c/zuul/zuul-storage-proxy/+/77494219:02
tobiashOpen10K8S: ^19:02
openstackgerritTobias Henkel proposed zuul/zuul-storage-proxy master: Initial import of zuul storage proxy  https://review.opendev.org/c/zuul/zuul-storage-proxy/+/77494219:03
Open10K8Stobiash: thank you19:08
openstackgerritTobias Henkel proposed zuul/zuul-storage-proxy master: Initial import of zuul storage proxy  https://review.opendev.org/c/zuul/zuul-storage-proxy/+/77494219:09
tobiashcorvus: is something left to do to make zuul act on this repo? ^19:11
corvuschecking19:13
fungiadd job configuration, yes19:13
fungiright now it's only been added to the tenant19:13
fungioh, or maybe your change already does that, looking19:14
tobiashfungi: the initial change adds that19:14
fungiyeah, i need to restart gertty ;)19:14
tobiashunless I don't have a typo in zuul.yaml19:14
fungioh!19:15
fungi"Last reconfigured: Wed, Feb 3, 2021 11:02 PM"19:15
fungii think our reconfig may not be triggering, or might just not have fired yet?19:15
tobiashah ok19:15
fungithat's a far more likely explanation anyway19:15
corvusjobs failed on https://review.opendev.org/77236419:15
tobiashoh, timeout in post jobs19:16
tobiashthat explains it19:16
fungioh, interesting, it was a timeout19:17
corvuslooking at log now19:18
corvus-> #opendev19:18
fungiPlaybook run took 0 days, 1 hours, 26 minutes, 14 seconds19:18
fungiomw ;)19:19
openstackgerritMonty Taylor proposed zuul/zuul-storage-proxy master: Use opendev base docker image and add jobs  https://review.opendev.org/c/zuul/zuul-storage-proxy/+/77499819:24
* mordred makes drive-by patch while eating lunch19:25
corvusfungi, tobiash, Open10K8S: i think manage-projects will eventually run in a cron, or at least for some other change; it might be best to just check back in later and see if it has updated19:26
corvusmordred: ++ thanks!19:27
fungiyes, we're under a bit of an incident in opendev (thanks for spotting this and raising it) but can do one of several things to make the zuul deployment/reconfig happen once it settles out19:28
openstackgerritTobias Henkel proposed zuul/zuul-storage-proxy master: Initial import of zuul storage proxy  https://review.opendev.org/c/zuul/zuul-storage-proxy/+/77494219:29
tobiashmordred: awesome :)19:31
openstackgerritJames E. Blair proposed zuul/zuul master: Use a full regex match on job implied branches  https://review.opendev.org/c/zuul/zuul/+/77456619:32
*** hashar has quit IRC19:33
tobiashcorvus: I have a (maybe) overlapping change in review: https://review.opendev.org/c/zuul/zuul/+/64027219:33
corvuslooking19:33
avassyep :)19:34
tobiashlooks like we even used the same variable names :)19:37
corvusyeah, only the test is different19:38
corvushah, there is a one-line ordering difference in model.py19:39
corvustobiash: i agree that your test validates the behavior, though it does it in a test for project-template branch matchers, which confuses the situation a little bit (mostly the test is focused on project-template implied branch matchers).  i could go either way on this -- we could merge my change, or i'd be happy to merge yours (which has the advantage of not adding a new test), but i think we should add some19:42
corvuscomments explaining clearly we're testing a second behavior19:42
corvusi'd be happy to write that comment if that's what we want to do19:42
tobiashcorvus: since yours is already in gate I'll abandon mine19:43
corvustobiash: you sure?  i'm totally able to be swayed by "have one less test" :)19:43
corvusi just failed to find the test that already had the substring issue in it when i wrote my change :)19:43
tobiashcorvus: I leave the decision to you which test you like better, I'm glad that this is finally fixed19:44
openstackgerritJames E. Blair proposed zuul/zuul master: Use implied branch matcher for implied branches  https://review.opendev.org/c/zuul/zuul/+/64027219:50
corvustobiash: ^ there's a comment that makes me happy.  i dug into the test fixtures to make sure it's testing the same thing, and i'm convinced it is.  i think we should go with that.19:50
tobiashthanks19:51
corvustristanC, mordred: ^ can you review 640272 which is nearly identical to https://review.opendev.org/774566 which you previously +2d ?19:51
corvus(and sorry, that's a rebase + comment change in one patchset; i cherry-picked it to run the tests locally)19:52
tobiashzuul reconfig happened and storage proxy jobs run now20:19
openstackgerritTobias Henkel proposed zuul/zuul-storage-proxy master: Use opendev base docker image and add jobs  https://review.opendev.org/c/zuul/zuul-storage-proxy/+/77499820:20
openstackgerritTobias Henkel proposed zuul/zuul-storage-proxy master: Use opendev base docker image and add jobs  https://review.opendev.org/c/zuul/zuul-storage-proxy/+/77499820:22
tobiashmordred: fixed small issue in your drive-by patch ^20:30
tobiashcorvus: there qre several retry limits in zuul's jobs: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_e8f/772602/3/gate/zuul-stream-functional-2.8/e8f735e/job-output.txt20:33
tobiashwe had the same issue installing cryptogrphy in our system20:34
tobiasholder pip don't use the abi3 wheels and use source installation which now needs a rust compiler20:34
openstackgerritTobias Henkel proposed zuul/zuul master: Upgrade pip before installing zuul  https://review.opendev.org/c/zuul/zuul/+/77501320:39
tobiashlet's see if this fixes the zuul-stream-functional jobs20:39
openstackgerritTobias Henkel proposed zuul/nodepool master: Upgrade pip before installing zuul  https://review.opendev.org/c/zuul/nodepool/+/77501720:44
tobiashcorvus: those two should fix the zuul gate, live logs show successful installation of cryptography ^20:55
tristanCtobiash: i guess we are now ok to depends on rust dependencies for zuul?21:11
tobiashtristanC: we can use the precompiled wheels21:12
tobiashtristanC: which depebdency do you have in mind?21:13
tobiash(despite cryptography)21:13
tristanCtobiash: the orjson library for example21:14
tobiashtristanC: if that has precompiled wheels I guess yes21:14
corvuslooks good to me; i think the main thing is it will preclude pypy, but i don't think there's a lot of interest in trying to get zuul to run in pypy21:15
tobiashcorvus: well, I spent some time since that promised to improve our main loop performance21:16
corvuscould really come in handy for the zk work, where we're (de)serializing json a lot21:16
tobiashbut pypy needs a reimplementation of the re2 wrapper using cffi21:17
tobiashbut ++ for a faster json lib, based on profiling a while ago nodepool could also be improved by a faster json lib21:18
corvustobiash: do you think pypy is worth keeping in mind?  i mean, we can try to minimize native dependencies; or we could look at making orjson optional in the same way that the c yaml lib is optional21:18
tobiashcorvus: I think currently the only blocker for pypy is re221:19
corvus(and maybe now cryptography?)21:19
tobiashso if we could get rid of this blocker at some time pypy still would be an option we could explore21:19
tobiashneed to check if/how cryptography is compatible with pypy21:20
corvusokay, so it's probably worth keeping that in mind -- if we can just use orjson as a drop-in replacement that keeps our options open21:20
corvusi think that should be easy, because our usage of json is pretty simple.21:21
tobiashthere is an open issue for cryptography on pypy: https://github.com/pyca/cryptography/issues/580621:22
tobiashhrm, according to that issue pypy works when having a rust compiler21:23
tobiashso that doesn't seem to be a problem other than needing the rust compiler at installation time21:23
tobiashbut orjson explicitly states that it's nit compatible to pypy21:24
tristanCtobiash: wheels are convenients when available, but it seems important to be able to build from source too21:25
tobiashtristanC: I guess build from source will always be possible giben a rust compiler, however I think we should require wheels to be available when adding new dependencies21:27
clarkbyes I think cryptography is expected to work with pypi you just need the build deps21:28
clarkb(no pypy wheels)21:28
tristanCtobiash: fair enough, it doesn't seem like we have much of a choice with cryptography, and i'm happy to see such language being used, but that is quite a change21:32
tobiashcorvus, tristanC: I just found a new re2 wrapper using pybind11 under the hood instead of native cpython bindings: https://pypi.org/project/google-re2/21:33
tobiashso that could enable exploration of pypy21:34
tobiashat least pybind11 claims compatibility with pypy21:34
corvustobiash: nice.  btw, i like pypy, but i'm worried that it could be risky and uncover new edge cases or otherwise not behave as well.  just a word of caution.  :)21:35
tobiashcorvus: I won't throw it straight into production :)21:35
tobiashbut I guess I'll see if it works in principal and if it does try it out in our staging env21:36
*** andy-ladjadj has joined #zuul21:39
*** andy-ladjadj has quit IRC21:40
*** andy-ladjadj has joined #zuul21:40
openstackgerritTobias Henkel proposed zuul/zuul master: DNM: Try out google-re2 instead of fb-re2  https://review.opendev.org/c/zuul/zuul/+/77502821:41
corvusgoogle vs fb: fight!21:41
tobiash:)21:41
tobiashthe package name seems to be the same so it might be just a matter of the dependency (and successful installation of it)21:42
openstackgerritTobias Henkel proposed zuul/zuul master: DNM: Try pypy  https://review.opendev.org/c/zuul/zuul/+/77502921:48
*** andy-ladjadj has quit IRC21:48
*** andy-ladjadj has joined #zuul21:48
*** andy-ladjadj has quit IRC21:50
*** jamesmcarthur has joined #zuul21:51
openstackgerritTobias Henkel proposed zuul/zuul master: DNM: Try out google-re2 instead of fb-re2  https://review.opendev.org/c/zuul/zuul/+/77502821:55
openstackgerritTobias Henkel proposed zuul/zuul master: DNM: Try pypy  https://review.opendev.org/c/zuul/zuul/+/77502921:55
tobiashmissing dep, fb won, next round21:55
*** andy-ladjadj has joined #zuul22:12
openstackgerritMerged zuul/zuul master: Upgrade pip before installing zuul  https://review.opendev.org/c/zuul/zuul/+/77501322:15
openstackgerritMerged zuul/zuul master: Use implied branch matcher for implied branches  https://review.opendev.org/c/zuul/zuul/+/64027222:21
corvusguillaumec: re https://review.opendev.org/771733 discussion from #openstack-infra -- we probably should have the version check for http then, but since zuul added support for http after that landed, it's unlikely anyone ran into a problem with it.22:22
corvusguillaumec: but it's still the case that if someone is running 2.12 with ssh, this could break them.22:23
corvusguillaumec: so in addition to the 2 options i left in review, how about a third option: we ask if anyone is using <2.13 and if no one replies, we merge it as is?  basically, find out what our minimum gerrit version is22:24
clarkbqualcomm has stated they are on 2.7 on the gerrit mailing list22:25
clarkbI have no idea if they use zuul, but there are definitely some old gerrit still out there22:25
corvusneat22:25
corvuswell, i'd like it if they did use zuul22:25
avasscorvus: I happen to know of people (not volvo) using gerrit <2.13 who has shown interest in zuul. but no clue if they will actually use it :)22:26
corvusguillaumec: how about we just add the version check in both places?22:26
guillaumeccorvus, was already doing it :)22:26
corvuscool :)22:26
*** andy-ladjadj has quit IRC22:36
*** jamesmcarthur has quit IRC22:41
*** jamesmcarthur has joined #zuul22:42
*** andy-ladjadj has joined #zuul22:43
*** andy-ladjadj has quit IRC22:44
*** jamesmcarthur has quit IRC22:44
*** jamesmcarthur has joined #zuul22:45
*** vishalmanchanda has quit IRC22:51
openstackgerritGuillaume Chauvel proposed zuul/zuul master: gerrit: Add gerrit version check for HTTP review tag  https://review.opendev.org/c/zuul/zuul/+/77503722:53
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Gerrit: Add SSH review tags  https://review.opendev.org/c/zuul/zuul/+/77173322:54
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Gerrit: Add SSH review tag  https://review.opendev.org/c/zuul/zuul/+/77173323:01
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Gerrit: Add gerrit version check for HTTP review tag  https://review.opendev.org/c/zuul/zuul/+/77503723:01
*** andy-ladjadj has joined #zuul23:04
*** andy-ladjadj has quit IRC23:07
corvusguillaumec: thanks!23:11
openstackgerritJames E. Blair proposed zuul/zuul master: Add spec for building Nodepool images in Zuul  https://review.opendev.org/c/zuul/zuul/+/77504223:12
*** rlandy has quit IRC23:30
openstackgerritMerged zuul/zuul master: Add waiting cause to status API  https://review.opendev.org/c/zuul/zuul/+/77321823:43
clarkbcorvus: iurygregory you approved the ssh change any reason to not approve https://review.opendev.org/c/zuul/zuul/+/775037 this http one?23:53

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!