*** harrymichal_ has quit IRC | 00:02 | |
*** jamesmcarthur has joined #zuul | 00:08 | |
*** jamesmcarthur has quit IRC | 00:12 | |
*** jamesmcarthur has joined #zuul | 00:12 | |
*** jamesmcarthur has quit IRC | 00:15 | |
*** tosky has quit IRC | 00:20 | |
*** jamesmcarthur has joined #zuul | 00:27 | |
*** jamesmcarthur has quit IRC | 00:27 | |
*** jamesmcarthur has joined #zuul | 00:40 | |
*** jamesmcarthur has quit IRC | 00:47 | |
*** jamesmcarthur has joined #zuul | 00:53 | |
fungi | anybody happen to know of a job which regularly produces a 10mb+ logfile? i've found builds like https://zuul.opendev.org/t/openstack/build/e27464d56af848d8919b05578e171a20 which produce 10mb+ job-output.json but the corresponding job-output.txt is a mere 600-700kb | 00:56 |
---|---|---|
*** Pilou has joined #zuul | 01:00 | |
*** jamesmcarthur has quit IRC | 01:02 | |
*** jamesmcarthur has joined #zuul | 01:04 | |
*** jamesmcarthur has quit IRC | 01:05 | |
*** jamesmcarthur has joined #zuul | 01:05 | |
openstackgerrit | Albin Vass proposed zuul/zuul master: Reset repo to previous head on .gitmodules error https://review.opendev.org/c/zuul/zuul/+/775334 | 01:11 |
avass | corvus: new idea, how about something like that ^ ? Should be better than deleting the repo but might need a try/except to delete the repo as a last resort. I'll look more at that tomorrow :) | 01:12 |
fungi | lest anyone need a large logfile for testing something, looks like the controller/logs/screen-q-l3.txt file from successful builds of the neutron-tempest-slow-py3 job in the openstack tenant is in the vicinity of 25mb | 01:31 |
*** jamesmcarthur has quit IRC | 01:35 | |
*** jamesmcarthur has joined #zuul | 01:41 | |
openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: web: add benchmark test for build output https://review.opendev.org/c/zuul/zuul/+/775468 | 01:45 |
*** jamesmcarthur has quit IRC | 01:47 | |
*** jamesmcarthur has joined #zuul | 01:48 | |
*** jamesmcarthur has quit IRC | 01:51 | |
openstackgerrit | James E. Blair proposed zuul/zuul master: Connect merger to Zookeeper https://review.opendev.org/c/zuul/zuul/+/775461 | 01:57 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Update component doc re ZooKeeper https://review.opendev.org/c/zuul/zuul/+/775462 | 01:57 |
*** jamesmcarthur has joined #zuul | 02:00 | |
*** jamesmcarthur has quit IRC | 02:06 | |
*** jamesmcarthur has joined #zuul | 02:19 | |
*** jamesmcarthur has quit IRC | 02:29 | |
*** paladox has quit IRC | 02:30 | |
*** jamesmcarthur has joined #zuul | 02:30 | |
*** paladox has joined #zuul | 02:30 | |
*** jamesmcarthur has quit IRC | 02:35 | |
*** jamesmcarthur has joined #zuul | 02:46 | |
*** jamesmcarthur has quit IRC | 02:55 | |
*** jamesmcarthur has joined #zuul | 03:00 | |
*** jamesmcarthur has quit IRC | 03:02 | |
*** jamesmcarthur has joined #zuul | 03:05 | |
*** jamesmcarthur has quit IRC | 03:11 | |
*** jamesmcarthur has joined #zuul | 03:15 | |
*** jamesmcarthur has quit IRC | 03:17 | |
*** jamesmcarthur has joined #zuul | 03:36 | |
*** jamesmcarthur has quit IRC | 03:41 | |
*** jamesmcarthur has joined #zuul | 03:44 | |
*** jamesmcarthur has quit IRC | 03:46 | |
*** jamesmcarthur has joined #zuul | 03:47 | |
*** jamesmcarthur has quit IRC | 03:50 | |
*** jamesmcarthur has joined #zuul | 03:56 | |
*** jamesmcarthur has quit IRC | 03:58 | |
*** jamesmcarthur has joined #zuul | 04:07 | |
*** jamesmcarthur has quit IRC | 04:11 | |
*** jamesmcarthur has joined #zuul | 04:26 | |
*** jamesmcarthur has quit IRC | 04:29 | |
*** jamesmcarthur has joined #zuul | 04:30 | |
*** jamesmcarthur has quit IRC | 04:35 | |
*** jamesmcarthur has joined #zuul | 04:48 | |
*** jamesmcarthur has quit IRC | 05:05 | |
*** jamesmcarthur has joined #zuul | 05:21 | |
*** evrardjp has quit IRC | 05:33 | |
*** evrardjp has joined #zuul | 05:33 | |
*** ikhan has joined #zuul | 05:54 | |
*** Eighth_Doctor has quit IRC | 08:47 | |
*** evrardjp has quit IRC | 08:49 | |
*** EmilienM has quit IRC | 08:49 | |
*** mgoddard has quit IRC | 08:49 | |
*** irclogbot_0 has quit IRC | 08:49 | |
*** arxcruz|ruck has quit IRC | 08:49 | |
*** ttx has quit IRC | 08:49 | |
*** asettle has quit IRC | 08:49 | |
*** ianychoi has quit IRC | 08:49 | |
*** gundalow has quit IRC | 08:49 | |
*** gmann has quit IRC | 08:49 | |
*** mnaser has quit IRC | 08:49 | |
*** samccann has quit IRC | 08:49 | |
*** Open10K8S has quit IRC | 08:49 | |
*** rpittau|afk has quit IRC | 08:49 | |
*** pots has quit IRC | 08:49 | |
*** johanssone has quit IRC | 08:49 | |
*** logan- has quit IRC | 08:49 | |
*** tobberydberg has quit IRC | 08:49 | |
*** Eighth_Doctor has joined #zuul | 08:49 | |
*** ianychoi has joined #zuul | 08:52 | |
*** gundalow has joined #zuul | 08:52 | |
*** gmann has joined #zuul | 08:52 | |
*** mnaser has joined #zuul | 08:52 | |
*** samccann has joined #zuul | 08:52 | |
*** Open10K8S has joined #zuul | 08:52 | |
*** rpittau|afk has joined #zuul | 08:52 | |
*** pots has joined #zuul | 08:52 | |
*** evrardjp has joined #zuul | 08:52 | |
*** EmilienM has joined #zuul | 08:52 | |
*** mgoddard has joined #zuul | 08:52 | |
*** irclogbot_0 has joined #zuul | 08:52 | |
*** arxcruz|ruck has joined #zuul | 08:52 | |
*** Eighth_Doctor has quit IRC | 08:53 | |
*** mordred has quit IRC | 08:54 | |
*** mnaser has quit IRC | 08:56 | |
*** johanssone has joined #zuul | 08:56 | |
*** logan- has joined #zuul | 08:56 | |
*** tobberydberg has joined #zuul | 08:56 | |
*** logan- has quit IRC | 08:56 | |
*** gundalow has quit IRC | 08:56 | |
*** mnaser has joined #zuul | 08:57 | |
*** gundalow has joined #zuul | 08:58 | |
*** logan- has joined #zuul | 09:01 | |
*** asettle has joined #zuul | 09:01 | |
*** ttx has joined #zuul | 09:01 | |
*** mordred has joined #zuul | 09:24 | |
*** mordred has quit IRC | 09:42 | |
*** jamesmcarthur has quit IRC | 10:19 | |
*** jamesmcarthur has joined #zuul | 10:19 | |
*** jamesmcarthur has quit IRC | 10:23 | |
*** jamesmcarthur has joined #zuul | 10:23 | |
*** Eighth_Doctor has joined #zuul | 10:28 | |
*** jamesmcarthur has quit IRC | 10:29 | |
*** saneax has quit IRC | 10:32 | |
*** saneax has joined #zuul | 10:36 | |
*** jhesketh has quit IRC | 10:37 | |
*** sanjayu_ has joined #zuul | 10:38 | |
*** saneax has quit IRC | 10:40 | |
*** mordred has joined #zuul | 10:46 | |
*** jamesmcarthur has joined #zuul | 10:54 | |
openstackgerrit | Albin Vass proposed zuul/zuul master: Reset repo to previous head on .gitmodules error https://review.opendev.org/c/zuul/zuul/+/775334 | 11:05 |
openstackgerrit | Albin Vass proposed zuul/zuul master: Replace reset_repo_to_head(repo) with GitPython. https://review.opendev.org/c/zuul/zuul/+/775499 | 11:13 |
avass | corvus: that does not need to delete the repo as long as the initial commit doesn't have a .gitmodules file :) | 11:28 |
*** jamesmcarthur has quit IRC | 11:33 | |
*** tosky has joined #zuul | 13:21 | |
*** jamesmcarthur has joined #zuul | 13:31 | |
*** jamesmcarthur has quit IRC | 13:37 | |
corvus | avass: i don't think we can assume that :( | 13:57 |
openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: web: add benchmark test for build output https://review.opendev.org/c/zuul/zuul/+/775468 | 14:47 |
openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: web: render links and ansi escape sequences in build output https://review.opendev.org/c/zuul/zuul/+/775503 | 14:59 |
tristanC | following up on rendering links, i've added this feature to the ansi library i wrote previously, so that both escape sequences and links are processed in one pass | 15:10 |
corvus | tristanC: how big is your benchmark test? | 15:16 |
tristanC | corvus: it uses a failed task with 512 lines of 1024 characters in the stderr_lines attribute | 15:19 |
corvus | tristanC: do you think that's a sufficiently large file? i was thinking that multi-mb files aren't uncommon. | 15:21 |
tristanC | corvus: this is for the task summary | 15:22 |
corvus | tristanC: ah, so we're not aiming for consistency | 15:24 |
tristanC | well if that's ok for the task summary, i can look at adding such processing to the other component too | 15:26 |
corvus | i'm not sure i'd say 5x the render time is even okay for the task summary | 15:27 |
corvus | 150ms is borderline, maybe? | 15:29 |
corvus | 4s is certainly bad | 15:30 |
tristanC | i think link rendering can be faster by directly looking for `http` using the js string api, but to render ansi it seems like we do need to go through each codepoint | 15:31 |
corvus | tristanC: what are we doing for the severity filters, and how do those perform in the benchmark? | 15:32 |
tristanC | perhaps using a better data structure i can make re-ansi go a bit faster, but i'm not sure it will be significant | 15:32 |
tristanC | for the logfile, it seems the severity annotation is added in the action, so that could be measure independently | 15:37 |
tristanC | and for the dom component, it seems like it is using effects, so measuring rendering time may be trickier | 15:38 |
corvus | tristanC: we're just using regexes, right? but maybe severity regexes are simple enough its fast | 15:39 |
corvus | tristanC: and in 775109 it's a regex that starts with "^.+" which, if that is applied to every char in the string is something like O(n^2) | 15:41 |
corvus | tristanC: so maybe a stricter regex with linkify, or, as you suggest, something simpler with the js string api might be more efficient | 15:42 |
openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: web: render links and ansi escape sequences in logfile and console https://review.opendev.org/c/zuul/zuul/+/775505 | 15:42 |
tristanC | corvus: that sounds worth trying | 15:45 |
*** iurygregory has quit IRC | 15:53 | |
corvus | tristanC, fungi: i left a comment on 775109 | 15:55 |
*** tosky has quit IRC | 16:01 | |
openstackgerrit | Adam Richter proposed zuul/zuul master: Linkify BuildOutput in the Task Summary view https://review.opendev.org/c/zuul/zuul/+/775109 | 16:15 |
corvus | tristanC: ^ is there a way to get an updated benchmark result with depends-on, or are you just running that manually? | 16:34 |
tristanC | corvus: i've been cherry-picking the benchmark, and you can run it using `yarn test BuildOutput` | 16:39 |
corvus | tristanC: ok; good to know, thanks. my working tree is a bit of a mess as i'm debugging something with type annotations and test runtimes right now, so i'll leave that to you or others :) | 16:42 |
tristanC | with the new regexp it still takes 4383 ms to render | 16:44 |
avass | corvus: oh, why? | 16:44 |
avass | I mean I don't see why resetting to a commit to before the file is added wouldn't work? | 16:45 |
corvus | avass: i don't think we can assume the initial commit in the repo doesn't have a .gitmodules | 16:45 |
avass | corvus: Oh if it does it just deletes the repo | 16:46 |
corvus | avass: ok, that's not as bad then :) | 16:46 |
*** jamesmcarthur has joined #zuul | 16:46 | |
openstackgerrit | James E. Blair proposed zuul/zuul master: Connect merger to Zookeeper https://review.opendev.org/c/zuul/zuul/+/775461 | 16:50 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Update component doc re ZooKeeper https://review.opendev.org/c/zuul/zuul/+/775462 | 16:50 |
*** iurygregory has joined #zuul | 16:50 | |
*** jamesmcarthur has quit IRC | 17:48 | |
openstackgerrit | Tobias Henkel proposed zuul/nodepool master: WIP: Optimize node deletion https://review.opendev.org/c/zuul/nodepool/+/775438 | 18:18 |
openstackgerrit | Tobias Henkel proposed zuul/nodepool master: WIP: Optimize node deletion https://review.opendev.org/c/zuul/nodepool/+/775438 | 18:33 |
openstackgerrit | Tobias Henkel proposed zuul/nodepool master: WIP: Optimize node deletion https://review.opendev.org/c/zuul/nodepool/+/775438 | 18:34 |
*** tosky has joined #zuul | 18:45 | |
openstackgerrit | James E. Blair proposed zuul/zuul master: DNM: Test regex replacements for linkify https://review.opendev.org/c/zuul/zuul/+/775506 | 19:08 |
corvus | tristanC, fungi: really rough prototype; i think it shows the regex replacement approach is very low cost | 19:09 |
corvus | tristanC, fungi: (see comments i left on https://review.opendev.org/775109 | 19:09 |
corvus | either that, or i didn't use the benchmark test right :) (but i did test it in browser and got a replacement, so i think it's doing something) | 19:11 |
openstackgerrit | Tobias Henkel proposed zuul/nodepool master: WIP: Optimize node launches https://review.opendev.org/c/zuul/nodepool/+/775507 | 19:14 |
*** harrymichal has joined #zuul | 19:20 | |
*** harrymichal has quit IRC | 19:23 | |
openstackgerrit | Tobias Henkel proposed zuul/zuul-jobs master: Fix default origin_version in readme https://review.opendev.org/c/zuul/zuul-jobs/+/775508 | 19:35 |
openstackgerrit | Tobias Henkel proposed zuul/nodepool master: WIP: Optimize node launches https://review.opendev.org/c/zuul/nodepool/+/775507 | 19:39 |
openstackgerrit | Tobias Henkel proposed zuul/nodepool master: Run nodepool-functional-openshift on centos-8 https://review.opendev.org/c/zuul/nodepool/+/775509 | 19:44 |
*** jamesmcarthur has joined #zuul | 19:46 | |
*** jamesmcarthur has quit IRC | 19:52 | |
*** jamesmcarthur has joined #zuul | 20:04 | |
openstackgerrit | James E. Blair proposed zuul/zuul master: Connect merger to Zookeeper https://review.opendev.org/c/zuul/zuul/+/775461 | 20:04 |
*** jamesmcarthur has quit IRC | 20:15 | |
*** jamesmcarthur has joined #zuul | 20:16 | |
*** jamesmcarthur has quit IRC | 20:21 | |
*** jamesmcarthur has joined #zuul | 20:46 | |
openstackgerrit | Tobias Henkel proposed zuul/nodepool master: WIP: Optimize node deletion https://review.opendev.org/c/zuul/nodepool/+/775438 | 21:00 |
openstackgerrit | Tobias Henkel proposed zuul/nodepool master: WIP: Optimize node launches https://review.opendev.org/c/zuul/nodepool/+/775507 | 21:00 |
*** jamesmcarthur has quit IRC | 21:17 | |
*** jamesmcarthur has joined #zuul | 21:18 | |
openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: web: add benchmark test for logfile https://review.opendev.org/c/zuul/zuul/+/775510 | 21:20 |
tobiash | tristanC: the nodepool-zuul-functional-openshift job is broken and blocks nodepool gate: https://zuul.opendev.org/t/zuul/build/2ec2674f46e74c2eb9f9cc1388f06e7e | 21:23 |
tobiash | it looks like a yum repo is missing upstream now but I don't find the place where this gets added | 21:24 |
openstackgerrit | Tobias Henkel proposed zuul/zuul-jobs master: Fix default origin_version in readme https://review.opendev.org/c/zuul/zuul-jobs/+/775508 | 21:36 |
openstackgerrit | Tristan Cacqueray proposed zuul/zuul-jobs master: ensure-openshift: workaround missing ansible26 repository https://review.opendev.org/c/zuul/zuul-jobs/+/775511 | 21:39 |
tristanC | tobiash: arg, that is unfortunate upstream is broken, here is a fix we applied in sf: ^ | 21:39 |
*** andy-ladjadj has joined #zuul | 21:44 | |
tobiash | tristanC: awesome, thanks :) | 21:44 |
*** andy-ladjadj has quit IRC | 21:47 | |
*** jamesmcarthur has quit IRC | 22:16 | |
*** jamesmcarthur has joined #zuul | 22:17 | |
*** jamesmcarthur has quit IRC | 22:22 | |
*** jamesmcarthur has joined #zuul | 22:38 | |
openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: web: add benchmark test for logfile https://review.opendev.org/c/zuul/zuul/+/775510 | 22:46 |
corvus | felixedel, swest, tobiash: if you agree with the next step i propose in http://lists.zuul-ci.org/pipermail/zuul-discuss/2021-February/001529.html feel free to go ahead and do that on monday before i get started. if not, we can talk about it then :) | 23:31 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!