*** tosky has quit IRC | 00:11 | |
*** zenkuro has quit IRC | 01:52 | |
*** saneax has joined #zuul | 01:58 | |
*** vishalmanchanda has joined #zuul | 03:34 | |
*** ianychoi_ has joined #zuul | 03:40 | |
*** ianychoi has quit IRC | 03:43 | |
*** ykarel has joined #zuul | 04:44 | |
*** reiterative has quit IRC | 04:50 | |
*** reiterative has joined #zuul | 04:50 | |
*** ykarel has quit IRC | 05:04 | |
*** ykarel has joined #zuul | 05:06 | |
*** jfoufas1 has joined #zuul | 05:21 | |
*** evrardjp has quit IRC | 05:33 | |
*** evrardjp has joined #zuul | 05:33 | |
*** ykarel_ has joined #zuul | 05:43 | |
*** ykarel has quit IRC | 05:45 | |
*** rlandy|bbl has quit IRC | 05:55 | |
*** yoctozepto has quit IRC | 06:00 | |
*** yoctozepto has joined #zuul | 06:02 | |
*** ykarel_ is now known as ykarel | 06:18 | |
*** ykarel_ has joined #zuul | 06:34 | |
*** ykarel has quit IRC | 06:36 | |
*** ajitha has joined #zuul | 07:15 | |
openstackgerrit | Daniel Blixt proposed zuul/zuul master: Add unit tests for shell-type https://review.opendev.org/c/zuul/zuul/+/778585 | 07:20 |
---|---|---|
*** piotrowskim has joined #zuul | 07:31 | |
*** hamalq has joined #zuul | 07:45 | |
openstackgerrit | Andreas Jaeger proposed zuul/zuul-jobs master: cabal-test: add install_args and build_args role var https://review.opendev.org/c/zuul/zuul-jobs/+/777653 | 07:51 |
*** jpena|off is now known as jpena | 07:52 | |
*** jcapitao has joined #zuul | 07:53 | |
*** rpittau|afk is now known as rpittau | 08:08 | |
openstackgerrit | Daniel Blixt proposed zuul/nodepool master: Add shell-type to more providers https://review.opendev.org/c/zuul/nodepool/+/778580 | 08:08 |
*** ykarel_ is now known as ykarel | 08:13 | |
*** iamweswilson_ has joined #zuul | 08:28 | |
*** ofosos_ has joined #zuul | 08:29 | |
*** stevthedev_ has joined #zuul | 08:29 | |
*** parallax_ has joined #zuul | 08:30 | |
*** johnsom_ has joined #zuul | 08:30 | |
*** hashar has joined #zuul | 08:30 | |
*** persia has joined #zuul | 08:31 | |
*** leoluk_ has joined #zuul | 08:33 | |
*** mnasiadka_ has joined #zuul | 08:33 | |
*** rpittau_ has joined #zuul | 08:33 | |
*** tosky has joined #zuul | 08:36 | |
*** mnasiadka has quit IRC | 08:43 | |
*** stevthedev has quit IRC | 08:43 | |
*** parallax has quit IRC | 08:43 | |
*** persia_ has quit IRC | 08:43 | |
*** rpittau has quit IRC | 08:43 | |
*** johnsom has quit IRC | 08:43 | |
*** ofosos has quit IRC | 08:43 | |
*** iamweswilson has quit IRC | 08:43 | |
*** leoluk has quit IRC | 08:43 | |
*** stevthedev_ is now known as stevthedev | 08:43 | |
*** mnasiadka_ is now known as mnasiadka | 08:43 | |
*** ofosos_ is now known as ofosos | 08:43 | |
*** iamweswilson_ is now known as iamweswilson | 08:43 | |
*** johnsom_ is now known as johnsom | 08:43 | |
*** rpittau_ is now known as rpittau | 08:43 | |
*** parallax_ is now known as parallax | 08:43 | |
*** hamalq has quit IRC | 08:47 | |
openstackgerrit | Daniel Blixt proposed zuul/nodepool master: Add shell-type to more providers https://review.opendev.org/c/zuul/nodepool/+/778580 | 08:56 |
*** ykarel has quit IRC | 09:23 | |
*** jpodivin has joined #zuul | 09:27 | |
jpodivin | hi there, I wanted to ask: what is the proper way of setting env vars for a zuul job? | 09:29 |
*** sshnaidm|afk is now known as sshnaidm|aoff | 09:41 | |
*** sshnaidm|aoff is now known as sshnaidm|off | 09:41 | |
avass | jpodivin: you mean setting environment for a specific task in a job? | 09:41 |
jpodivin | avass: not exactly. I have a job that runs some playbooks. I need to make sure some environment variables are set. | 09:44 |
avass | oh set environment on the worker node? | 09:45 |
jpodivin | yep, as in normal unix env variable. | 09:50 |
*** nils has joined #zuul | 10:05 | |
avass | I think that sort of depends on the node. but usually ssh is set up to load /etc/environment so that's my goto when I need to do that | 10:06 |
jpodivin | avass: hmm. maybe I could go around it. Is there a way to set term characteristics for zuul, other than adjusting environment vars? | 10:21 |
*** ykarel has joined #zuul | 10:30 | |
avass | jpodivin: sorry I'm not sure I understand what you need to do. do you have an example? | 10:35 |
*** jangutter has joined #zuul | 10:41 | |
jpodivin | avass: long story short, I want to prevent zuul from sending things to stdout in color. The the way it's encoded makes it come out all mangled. | 10:41 |
*** zenkuro has joined #zuul | 10:42 | |
*** jangutter has quit IRC | 10:43 | |
*** jangutter has joined #zuul | 10:43 | |
*** jangutter_ has quit IRC | 10:44 | |
avass | jpodivin: then I take it that it's a specific task or a number of tasks that produce that? | 10:49 |
avass | I think you want to look at: https://docs.ansible.com/ansible/latest/user_guide/playbooks_environment.html#setting-the-remote-environment-in-a-task | 10:49 |
openstackgerrit | Ashley Bullock proposed zuul/zuul master: Add initial bitbucket cloud driver using webhooks https://review.opendev.org/c/zuul/zuul/+/759003 | 10:50 |
avass | we got a similar problem with cmake producing output with colors | 10:50 |
jpodivin | avass: thanks I'll check it out | 10:51 |
jpodivin | avass++ | 10:51 |
*** jcapitao is now known as jcapitao_lunch | 11:33 | |
*** hashar is now known as hasharLunch | 11:40 | |
*** jangutter_ has joined #zuul | 11:42 | |
*** jangutter has quit IRC | 11:45 | |
*** ykarel_ has joined #zuul | 11:45 | |
*** ykarel has quit IRC | 11:47 | |
*** rlandy has joined #zuul | 12:28 | |
*** ykarel_ is now known as ykarel | 12:30 | |
*** jpena is now known as jpena|lunch | 12:32 | |
*** hasharLunch is now known as hashar | 12:43 | |
*** bhavikdbavishi has joined #zuul | 12:54 | |
*** ikhan has quit IRC | 12:54 | |
*** ikhan has joined #zuul | 13:03 | |
*** jcapitao_lunch is now known as jcapitao | 13:07 | |
*** sduthil has quit IRC | 13:33 | |
*** sduthil has joined #zuul | 13:33 | |
*** jpena|lunch is now known as jpena | 13:33 | |
*** jangutter has joined #zuul | 13:34 | |
*** jangutter_ has quit IRC | 13:37 | |
*** bhavikdbavishi has quit IRC | 13:41 | |
*** jangutter has quit IRC | 13:43 | |
openstackgerrit | Simon Westphahl proposed zuul/zuul master: Improve typings in context of builds via ZooKeeper https://review.opendev.org/c/zuul/zuul/+/753578 | 13:43 |
openstackgerrit | Simon Westphahl proposed zuul/zuul master: Make ZooKeeper mandatory for Scheduler https://review.opendev.org/c/zuul/zuul/+/756716 | 13:43 |
openstackgerrit | Simon Westphahl proposed zuul/zuul master: Move setupZK() helper function to BaseTestCase class https://review.opendev.org/c/zuul/zuul/+/776639 | 13:43 |
openstackgerrit | Simon Westphahl proposed zuul/zuul master: Initialize ZooKeeper connection in server rather than in cmd classes https://review.opendev.org/c/zuul/zuul/+/776640 | 13:44 |
openstackgerrit | Simon Westphahl proposed zuul/zuul master: Make ConnectionRegistry mandatory for Scheduler https://review.opendev.org/c/zuul/zuul/+/757095 | 13:44 |
openstackgerrit | Simon Westphahl proposed zuul/zuul master: Improve typings in context of 756716 and 757095 https://review.opendev.org/c/zuul/zuul/+/757148 | 13:44 |
openstackgerrit | Simon Westphahl proposed zuul/zuul master: Instantiate executor client, merger, nodepool and app within Scheduler https://review.opendev.org/c/zuul/zuul/+/757149 | 13:44 |
openstackgerrit | Simon Westphahl proposed zuul/zuul master: Improve typings in context of lock nodes on executor https://review.opendev.org/c/zuul/zuul/+/757097 | 13:44 |
openstackgerrit | Simon Westphahl proposed zuul/zuul master: DNM: Reduce number of jobs for SOS development https://review.opendev.org/c/zuul/zuul/+/775081 | 13:44 |
*** jangutter_ has joined #zuul | 13:44 | |
swest_ | corvus: I cleaned up the type annotations in 753578 and ff. and tried to make them as unobtrusive as possible. let me know in case I've missed something, which is very possible as I'm feeling a little type blind after the rebase :D | 13:53 |
*** swest_ is now known as swest | 13:59 | |
corvus | swest: thanks! there are still a lot of type hints in there, so it seems that mypi isn't allowing us to just have hints in the function signatures without also needing to annotate variables too. there are also quite a few code changes in there that are really quite subtle. for instance, any time we change "if foo.bar" to "if foo and foo.bar" we're removing a place where an error could be caught and hiding | 14:14 |
corvus | that condition. erroring on a null dereference isn't wrong if the value is never supposed to be null. in short, this is a very complicated change and to be honest, i'm starting to feel like we're spending too much time rewriting code trying to make mypi happy and we're not getting what we value out of it. | 14:14 |
corvus | swest: to be honest, i would prefer we continue to scale back our use of type hints; i'm much more interested in getting to the meat of the code that's behind that change. | 14:15 |
*** jangutter has joined #zuul | 14:16 | |
corvus | (so far typing has caused us to chase circular imports and test runtime explosion; i feel like we're spending a lot of time trying to prevent it from introducing bugs) | 14:18 |
swest | corvus: I'll try to remove the typing patches from the sos stack. There will probably be quite some merge conflicts, but I think you are right in that we should focus on the functionality instead | 14:18 |
corvus | swest: thanks, and thanks again for looking into it. | 14:20 |
*** jangutter_ has quit IRC | 14:20 | |
*** ianychoi__ has joined #zuul | 14:46 | |
*** ianychoi_ has quit IRC | 14:49 | |
*** GomathiselviS has joined #zuul | 15:10 | |
GomathiselviS | fungi corvus : Can you please take a look at https://review.opendev.org/c/zuul/zuul-jobs/+/773474 ? I have addressed /replied the review comments | 15:17 |
*** saneax has quit IRC | 15:25 | |
*** saneax has joined #zuul | 15:26 | |
*** ykarel has quit IRC | 15:58 | |
*** jpodivin has quit IRC | 16:03 | |
corvus | GomathiselviS: thanks, will do (just a little later today) | 16:07 |
fungi | same, i'm buried under meetings at the moment, unfortunately | 16:14 |
GomathiselviS | No issues, it was just a reminder. Please review it at your convenience. | 16:15 |
*** vishalmanchanda has quit IRC | 16:17 | |
fungi | thanks! | 16:21 |
*** jfoufas1 has quit IRC | 16:34 | |
*** bhavikdbavishi has joined #zuul | 16:35 | |
*** jcapitao has quit IRC | 16:50 | |
fungi | zuul-maint: i've attempted to summarize the zuul approach to policy enforcement at https://hackmd.io/__6IAnVuR8C8mPD--XMbWg#Zuul but please let me know if i've misrepresented anything | 16:53 |
fungi | (policy-driven cd is an active topic the cdf interop sig is trying to survey across different solutions and use cases) | 16:54 |
tristanC | fungi: perhaps this could mention the PTI doc from https://zuul-ci.org/docs/zuul/howtos/pti.html ? | 16:55 |
fungi | tristanC: added, how's that? | 16:57 |
tristanC | fungi: looks great, thanks! | 16:57 |
fungi | tweaked the wording for that sentence a little more, thanks for the suggestiom! | 17:00 |
fungi | suggestion | 17:00 |
*** jpena is now known as jpena|off | 17:02 | |
*** saneax has quit IRC | 17:15 | |
*** jangutter_ has joined #zuul | 17:26 | |
*** rpittau is now known as rpittau|afk | 17:27 | |
*** jangutter has quit IRC | 17:29 | |
*** nils has quit IRC | 17:45 | |
*** harrymichal has joined #zuul | 18:11 | |
clarkb | fungi: what you've written there lgtm | 18:15 |
fungi | thanks | 18:15 |
*** iurygregory has quit IRC | 18:22 | |
*** iurygregory has joined #zuul | 18:22 | |
*** hashar has quit IRC | 18:23 | |
*** bhavikdbavishi has quit IRC | 18:51 | |
openstackgerrit | Daniel Blixt proposed zuul/nodepool master: Add shell-type to more providers https://review.opendev.org/c/zuul/nodepool/+/778580 | 18:55 |
*** mgagne has quit IRC | 18:56 | |
*** mgagne has joined #zuul | 18:57 | |
*** piotrowskim has quit IRC | 19:11 | |
corvus | tobiash: if you have a quick second to look at this zuul-storage-proxy change, i'd appreciate it https://review.opendev.org/777261 -- i don't think it will impact your env, but it makes it a little easier to use behind certain load balancers | 19:16 |
*** hamalq has joined #zuul | 19:41 | |
openstackgerrit | Merged zuul/zuul-storage-proxy master: Allow mounting somewhere other than / https://review.opendev.org/c/zuul/zuul-storage-proxy/+/777261 | 19:42 |
openstackgerrit | Merged zuul/zuul-storage-proxy master: Add an integration test to the image build https://review.opendev.org/c/zuul/zuul-storage-proxy/+/777262 | 19:43 |
*** GomathiselviS has quit IRC | 20:22 | |
corvus | i wonder if we could adjust our logging config setup so that zuul sets up all the loggers, but we let people supply their own handlers. that way if you wanted to use logstash/splunk/syslog/whatever you could just supply a python logging dict for the handler you want to add and leave the rest to zuul | 21:03 |
*** openstackgerrit has quit IRC | 21:05 | |
avass | that would be nice | 21:51 |
*** harrymichal has quit IRC | 21:54 | |
*** ajitha has quit IRC | 22:24 | |
*** rlandy is now known as rlandy|bbl | 23:02 | |
*** openstackgerrit has joined #zuul | 23:26 | |
openstackgerrit | James E. Blair proposed zuul/nodepool master: Add python-logstash-async to container images https://review.opendev.org/c/zuul/nodepool/+/778793 | 23:26 |
corvus | tristanC, mordred: ^ er, since we did that in zuul, we should probably do it in nodepool too :) | 23:27 |
*** jamesmcarthur has joined #zuul | 23:48 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!