| *** tosky has quit IRC | 00:10 | |
| *** rlandy has quit IRC | 00:23 | |
| *** hamalq has quit IRC | 00:26 | |
| *** ianychoi has joined #zuul | 01:24 | |
| *** ianychoi_ has quit IRC | 01:26 | |
| *** ajitha has joined #zuul | 01:30 | |
| *** evrardjp has quit IRC | 03:33 | |
| *** evrardjp has joined #zuul | 03:33 | |
| *** bhavikdbavishi has joined #zuul | 03:53 | |
| *** bhavikdbavishi1 has joined #zuul | 03:55 | |
| *** bhavikdbavishi has quit IRC | 03:57 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 03:57 | |
| *** pleia2 has joined #zuul | 04:11 | |
| *** ykarel|away has joined #zuul | 04:17 | |
| *** ykarel|away is now known as ykarel | 04:17 | |
| *** vishalmanchanda has joined #zuul | 04:26 | |
| *** ykarel_ has joined #zuul | 06:12 | |
| *** ykarel has quit IRC | 06:13 | |
| *** ykarel_ has quit IRC | 06:26 | |
| *** ykarel has joined #zuul | 06:30 | |
| *** ykarel_ has joined #zuul | 07:03 | |
| *** ykarel has quit IRC | 07:03 | |
| *** ykarel_ has quit IRC | 07:07 | |
| *** ykarel_ has joined #zuul | 07:08 | |
| *** ykarel_ has quit IRC | 07:12 | |
| *** jcapitao has joined #zuul | 07:29 | |
| *** bhavikdbavishi has quit IRC | 07:48 | |
| *** hashar has joined #zuul | 08:10 | |
| *** rpittau|afk is now known as rpittau | 08:23 | |
| openstackgerrit | Albin Vass proposed zuul/zuul master: Filter events on event connection https://review.opendev.org/c/zuul/zuul/+/760907 | 08:24 |
|---|---|---|
| *** bhavikdbavishi has joined #zuul | 08:25 | |
| *** bhavikdbavishi has quit IRC | 08:42 | |
| *** zbr has joined #zuul | 08:42 | |
| openstackgerrit | Albin Vass proposed zuul/zuul master: Filter events on event connection https://review.opendev.org/c/zuul/zuul/+/760907 | 08:56 |
| *** jpena|off is now known as jpena | 08:57 | |
| *** tosky has joined #zuul | 09:03 | |
| *** nils has joined #zuul | 09:21 | |
| openstackgerrit | Albin Vass proposed zuul/zuul master: Filter events on event connection https://review.opendev.org/c/zuul/zuul/+/760907 | 09:23 |
| *** openstackgerrit has quit IRC | 09:33 | |
| *** ykarel has joined #zuul | 09:44 | |
| *** hashar has quit IRC | 10:51 | |
| *** rlandy has joined #zuul | 11:37 | |
| *** rlandy has quit IRC | 11:39 | |
| *** rlandy has joined #zuul | 11:39 | |
| *** jcapitao is now known as jcapitao_lunch | 11:58 | |
| avass | zbr: ansible-lint seem to have missed loop_var on: https://review.opendev.org/c/zuul/zuul-jobs/+/623594 | 12:33 |
| zbr | looking | 12:33 |
| *** jpena is now known as jpena|lunch | 12:34 | |
| avass | just noticed it ran 21 jan so I rechecked it | 12:34 |
| zbr | i see it, now trying to add a test/fix. | 12:35 |
| zbr | avass: btw, did my v5 change went in? that would explain why it did not work. | 12:36 |
| zbr | that rule is activated only when there is a config item enabling the rule. | 12:36 |
| avass | but then the old custom rule should have caught it | 12:37 |
| zbr | that is another issue, but i am not willing to fix some code that is removed | 12:38 |
| avass | yeah, probably good to get the v5 change in | 12:38 |
| avass | the recheck failed on yamllint anyway :) | 12:39 |
| zbr | you can try rebasing it on top of v5 one and see if newer code finds it. | 12:45 |
| *** jangutter_ has joined #zuul | 12:58 | |
| *** ykarel has quit IRC | 12:59 | |
| *** rlandy is now known as rlandy|training | 13:00 | |
| *** jcapitao_lunch is now known as jcapitao | 13:01 | |
| *** jangutter has quit IRC | 13:02 | |
| *** GomathiselviS has joined #zuul | 13:06 | |
| GomathiselviS | corvus: Requesting review on https://review.opendev.org/c/zuul/zuul-jobs/+/773474. We are waiting on the merge | 13:07 |
| zbr | zuul-maint: https://review.opendev.org/c/zuul/zuul-jobs/+/623594 please. | 13:08 |
| tristanC | zbr: zuul is failing on that? | 13:09 |
| zbr | sorry wrong link in clipboard, https://review.opendev.org/c/zuul/zuul-jobs/+/773245 | 13:10 |
| *** ykarel has joined #zuul | 13:12 | |
| *** jpena|lunch is now known as jpena | 13:32 | |
| avass | GomathiselviS: just nits on the documentation otherwise it's lgtm. I think we can approve that later unless corvus wants a look at it first | 13:40 |
| avass | since I guess the -1 is mostly there for moving vars to defaults | 13:42 |
| corvus | avass, GomathiselviS, pabelanger: lgtm but i haven't done a base-test cycle with it and can't monitor it right now, so i won't +w; if someone has done a cycle or is available for monitoring, feel free to +w | 13:48 |
| avass | oh yes that too | 13:51 |
| *** newbie2020 has joined #zuul | 13:53 | |
| *** openstackgerrit has joined #zuul | 13:53 | |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Unify handling of dequeue and enqueue events https://review.opendev.org/c/zuul/zuul/+/781099 | 13:53 |
| openstackgerrit | Gomathi Selvi Srinivasan proposed zuul/zuul-jobs master: Create a template for ssh-key and size https://review.opendev.org/c/zuul/zuul-jobs/+/773474 | 13:54 |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: runner: add job parameters listing https://review.opendev.org/c/zuul/zuul/+/644795 | 13:57 |
| *** harrymichal has joined #zuul | 13:57 | |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Switch to Zookeeper backed trigger event queues https://review.opendev.org/c/zuul/zuul/+/763754 | 14:00 |
| *** saneax has quit IRC | 14:11 | |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Switch to Zookeeper backed management event queues https://review.opendev.org/c/zuul/zuul/+/761738 | 14:16 |
| corvus | rebase 6 | 14:16 |
| corvus | ^ | 14:16 |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: web: add depends-on support to the freeze job API https://review.opendev.org/c/zuul/zuul/+/639022 | 14:20 |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: runner: add support for depends-on https://review.opendev.org/c/zuul/zuul/+/632064 | 14:21 |
| *** vishalmanchanda has quit IRC | 14:25 | |
| *** vishalmanchanda has joined #zuul | 14:35 | |
| mordred | corvus: reviewing the zk stack there - the first 4 or 5 seem completely safe to actually merge - any reason not to? | 14:41 |
| mordred | (It seems like "Switch to Zookeeper backed trigger event queues" is the first one where there are operational impacts) | 14:43 |
| avass | corvus: tests are passing again: https://review.opendev.org/c/zuul/zuul/+/760907 | 14:44 |
| avass | it seems like the test_git_dependency_with_cycle test is a bit unstable | 14:45 |
| corvus | mordred: yeah, i think that's the case; i'm sort of inclined to release what opendev is running as 4.1, then merge that chunk (including the zk event queues) and restart with it to start exercising it (with a quick switch back to 4.1 if it goes pear shaped) | 14:50 |
| corvus | avass: yeah, i've seen that once or twice too, i'll dig into it | 14:52 |
| *** ykarel is now known as ykarel|away | 15:06 | |
| openstackgerrit | Merged zuul/zuul master: Change Description of DB in Components Page on Zuul Document https://review.opendev.org/c/zuul/zuul/+/781072 | 15:13 |
| *** saneax has joined #zuul | 15:15 | |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: runner: add job parameters listing https://review.opendev.org/c/zuul/zuul/+/644795 | 15:18 |
| *** ykarel|away has quit IRC | 15:42 | |
| openstackgerrit | Sorin Sbârnea proposed zuul/zuul-jobs master: Upgrade ansible-lint to 5.0 https://review.opendev.org/c/zuul/zuul-jobs/+/773245 | 15:43 |
| *** rlandy|training is now known as rlandy | 15:44 | |
| openstackgerrit | Sorin Sbârnea proposed zuul/zuul-jobs master: Upgrade ansible-lint to 5.0 https://review.opendev.org/c/zuul/zuul-jobs/+/773245 | 15:45 |
| *** saneax has quit IRC | 15:53 | |
| pabelanger | corvus: avass: GomathiselviS: I can help test on opendev base jobs, maybe later today / tomorrow. We've confirmed on zuul.a.c it worked, but can also understand the need for opendev | 15:59 |
| zbr | tristanC: some arm64 nodes not working?: https://zuul.opendev.org/t/zuul/buildset/ab35bbb33ee1423cba5cc0ace6401b95 | 16:16 |
| zbr | i do not even understand why zuul-jobs-test-ensure-docker* jobs are triggered on that change as it does not seem to touch any of the files: ... | 16:21 |
| corvus | tristanC, tobiash: can you take a look at this real quick? https://etherpad.opendev.org/p/LPsdvSvlnnMRM0vWq__6 | 16:31 |
| *** hamalq has joined #zuul | 16:31 | |
| corvus | tristanC, tobiash: i'd like to get https://review.opendev.org/776287 merged asap and restart opendev with it to start collecting those stats | 16:31 |
| corvus | but i think maybe 1 or two more would be useful | 16:32 |
| tobiash | corvus: the pre-processing time is tenant-less | 16:32 |
| corvus | i think tristanC is right -- it would be really good to have data from those before we restart with any HA scheduler changes | 16:32 |
| corvus | tobiash: good point -- but we could still emit all 3 of these upon enqueue, so we could put it in the tenant anyway | 16:33 |
| tobiash | ok, that makes sense | 16:33 |
| tobiash | corvus: oh, I just notices that 776287 also has the pipeline with it which I think might be overkill | 16:34 |
| tobiash | it should use basekey instead probably | 16:34 |
| corvus | tobiash: yeah, i think so -- i dropped that in the etherpad version | 16:34 |
| corvus | (i sort of think it might make sense for drivers to emit some driver-specific stats too, but i'm mostly focused on the zk change; i think tristan's enqueue_time (which i'm suggesting we rename to enqueue_processing_time) is the key metric for that) | 16:35 |
| tobiash | corvus: yepp, makes sense. It looks like the driver event queues are later in the sos queue | 16:37 |
| corvus | hrm, we also have the zuul.event.driver hierarchy... | 16:37 |
| tobiash | so tristanC's change (updated with what we agree on the etherpad) would probably sufficient for the next restart | 16:37 |
| corvus | i guess my big question is: does zuul.tenant.x.event_pre_processing_time make sense, or should that be under zuul.event.<driver>.processing_time ? | 16:38 |
| tobiash | the pre-processing time probably fits better into the driver | 16:39 |
| tobiash | I'm in favor of the second suggestion on the etherpad | 16:40 |
| corvus | yeah, i'm leaning that way too | 16:40 |
| avass | should it be connection or driver? could a connection with a lot of events take more time than a connection of the same type with fewer events? | 16:41 |
| tobiash | actually connection | 16:42 |
| tobiash | corvus: do you know wether zuul.event.<driver>.<type> is actually driver or connection atm? | 16:42 |
| tobiash | the docs state driver | 16:43 |
| corvus | tobiash: i don't | 16:43 |
| tobiash | it's driver | 16:43 |
| corvus | i could definitely see us wanting to change that :) | 16:43 |
| tobiash | yeah, driver doesn't really make sense for that | 16:44 |
| tobiash | oh wait | 16:44 |
| tobiash | we also have zuul.event.<driver>.<connection>.<event-type> | 16:44 |
| tobiash | (that's undocumented it seems) | 16:45 |
| tobiash | or at least half documented | 16:45 |
| openstackgerrit | James E. Blair proposed zuul/zuul master: WIP stats updates https://review.opendev.org/c/zuul/zuul/+/781128 | 16:46 |
| corvus | tobiash, tristanC: ^ that's just a proposed doc update to match the zk-relevant parts of the etherpad | 16:47 |
| tobiash | that lgtm | 16:50 |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Update trigger/scheduler timestamps https://review.opendev.org/c/zuul/zuul/+/781128 | 16:54 |
| corvus | tobiash, tristanC: ^ if you could review that ASAP, i'd like to merge something quickly and restart opendev with it today to start collecting data | 16:54 |
| tobiash | lgtm | 16:56 |
| corvus | erm, i think we have some mixups with time.monotonic and time.time | 17:03 |
| corvus | i think the drivers are using time.time so we should do that | 17:07 |
| *** rpittau is now known as rpittau|afk | 17:08 | |
| *** jcapitao has quit IRC | 17:13 | |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Update trigger/scheduler timestamps https://review.opendev.org/c/zuul/zuul/+/781128 | 17:17 |
| corvus | tobiash, tristanC: ^ updated to time.time with tests | 17:18 |
| tristanC | corvus: shouldn't we do the otherway around, make the driver use time.monotonic? | 17:19 |
| tristanC | corvus: if i understand correctly, the last time.time() may be lesser than the initial time.time() if the system time change between measurement, resulting in possibly negative enqueue time | 17:19 |
| corvus | tristanC: i think those are also reported as real timestamp values | 17:19 |
| corvus | tristanC: yes, i think that's right | 17:20 |
| corvus | but if we switch to monotonic, we can't report the raw values | 17:20 |
| corvus | i think the most correct thing to do would be to record both things | 17:20 |
| corvus | like, every time we save a timestamp, record the time and monotonic, and use time for reporting raw values and monotonic for deltas | 17:21 |
| corvus | i think using time.time is the easiest thing to do now, and is only occasionally slightly incorrect; then maybe we should get more serious about timestamps and make a timestamp class that does both and use that everywhere? | 17:24 |
| tobiash | with scale out scheduler we anyway cannot use monotonic anymore since then those times will be cross process/machine | 17:26 |
| corvus | tobiash: i was just thinking the same thing | 17:26 |
| corvus | monotonic has an undefined reference point and is only guaranteed within the same process | 17:27 |
| corvus | and that's actually one of the things we want to measure here (once we have 2 schedulers, we'll be measuring enqueue on one scheduler to dequeue on another) | 17:28 |
| * corvus deletes newly created zuul/lib/timestamps.py | 17:28 | |
| corvus | tristanC: ^ i think we need to stick with time | 17:32 |
| *** hashar has joined #zuul | 17:36 | |
| corvus | tristanC: do you want to leave a review on https://review.opendev.org/781128 ? sorry to pester, but i'd like to restart that today to collect data | 17:39 |
| corvus | tristanC: (if you want to, i'll wait for your review; if you don't care, i can ask others) | 17:39 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add build-info subcommand https://review.opendev.org/c/zuul/zuul-client/+/751070 | 17:40 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add buildsets, buildset-info to subcommands https://review.opendev.org/c/zuul/zuul-client/+/752909 | 17:44 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add console-stream subcommand https://review.opendev.org/c/zuul/zuul-client/+/751238 | 17:47 |
| corvus | clarkb, fungi: can you review https://review.opendev.org/781128 asap? i'd like to get that into prod today so we have data before we start merging zk changes | 17:53 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add object models and support for formatters, document API https://review.opendev.org/c/zuul/zuul-client/+/755292 | 17:53 |
| *** newbie2020 has quit IRC | 17:54 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add change-status subcommand https://review.opendev.org/c/zuul/zuul-client/+/759838 | 17:56 |
| tristanC | corvus: i can review now | 17:58 |
| corvus | \o/ | 17:58 |
| clarkb | I think I've found the meetpad issue, and can review the chnge once testing and hopefully the fix is pushed for that | 18:04 |
| corvus | clarkb: i think we're gtg thanks to tristanC's review | 18:05 |
| clarkb | k | 18:06 |
| *** jpena is now known as jpena|off | 18:06 | |
| avass | it would be great to get some reviews on: https://review.opendev.org/c/zuul/zuul/+/760907 later, that's going to be annoying unless we set up separate pipelines for another connections in the coming week | 18:09 |
| avass | uh, actually I don't event think it matters if it's another pipeline since any triggers would apply to all connections of the same type | 18:10 |
| corvus | well, projects wouldn't be attached to the same pipelines if you made more | 18:11 |
| corvus | avass: is this all within a single tenant? | 18:11 |
| *** holser has quit IRC | 18:12 | |
| *** y2kenny has joined #zuul | 18:15 | |
| y2kenny | Hi, I just upgraded to 4.0.0 but my previously working zuul-config came back with error of "extra keys not allowed @ data['success']['mysql']". I am wondering if I misunderstood the release note that say "sql connection" being deprecated. | 18:32 |
| y2kenny | if I use a sql reporter, do I still need to have an [connection "mysql"] entry in addition to a [database] entry? | 18:33 |
| avass | corvus: yup | 18:34 |
| avass | corvus: no but it could still be a problem with secrets | 18:35 |
| avass | though I don't think we have that | 18:35 |
| corvus | avass: if it's multiple tenants, then it shouldn't be a a problem; within a tenant then probably someone could attach a project to the "wrong" pipeline and gain secrets access | 18:35 |
| avass | yup | 18:36 |
| *** jangutter has joined #zuul | 18:38 | |
| corvus | y2kenny: you no longer need a [connection "mysql"] entry in the config file, and you also no longer need a "success: mysql" attribute in pipelines | 18:38 |
| y2kenny | corvus: ok... so I remove both. Thanks | 18:39 |
| corvus | y2kenny: if you remove "success: mysql" from pipelines first, then remove [connection "mysql"] from the config file, that sequence should be error free | 18:39 |
| corvus | (and obviously add [database]) | 18:39 |
| avass | we also never fixed this: https://review.opendev.org/c/zuul/zuul/+/777638 | 18:39 |
| y2kenny | corvus: understood | 18:39 |
| avass | so that probably adds to the confusion :) | 18:40 |
| corvus | avass: ++ not for much longer :) | 18:40 |
| *** holser has joined #zuul | 18:44 | |
| *** jangutter_ has quit IRC | 18:46 | |
| *** yolanda has joined #zuul | 18:48 | |
| *** harrymichal has quit IRC | 19:07 | |
| *** harrymichal has joined #zuul | 19:07 | |
| *** nils has quit IRC | 19:07 | |
| *** y2kenny has quit IRC | 19:16 | |
| openstackgerrit | Merged zuul/zuul master: scheduler: add statsd metric for enqueue time https://review.opendev.org/c/zuul/zuul/+/776287 | 19:18 |
| *** bhavikdbavishi has joined #zuul | 19:22 | |
| openstackgerrit | Merged zuul/zuul master: Update trigger/scheduler timestamps https://review.opendev.org/c/zuul/zuul/+/781128 | 19:25 |
| *** bhavikdbavishi has quit IRC | 19:32 | |
| *** vishalmanchanda has quit IRC | 19:35 | |
| *** gmann is now known as gmann_afk | 19:41 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Web UI: add Autoholds, Autohold page https://review.opendev.org/c/zuul/zuul/+/768199 | 19:49 |
| mhu | Any chance the admin web ui patch chain can get some eyes? https://review.opendev.org/q/topic:%22fffaff%22+(status:open%20OR%20status:merged) - The compose in https://review.opendev.org/c/zuul/zuul/+/769943 should allow you to deploy zuul + keycloak without much trouble | 19:52 |
| openstackgerrit | Merged zuul/zuul master: Remove sqlreporter from example pipeline definitions https://review.opendev.org/c/zuul/zuul/+/777638 | 19:53 |
| *** rlandy is now known as rlandy|training | 20:48 | |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: web: add depends-on support to the freeze job API https://review.opendev.org/c/zuul/zuul/+/639022 | 20:58 |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: runner: add support for depends-on https://review.opendev.org/c/zuul/zuul/+/632064 | 20:58 |
| tobiash | mhu: does it now remember the session when refreshing the page? | 21:00 |
| corvus | tristanC: btw, if you want to start collecting those same zk stats discussed in #opendev, there is a prometheus exporter; so you have your choice of that or statsd | 21:16 |
| *** jangutter_ has joined #zuul | 21:22 | |
| *** jangutter has quit IRC | 21:24 | |
| *** rlandy|training is now known as rlandy | 21:45 | |
| *** sduthil has quit IRC | 21:52 | |
| *** harrymichal has quit IRC | 22:00 | |
| *** harrymichal has joined #zuul | 22:01 | |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Report enqueue stats as ms https://review.opendev.org/c/zuul/zuul/+/781169 | 22:04 |
| *** rlandy is now known as rlandy|bbl | 22:05 | |
| corvus | zuul-maint: brown-paper bag fix for the stats change ^ | 22:05 |
| *** hashar has quit IRC | 22:19 | |
| mhu | tobiash, it should now. The user info is serialized to the local storage after a successful login, which is shared among tabs | 22:30 |
| corvus | mhu: ++ | 22:36 |
| *** gmann_afk is now known as gmann | 22:39 | |
| avass | mhu: oh I wanna take a look at that | 22:48 |
| avass | mhu: I think the 'keycloak' hostname comes from the docker-compose file so it could be enough to just explicitly set hostname: localhost for the keycloak service | 22:51 |
| avass | mhu: yeah that works | 22:53 |
| openstackgerrit | Merged zuul/zuul master: Report enqueue stats as ms https://review.opendev.org/c/zuul/zuul/+/781169 | 23:13 |
| avass | mhu: I think I found a problem with the local store, if you logout you cannot login as another user because it automatically logs in as the first user you logged in as | 23:28 |
| *** harrymichal has quit IRC | 23:30 | |
| *** ajitha has quit IRC | 23:40 | |
| *** hamalq has quit IRC | 23:57 | |
| *** hamalq has joined #zuul | 23:57 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!