| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 819557: Report total duration when a build set is finished https://review.opendev.org/c/zuul/zuul/+/819557 | 02:42 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 819557: Report total duration when a build set is finished https://review.opendev.org/c/zuul/zuul/+/819557 | 04:08 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 819557: Report total duration when a build set is finished https://review.opendev.org/c/zuul/zuul/+/819557 | 05:00 | |
| -@gerrit:opendev.org- Felix Edel proposed on behalf of Simon Westphahl: [zuul/zuul] 815278: DNM: execute tests with two schedulers https://review.opendev.org/c/zuul/zuul/+/815278 | 07:51 | |
| -@gerrit:opendev.org- Felix Edel proposed: | 07:51 | |
| - [zuul/zuul] 818864: Limit scheduler_count to 1 for invalid tenant config tests https://review.opendev.org/c/zuul/zuul/+/818864 | ||
| - [zuul/zuul] 818867: Don't use RecordingMergeClient.history in TestNonLiveMerges https://review.opendev.org/c/zuul/zuul/+/818867 | ||
| - [zuul/zuul] 818868: Combine different history approaches for merge jobs in tests https://review.opendev.org/c/zuul/zuul/+/818868 | ||
| - [zuul/zuul] 819270: Add helper method to allow skipping test cases for multi scheduler https://review.opendev.org/c/zuul/zuul/+/819270 | ||
| - [zuul/zuul] 819271: Skip gerrit checks API scheme test on multi scheduler https://review.opendev.org/c/zuul/zuul/+/819271 | ||
| - [zuul/zuul] 819272: Limit scheduler_count to 1 (or skip) for some repo config tests https://review.opendev.org/c/zuul/zuul/+/819272 | ||
| - [zuul/zuul] 819313: Skip TestGitlabDriver.test_ref_update on multi scheduler https://review.opendev.org/c/zuul/zuul/+/819313 | ||
| - [zuul/zuul] 818205: Add source attribute to GitConnection https://review.opendev.org/c/zuul/zuul/+/818205 | ||
| - [zuul/zuul] 819408: Skip tests asserting on tenant reconfig results on multi scheduler https://review.opendev.org/c/zuul/zuul/+/819408 | ||
| - [zuul/zuul] 819407: Limit scheduler count to 1 for other github related tests https://review.opendev.org/c/zuul/zuul/+/819407 | ||
| - [zuul/zuul] 819606: Limit scheduler count to 1 for Elasticsearch connection tests https://review.opendev.org/c/zuul/zuul/+/819606 | ||
| -@gerrit:opendev.org- Felix Edel proposed on behalf of Simon Westphahl: [zuul/zuul] 815278: DNM: execute tests with two schedulers https://review.opendev.org/c/zuul/zuul/+/815278 | 08:26 | |
| -@gerrit:opendev.org- Felix Edel proposed: | 08:26 | |
| - [zuul/zuul] 819407: Limit scheduler count to 1 for other github related tests https://review.opendev.org/c/zuul/zuul/+/819407 | ||
| - [zuul/zuul] 819606: Limit scheduler count to 1 for Elasticsearch connection tests https://review.opendev.org/c/zuul/zuul/+/819606 | ||
| - [zuul/zuul] 819408: Skip tests asserting on tenant reconfig results on multi scheduler https://review.opendev.org/c/zuul/zuul/+/819408 | ||
| - [zuul/zuul] 819609: Copy project list in gitwatcher for iteration https://review.opendev.org/c/zuul/zuul/+/819609 | ||
| -@gerrit:opendev.org- Felix Edel proposed: | 09:12 | |
| - [zuul/zuul] 819407: Limit scheduler count to 1 for other github related tests https://review.opendev.org/c/zuul/zuul/+/819407 | ||
| - [zuul/zuul] 819606: Limit scheduler count to 1 for Elasticsearch connection tests https://review.opendev.org/c/zuul/zuul/+/819606 | ||
| - [zuul/zuul] 819609: Copy project list in gitwatcher for iteration https://review.opendev.org/c/zuul/zuul/+/819609 | ||
| - [zuul/zuul] 819408: Skip tests asserting on tenant reconfig results on multi scheduler https://review.opendev.org/c/zuul/zuul/+/819408 | ||
| -@gerrit:opendev.org- Felix Edel proposed on behalf of Simon Westphahl: [zuul/zuul] 815278: DNM: execute tests with two schedulers https://review.opendev.org/c/zuul/zuul/+/815278 | 09:12 | |
| -@gerrit:opendev.org- likui proposed: [zuul/nodepool] 819614: Replace deprecated assertEquals https://review.opendev.org/c/zuul/nodepool/+/819614 | 09:30 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Felix Edel: [zuul/zuul] 818774: Remove unused _get_reporter_from_connection_name helper method https://review.opendev.org/c/zuul/zuul/+/818774 | 13:22 | |
| -@gerrit:opendev.org- Felix Edel proposed on behalf of Simon Westphahl: [zuul/zuul] 815278: DNM: execute tests with two schedulers https://review.opendev.org/c/zuul/zuul/+/815278 | 13:56 | |
| -@gerrit:opendev.org- Felix Edel proposed: | 13:56 | |
| - [zuul/zuul] 819270: Add helper method to allow skipping test cases for multi scheduler https://review.opendev.org/c/zuul/zuul/+/819270 | ||
| - [zuul/zuul] 819271: Skip gerrit checks API scheme test on multi scheduler https://review.opendev.org/c/zuul/zuul/+/819271 | ||
| - [zuul/zuul] 819272: Limit scheduler_count to 1 (or skip) for some repo config tests https://review.opendev.org/c/zuul/zuul/+/819272 | ||
| - [zuul/zuul] 819313: Skip TestGitlabDriver.test_ref_update on multi scheduler https://review.opendev.org/c/zuul/zuul/+/819313 | ||
| - [zuul/zuul] 818205: Add source attribute to GitConnection https://review.opendev.org/c/zuul/zuul/+/818205 | ||
| - [zuul/zuul] 819407: Limit scheduler count to 1 for other github related tests https://review.opendev.org/c/zuul/zuul/+/819407 | ||
| - [zuul/zuul] 819606: Limit scheduler count to 1 for Elasticsearch connection tests https://review.opendev.org/c/zuul/zuul/+/819606 | ||
| - [zuul/zuul] 819609: Copy project list in gitwatcher for iteration https://review.opendev.org/c/zuul/zuul/+/819609 | ||
| - [zuul/zuul] 819408: Skip tests asserting on tenant reconfig results on multi scheduler https://review.opendev.org/c/zuul/zuul/+/819408 | ||
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 817949: zuul-web: add substring search on some fields https://review.opendev.org/c/zuul/zuul/+/817949 | 16:18 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed on behalf of Felix Edel: | 16:57 | |
| - [zuul/zuul] 819272: Limit scheduler_count to 1 (or skip) for some repo config tests https://review.opendev.org/c/zuul/zuul/+/819272 | ||
| - [zuul/zuul] 819313: Skip TestGitlabDriver.test_ref_update on multi scheduler https://review.opendev.org/c/zuul/zuul/+/819313 | ||
| - [zuul/zuul] 818205: Add source attribute to GitConnection https://review.opendev.org/c/zuul/zuul/+/818205 | ||
| - [zuul/zuul] 819407: Limit scheduler count to 1 for other github related tests https://review.opendev.org/c/zuul/zuul/+/819407 | ||
| - [zuul/zuul] 819606: Limit scheduler count to 1 for Elasticsearch connection tests https://review.opendev.org/c/zuul/zuul/+/819606 | ||
| - [zuul/zuul] 819609: Copy project list in gitwatcher for iteration https://review.opendev.org/c/zuul/zuul/+/819609 | ||
| - [zuul/zuul] 819408: Skip tests asserting on tenant reconfig results on multi scheduler https://review.opendev.org/c/zuul/zuul/+/819408 | ||
| @jim:acmegating.com | fungi, tobiash: https://review.opendev.org/819156 is a doc update that's ready to go; it moves parts of the sos spec into permament documentation. | 17:12 |
|---|---|---|
| @fungicide:matrix.org | thanks, reading it now | 17:44 |
| -@gerrit:opendev.org- Ade Lee proposed on behalf of Jiri Podivin: [zuul/zuul-jobs] 807031: DNM enable_fips role for zuul jobs https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 18:50 | |
| @fungicide:matrix.org | corvus: i suggested some edits on 819156, but overall looks good. thanks for writing it! | 18:58 |
| @jim:acmegating.com | fungi: thanks! | 19:11 |
| @jim:acmegating.com | though tobiash wrote a lot of it, i mostly just changed future tense to present :) | 19:11 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 19:12 | |
| - [zuul/zuul] 817495: Use merger API for merger stats https://review.opendev.org/c/zuul/zuul/+/817495 | ||
| - [zuul/zuul] 817626: Remove rpcclient from autohold tests https://review.opendev.org/c/zuul/zuul/+/817626 | ||
| - [zuul/zuul] 819699: Remove rpcclient tests https://review.opendev.org/c/zuul/zuul/+/819699 | ||
| - [zuul/zuul] 819700: Remove rpcclient use from github tests https://review.opendev.org/c/zuul/zuul/+/819700 | ||
| - [zuul/zuul] 819701: Remove rpcclient from gitlab tests https://review.opendev.org/c/zuul/zuul/+/819701 | ||
| - [zuul/zuul] 819702: Remove rpcclient from pagure tests https://review.opendev.org/c/zuul/zuul/+/819702 | ||
| - [zuul/zuul] 819703: Remove rpcclient from test_reporting https://review.opendev.org/c/zuul/zuul/+/819703 | ||
| - [zuul/zuul] 819704: Remove rpcclient from test_v3 https://review.opendev.org/c/zuul/zuul/+/819704 | ||
| - [zuul/zuul] 819705: Remove rpcclient from test_web https://review.opendev.org/c/zuul/zuul/+/819705 | ||
| - [zuul/zuul] 819706: Remove rpcclient from test_zuulclient https://review.opendev.org/c/zuul/zuul/+/819706 | ||
| - [zuul/zuul] 819707: Remove rpcclient from test_circular_dependencies https://review.opendev.org/c/zuul/zuul/+/819707 | ||
| - [zuul/zuul] 819708: Remove rpcclient from connection test fixtures https://review.opendev.org/c/zuul/zuul/+/819708 | ||
| - [zuul/zuul] 819709: Remove the rpc client and listener https://review.opendev.org/c/zuul/zuul/+/819709 | ||
| - [zuul/zuul] 819710: Remove disused gearman_server usages from tests https://review.opendev.org/c/zuul/zuul/+/819710 | ||
| - [zuul/zuul] 819711: Remove gearman server https://review.opendev.org/c/zuul/zuul/+/819711 | ||
| - [zuul/zuul] 819712: Remove gearman from docs https://review.opendev.org/c/zuul/zuul/+/819712 | ||
| @jim:acmegating.com | the gearmanectomy is nigh! | 19:12 |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 817949: zuul-web: add substring search on some fields https://review.opendev.org/c/zuul/zuul/+/817949 | 19:22 | |
| @clarkb:matrix.org | ooh | 19:32 |
| @fungicide:matrix.org | i hope it's an outpatient procedure, i'm not sure our insurance covers overnight observation | 20:03 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 20:41 | |
| - [zuul/zuul] 819708: Remove rpcclient from connection test fixtures https://review.opendev.org/c/zuul/zuul/+/819708 | ||
| - [zuul/zuul] 819709: Remove the rpc client and listener https://review.opendev.org/c/zuul/zuul/+/819709 | ||
| - [zuul/zuul] 819710: Remove disused gearman_server usages from tests https://review.opendev.org/c/zuul/zuul/+/819710 | ||
| - [zuul/zuul] 819711: Remove gearman server https://review.opendev.org/c/zuul/zuul/+/819711 | ||
| - [zuul/zuul] 819712: Remove gearman from docs https://review.opendev.org/c/zuul/zuul/+/819712 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 819156: Add SOS documentation and remove spec https://review.opendev.org/c/zuul/zuul/+/819156 | 21:01 | |
| @jim:acmegating.com | fungitobiash ^ addressed comments if you have time for a quick re-review | 21:03 |
| @fungicide:matrix.org | corvus: lgtm other than the new typo that revision added, see inline | 21:10 |
| @jim:acmegating.com | argh | 21:14 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 819156: Add SOS documentation and remove spec https://review.opendev.org/c/zuul/zuul/+/819156 | 21:14 | |
| @fungicide:matrix.org | i know the feeling | 21:20 |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 817949: zuul-web: add substring search on some fields https://review.opendev.org/c/zuul/zuul/+/817949 | 21:28 | |
| @spamaps:spamaps.ems.host | > <@jim:acmegating.com> the gearmanectomy is nigh! | 21:35 |
| For whom the bell tolls? | ||
| @spamaps:spamaps.ems.host | 🤘THE BELL TOLLS FOR ME 🤘 | 21:35 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 819023: Add a scale-out-scheduler smoke test https://review.opendev.org/c/zuul/zuul/+/819023 | 22:14 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 819727: Don't delete pipeline summary objects if they have a syntax error https://review.opendev.org/c/zuul/zuul/+/819727 | 22:17 | |
| @jim:acmegating.com | that's a patch to fix an issue frickler noticed in opendev over the weekend | 22:19 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed on behalf of Felix Edel: | 23:26 | |
| - [zuul/zuul] 818862: Only use a single createScheduler() helper method in tests https://review.opendev.org/c/zuul/zuul/+/818862 | ||
| - [zuul/zuul] 818863: Limit scheduler_count to 1 for Scale out Scheduler tests https://review.opendev.org/c/zuul/zuul/+/818863 | ||
| - [zuul/zuul] 818864: Limit scheduler_count to 1 for invalid tenant config tests https://review.opendev.org/c/zuul/zuul/+/818864 | ||
| - [zuul/zuul] 818867: Don't use RecordingMergeClient.history in TestNonLiveMerges https://review.opendev.org/c/zuul/zuul/+/818867 | ||
| - [zuul/zuul] 818868: Combine different history approaches for merge jobs in tests https://review.opendev.org/c/zuul/zuul/+/818868 | ||
| - [zuul/zuul] 819270: Add helper method to allow skipping test cases for multi scheduler https://review.opendev.org/c/zuul/zuul/+/819270 | ||
| - [zuul/zuul] 819271: Skip gerrit checks API scheme test on multi scheduler https://review.opendev.org/c/zuul/zuul/+/819271 | ||
| - [zuul/zuul] 819272: Limit scheduler_count to 1 (or skip) for some repo config tests https://review.opendev.org/c/zuul/zuul/+/819272 | ||
| - [zuul/zuul] 819313: Skip TestGitlabDriver.test_ref_update on multi scheduler https://review.opendev.org/c/zuul/zuul/+/819313 | ||
| - [zuul/zuul] 818205: Add source attribute to GitConnection https://review.opendev.org/c/zuul/zuul/+/818205 | ||
| - [zuul/zuul] 819407: Limit scheduler count to 1 for other github related tests https://review.opendev.org/c/zuul/zuul/+/819407 | ||
| - [zuul/zuul] 819606: Limit scheduler count to 1 for Elasticsearch connection tests https://review.opendev.org/c/zuul/zuul/+/819606 | ||
| - [zuul/zuul] 819609: Copy project list in gitwatcher for iteration https://review.opendev.org/c/zuul/zuul/+/819609 | ||
| - [zuul/zuul] 819408: Skip tests asserting on tenant reconfig results on multi scheduler https://review.opendev.org/c/zuul/zuul/+/819408 | ||
| @clarkb:matrix.org | corvus: felixedel for https://review.opendev.org/c/zuul/zuul/+/819271/6/tests/unit/test_gerrit.py why not put the test case in a test class with a single scheduler? I think the scheduler count is fixed right? we can just set it back to 1 for that one test? | 23:26 |
| @clarkb:matrix.org | I'm not sure why we need a conditional skip if we know and control the number of schedulers | 23:27 |
| @jim:acmegating.com | Clark: i think it's to keep the churn/delta small. that test isn't really worth moving to its own class because it only happens to be failing due to the way it was written (actually, the way the test infrastructure was designed). ideally we will rework that test infrastructure and remove the skip. | 23:29 |
| @jim:acmegating.com | i think there are 3 cases: | 23:29 |
| @clarkb:matrix.org | the next change does what I suggest for another test case though so it seems like this is reasonable? | 23:30 |
| @clarkb:matrix.org | I guess it is weird to me to do a skip when we have a trivial fix that can be employed (and indeed the next change does the trivial fix for another situation) | 23:31 |
| @jim:acmegating.com | 1) test intentionally designed for a single scheduler (test_sos is ironically like this because they deliberately start the second scheduler). these should set the class variable to scheduler_count=1 | 23:31 |
| 2) entire test class that accidentally doesn't work with 2 schedulers: set class var to 1 because it's the least churn | ||
| 3) single test class that doesn't work with 2 schedulers: add skip because it's the least churn | ||
| @jim:acmegating.com | Clark: either way (option 2 or 3) that test will not be giving us information about potential problems with a second scheduler, so choosing based on least code churn makes sense to me | 23:32 |
| @clarkb:matrix.org | after the fun of zuulv3 I think having a test case transition to a class that we can hopefully move it out of one day so that we have some coverage is preferable to disabling it entirely | 23:33 |
| @jim:acmegating.com | (there is a trade-off between potentially catching issues running under one scheduler while generally running the tests with 2 schedulers, but since we're always going to run the suite with 1 scheduler in the gate anyway, i'm not too worried about running as many single-scheduler tests as possible when running the suite with 2 schedulers; arguably, we might like that it runs fewer tests in thate case) | 23:33 |
| @jim:acmegating.com | oh... so let's be clear here | 23:34 |
| @clarkb:matrix.org | "we're always going to run the suite with 1 scheduler in the gate anyway" <- this is something that isn't claer to me | 23:35 |
| @jim:acmegating.com | this effort is aimed at creating the possibility to run the test suite with 2 schedulers so that we might sort of randomly catch some bugs. it's totally a best-effort thing. it's not something we will enable in the gate, because it's way too flaky. | 23:35 |
| @clarkb:matrix.org | Ok so something will followup at the end to bump the default count to say 2 | 23:35 |
| @clarkb:matrix.org | but that will be opt in | 23:35 |
| @jim:acmegating.com | we might do a non-voting job just to exercise it... | 23:36 |
| -@gerrit:opendev.org- Zuul merged on behalf of Felix Edel: [zuul/zuul] 818775: Add missing attributes to Gitlab MergeRequest https://review.opendev.org/c/zuul/zuul/+/818775 | 23:36 | |
| @jim:acmegating.com | i think the default will remain 1 for the forseeable future | 23:36 |
| @jim:acmegating.com | setting it to 2 will happen either in local testing or in a non-voting gate job | 23:36 |
| @jim:acmegating.com | it's basically throwing spaghetti at the wall :) | 23:36 |
| @clarkb:matrix.org | gotcha | 23:36 |
| @jim:acmegating.com | it's useful though! several bugfixes from felixedel and swest came out of this | 23:37 |
| @jim:acmegating.com | i think maybe if we add a non-voting job and it's stable, we can think about making it voting. but my expectations are very low just because of how much stuff would have to just coincidentally work. | 23:38 |
| @clarkb:matrix.org | I think in my head this work was making it so that scheduler count could be >1 by default | 23:39 |
| @clarkb:matrix.org | but in reality we're just making it possible to run that way but not as a default | 23:39 |
| @clarkb:matrix.org | in which case skipping under non default conditions is fine | 23:39 |
| @jim:acmegating.com | yep; i think it will be potentially useful for changes where we say "hrm i wonder if that could have an effect under 2 schedulers"... run it and if it blows up more than normal, dig deeper | 23:40 |
| @jim:acmegating.com | Clark: i rebased and +w'd up to where you are, so if you want to continue with +3s feel free | 23:40 |
| @clarkb:matrix.org | ok. I think I've gotten ahead too. but I can +3 any I already +2'd | 23:41 |
| @clarkb:matrix.org | alright I think that entire stack is approved now | 23:45 |
| @jim:acmegating.com | \o/ | 23:46 |
| @clarkb:matrix.org | corvus: does the toggle to switch to multiple schedulers already exist? | 23:52 |
| @jim:acmegating.com | Clark: yeah, i think that landed a few days ago; i think it's an env variable to set when running testr | 23:52 |
| @clarkb:matrix.org | ok that hint helped it is ZUUL_SCHEDULER_COUNT | 23:53 |
| @clarkb:matrix.org | is it worth adding a change to the end of that stack to add a nonvoting py38 job that sets it to 2? | 23:53 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 818300: Add support for adding and removing labels in gitlab https://review.opendev.org/c/zuul/zuul/+/818300 | 23:54 | |
| @jim:acmegating.com | Clark: yeah i think so | 23:55 |
| @clarkb:matrix.org | oh there is a DNM change already | 23:56 |
| @clarkb:matrix.org | it needs to be rebased and maybe updated to just run the tests as non voting. I can do that update | 23:56 |
| @jim:acmegating.com | cool. based on the comments in that, we may still be a little ways away from that even sort-of working :) | 23:57 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!