| @jim:acmegating.com | zuul-maint: how does this look for zuul 4.12.0? commit 1ed186108956a1f7cc5fe34dc9d93731beaa56f6 (HEAD -> master, tag: 4.12.0, origin/master, refs/changes/87/825087/2) | 15:52 |
|---|---|---|
| @jim:acmegating.com | pushed 4.12.0 | 17:35 |
| @spamaps:spamaps.ems.host | I'm refreshing my zuul experiment.. should I go 4.11.0 or wait for 4.12.0 to get through the tubes? | 17:38 |
| @fungicide:matrix.org | corvus: thanks! belated lgtm for 4.12.0 | 17:42 |
| @fungicide:matrix.org | spamaps: skimming the git log between those tags, there's a slew of bugfixes, some performance improvements, and also pagination in the webui | 17:46 |
| @fungicide:matrix.org | also it's almost-v5 (basically just shy the gearmanectomy now i think?) | 17:47 |
| @clarkb:matrix.org | ya I think we can approve the gearmanectomy now. Though not sure if we are wanting to wait on that for any 4.12.0 porlbme reports | 17:48 |
| @spamaps:spamaps.ems.host | I'm on 4.10.4 at the moment so not that far behind | 17:48 |
| @spamaps:spamaps.ems.host | just wanted to pull in latest everything as we start the next phase .. running actual jobs in paralllel with our other CI system. | 17:48 |
| @fungicide:matrix.org | spamaps: pypi and dockerhub uploads are already in progress, so likely will appear momentarily | 17:48 |
| @spamaps:spamaps.ems.host | well I might as well do 4.12.0 then | 17:49 |
| @fungicide:matrix.org | yeah, if it were me, i'd take the opportunity to grab a cup of coffee or something | 17:49 |
| @spamaps:spamaps.ems.host | That's exactly what I'm doing. Haven't had breakfast yet. | 17:50 |
| @ecsantos:matrix.org | Hello folks, I have a quick question: how are Gerrit comments formatted in Zuul? After pipeline.success [1], there's additional job information (which passed and which didn't), and I'd like to know how Zuul knows where the logs are (looking at the base job I don't see if/where it reports the URLs back to Zuul). I know I can turn it on or off [3], but I didn't find any options to customize it, for example. | 18:03 |
| [1] https://zuul-ci.org/docs/zuul/latest/config/pipeline.html#attr-pipeline.success | ||
| [2] https://opendev.org/opendev/base-jobs/raw/branch/master/playbooks/base/post-logs.yaml | ||
| [3] https://zuul-ci.org/docs/zuul/latest/drivers/gerrit.html#attr-pipeline.reporter.%3Cgerrit%20reporter%3E.comment | ||
| @ecsantos:matrix.org | * Hello folks, I have a quick question: how are Gerrit comments formatted in Zuul? After pipeline.success [1], there's additional job information (which passed and which didn't), and I'd like to know how Zuul knows where the logs are (looking at the base job [2] I don't see if/where it reports the URLs back to Zuul). I know I can turn it on or off [3], but I didn't find any options to customize it, for example. | 18:03 |
| [1] https://zuul-ci.org/docs/zuul/latest/config/pipeline.html#attr-pipeline.success | ||
| [2] https://opendev.org/opendev/base-jobs/raw/branch/master/playbooks/base/post-logs.yaml | ||
| [3] https://zuul-ci.org/docs/zuul/latest/drivers/gerrit.html#attr-pipeline.reporter.%3Cgerrit%20reporter%3E.comment | ||
| @clarkb:matrix.org | ecsantos: the upload task called by the post-logs.yaml playbook does it: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/upload-logs-swift/tasks/main.yaml#L34-L39 | 18:05 |
| @ecsantos:matrix.org | Clark: And zuul.log_url is formatted in the code, right? To be presented to Gerrit | 18:08 |
| @ecsantos:matrix.org | I mean, the actual string that is commented in the changes | 18:11 |
| @fungicide:matrix.org | ecsantos: if you're looking to customize it, that can be done in your pipeline definitions, like so: https://opendev.org/zuul/project-config/src/branch/master/zuul.d/pipelines.yaml#L6-L9 | 18:14 |
| @fungicide:matrix.org | customizing the message included with the build results that is | 18:15 |
| @ecsantos:matrix.org | fungi: Yes, but is it possible to customize the job results message below that? Or are they hard coded? An example: "• zuul-build-image https://zuul.opendev.org/t/zuul/build/be100f62da5a4f14b555f9dfff45324f : SUCCESS in 42m 36s" | 18:16 |
| @clarkb:matrix.org | Oh I see you aren't concerned so much about how the log urls is set as much as the entire message | 18:19 |
| @clarkb:matrix.org | I want to say the entire message may be hard coded | 18:19 |
| @fungicide:matrix.org | ecsantos: that's determined by the _formatItemReportJobs() method of the reporter, as seen here: https://opendev.org/zuul/zuul/src/branch/master/zuul/reporter/__init__.py#L193-L195 | 18:19 |
| @clarkb:matrix.org | since we got rid of success and error message? | 18:20 |
| @fungicide:matrix.org | the table itself isn't customizable other than with a custom reporter | 18:20 |
| @ecsantos:matrix.org | Oh I see now, thanks guys, that's exatcly what I was looking for :) | 18:22 |
| @fungicide:matrix.org | ecsantos: if you can explain how you want it changed, that might better help us determine if that's something which could be supported by implementing new configuration options, or if it's outside the scope/intent of the project | 18:22 |
| @ecsantos:matrix.org | Nah I'm personally happy with it, just curious on how the string was generated, since I didn't find an option to customize it | 18:23 |
| @ecsantos:matrix.org | But new configuration options to customize it sounds cool, wouldn't something like a string with some variable substitutions do the job? Or is the table generation more complex than that? | 18:25 |
| @clarkb:matrix.org | Well we had that in the past and we're trying to get away from it | 18:25 |
| @clarkb:matrix.org | The Zuul web UI is quite featureful now so the idea is to redirect people to that rather than try and put all the info in the code review system comments | 18:26 |
| @ecsantos:matrix.org | Oh I see, that makes sense | 18:28 |
| @fungicide:matrix.org | yeah, options to format the table differently might make sense depending on what formatting it was, but changing what links are included for the builds is probably not going to fit with the plans for the project as we already took out the feature allowing linking directly to the logs instead of the result dashboard | 18:45 |
| @fungicide:matrix.org | linking the dashboard's build results page provides a more consistent user experience | 18:46 |
| @fungicide:matrix.org | you can get to the raw logs directly from the build results page, but not the other way around (and also the build results page provides links to other things builds may create, like artifacts) | 18:47 |
| @jim:acmegating.com | ecsantos: to have the zuul results show up in a nicer table in gerrit, see this plugin https://gerrit.googlesource.com/plugins/zuul-results-summary/ (that is in use on opendev's gerrit) | 18:50 |
| @ecsantos:matrix.org | fungi: I agree with the UX argument, I just have one use case that I'd like to bring to the table. In my team we have a private Zuul instance running our jobs. The Zuul instance is behind our intranet, but our log server is publicly accessible. My understading is that, with the current implementation, we won't be able to publish log URLs to Gerrit, right? | 18:53 |
| @ecsantos:matrix.org | Or is it possible to pass the zuul.log_url variable to the success message? | 18:53 |
| @ecsantos:matrix.org | corvus: Thanks! I'll take a look :) | 18:53 |
| @fungicide:matrix.org | ecsantos: correct, the zuul-web component is intended to be run somewhere accessible by users. note that it's not necessary to run it on the same system as any other parts of zuul, and it supports access controls | 18:54 |
| @fungicide:matrix.org | the system is designed so that you'd be able to run zuul-web in a different network like a dmz, and it uses only authenticated and encrypted connections to communicate with other components | 18:55 |
| @fungicide:matrix.org | ecsantos: see this document for what communications you'd need to allow between zuul-web and other components: https://zuul-ci.org/docs/zuul/latest/components.html | 18:57 |
| @ecsantos:matrix.org | fungi: I see, that's good to know. Thank you! :) | 18:57 |
| @ecsantos:matrix.org | Yeah, I usually do an AIO Zuul deploy but separating Zuul Web is a nice option I didn't think about | 18:57 |
| @clarkb:matrix.org | It does need to talk to zookeeper though | 18:58 |
| @clarkb:matrix.org | But that is authenticated and done with tls now | 18:58 |
| @fungicide:matrix.org | and with the most recent releases of zuul, you can even run multiple zuul-web services and use a load balancer to manage high availability | 18:58 |
| @fungicide:matrix.org | something we've been meaning to set up in our deployment as well | 18:59 |
| @ecsantos:matrix.org | That's nice. One instance with TLS should be enough for us | 19:01 |
| @spamaps:spamaps.ems.host | There's no nodepool-builder driver for GCE.. bummer. | 19:10 |
| @josefwells:matrix.org | Hello, I'm seeing issues going from 4.3.0 to 4.4.0, external MySQL server and I get errors: ERROR zuul.SQLConnection: Unable to connect to the database or establish the required tables. | 20:14 |
| @fungicide:matrix.org | josefwells: looking at https://zuul-ci.org/docs/zuul/latest/releasenotes.html#relnotes-4-4-0 i don't see any upgrade steps related to database connections, did you change anything in your configuration while upgrading? | 20:38 |
| @fungicide:matrix.org | are you sure about those version numbers? they're coincidentally the most recent two nodepool releases, and you didn't specifically say you were upgrading zuul, so just want to double-check (but nodepool doesn't use an sql db) | 20:41 |
| @josefwells:matrix.org | fungi: Nothing changed in my config. I went from 4.2ish to 4.11 and found this problem. So I went back to 4.3, it worked, and 4.4 broke me. I left nodepool at 4.4.0, since that seemed to not break anything. | 21:22 |
| @clarkb:matrix.org | josefwells: fungi: could it be related to the chagne of the database configuration directives? They were done to be backward compatible but maybe somethign was missed | 21:28 |
| @jim:acmegating.com | they were done in 4.0 | 21:30 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 826158: Add upload-logs-ibm role https://review.opendev.org/c/zuul/zuul-jobs/+/826158 | 21:47 | |
| @fungicide:matrix.org | josefwells: and you're using the newer 4.0.0 style database configuration like https://zuul-ci.org/docs/zuul/latest/configuration.html#database (not the deprecated sql reporter)? | 21:57 |
| @jim:acmegating.com | I've approved the gearmanectomy stack | 23:17 |
| @clarkb:matrix.org | Today is full of fun excitement! | 23:18 |
| @josefwells:matrix.org | fungi: yeah, crazy thing is if I go in and delete the database, then fire up zuul, I see the database and tables get recreated. | 23:37 |
| [connection "mysql"] | ||
| name=mysql | ||
| driver=sql | ||
| dburi=mysql+pymysql://zuul:%(ZUUL_MYSQL_PASSWORD)s@myserver/zuul | ||
| @josefwells:matrix.org | Seems like I have to create the zuul database, then the tables get filled in, but I still get errors from scheduler (in 4.11.0 I was also getting errors from zuul_web) | 23:58 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!