| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 833676: Clear branch cache on full reconfiguration https://review.opendev.org/c/zuul/zuul/+/833676 | 00:26 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: | 07:07 | |
| - [zuul/zuul] 830707: Use a transaction for BuildCompletedEvent https://review.opendev.org/c/zuul/zuul/+/830707 | ||
| - [zuul/zuul] 830896: Use kazoo.retry in zkobject https://review.opendev.org/c/zuul/zuul/+/830896 | ||
| @q:fricklercloud.de | fungi: tobiash the links to your keys in https://zuul-ci.org/docs/zuul/latest/vulnerabilities.html seem to be non-functional | 07:47 |
|---|---|---|
| -@gerrit:opendev.org- Tobias Henkel proposed: [zuul/zuul] 833726: Fix links to pgp keys https://review.opendev.org/c/zuul/zuul/+/833726 | 07:57 | |
| -@gerrit:opendev.org- Albin Vass proposed: [zuul/zuul-jobs] 833755: Add flag to reset submodules https://review.opendev.org/c/zuul/zuul-jobs/+/833755 | 09:53 | |
| -@gerrit:opendev.org- Albin Vass proposed: [zuul/zuul-jobs] 833755: Add flag to reset submodules https://review.opendev.org/c/zuul/zuul-jobs/+/833755 | 10:09 | |
| -@gerrit:opendev.org- Albin Vass proposed: [zuul/zuul-jobs] 833755: Add flag to reset submodules https://review.opendev.org/c/zuul/zuul-jobs/+/833755 | 10:09 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 833760: Fix ZKObject compressed data size estimate https://review.opendev.org/c/zuul/zuul/+/833760 | 10:17 | |
| @fungicide:matrix.org | > <@q:fricklercloud.de> fungi: tobiash the links to your keys in https://zuul-ci.org/docs/zuul/latest/vulnerabilities.html seem to be non-functional | 13:17 |
| thanks for the heads up, looks like that was broken in the transition to versioned documentation. i'll get a change up to correct that, but i'm also probably overdue for refreshing the copy of my key there with an updated self-sig expiration, and we need to drop the sks keyservers links now that their network has collapsed. series of changes for all of that up shortly | ||
| @tobias.henkel:matrix.org | fungi: see https://review.opendev.org/c/zuul/zuul/+/833726 | 13:19 |
| @tobias.henkel:matrix.org | * fungi: : see https://review.opendev.org/c/zuul/zuul/+/833726 | 13:20 |
| @tobias.henkel:matrix.org | * fungi: see https://review.opendev.org/c/zuul/zuul/+/833726 | 13:20 |
| @fungicide:matrix.org | oh, thanks tobiash! i'll add my other fixes atop that, then | 13:20 |
| -@gerrit:opendev.org- Jeremy Stanley https://matrix.to/#/@fungicide:matrix.org proposed: | 13:33 | |
| - [zuul/zuul] 833790: Drop SKS Keyserver links from vulnerabilities doc https://review.opendev.org/c/zuul/zuul/+/833790 | ||
| - [zuul/zuul] 833791: Refresh self-keysig expiration on my OpenPGP key https://review.opendev.org/c/zuul/zuul/+/833791 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 821711: Add IBM Cloud VPC driver https://review.opendev.org/c/zuul/nodepool/+/821711 | 13:50 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 833794: Log debug messages when remote ref is missing https://review.opendev.org/c/zuul/zuul/+/833794 | 13:50 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 833794: Log debug messages when remote ref is missing https://review.opendev.org/c/zuul/zuul/+/833794 | 14:58 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 833794: Log debug messages when remote ref is missing https://review.opendev.org/c/zuul/zuul/+/833794 | 15:07 | |
| -@gerrit:opendev.org- Tristan Cacqueray proposed: [zuul/zuul] 833841: WIP: web: add builds order_by attribute https://review.opendev.org/c/zuul/zuul/+/833841 | 15:24 | |
| @clarkb:matrix.org | corvus: https://review.opendev.org/c/zuul/zuul/+/833691 is a first step at trying to make the nodejs memory problems happier. If that doesn't help or makes it worse then I think we may need to find a way to pass in nodejs memory settings to the react-scripts build command | 15:37 |
| @jim:acmegating.com | Clark: lgtm; i'm unaware of any reason we might need to stay on an older v. | 15:39 |
| -@gerrit:opendev.org- Zuul merged on behalf of Tobias Henkel: [zuul/zuul] 833726: Fix links to pgp keys https://review.opendev.org/c/zuul/zuul/+/833726 | 16:04 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Jeremy Stanley https://matrix.to/#/@fungicide:matrix.org: | 16:21 | |
| - [zuul/zuul] 833790: Drop SKS Keyserver links from vulnerabilities doc https://review.opendev.org/c/zuul/zuul/+/833790 | ||
| - [zuul/zuul] 833791: Refresh self-keysig expiration on my OpenPGP key https://review.opendev.org/c/zuul/zuul/+/833791 | ||
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/nodepool] 821711: Add IBM Cloud VPC driver https://review.opendev.org/c/zuul/nodepool/+/821711 | 16:23 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Clark Boylan: [zuul/zuul] 833691: Update nodejs runtime to version 16 https://review.opendev.org/c/zuul/zuul/+/833691 | 17:01 | |
| @q:fricklercloud.de | should changing from one (github) connection to another in zuul.conf be supported? I kept getting zuul crashes because it still tried to do things with the old connection. solved for now by dumping zookeeper data completely, as this was still a wip deployment. but maybe people would like to migrate from github to gerrit at some stage | 19:52 |
| @clarkb:matrix.org | > <@q:fricklercloud.de> should changing from one (github) connection to another in zuul.conf be supported? I kept getting zuul crashes because it still tried to do things with the old connection. solved for now by dumping zookeeper data completely, as this was still a wip deployment. but maybe people would like to migrate from github to gerrit at some stage | 19:53 |
| The OpenDev zuul is currently connected to the opendev gerrit, gerrit's gerrit, and one other gerrit iirc. As well as github.com. It should be supported | ||
| @clarkb:matrix.org | You probably need to change the connection names though | 19:53 |
| @q:fricklercloud.de | but we never dropped a connection from opendev zuul so far, did we? | 20:04 |
| @q:fricklercloud.de | guess I can do a testcase with that in the quickstart setup | 20:05 |
| @jim:acmegating.com | q: there's a lot of stuff in zuul that assumes connection names are synonymous with their corresponding systems, so yeah, changing the target of a connection without changing the name would require a downtime and 'zuul delete-state'. | 20:28 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 833918: Fix gitlab timer events https://review.opendev.org/c/zuul/zuul/+/833918 | 20:44 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 833918: Fix gitlab timer events https://review.opendev.org/c/zuul/zuul/+/833918 | 20:44 | |
| @clarkb:matrix.org | ianw: I'm looking at https://review.opendev.org/c/zuul/zuul/+/832486/5/zuul/web/__init__.py and two things pop out at me. First is that HEAD seems like a valid request against those URLS? In fact it seems we use HEAD for the opendev haproxy http checks. Second is that cherrypy seems to have an @cherrypy.tools.handle_options(allowed_methods=['GET', ]) decorator that we use in some places. I wonder if that might be a better way to accomplish this? | 20:48 |
| @clarkb:matrix.org | Left the notes inlien as well. I think I'll hold off on reviewing the rest of the stack until you can take a look at that as I expect this may impact the whole stack | 20:50 |
| @clarkb:matrix.org | corvus: https://review.opendev.org/c/zuul/zuul-registry/+/831440/ is the point in ianw's registry stack that you haven't reviewed yet if you have time to take a look at the rest of it. I think you've already reviewed a good chunk of what was going on there. | 20:53 |
| @jim:acmegating.com | Clark: thx, i left notes for myself, so some easy +3s there. cc ianw | 20:55 |
| -@gerrit:opendev.org- Zuul merged on behalf of lotorev vitaly: [zuul/zuul] 833514: Switch to 8005 nodepool webapp port in example docs https://review.opendev.org/c/zuul/zuul/+/833514 | 21:05 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: [zuul/zuul-registry] 831319: podman buildset testing: dump image list https://review.opendev.org/c/zuul/zuul-registry/+/831319 | 21:39 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: | 21:41 | |
| - [zuul/zuul-registry] 831339: podman: make sure we remove the pulled image https://review.opendev.org/c/zuul/zuul-registry/+/831339 | ||
| - [zuul/zuul-registry] 831440: Fix and/or matching for image pre-conditions https://review.opendev.org/c/zuul/zuul-registry/+/831440 | ||
| @iwienand:matrix.org | Clark: to the first, I guess we should support HEAD; i imagine currently we just return the whole body | 22:24 |
| @clarkb:matrix.org | ianw: ya I suspect HEAD is equivalent to GET in this case | 22:25 |
| @clarkb:matrix.org | but at least that makes things like haproxy happy (though I have now discovered that we HEAD / not /api so not affected?) | 22:25 |
| @iwienand:matrix.org | with the second about the decorator, that was suggested but i thought it was worth considering separately; https://review.opendev.org/c/zuul/zuul/+/832731 | 22:25 |
| @iwienand:matrix.org | curl --head https://zuul.opendev.org is doing the right thing | 22:27 |
| @clarkb:matrix.org | oh interesting I didn't realize that was our own implementation of a decorator | 22:27 |
| @jim:acmegating.com | and so does /api/info | 22:27 |
| @iwienand:matrix.org | i wonder if cherrypy intercepts that | 22:28 |
| @jim:acmegating.com | i would characterize it as "handling correctly" rather than "intercepting", but i do think cherrypy is responsible for the correct behavior. | 22:29 |
| @iwienand:matrix.org | well yeah, it must pass it on to the handlers as a GET? because there's no specific HEAD handling I can see | 22:30 |
| @iwienand:matrix.org | i guess currently with the @expose decorator like https://opendev.org/zuul/zuul/src/branch/master/zuul/web/__init__.py#L822 it is returning the full response | 22:34 |
| @iwienand:matrix.org | presumably cherry-py then lops off the content if it's a HEAD request | 22:35 |
| @iwienand:matrix.org | but you might be right that if we do a if request == GET in there, we won't respond correctly to HEAD requests now | 22:36 |
| @clarkb:matrix.org | ya I suspect the request would nknow it is a head request and raise the error | 22:36 |
| @iwienand:matrix.org | so presumably we could do the same, and just treat GET==HEAD | 22:36 |
| @clarkb:matrix.org | ++ | 22:37 |
| @iwienand:matrix.org | a good unit test would be to GET and then HEAD and make sure the content-length is the same i guess | 22:38 |
| @jim:acmegating.com | it looks like you're trying to make DELETE not work -- how about updating the route dispatcher instead? | 22:40 |
| @jim:acmegating.com | that would be the more framework-native thing to do in cherrypy | 22:40 |
| @iwienand:matrix.org | well more than DELETE just make it so that endpoints that only make sense to GET from fail with anything else | 22:42 |
| @iwienand:matrix.org | it's a minor thing, but the haproxy did highlight that monitoring things do probe apis in ways like that | 22:42 |
| @jim:acmegating.com | sure -- you can specify with the route dispatcher what methods are valid | 22:43 |
| @jim:acmegating.com | that's a better place for that rather than in the handler itself | 22:43 |
| @jim:acmegating.com | ianw: https://docs.cherrypy.dev/en/3.2.6/concepts/dispatching.html#other-dispatchers | 22:47 |
| @iwienand:matrix.org | ahh, i guess "conditions=" in there | 22:47 |
| @jim:acmegating.com | yeah i think that should do it | 22:48 |
| @iwienand:matrix.org | https://docs.cherrypy.dev/en/3.2.6/refman/_cpdispatch.html#cherrypy._cpdispatch.Dispatcher is ... interesting | 22:53 |
| @iwienand:matrix.org | some things it seems autogenerated docs are not good for | 22:54 |
| @iwienand:matrix.org | i'll rework the changes, probably not today | 23:02 |
| @clarkb:matrix.org | no rush, just wanted to make sure we didn't do something silly there | 23:02 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!