| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 851093: ensure-kubernetes: install cri-dockerd https://review.opendev.org/c/zuul/zuul-jobs/+/851093 | 00:19 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 851093: ensure-kubernetes: install cri-dockerd https://review.opendev.org/c/zuul/zuul-jobs/+/851093 | 00:30 | |
| @iwienand:matrix.org | there seem to be two things stuck in the gate according to the status page -> https://zuul.opendev.org/t/zuul/status | 00:44 |
|---|---|---|
| @iwienand:matrix.org | https://review.opendev.org/850119 and https://review.opendev.org/850694 | 00:44 |
| -@gerrit:opendev.org- Ian Wienand proposed: | 00:54 | |
| - [zuul/zuul-jobs] 851093: ensure-kubernetes: install cri-dockerd; fix networking https://review.opendev.org/c/zuul/zuul-jobs/+/851093 | ||
| - [zuul/zuul-jobs] 851089: test/upload-pypi : install venv https://review.opendev.org/c/zuul/zuul-jobs/+/851089 | ||
| - [zuul/zuul-jobs] 851088: setup.py: override modules to stop auto-detection https://review.opendev.org/c/zuul/zuul-jobs/+/851088 | ||
| - [zuul/zuul-jobs] 851014: linters: fix spaces between filters https://review.opendev.org/c/zuul/zuul-jobs/+/851014 | ||
| - [zuul/zuul-jobs] 851015: linters: add names to blocks https://review.opendev.org/c/zuul/zuul-jobs/+/851015 | ||
| - [zuul/zuul-jobs] 851016: linters: rename loop variable https://review.opendev.org/c/zuul/zuul-jobs/+/851016 | ||
| - [zuul/zuul-jobs] 851017: linters: update to ansible-lint 6 https://review.opendev.org/c/zuul/zuul-jobs/+/851017 | ||
| -@gerrit:opendev.org- Ian Wienand proposed: | 01:14 | |
| - [zuul/zuul-jobs] 851088: setup.py: override modules to stop auto-detection https://review.opendev.org/c/zuul/zuul-jobs/+/851088 | ||
| - [zuul/zuul-jobs] 851014: linters: fix spaces between filters https://review.opendev.org/c/zuul/zuul-jobs/+/851014 | ||
| - [zuul/zuul-jobs] 851015: linters: add names to blocks https://review.opendev.org/c/zuul/zuul-jobs/+/851015 | ||
| - [zuul/zuul-jobs] 851016: linters: rename loop variable https://review.opendev.org/c/zuul/zuul-jobs/+/851016 | ||
| - [zuul/zuul-jobs] 851017: linters: update to ansible-lint 6 https://review.opendev.org/c/zuul/zuul-jobs/+/851017 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 851107: Add job graph support to web UI https://review.opendev.org/c/zuul/zuul/+/851107 | 02:14 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 851147: [wip] upload-git-mirror : testing https://review.opendev.org/c/zuul/zuul-jobs/+/851147 | 03:26 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 851147: [wip] upload-git-mirror : testing https://review.opendev.org/c/zuul/zuul-jobs/+/851147 | 03:59 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 851147: [wip] upload-git-mirror : testing https://review.opendev.org/c/zuul/zuul-jobs/+/851147 | 04:23 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 851147: [wip] upload-git-mirror : testing https://review.opendev.org/c/zuul/zuul-jobs/+/851147 | 04:29 | |
| -@gerrit:opendev.org- Ian Wienand proposed: | 04:42 | |
| - [zuul/zuul-jobs] 851147: upload-git-mirror: fix ssh key newline https://review.opendev.org/c/zuul/zuul-jobs/+/851147 | ||
| - [zuul/zuul-jobs] 851014: linters: fix spaces between filters https://review.opendev.org/c/zuul/zuul-jobs/+/851014 | ||
| - [zuul/zuul-jobs] 851015: linters: add names to blocks https://review.opendev.org/c/zuul/zuul-jobs/+/851015 | ||
| - [zuul/zuul-jobs] 851016: linters: rename loop variable https://review.opendev.org/c/zuul/zuul-jobs/+/851016 | ||
| - [zuul/zuul-jobs] 851017: linters: update to ansible-lint 6 https://review.opendev.org/c/zuul/zuul-jobs/+/851017 | ||
| -@gerrit:opendev.org- Ian Wienand proposed: | 07:20 | |
| - [zuul/zuul-jobs] 851016: linters: rename loop variable https://review.opendev.org/c/zuul/zuul-jobs/+/851016 | ||
| - [zuul/zuul-jobs] 851014: linters: fix spaces between filters https://review.opendev.org/c/zuul/zuul-jobs/+/851014 | ||
| - [zuul/zuul-jobs] 851015: linters: add names to blocks https://review.opendev.org/c/zuul/zuul-jobs/+/851015 | ||
| - [zuul/zuul-jobs] 851017: linters: update to ansible-lint 6 https://review.opendev.org/c/zuul/zuul-jobs/+/851017 | ||
| - [zuul/zuul-jobs] 851163: emit-job-header: noqa on error ignore https://review.opendev.org/c/zuul/zuul-jobs/+/851163 | ||
| - [zuul/zuul-jobs] 851164: ansible-lint: disable progressive mode https://review.opendev.org/c/zuul/zuul-jobs/+/851164 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 851255: Clear pipeline change cache at start of refresh https://review.opendev.org/c/zuul/zuul/+/851255 | 19:49 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 851256: Reconcile pipeline change cache at start of refresh https://review.opendev.org/c/zuul/zuul/+/851256 | 19:49 | |
| @jim:acmegating.com | Clark swest ^ i'd appreciate your thoughts on which of those fixes we should merge | 19:52 |
| @jim:acmegating.com | (those two changes are alternate approaches) | 19:52 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 851107: Add job graph support to web UI https://review.opendev.org/c/zuul/zuul/+/851107 | 20:02 | |
| @clarkb:matrix.org | corvus: just reading the commit message I assume BMW may want the reconcile cache? I suspect hitting zk a bit more in the clearing case is fine for opendev's scale | 20:19 |
| @clarkb:matrix.org | * corvus: just reading the commit message I assume BMW may want the reconciled cache? I suspect hitting zk a bit more in the clearing case is fine for opendev's scale | 20:19 |
| @jim:acmegating.com | Clark: yeah, though the fact that it really only hits with depends-on is certainly a mitigating factor | 20:19 |
| @clarkb:matrix.org | definitely from a maintenance perspective the clear on refresh change is much simpler | 20:25 |
| @clarkb:matrix.org | maybe we start with that one and can replace it with the reconciliation change if performance is poor? | 20:25 |
| @jim:acmegating.com | i think a nuance that merits consideration is that normally we're going to make sure the local Change object is up to date with respect to ZK when we enqueue a change because we will have just fetched it from the source when we processed the trigger event. but any commit-dependent changes might come from the pipeline cache and therefore won't be checked against ZK. that means that if we're just a little slow on the asynchronous ChangeCache updates, we might be enqueing a change with slightly out of date information. now, that seems pretty unlikely (not the least because any interesting events have probably already been manifested in the change cache by the time we get around to doing work). but it's worth thinking about. i think it means that the "clear" option leans toward a brute-force approach to correctness, but and the "reconcile" option has a theoretical possibility of being slightly incorrect but with a vanishingly small probability of it happening and even if it does, an even smaller probability of the information affecting the outcome, and even if it does, a very high probability that it would be corrected in a later pass. and the flip side of all that is a performance increase of currently unknown size (but i guess it will be small). | 20:29 |
| @jim:acmegating.com | i ran a lot of tests locally and wasn't able to get a significant difference in runtimes, but then our tests have very small data sets. mostly that just verified that it doesn't do anything pathalogically bad to performance. | 20:29 |
| @jim:acmegating.com | > <@clarkb:matrix.org> maybe we start with that one and can replace it with the reconciliation change if performance is poor? | 20:30 |
| I think i like that idea. it feels like a lot of extra code/complexity for something that *shouldn't* matter, and then if it does matter, it's totally worth it. | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 851259: Fix race in test_node_list_json https://review.opendev.org/c/zuul/nodepool/+/851259 | 20:37 | |
| @jim:acmegating.com | zuul-maint: that's a simple test race fix that's been hitting a lot recently ^ | 20:37 |
| @clarkb:matrix.org | corvus: I left a question on 851255 | 20:39 |
| @iwienand:matrix.org | zuul-maint: if you have a little time for zuul-jobs updates https://review.opendev.org/q/topic:ansible-lint-update-6 is ready. although there's a lot it's all pretty simple | 20:49 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 850694: Fix deduplicated build references https://review.opendev.org/c/zuul/zuul/+/850694 | 21:14 | |
| @jim:acmegating.com | Clark: replied, thx | 21:14 |
| @clarkb:matrix.org | corvus: got it, that makes sense where it is the internal object updates that fail. For some reason I had it in my head the problem was above the actual memory representation | 21:18 |
| @jim:acmegating.com | yeah, sorry i didn't translate that context very well. comes from spending 6 hours digging through logs. by the end, i forgot where i started. :) | 21:19 |
| @jim:acmegating.com | (and btw, this is why we have verbose debug logs in zuul; yes it took a while, but it was possible to reconstruct this extremely rare sequence of events) | 21:20 |
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: [zuul/zuul-jobs] 851087: upload-artifactory: fix version comparision https://review.opendev.org/c/zuul/zuul-jobs/+/851087 | 21:22 | |
| @jim:acmegating.com | ianw: there's a +2 comment from Clark that i think warrants an ack-or-respin from you on the 2nd change in that stack | 21:23 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 850119: Fix nodepool label query https://review.opendev.org/c/zuul/zuul/+/850119 | 21:24 | |
| @iwienand:matrix.org | yeah i noticed they have debs and rpms as well after writing that based on the kube dockerfile | 21:36 |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 851263: ensure-kubernetes: pull cri-dockerd systemd from tag https://review.opendev.org/c/zuul/zuul-jobs/+/851263 | 21:41 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 851263: ensure-kubernetes: pull cri-dockerd systemd from tag https://review.opendev.org/c/zuul/zuul-jobs/+/851263 | 22:26 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 851268: Add freeze job to web UI https://review.opendev.org/c/zuul/zuul/+/851268 | 23:15 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 851268: Add freeze job to web UI https://review.opendev.org/c/zuul/zuul/+/851268 | 23:16 | |
| @iwienand:matrix.org | corvus: did you want to hold off on the ansible-lint change @ https://review.opendev.org/c/zuul/zuul-jobs/+/851017/ ? i just ask because you did review the rest of the stack | 23:20 |
| @jim:acmegating.com | ianw: sorry, thought someone else got that; +3 | 23:23 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 23:29 | |
| - [zuul/zuul] 851107: Add job graph support to web UI https://review.opendev.org/c/zuul/zuul/+/851107 | ||
| - [zuul/zuul] 851268: Add freeze job to web UI https://review.opendev.org/c/zuul/zuul/+/851268 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 23:30 | |
| - [zuul/zuul] 851107: Add job graph support to web UI https://review.opendev.org/c/zuul/zuul/+/851107 | ||
| - [zuul/zuul] 851268: Add freeze job to web UI https://review.opendev.org/c/zuul/zuul/+/851268 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 23:31 | |
| - [zuul/zuul-client] 850108: Add support for freezing the job graph https://review.opendev.org/c/zuul/zuul-client/+/850108 | ||
| - [zuul/zuul-client] 850110: Add freeze-job subcommand https://review.opendev.org/c/zuul/zuul-client/+/850110 | ||
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 851269: upload-git-mirror: no_log around key writing https://review.opendev.org/c/zuul/zuul-jobs/+/851269 | 23:33 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: | 23:53 | |
| - [zuul/zuul-jobs] 851093: ensure-kubernetes: install cri-dockerd; fix networking https://review.opendev.org/c/zuul/zuul-jobs/+/851093 | ||
| - [zuul/zuul-jobs] 851089: test/upload-pypi : install venv https://review.opendev.org/c/zuul/zuul-jobs/+/851089 | ||
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: | 23:53 | |
| - [zuul/zuul-jobs] 851088: setup.py: override modules to stop auto-detection https://review.opendev.org/c/zuul/zuul-jobs/+/851088 | ||
| - [zuul/zuul-jobs] 851147: upload-git-mirror: fix ssh key newline https://review.opendev.org/c/zuul/zuul-jobs/+/851147 | ||
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: [zuul/zuul-jobs] 851016: linters: rename loop variable https://review.opendev.org/c/zuul/zuul-jobs/+/851016 | 23:53 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!