| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 00:05 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 852670: Add support for dynamic tags https://review.opendev.org/c/zuul/nodepool/+/852670 | 00:08 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 00:18 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 00:35 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 00:55 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 01:20 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 02:09 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 02:58 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 03:17 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 03:45 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 03:48 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 04:12 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 04:51 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 05:11 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 06:13 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 06:47 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 07:15 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 853144: Set remote URL when different in config https://review.opendev.org/c/zuul/zuul/+/853144 | 07:42 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 07:51 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 08:06 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 08:36 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 10:08 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 10:37 | |
| @bridgefan:matrix.org | Out of curiosity, does zuul support the ability to modify a commit on submit? The use case being to use a source code auto formatter like yapf for python. | 11:44 |
|---|---|---|
| @fungicide:matrix.org | > <@bridgefan:matrix.org> Out of curiosity, does zuul support the ability to modify a commit on submit? The use case being to use a source code auto formatter like yapf for python. | 11:46 |
| zuul currently asks the code review system to do the submitting, so does not control the content of the commits (only whether or not they should merge) | ||
| @fungicide:matrix.org | some of opendev's projects have normalization jobs which checkout the current branch state, run some formatter over the files, create a commit from what it changes, and push that as a new code review for maintainers to consider and approve | 11:47 |
| @bridgefan:matrix.org | ok that's good to know | 11:48 |
| @bridgefan:matrix.org | any chance you know the location of one of these jobs? | 11:49 |
| @bridgefan:matrix.org | either way, thanks a lot for the explanations | 11:50 |
| @fungicide:matrix.org | sure, i can find you an example, just a moment | 11:51 |
| @fungicide:matrix.org | bridgefan: here's an example run of a job which proposes the result of normalizing our project list: https://zuul.opendev.org/t/openstack/build/9ec9bee2d6784d02be516810e6de6c47/console | 11:59 |
| @fungicide:matrix.org | the job definition is very simple: https://opendev.org/openstack/project-config/src/branch/master/zuul.d/jobs.yaml#L848-L854 | 12:00 |
| @fungicide:matrix.org | it inherits from the propose-updates job definition a couple of entries up from there | 12:00 |
| @fungicide:matrix.org | the run playbook is just a shell script wrapper: https://opendev.org/openstack/project-config/src/branch/master/playbooks/proposal/propose-project-config-update.yaml | 12:02 |
| @fungicide:matrix.org | and it's calling this script: https://opendev.org/openstack/project-config/src/branch/master/tools/propose_projects_yaml_update.sh | 12:03 |
| @fungicide:matrix.org | for reference, the resulting proposal from that build was https://review.opendev.org/852931 | 12:04 |
| @fungicide:matrix.org | an up side to this approach is that, for example, if your contributors are signing their commits then changing their commits before merging would invalidate their signatures | 12:10 |
| @fungicide:matrix.org | but also the commits in their local trees will match what ends up committed, so there's less of a need for them to force reset local branches or perform similar non-fast-forwardable operations | 12:11 |
| @fungicide:matrix.org | of course, another approach is to simply have a check job which diffs the proposed files against the same files run through the formatter, and fail if there's any difference (providing either the diff or inline comments along with a reminder of what the developer can run locally to auto-apply the same transformation for their next revision) | 12:13 |
| @fungicide:matrix.org | we take that approach for some data where we want to keep things sorted in alpha order for ease of maintenance | 12:14 |
| @bridgefan:matrix.org | wow thanks a lot! this is great :) | 12:26 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 853351: Add zuul change queue https://review.opendev.org/c/zuul/zuul/+/853351 | 17:37 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-client] 853352: Add zuul-client to zuul change queue https://review.opendev.org/c/zuul/zuul-client/+/853352 | 17:38 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Matthieu Huin https://matrix.to/#/@mhuin:matrix.org: [zuul/zuul] 850759: Update keycloak demo, documentation for keycloak 18 https://review.opendev.org/c/zuul/zuul/+/850759 | 17:39 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul-client] 850108: Add support for freezing the job graph https://review.opendev.org/c/zuul/zuul-client/+/850108 | 17:54 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul-client] 850110: Add freeze-job subcommand https://review.opendev.org/c/zuul/zuul-client/+/850110 | 17:57 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: | 19:29 | |
| - [zuul/zuul] 850109: Add tests for zuul-client job-graph https://review.opendev.org/c/zuul/zuul/+/850109 | ||
| - [zuul/zuul] 850111: Add test for zuul-client freeze-job https://review.opendev.org/c/zuul/zuul/+/850111 | ||
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 851107: Add job graph support to web UI https://review.opendev.org/c/zuul/zuul/+/851107 | 19:37 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 20:02 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 20:24 | |
| @pearcetyler:matrix.org | Any idea what would cause `prepare-workspace` to take more than 20 minutes? It seemed fine last week but is taking an excessive amount of time this week | 21:12 |
| `2022-08-16 20:37:03.729258 | TASK [prepare-workspace : Synchronize src repos to workspace directory.] | ||
| 2022-08-16 20:59:05.851770 | ubuntu-focal | Output suppressed because no_log was given` | ||
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 21:15 | |
| @clarkb:matrix.org | > <@pearcetyler:matrix.org> Any idea what would cause `prepare-workspace` to take more than 20 minutes? It seemed fine last week but is taking an excessive amount of time this week | 21:19 |
| > `2022-08-16 20:37:03.729258 | TASK [prepare-workspace : Synchronize src repos to workspace directory.] | ||
| > 2022-08-16 20:59:05.851770 | ubuntu-focal | Output suppressed because no_log was given` | ||
| `prepare-workspace`s primary function is to set up the git repos and copy the zuul git state into them. In opendev we rely on git repo caches in our test nodes to speed things up. In our environment the first thing I would look at after network slowness is whether or not the cache is out of date forcing more data to go over the network. I would look at those two things assuming you also use a git repo cache on your test nodes | ||
| @pearcetyler:matrix.org | Thanks for the quick response! We aren't using caching here, so it was surprising for it to get so slow so suddenly. Even without caching 20 minutes seemed unusual đŸ˜… | 21:25 |
| @pearcetyler:matrix.org | I'll keep looking into things to see what I can find | 21:25 |
| @clarkb:matrix.org | Maybe one or more of the repos grew in size quite a bit suddenly? | 21:30 |
| @pearcetyler:matrix.org | It grew about ~8-10KB in the past 10 days | 21:37 |
| @pearcetyler:matrix.org | Is it preferred to use `prepare-workspace-git` over `prepare-workspace`? | 21:39 |
| @clarkb:matrix.org | Probably `prepare-workspace-git` if you have a cache since the caching really only works with the git operations (rsync will just copy everything since the packfiles will likely differ) | 21:40 |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853369: [wip] zuul-stream : validate on per-node basis https://review.opendev.org/c/zuul/zuul/+/853369 | 21:41 | |
| -@gerrit:opendev.org- Ian Wienand proposed: | 21:47 | |
| - [zuul/zuul] 853369: [wip] validate on per node basis https://review.opendev.org/c/zuul/zuul/+/853369 | ||
| - [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | ||
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 853208: [wip] zuul-stream : 2.7 testing https://review.opendev.org/c/zuul/zuul/+/853208 | 21:59 | |
| @vlotorev:matrix.org | Hi, it seems zuul behaviour for gerrit topics has changed from 5.x to 6.2.0. My gerrit has submitWholeTopic enabled. 6.2.0 zuul reports 'cycle dependency detected' and doesn't enqueue items. I don't have queue.allow-circular-dependencies enabled. | 22:23 |
| This behaviour was not before 6.x (zuul ignored topics and enqueued items ignoring topics). | ||
| Can't zuul just ignore gerrit topics? | ||
| @vlotorev:matrix.org | * Hi, it seems zuul behaviour for gerrit topics has changed from 5.x to 6.2.0. My gerrit has submitWholeTopic enabled. 6.2.0 zuul reports 'cycle dependency detected' and doesn't enqueue items. I don't have queue.allow-circular-dependencies enabled. | 22:23 |
| This behaviour was not before 6.x (zuul ignored topics and enqueued items ignoring topics). | ||
| Can't zuul ignore gerrit topics? | ||
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: | 22:24 | |
| - [zuul/zuul] 851268: Add freeze job to web UI https://review.opendev.org/c/zuul/zuul/+/851268 | ||
| - [zuul/zuul] 851604: Use internal links in job graph display https://review.opendev.org/c/zuul/zuul/+/851604 | ||
| @jim:acmegating.com | vlotorev: you can disable submitWholeTopic or enable circular dependencies. either way, the two systems need to be in sync. | 22:26 |
| @jim:acmegating.com | vlotorev: see the release note here: https://zuul-ci.org/docs/zuul/latest/releasenotes.html#relnotes-5-2-0 | 22:28 |
| @vlotorev:matrix.org | corvus: Thanks, I've read release notes multiple times, but haven't thought 'Zuul now matches Gerrit’s behavior when change.submitWholeTopic is set in Gerrit.' is that literal :) | 22:31 |
| @vlotorev:matrix.org | * corvus: Thanks, I've read release notes multiple times, but haven't thought `Zuul now matches Gerrit’s behavior when change.submitWholeTopic is set in Gerrit.` is that literal :) | 22:31 |
| @jim:acmegating.com | vlotorev: well, i was more thinking of `If the projects are not part of pipeline queues which are configured to allow circular dependencies, then Zuul will report failure on enqueue. Be sure that the submitWholeTopic setting in Gerrit and the allow-circular-dependencies setting in Zuul match.` but granted, it's not the first thing, and we could have added a second mention under `upgrade notes` | 22:33 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 23:13 | |
| - [zuul/nodepool] 853371: AWS add support for multiple instance types https://review.opendev.org/c/zuul/nodepool/+/853371 | ||
| - [zuul/nodepool] 853372: Convert GCE to state machine driver and remove simple https://review.opendev.org/c/zuul/nodepool/+/853372 | ||
| @jim:acmegating.com | +276, -1092 ^ for what is hopefully no change in behavior | 23:16 |
| @jim:acmegating.com | * +276, -1092 ^ for what is hopefully no change in behavior (should be a maintenance improvement) | 23:16 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!