| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 855309: [wip] disable streaming writing via var https://review.opendev.org/c/zuul/zuul/+/855309 | 00:35 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 855309: [wip] disable streaming writing via var https://review.opendev.org/c/zuul/zuul/+/855309 | 00:54 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 855309: [wip] disable streaming writing via var https://review.opendev.org/c/zuul/zuul/+/855309 | 01:12 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 855309: [wip] disable streaming writing via var https://review.opendev.org/c/zuul/zuul/+/855309 | 01:29 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 855309: [wip] disable streaming writing via var https://review.opendev.org/c/zuul/zuul/+/855309 | 01:41 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 855403: Do not use _display outside the main thread in zuul_stream https://review.opendev.org/c/zuul/zuul/+/855403 | 01:46 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 855309: [wip] disable streaming writing via var https://review.opendev.org/c/zuul/zuul/+/855309 | 02:24 | |
| -@gerrit:opendev.org- Ian Wienand proposed: | 04:30 | |
| - [zuul/zuul] 851942: docs: update console streaming docs https://review.opendev.org/c/zuul/zuul/+/851942 | ||
| - [zuul/zuul] 855309: [wip] disable streaming writing via var https://review.opendev.org/c/zuul/zuul/+/855309 | ||
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 855309: zuul-stream: Add variable to disable writing streaming files https://review.opendev.org/c/zuul/zuul/+/855309 | 05:08 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 855297: web: console: compress datalist https://review.opendev.org/c/zuul/zuul/+/855297 | 06:45 | |
| @avass:vassast.org | > <@jim:acmegating.com> Albin Vass: ^ you may be interested in... well... most of the conversation above re 855403 | 07:58 |
|---|---|---|
| ah nice :) | ||
| -@gerrit:opendev.org- Thomas Cardonne marked as active: [zuul/zuul] 855439: feat(elasticsearch): allow filtering of reported returned-vars https://review.opendev.org/c/zuul/zuul/+/855439 | 11:36 | |
| @mbecker12:matrix.org | corvus: I fixed some of your comments in https://review.opendev.org/c/zuul/nodepool/+/853993. I'm not sure how to handle the timeout in the test when the node is locked. And I think we would like to keep the configurable timeout in the command to still be able to hold a node after it's done with a job, for static nodes anyway | 12:46 |
| @jim:acmegating.com | mbecker12: i would not recommend that workflow. you will be racing nodepool itself. in that case i would recommend removing the node from the config file. | 14:12 |
| @mbecker12:matrix.org | Yeah I see. regarding the nodepool config, you were talking about a nodepool-in-zuul spec. Do you have more info on that? Or a link or something? :) | 14:19 |
| @jim:acmegating.com | mbecker12: https://review.opendev.org/849887 and yeah, it would make that process much simpler/faster | 14:24 |
| @mbecker12:matrix.org | Cool, thanks! I will have a look | 14:39 |
| @mbecker12:matrix.org | Do you want me to remove the timeout from the command altogether then? I think it would be more in line with the other commands | 14:41 |
| @jim:acmegating.com | yeah, i think that would be best | 14:44 |
| -@gerrit:opendev.org- Marvin Becker proposed: [zuul/nodepool] 853993: Add hold command to disable nodes https://review.opendev.org/c/zuul/nodepool/+/853993 | 16:09 | |
| -@gerrit:opendev.org- Marvin Becker proposed: [zuul/nodepool] 853993: Add hold command to disable nodes https://review.opendev.org/c/zuul/nodepool/+/853993 | 16:15 | |
| @mbecker12:matrix.org | corvus: Done! I also left another comment regarding the test cases | 16:27 |
| @clarkb:matrix.org | when writing an ansible module is there is a utility method to convert 'yes' 'True' etc into a boolean python value consistent with ansible expectations? | 17:40 |
| @clarkb:matrix.org | oh apparently it is just module.boolean()? | 17:43 |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul-jobs] 855402: Speed up log file fetching tasks https://review.opendev.org/c/zuul/zuul-jobs/+/855402 | 18:03 | |
| @clarkb:matrix.org | When you invoke a script liek that on the command line how do you pass arguments to it? does ansible module do some magic for command line use? | 18:05 |
| @clarkb:matrix.org | I haven't run it locally yet as that bit isn't clear to me. | 18:05 |
| @tristanc_:matrix.org | Clark: do you mean something like this: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/htmlify-logs/library ? | 18:07 |
| @clarkb:matrix.org | Ya I guess I need to split the main calls up like that one | 18:08 |
| @clarkb:matrix.org | I'll see what zuul complains about first then look into that after lunch if I've got time | 18:09 |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul-jobs] 855402: Speed up log file fetching tasks https://review.opendev.org/c/zuul/zuul-jobs/+/855402 | 18:12 | |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul-jobs] 855402: Speed up log file fetching tasks https://review.opendev.org/c/zuul/zuul-jobs/+/855402 | 18:25 | |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul-jobs] 855402: Speed up log file fetching tasks https://review.opendev.org/c/zuul/zuul-jobs/+/855402 | 18:45 | |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul-jobs] 855402: Speed up log file fetching tasks https://review.opendev.org/c/zuul/zuul-jobs/+/855402 | 19:40 | |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul-jobs] 855402: Speed up log file fetching tasks https://review.opendev.org/c/zuul/zuul-jobs/+/855402 | 20:23 | |
| @clarkb:matrix.org | I'm still a bit stumped on what python2 isn't liking in that change. | 20:23 |
| @vlotorev:matrix.org | Hi, I'm having unexpected behaviour: | 20:31 |
| * two jobs in check pipeline, the first one 'provides', the second one 'requires'. job with 'requires' has 'dependencies' | ||
| * zuul runs four jobs for two changes changes changeA, changeB | ||
| * 'provides' job for changeB finishes earlier then 'provides' for changeA, | ||
| as a result: artifacts from changeB are passed to changeA 'requires' job. | ||
| Is this expected? | ||
| @clarkb:matrix.org | I think so. provides and requires describe the relationship between buildsets. Then the job dependencies ensure order within a buildset | 20:32 |
| @clarkb:matrix.org | What this means is whichever runs first will provide the image for other buildsets. If those other buildsets need to make their own updates to the image they need to have a dependency on the image build job which overrides the provided image | 20:33 |
| @vlotorev:matrix.org | But if buildsets provide artifacts to each other that would mean totaly random order. In my case changeA starts testing image from later changeB and sometimes it's testing from changeA. | 20:36 |
| @clarkb:matrix.org | vlotorev: the idea is that you'd express the dependencies through git or depends on so that it isn't random | 20:38 |
| @vlotorev:matrix.org | In my case changeA and changeB in the same repo. | 20:39 |
| @clarkb:matrix.org | It may be the case that having the provides be satisfied without that relationship is a bug if that is happening | 20:39 |
| @clarkb:matrix.org | I'd have to think about that more | 20:39 |
| @clarkb:matrix.org | > <@vlotorev:matrix.org> In my case changeA and changeB in the same repo. | 20:40 |
| Note you can use git's built in lineage for changes or depends on within a single repo. But only depends on will work between different repos or different branches | ||
| @vlotorev:matrix.org | In my case changeA and changeB are linear in the same repo. | 20:41 |
| @clarkb:matrix.org | Is changeB the parent of changeA if so the behavior you described is expected | 20:42 |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul-jobs] 855402: Speed up log file fetching tasks https://review.opendev.org/c/zuul/zuul-jobs/+/855402 | 20:43 | |
| @vlotorev:matrix.org | changeA is parent of changeB | 20:43 |
| @clarkb:matrix.org | In that case I believe the expected behavior is taht change B would wait until changeA's resource is available so that the child can consume the parent's build | 20:44 |
| @clarkb:matrix.org | (Again it shouldn't be random nor should it be child before parent) | 20:44 |
| @clarkb:matrix.org | corvus: ^ did we break that? | 20:44 |
| @vlotorev:matrix.org | It's random because it depends on how long 'provides' job for changeA and changeB are running. And this length is not controlled by zuul (there might changes in playbooks). | 20:48 |
| If 'provides' job for changeB finishes earlier then 'provides' job for changeB then artifacts from this job are in 'requires' job in changeA. | ||
| if 'provides' job for changeB finishes later then 'provides' job for changeB then *no* artifacts from changeB in changeA. | ||
| @vlotorev:matrix.org | * It's random because it depends on how long 'provides' job for changeA and changeB are running. And this duration is not controlled by zuul (there might changes in playbooks). | 20:49 |
| If 'provides' job for changeB finishes earlier then 'provides' job for changeB then artifacts from this job are in 'requires' job in changeA. | ||
| if 'provides' job for changeB finishes later then 'provides' job for changeB then _no_ artifacts from changeB in changeA. | ||
| @clarkb:matrix.org | Except zuul knows what the dependencies are and it is supposed to wait | 20:49 |
| @clarkb:matrix.org | I wonder if there is some missing config to make that happen | 20:49 |
| @clarkb:matrix.org | vlotorev: maybe you can share your configs? | 20:51 |
| @vlotorev:matrix.org | Let me recheck, probably when I have one change then it works as expected. And then two changes then changeA always waiting for child changeB. | 20:56 |
| @vlotorev:matrix.org | * Let me recheck, probably when I have one change then it works as expected. And when there two changes then changeA always waiting for child changeB. | 20:56 |
| @clarkb:matrix.org | Zuulians https://review.opendev.org/c/zuul/zuul-jobs/+/855402/ is ready for review now I think. It passes testing and I added a bit more testing including using the unitest framework and the ansible integration testing. That said this will likely affect many base jobs so please review it carefully and suggest additional testing. I'll do my best to add it | 20:59 |
| @clarkb:matrix.org | For some of opendev's jobs i expect that to cut minutes off our runtime though which would be great | 20:59 |
| @clarkb:matrix.org | The python2 issue is I needed a __init__.py file in the role dir not just the role/library dir | 21:00 |
| @vlotorev:matrix.org | Clark: Is there any sandbox project with zuul enabled so I could upload both jobs and demonstrate how they are running? | 21:05 |
| @clarkb:matrix.org | vlotorev: opendev has a sandbox repo. I don't know how much effort it would be to port something like that into that repo | 21:06 |
| @clarkb:matrix.org | But it is theoretically doable | 21:06 |
| @vlotorev:matrix.org | This one https://zuul.opendev.org/t/openstack/project/opendev.org/opendev/sandbox ? | 21:07 |
| @clarkb:matrix.org | yes | 21:07 |
| @jim:acmegating.com | Clark: i'm not aware of any breakage related to that. i believe that's working as designed/specified (if not as expected). | 21:22 |
| @jim:acmegating.com | vlotorev: provides/requires isn't intended for the case where the buildset in question has both a provide and requires job. | 21:23 |
| @jim:acmegating.com | (it is, as you observed, self-satisfying in that case) | 21:23 |
| @vlotorev:matrix.org | I've uploaded two jobs and two changes https://review.opendev.org/c/opendev/sandbox/+/855590/. | 21:38 |
| ChangeA is parent for changeB, even though jobs for changeB are faster they still wait for jobs from changeA to finish and artifacts from changeA are provided to change B. | ||
| Is this expected behaviour? | ||
| @vlotorev:matrix.org | Clark: corvus thanks for help. Behaviour on https://review.opendev.org/c/opendev/sandbox/+/855069/ matches the one on my instance and it matches doc in https://zuul-ci.org/docs/zuul/latest/config/job.html?highlight=job+requires#attr-job.requires. | 22:03 |
| -@gerrit:opendev.org- Ian Wienand proposed: | 22:19 | |
| - [zuul/zuul] 855574: web: task summary: make more consistent with other tabs https://review.opendev.org/c/zuul/zuul/+/855574 | ||
| - [zuul/zuul] 855575: web: console: better task modal titles https://review.opendev.org/c/zuul/zuul/+/855575 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 22:40 | |
| - [zuul/zuul] 854458: Add support for configuring and testing tracing https://review.opendev.org/c/zuul/zuul/+/854458 | ||
| - [zuul/zuul] 855096: Tracing: implement span save/restore https://review.opendev.org/c/zuul/zuul/+/855096 | ||
| - [zuul/zuul] 855293: Add tracing tutorial https://review.opendev.org/c/zuul/zuul/+/855293 | ||
| -@gerrit:opendev.org- Ian Wienand proposed: | 23:38 | |
| - [zuul/zuul] 854556: web: console: convert to PF4 DataList https://review.opendev.org/c/zuul/zuul/+/854556 | ||
| - [zuul/zuul] 855297: web: console: compress datalist https://review.opendev.org/c/zuul/zuul/+/855297 | ||
| - [zuul/zuul] 855574: web: task summary: make more consistent with other tabs https://review.opendev.org/c/zuul/zuul/+/855574 | ||
| - [zuul/zuul] 855575: web: console: better task modal titles https://review.opendev.org/c/zuul/zuul/+/855575 | ||
| - [zuul/zuul] 855577: web: update to patternfly 4.235.7 https://review.opendev.org/c/zuul/zuul/+/855577 | ||
| - [zuul/zuul] 855578: web: build/autohold: fix props input https://review.opendev.org/c/zuul/zuul/+/855578 | ||
| @iwienand:matrix.org | corvus: ^ that has addressed all your prior comments; 855297 fiddles things to make the pf4 console page more compressed as requested. more tweaking may be possible there. i've added on a few other things that seemed inconsistent to me when flipping around with the updated console too | 23:58 |
| @iwienand:matrix.org | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_598/855575/2/check/zuul-build-dashboard-opendev/598ac0c/npm/html/ | 23:59 |
| @iwienand:matrix.org | is the capstone site preview if anyone wants to poke quickly | 23:59 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!