| -@gerrit:opendev.org- Felix Edel proposed: [zuul/zuul] 864903: Abort job if cleanup playbook timed out https://review.opendev.org/c/zuul/zuul/+/864903 | 14:23 | |
| @spamaps:spamaps.ems.host | ... Watching our internal CI team repeat literally everything Zuul dev went through.. Jenkins removal under way.. encrypting secrets to a public key published by the API next... 🤦 Anyway y'all are amazing wish I could work with Zuul more. 👋 | 19:05 |
|---|---|---|
| @avass:vassast.org | I too wish I could work with zuul more :) | 19:49 |
| @michael_kelly_anet:matrix.org | Anyone able to give me a second +2 for https://review.opendev.org/c/zuul/zuul-jobs/+/861799 ? And maybe a workflow+1? | 20:35 |
| @jim:acmegating.com | Michael Kelly: i did leave a question on that change, not sure if you saw it. also, i see that you have been rebasing it a lot. there's generally no need to do that unless there's an actual conflict. it makes it easier for reviewers to see what has changed. | 20:45 |
| @michael_kelly_anet:matrix.org | Hard to figure out there's a conflict if I don't rebase ;) | 20:47 |
| As to the comment: my memory has been foggy as it's been sitting for a bit, but iirc the script for generating this either complained or stripped this out automatically. | ||
| @jim:acmegating.com | Michael Kelly: gerrit will tell you if there's a conflict. you can also rebase locally to determine if there's a conflict. | 20:48 |
| @michael_kelly_anet:matrix.org | Yes, I'm familiar with how gerrit works. My personal preference is to keep things up to date to reduce probability of causing headaches for myself later. :) | 20:50 |
| @michael_kelly_anet:matrix.org | (and to keep merge cycles short, of course) | 20:51 |
| @michael_kelly_anet:matrix.org | Yea, when I re-run the command to generate this output that blob doesn't get re-inserted. | 20:51 |
| @michael_kelly_anet:matrix.org | It injects the autogenerated jobs though. | 20:52 |
| @michael_kelly_anet:matrix.org | Also, fwiw, harder to notice comments when they're already marked as resolved. :) | 20:55 |
| @michael_kelly_anet:matrix.org | Interestingly, when I inject that comment block it actually gets stripped out by the auto-generator. | 20:55 |
| @jim:acmegating.com | strange, it should keep comments. well, feel free to leave a response. and do please consider avoiding rebases when not necessary in the future. reviewers will appreciate it. | 20:56 |
| @michael_kelly_anet:matrix.org | Replied. | 21:27 |
| @michael_kelly_anet:matrix.org | Mind to give that a Workflow+1 as well so that I can nudge it along? | 21:35 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 864947: Add AUTOGENERATED comment to helm-jobs https://review.opendev.org/c/zuul/zuul-jobs/+/864947 | 21:43 | |
| @michael_kelly_anet:matrix.org | Is this a version issue or someting else? | 21:45 |
| @jim:acmegating.com | no, is explained in the commit message. it's just really sensitive to some yaml constructions. changing that to ` - test-chart` would work too. | 21:46 |
| @michael_kelly_anet:matrix.org | I see. Interesting | 21:48 |
| @michael_kelly_anet:matrix.org | Maybe a good place for an upstream fix ;) | 21:48 |
| @jim:acmegating.com | yep. to be fair, association of comments with semantically relevant data structure locations is a hard problem. | 21:50 |
| @iwienand:matrix.org | huh, i thought the script put that in too | 22:10 |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-operator] 863948: zuul-operator-funcitonal-k8s: update to Jammy nodes https://review.opendev.org/c/zuul/zuul-operator/+/863948 | 22:14 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Michael Kelly: [zuul/zuul-jobs] 861799: helm: Add job for linting helm charts https://review.opendev.org/c/zuul/zuul-jobs/+/861799 | 22:21 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul-jobs] 864947: Add AUTOGENERATED comment to helm-jobs https://review.opendev.org/c/zuul/zuul-jobs/+/864947 | 22:25 | |
| @michael_kelly_anet:matrix.org | It'd be keen if I can get some reviews on https://review.opendev.org/q/owner:mkelly+project:zuul/zuul-operator+status:open as well | 22:39 |
| -@gerrit:opendev.org- Michael Kelly proposed: | 22:42 | |
| - [zuul/zuul-operator] 863191: helm: Add pxc-operator as optional dependency https://review.opendev.org/c/zuul/zuul-operator/+/863191 | ||
| - [zuul/zuul-operator] 863579: test: Convert functional test to use helm chart https://review.opendev.org/c/zuul/zuul-operator/+/863579 | ||
| - [zuul/zuul-operator] 863474: pxc: Don't install PXC operator from Zuul operator https://review.opendev.org/c/zuul/zuul-operator/+/863474 | ||
| - [zuul/zuul-operator] 863475: cert-manager: Don't install cert-manager via zuul-operator https://review.opendev.org/c/zuul/zuul-operator/+/863475 | ||
| - [zuul/zuul-operator] 863586: helm: Remove unnecessary CRD access from clusterrole https://review.opendev.org/c/zuul/zuul-operator/+/863586 | ||
| - [zuul/zuul-operator] 863476: k8s: Enable administrator to limit the watched namespace scope https://review.opendev.org/c/zuul/zuul-operator/+/863476 | ||
| - [zuul/zuul-operator] 863477: k8s: Allow use of a default image version besides latest https://review.opendev.org/c/zuul/zuul-operator/+/863477 | ||
| - [zuul/zuul-operator] 863571: web: Enable custom metadata for Service resources https://review.opendev.org/c/zuul/zuul-operator/+/863571 | ||
| - [zuul/zuul-operator] 861279: bug: Select scheduler pod based on instance name on update https://review.opendev.org/c/zuul/zuul-operator/+/861279 | ||
| - [zuul/zuul-operator] 863572: bug: Properly parameterize zookeeper-client-tls everywhere https://review.opendev.org/c/zuul/zuul-operator/+/863572 | ||
| - [zuul/zuul-operator] 863439: doc: Re-write install doc to use helm chart https://review.opendev.org/c/zuul/zuul-operator/+/863439 | ||
| @michael_kelly_anet:matrix.org | corvus: https://review.opendev.org/c/zuul/zuul-operator/+/861488/13 One additional comment (want to ensure it doesn't get lost in the noise): we should allow users to explicitly disable the auto-install-another-operator functionality explicitly with the operator config so that it doesn't happen if the create a Zuul object if they misconfigured it. If you don't want this to happen it can be a pain to clean up | 22:46 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!