Wednesday, 2023-07-26

« Tuesday, 2023-07-25 Index Thursday, 2023-07-27 »
-@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com:06:40
- [zuul/nodepool] 887907: Use low-level OpenStack SDK calls for server listing https://review.opendev.org/c/zuul/nodepool/+/887907
- [zuul/zuul] 888627: Add AWS Kinesis support https://review.opendev.org/c/zuul/zuul/+/888627
-@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 889305: Add Zuul job variable to indicate a job will retry https://review.opendev.org/c/zuul/zuul/+/88930511:01
-@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 889305: Add Zuul job variable to indicate a job will retry https://review.opendev.org/c/zuul/zuul/+/88930511:03
@westphahl:matrix.orgflaper87: can you take a look at my comment in https://review.opendev.org/c/zuul/zuul/+/885455/11/web/src/api.js13:45
@jim:acmegating.comswest: flaper87 yoctozepto i've confirmed with a local run of `PUBLIC_URL=/zuul/ yarn build` that the output in the build directory has `PUBLIC_URL=/zuul`13:51
@jim:acmegating.comi think we should revert 885455 until we have a fix for this since we know it breaks subdirectory deployments13:51
@jim:acmegating.comhopefully the fix is quick and we can merge it again13:52
@jim:acmegating.com(maybe we just use PS9 of that change?)13:52
@westphahl:matrix.orgcorvus: I don't think PS9 solves the issue13:54
-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 889709: Revert "Use built-in URL data type instead of custom parse" https://review.opendev.org/c/zuul/zuul/+/88970913:54
@jim:acmegating.comswest: oh ok.  was mostly just going on comments :)13:54
@westphahl:matrix.orgoh, ok. I think it does. I missed the part where `path` is initialized to `/`13:55
@jim:acmegating.comat any rate, to be clear, i consider the revert a temporary measure and am happy to review an updated version.  :)13:55
@jim:acmegating.comtristanC: ^ fyi13:56
@jim:acmegating.comi think we can have test coverage of that, we just need to note that PUBLIC_URL has the trailing slash stripped (in other words, our test constants don't match reality)13:57
@jim:acmegating.comalso, we could look into *why* it gets stripped, but then we have to dig into yarn, webpack, etc.... not even sure who's doing that :)13:57
@tristanc_:matrix.orgarg, I see. So we just need to ensure that the getHomepageUrl output is terminated by a `/` right?13:59
@jim:acmegating.comtristanC: i think so?  so maybe we just need a substring check there?14:01
-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 889710: Fix URL generation for subdir deployments https://review.opendev.org/c/zuul/zuul/+/88971014:05
@jim:acmegating.comtristanC: maybe like that ^?14:05
@jim:acmegating.com(which is more or less what the original method did)14:06
@jim:acmegating.comswest: ^14:07
@westphahl:matrix.orglgtm14:08
@jim:acmegating.comok i'll hold the revert for folks to review the fix -- but let's land one of those today :)14:09
@tristanc_:matrix.orgcorvus: thanks, I've checked that the URL.pathname setter does not alter the trailing `/`14:11
@jim:acmegating.comtristanC: got catch, thanks14:11
@jim:acmegating.com * tristanC: good catch, thanks14:11
@yoctozepto:matrix.orgI commented on the fix14:15
@jim:acmegating.comtrue, but this is more defensive14:18
@yoctozepto:matrix.orgagreed14:19
-@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 889710: Fix URL generation for subdir deployments https://review.opendev.org/c/zuul/zuul/+/88971015:09
@g_gobi:matrix.orghttps://opendev.org/zuul/project-config/src/commit/6793d4703cd3bd8ad454193b928cc892ed9b4916/zuul.d/pipelines.yaml#L119-L12716:44
This option trigger pipeline for all the branches in the repository. Is there a way to trigger on a pipeline in a particular branch?
@jpew:matrix.org> <@g_gobi:matrix.org> https://opendev.org/zuul/project-config/src/commit/6793d4703cd3bd8ad454193b928cc892ed9b4916/zuul.d/pipelines.yaml#L119-L12716:59
> This option trigger pipeline for all the branches in the repository. Is there a way to trigger on a pipeline in a particular branch?
I would appreciate that also.... we have too many branches :/
@jim:acmegating.comtdlaw: that's handled at the job level: https://zuul-ci.org/docs/zuul/latest/config/job.html#attr-job.branches16:59
@jpew:matrix.orgcorvus: The thing I've noticed is that it looks like the scheduler still has to look at all the branches to disregard them16:59
@jpew:matrix.orgWe've seen pipeline queues with over 2000 entries, which causes some problems17:01
@g_gobi:matrix.orgHow to remove those entries? It was not started. So, I can't able to dequeue them.17:02
-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 889745: Refactor will_retry https://review.opendev.org/c/zuul/zuul/+/88974518:00
@g_gobi:matrix.orgCan we use timer + gerrit / gitlab in same pipeline trigger section?18:12
@g_gobi:matrix.org * Can we use timer + gerrit / gitlab in same pipeline's trigger section?18:12
@jim:acmegating.comyes18:13
@g_gobi:matrix.orgBut after adding timer + gitlab for trigger, I'm seeing the following error in scheduler18:17
```
scheduler_1 | 2023-07-26 18:15:04,333 INFO zuul.GitlabConnection: Getting change for test ref:branch1
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: Exception processing pipeline schedule-check in tenant default-tenant
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: Traceback (most recent call last):
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: File "/usr/local/lib/python3.11/site-packages/zuul/scheduler.py", line 2255, in process_pipelines
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: refreshed = self._process_pipeline(
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: ^^^^^^^^^^^^^^^^^^^^^^^
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: File "/usr/local/lib/python3.11/site-packages/zuul/scheduler.py", line 2337, in _process_pipeline
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: self.process_pipeline_trigger_queue(tenant, pipeline)
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: File "/usr/local/lib/python3.11/site-packages/zuul/scheduler.py", line 2572, in process_pipeline_trigger_queue
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: self._process_trigger_event(tenant, pipeline, event)
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: File "/usr/local/lib/python3.11/site-packages/zuul/scheduler.py", line 2605, in _process_trigger_event
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: pipeline.manager.addChange(change, event)
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: File "/usr/local/lib/python3.11/site-packages/zuul/manager/__init__.py", line 560, in addChange
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: match_result = f.matches(change)
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: ^^^^^^^^^^^^^^^^^
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: File "/usr/local/lib/python3.11/site-packages/zuul/driver/gitlab/gitlabmodel.py", line 263, in matches
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: if change.open != self.open:
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: ^^^^^^^^^^^
scheduler_1 | 2023-07-26 18:15:04,340 ERROR zuul.Scheduler: AttributeError: 'Branch' object has no attribute 'open'
```
@g_gobi:matrix.orgMy pipeline trigger section    18:20
```
trigger:
timer:
time: "* 10 * * *"
gitlab:
- event: gl_merge_request
action: comment
comment: (?i)^\s*re-check\s*$
- event: gl_merge_request
action:
- opened
- labeled
labels:
- schedule
```
@jim:acmegating.comit's a bug in the gitlab driver to raise that exception, but if you have a pipeline requirement that the change be open, then it won't work anyway.18:21
@g_gobi:matrix.org * My pipeline trigger section18:20
```
trigger:
timer:
time: "* 10 * * *"
gitlab:
- event: gl_merge_request
action: comment
comment: (?i)^\s*re-check\s*$
- event: gl_merge_request
action:
- opened
- labeled
labels:
- schedule
```
@jim:acmegating.comanyway, i was just answering the question that yes, multiple trigger drivers are intended to work together.  doing so can be complex.18:23
@g_gobi:matrix.orgSo, do I need to use the branch option in the job for the scheduled build? No other options18:25
@g_gobi:matrix.orgSo, GitLab won't work with the timer + Gitlab trigger option 18:30
@g_gobi:matrix.org> <@jim:acmegating.com> tdlaw: that's handled at the job level: https://zuul-ci.org/docs/zuul/latest/config/job.html#attr-job.branches18:40
This is not working. Even I mention branches: <needed-branch-name> in job
trigger:
timer:
time: "* 10 * * *"
It triggers the build for all the branches
@g_gobi:matrix.org> <@jim:acmegating.com> tdlaw: that's handled at the job level: https://zuul-ci.org/docs/zuul/latest/config/job.html#attr-job.branches18:50
* This is not working. Even I mention branches: \<needed-branch-name> in job
```
trigger:
timer:
time: "* 10 * * *"
```
It triggers the build for all the branches
@g_gobi:matrix.org * This is not working.  Even I mention branches: \<needed-branch-name> in job18:50
```
trigger:
timer:
time: "* 10 * * *"
```
It triggers the build for all the branches
@g_gobi:matrix.orgIs there any sample pipeline + job configuration for using timer option with gitlab? If yes, could you please share it here?18:57
-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed on behalf of Simon Westphahl: [zuul/zuul] 650276: Keep task stdout/stderr separate in result object https://review.opendev.org/c/zuul/zuul/+/65027621:29
« Tuesday, 2023-07-25 Index Thursday, 2023-07-27 »

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!