| -@gerrit:opendev.org- Lukas Kranz proposed wip: [zuul/zuul-jobs] 887917: prepare-workspace-git: Add ability to define synced pojects https://review.opendev.org/c/zuul/zuul-jobs/+/887917 | 08:25 | |
| @fungicide:matrix.org | tristanC: not sure if your recheck on https://review.opendev.org/890251 means you disagree with my observation or you just didn't spot ity | 17:19 |
|---|---|---|
| @fungicide:matrix.org | * tristanC: not sure if your recheck on https://review.opendev.org/890251 means you disagree with my observation or you just didn't spot it | 17:19 |
| @tristanc_:matrix.org | fungi: i didn't spot it before my comment | 17:19 |
| @fungicide:matrix.org | no worries, just making sure i wasn't misreading the build log | 17:20 |
| @fungicide:matrix.org | i'd propose a revision but i'm not entirely sure what the right correction would be | 17:21 |
| @jim:acmegating.com | while i look into that -- i was curious about that error -- do either of you know if something changed in python to cause that to not function, or is this purely linting? (to clarify: the linter does not allow the original construction which appeared to be perfectly fine to me) | 17:26 |
| @jim:acmegating.com | * while i look into that -- i was curious about that error -- do either of you know if something changed in python to cause that to not function, or is this purely linting? (to clarify: the linter no longer allows the original construction which appeared to be perfectly fine to me) | 17:26 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 890251: Fix linting errors https://review.opendev.org/c/zuul/zuul/+/890251 | 17:28 | |
| @jim:acmegating.com | iow, what exactly is the problem with "if foo: def bar()... else: bar=..." i wonder if it's something to facilitate the scoping optimizations in 3.11.... | 17:29 |
| @fungicide:matrix.org | i also don't see what would be wrong with that. what's the linter complain about exactly? | 17:33 |
| @jim:acmegating.com | ``` | 17:36 |
| tests/base.py:4612:13: F811 redefinition of unused 'fcn' from line 4610 | ||
| def fcn(_, app): | ||
| ``` | ||
| @jim:acmegating.com | so the pattern is really: "fcn=None; if foo: def fcn... elif bar: fcn=bar; fcn()" | 17:37 |
| @fungicide:matrix.org | seems like it's worried that `def fcn()` could unintentionally shadow the earlier implicit (through assignment) `fcn` definition, leading to bugs. is the `fcn-None` "initialization" necessary" like are there any `if fcn` conditionals elsewhere? | 17:56 |
| @fungicide:matrix.org | * seems like it's worried that `def fcn()` could unintentionally shadow the earlier implicit (through assignment) `fcn` definition, leading to bugs. is the `fcn=None` "initialization" necessary" like are there any `if fcn` conditionals elsewhere? | 17:57 |
| @fungicide:matrix.org | * seems like it's worried that `def fcn()` could unintentionally shadow the earlier implicit (through assignment) `fcn` definition, leading to bugs. is the `fcn=None` "initialization" necessary? like are there any `if fcn` conditionals elsewhere? | 17:57 |
| @fungicide:matrix.org | oh, or i guess you still want fcn assigned even `if !foo and !bar` | 17:57 |
| @fungicide:matrix.org | * oh, or i guess you still want `fcn` assigned even `if not foo and not bar` | 17:58 |
| @jim:acmegating.com | oh hrm so maybe the if/elif/else might work, lemme try that | 17:58 |
| @fungicide:matrix.org | * oh, or i guess you still want `fcn` assigned even `if not foo and not bar` | 17:58 |
| @fungicide:matrix.org | yeah, i was about to suggest an else as an alternative (or simply silence `F811` as overzealous) | 17:59 |
| @fungicide:matrix.org | * yeah, i was about to suggest an `else` clause as an alternative (or simply silence `F811` as overzealous) | 17:59 |
| @jim:acmegating.com | okay, it's happy with if/elif/else. i still don't know if the reason for the change is just style preferences or if there's an actual change that needs to happen in order to enable 3.11 scoping performance enhancements... | 18:00 |
| @jim:acmegating.com | (i don't think we need to update 890251) | 18:01 |
| @fungicide:matrix.org | i don't know of any behavior change in 3.11 that would necessitate that, seems more like some hobgoblin's preference | 18:01 |
| @jim:acmegating.com | :| | 18:01 |
| @fungicide:matrix.org | probably just came along for the ride in the latest pycodestyle release | 18:01 |
| @fungicide:matrix.org | style checkers are always a pile of someone else's preferences | 18:02 |
| @jim:acmegating.com | this is from pyflakes though, which (typically?) serves a legitimate use other than increasing SLOC change count | 18:02 |
| @jim:acmegating.com | until now, i've never felt like pyflakes was a waste of time, i've always been happy to see output from it. this one is puzzling. | 18:03 |
| @jim:acmegating.com | (at least, i assume that's what the F still means in F811) | 18:03 |
| @fungicide:matrix.org | oh, yep i missed that, assumed it was pycodestyle | 18:04 |
| @fungicide:matrix.org | https://www.flake8rules.com/rules/F811.html | 18:05 |
| @fungicide:matrix.org | seems like it may have expanded its scope | 18:05 |
| @jim:acmegating.com | that may be an understatement | 18:06 |
| @jim:acmegating.com | as just discussed in #_oftc_#opendev:matrix.org the nodepool openshift job relies on f36 nodes, and fedora has just archived (ie removed) the package repo for that. so that job needs to be updated to presumably use a later version of fedora. | 18:13 |
| @jim:acmegating.com | since this is colliding with the liter change, i think we should disable the openshift job until someone has time to fix it. | 18:14 |
| @jim:acmegating.com | * since this is colliding with the linter change, i think we should disable the openshift job until someone has time to fix it. | 18:14 |
| @fungicide:matrix.org | i agree. also opendev is winding down fedora images/nodes, so may just be a good time to drop fedora testing entirely | 18:15 |
| @jim:acmegating.com | looking at the def; it's for the "launcher", so i think no reason it couldn't be debuntu | 18:16 |
| @jim:acmegating.com | (and actually probably should be debian with py311) | 18:16 |
| @fungicide:matrix.org | wfm | 18:16 |
| @jim:acmegating.com | i think it was just to get some os diversity back in the day | 18:16 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 18:18 | |
| - [zuul/nodepool] 890252: Fix linting error and temp stop running openshift job https://review.opendev.org/c/zuul/nodepool/+/890252 | ||
| - [zuul/nodepool] 890353: Change image ID from int sequence to UUID https://review.opendev.org/c/zuul/nodepool/+/890353 | ||
| - [zuul/nodepool] 890354: Update references of build "number" to "id" https://review.opendev.org/c/zuul/nodepool/+/890354 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 890355: Run openshift test launcher on debian https://review.opendev.org/c/zuul/nodepool/+/890355 | 18:21 | |
| @jim:acmegating.com | let's see what happens! :) | 18:21 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 890251: Fix linting errors https://review.opendev.org/c/zuul/zuul/+/890251 | 19:27 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 890362: DNM: test ansible 8 https://review.opendev.org/c/zuul/zuul-jobs/+/890362 | 20:21 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 890363: DNM: test ansible 6 https://review.opendev.org/c/zuul/zuul-jobs/+/890363 | 20:31 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 890363: DNM: test ansible 6 https://review.opendev.org/c/zuul/zuul-jobs/+/890363 | 21:10 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 890363: DNM: test ansible 6 https://review.opendev.org/c/zuul/zuul-jobs/+/890363 | 21:11 | |
| @jim:acmegating.com | Who is interested in maintaining nimble jobs/roles in zuul-jobs? It looks like they have bitrotted as you can see from the results on https://review.opendev.org/890363 | 21:23 |
| @jim:acmegating.com | (they are in progress now; but will report there in a few mins) | 21:23 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 890036: Add early failure indication to the web UI https://review.opendev.org/c/zuul/zuul/+/890036 | 21:29 | |
| @jim:acmegating.com | remote: https://review.opendev.org/c/openstack/project-config/+/890367 Change zuul tenant ansible version to 8 [NEW] | 21:42 |
| @jim:acmegating.com | I think we're ready for that -- the only failures in the test change are common to both 6 and 8. | 21:42 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 21:46 | |
| - [zuul/nodepool] 890355: Run openshift test launcher on debian https://review.opendev.org/c/zuul/nodepool/+/890355 | ||
| - [zuul/nodepool] 890368: Update bindep for debian bookworm https://review.opendev.org/c/zuul/nodepool/+/890368 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 890166: Add gcloud pubsub support to Gerrit driver https://review.opendev.org/c/zuul/zuul/+/890166 | 21:50 | |
| @jim:acmegating.com | zuul-maint: https://review.opendev.org/890252 would be good to merge soon to unblock nodepool | 21:59 |
| -@gerrit:opendev.org- Zuul merged on behalf of lotorev vitaly: [zuul/zuul] 890065: doc: Specify implicitly created semaphores https://review.opendev.org/c/zuul/zuul/+/890065 | 22:34 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/nodepool] 890252: Fix linting error and temp stop running openshift job https://review.opendev.org/c/zuul/nodepool/+/890252 | 23:53 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!