@clarkb:matrix.org | I've written a Zuul annual report draft here: https://etherpad.opendev.org/p/2023-zuul-annual-report corvus I think you made the note about highlighting the number of zero downtime upgrades. Were you thinking about calling out that OpenDev has done those weekly now for a year? Not sure I have access to any additional info but hapyp to add that somewhere if I've interpretted it correctly | 01:05 |
---|---|---|
@clarkb:matrix.org | I definitely feel like my writing here could use some work, but figured getting soemthing drafted taht can be refined was better than just being frustrated I wasn't entirely happy with all of it | 01:06 |
@jim:acmegating.com | Clark: yeah, opendev what i was thinking -- as a public exemplar. thanks for doing that, i'll take a look tomorrow | 01:36 |
-@gerrit:opendev.org- Jeremy Stanley https://matrix.to/#/@fungicide:matrix.org proposed wip: [opendev/zone-zuul-ci.org] 902690: Add an SPF record for the listserv https://review.opendev.org/c/opendev/zone-zuul-ci.org/+/902690 | 14:48 | |
-@gerrit:opendev.org- Jeremy Stanley https://matrix.to/#/@fungicide:matrix.org proposed wip: [opendev/zone-zuul-ci.org] 902690: Add an SPF record for the listserv https://review.opendev.org/c/opendev/zone-zuul-ci.org/+/902690 | 15:09 | |
@jim:acmegating.com | i believe ansible 2.15.7 (ansible 8) just released and causes a breaking behavior change in zuul | 17:42 |
@jim:acmegating.com | probably this https://github.com/ansible/ansible/blob/stable-2.15/changelogs/CHANGELOG-v2.15.rst#security-fixes | 17:42 |
@clarkb:matrix.org | corvus: should we cautiously disable the auto deployment of zuul in opendev (since it will pull in newer images) | 17:43 |
@clarkb:matrix.org | I guess we have until the end of friday to do that so aren't in a rush and can focus on a fix first | 17:43 |
@fungicide:matrix.org | how is that behavior change manifesting in zuul? any ideas? | 17:44 |
@jim:acmegating.com | Clark: couldn't hurt. it released 19 hours ago, and we haven't merged a change since then, so no image updates | 17:44 |
@jim:acmegating.com | fungi: this test failure: (something about zuul vars and unsafe templating): https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f9f/902601/1/check/zuul-nox-py311/f9f8a76/testr_results.html | 17:44 |
@jim:acmegating.com | i haven't worked out the implications yet | 17:44 |
@jim:acmegating.com | Clark: actually, no need to disable opendev deployment | 17:45 |
@jim:acmegating.com | since we aren't going to be merging any changes that would cause an image build without addressing this. :) | 17:45 |
@jim:acmegating.com | yay gating | 17:45 |
@fungicide:matrix.org | "The conditional check \'zuul.project.name == \'{{ (zuul | zuul_legacy_vars).ZUUL_PROJECT }}\'\' failed. The error was: Conditional is marked as unsafe, and cannot be evaluated." | 17:45 |
@fungicide:matrix.org | that? | 17:45 |
@jim:acmegating.com | yep that | 17:46 |
@jim:acmegating.com | i'm going to go try to untangle whether that's a good thing or bad now. :) | 17:46 |
@clarkb:matrix.org | thank you for the heads up! | 17:49 |
@jim:acmegating.com | this is the change https://github.com/ansible/ansible/pull/82294 | 17:52 |
@jim:acmegating.com | that change says -- `assert - Nested templating may result in an inability for the conditional to be evaluated. See the porting guide for more information.` | 17:55 |
@jim:acmegating.com | but i don't find the words `assert` or `nested` in https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_8.html | 17:55 |
@jim:acmegating.com | i think we just need to drop the {{}} | 17:58 |
-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 902707: Remove nested templates from assert in tests https://review.opendev.org/c/zuul/zuul/+/902707 | 18:00 | |
@jim:acmegating.com | Clark: fungi ^ the way i'm reading this is that this is a mostly surface-level change for us -- in that it's a small adjustment we need to make to our unit tests, and it does not require any kind of structural change to how we deal with unsafe vars, etc. Users may need to make similar changes in their playbooks, but the connection to zuul is tenuous here (we just happened to notice this because we have some ancient assert strings that are checking zuul variables, but this could happen to any ansible variable evaluation, zuul or not) | 18:03 |
@clarkb:matrix.org | the ambiguity of what is and isn't interpretted as jinja is one of my frustrations with ansible. I'm guessing others have confusion about that too and ya we shoudl expect at least some fallout. At least the fix issimple | 18:04 |
@jim:acmegating.com | i'm not sure if we want to include a release note? we don't normally do anything for minor ansible point releases, but maybe since we happen to have noticed this one we should call it out? i don't want to create an expectation that we're going to vet or summarize ansible releases in the future though.... | 18:04 |
@jim:acmegating.com | or maybe we could just send a note to zuul-discuss giving folks a heads up | 18:04 |
@clarkb:matrix.org | a note to zuul-discuss seems like a good idea | 18:04 |
@jim:acmegating.com | i'll fire that off now | 18:05 |
@jim:acmegating.com | https://docs.ansible.com/ansible-core/2.15/porting_guides/porting_guide_core_2.15.html | 18:05 |
@jim:acmegating.com | oh apparently *that's* the porting guide i should have been looking at | 18:05 |
@jim:acmegating.com | mail sent: https://lists.zuul-ci.org/archives/list/zuul-discuss@lists.zuul-ci.org/thread/C7A2U7HGVH2W6NV2IPCQP6KAHOZKOMXX/ | 18:14 |
@jim:acmegating.com | I think we can/should approve that unit test change, and that will give us images with updated ansible 8. | 18:15 |
@fungicide:matrix.org | i agree, seems surprisingly straightforward. thanks for running it down! | 18:20 |
@fungicide:matrix.org | i'll keep an eye out for reports of new job failures in opendev's deployment next week | 18:21 |
@fungicide:matrix.org | and can refer them to the zuul-discuss post | 18:21 |
-@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 902707: Remove nested templates from assert in tests https://review.opendev.org/c/zuul/zuul/+/902707 | 19:34 | |
-@gerrit:opendev.org- Jeremy Stanley https://matrix.to/#/@fungicide:matrix.org marked as active: [opendev/zone-zuul-ci.org] 902690: Add an SPF record for the listserv https://review.opendev.org/c/opendev/zone-zuul-ci.org/+/902690 | 19:47 | |
-@gerrit:opendev.org- Zuul merged on behalf of Jeremy Stanley https://matrix.to/#/@fungicide:matrix.org: [opendev/zone-zuul-ci.org] 902690: Add an SPF record for the listserv https://review.opendev.org/c/opendev/zone-zuul-ci.org/+/902690 | 20:03 | |
@clarkb:matrix.org | corvus: I've updated the zuul annual report document with a paragraph about the rolling restart achievement | 22:01 |
@jim:acmegating.com | Clark: looks good; i made some editorial changes based on your invitation yesterday, but i tried to keep it light. if there's still anything else you're not thrilled about, let me know and i can try to focus more. | 22:15 |
@clarkb:matrix.org | corvus: will do I need to reread with fresh eyes probably tomorrow then can decide if anything else needs tightening up | 22:16 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!