| @f2ked:matrix.org | nodepool statemachine does not define `node.hostname` | 17:13 |
|---|---|---|
| ``` | ||
| nodepool/driver/statemachine.py:41:class StateMachineNodeLauncher(stats.StatsReporter): | ||
| ``` | ||
| but I can set `node.public_ipv4` is this intentional? | ||
| @f2ked:matrix.org | proposed diff | 17:17 |
| ``` | ||
| diff --git a/nodepool/driver/statemachine.py b/nodepool/driver/statemachine.py | ||
| index bb1c1a2e..2c60bb79 100644 | ||
| --- a/nodepool/driver/statemachine.py | ||
| +++ b/nodepool/driver/statemachine.py | ||
| @@ -170,7 +170,7 @@ class StateMachineNodeLauncher(stats.StatsReporter): | ||
| # the image attributes earlier, set those. | ||
| for attr in ('username', 'python_path', 'shell_type', | ||
| 'connection_port', 'connection_type', | ||
| - 'host_keys'): | ||
| + 'host_keys', 'hostname'): | ||
| if hasattr(instance, attr): | ||
| setattr(node, attr, getattr(instance, attr)) | ||
| ``` | ||
| @sylvass:albinvass.se | tristanC: I see you've merged: https://softwarefactory-project.io/r/c/software-factory/re-ansi/+/31495 | 18:32 |
| Is it a lot of work to update zuul to use that or is it just a version bump? | ||
| -@gerrit:opendev.org- Albin Vass proposed: [zuul/zuul] 920002: web: bump re-ansi to fix arm64 builds https://review.opendev.org/c/zuul/zuul/+/920002 | 18:38 | |
| @tristanc_:matrix.org | Albin Vass: The version published with that change is not yet usable in Zuul because the rescript standard lib is not available as pure javascript file, we need to use a bundler as suggested in https://github.com/rescript-lang/rescript-compiler/issues/6754 | 18:39 |
| @sylvass:albinvass.se | ah :( | 18:40 |
| @sylvass:albinvass.se | I'm not in a hurry for this so I'll hold: https://review.opendev.org/c/zuul/zuul/+/919413 for now. | 18:43 |
| Please send me a ping whenever re-ansi is ready to bump | ||
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!