| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/nodepool] 921425: WIP: Run tests in container https://review.opendev.org/c/zuul/nodepool/+/921425 | 08:38 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Monty Taylor https://matrix.to/#/@mordred:inaugust.com: [zuul/zuul] 921414: Remove iso8601 https://review.opendev.org/c/zuul/zuul/+/921414 | 12:36 | |
| @sandruz:matrix.org | > <@sandruz:matrix.org> Hi Everyone, first time here with a question regarding Zuul. | 13:25 |
|---|---|---|
| > In our environment we setup Github Actions in parallel with Zuul. | ||
| > We use GHA for fast checks on code and zuul for the entire build and test + various other pipelines associated. | ||
| > | ||
| > My question is: can I create a pipeline on zuul that requires a GHA to succeed before it gets triggered? | ||
| > | ||
| > Documentation mention this: | ||
| > | ||
| > --- | ||
| > | ||
| > pipeline.require.\<github source>.status | ||
| > A string value that corresponds with the status of the pull request. The syntax is user:status:value. This can also be a regular expression. | ||
| > | ||
| > Zuul does not differentiate between a status reported via status API or via checks API (which is also how Github behaves in terms of branch protection and status checks). Thus, the status could be reported by a pipeline.\<reporter>.\<github source>.status or a pipeline.\<reporter>.\<github source>.check. | ||
| > | ||
| > When a status is reported via the status API, Github will add a \[bot\] to the name of the app that reported the status, resulting in something like user\[bot\]:status:value. For a status reported via the checks API, the app’s slug will be used as is. | ||
| > | ||
| > --- | ||
| > | ||
| > But I haven't found any resources online, maybe someone here has already done this kind of integration before and can suggest me how to proceed. | ||
| > Any help will be really appreciated. | ||
| Hi guys, I'm still here with this request. | ||
| Do you know the style format for this request? | ||
| require: | ||
| github: | ||
| status: | ||
| - "pre-commit:status:success" | ||
| Documentation says that Github Checks are also returned from the Github Driver | ||
| https://zuul-ci.org/docs/zuul/4.2.0/reference/drivers/github.html#attr-pipeline.require.%3Cgithub%20source%3E.status | ||
| May I have an example please? | ||
| @sandruz:matrix.org | * Hi guys, I'm still here with this request. | 13:25 |
| Do you know the style format for this request? | ||
| ``` | ||
| require: | ||
| github: | ||
| status: | ||
| - "pre-commit:status:success" | ||
| ``` | ||
| This one it's not working, and I also tried removing the :status: part. | ||
| Documentation says that Github Checks are also returned from the Github Driver | ||
| https://zuul-ci.org/docs/zuul/4.2.0/reference/drivers/github.html#attr-pipeline.require.%3Cgithub%20source%3E.status | ||
| May I have an example please? | ||
| @sandruz:matrix.org | * Hi guys, I'm still here with this request. | 13:45 |
| Do you know the style format for this request? | ||
| ``` | ||
| require: | ||
| github: | ||
| status: | ||
| - "pre-commit:status:success" | ||
| ``` | ||
| This one is not working, and I also tried removing the :status: part. | ||
| The documentation says that Github Checks are also returned from the Github Driver | ||
| https://zuul-ci.org/docs/zuul/4.2.0/reference/drivers/github.html#attr-pipeline.require.%3Cgithub%20source%3E.status | ||
| May I have an example please? Documentation it's fuzzy in this regards. | ||
| @sandruz:matrix.org | * Hi guys, I'm still here with this request. | 14:03 |
| Do you know the style format for this request? | ||
| ``` | ||
| require: | ||
| github: | ||
| status: | ||
| - "pre-commit:status:success" | ||
| ``` | ||
| In my use case "pre-commit" it's a Github Required Check. | ||
| The documentation says that Github Checks are also returned from the Github Driver but doesn't provide HOW they are supposed to be used. | ||
| https://zuul-ci.org/docs/zuul/4.2.0/reference/drivers/github.html#attr-pipeline.require.%3Cgithub%20source%3E.status | ||
| May I have an example please? Documentation it's fuzzy in this regards. | ||
| @clarkb:matrix.org | > <@sandruz:matrix.org> Hi guys, I'm still here with this request. | 15:16 |
| > Do you know the style format for this request? | ||
| > | ||
| > ``` | ||
| > require: | ||
| > github: | ||
| > status: | ||
| > - "pre-commit:status:success" | ||
| > ``` | ||
| > In my use case "pre-commit" it's a Github Required Check. | ||
| > The documentation says that Github Checks are also returned from the Github Driver but doesn't provide HOW they are supposed to be used. | ||
| > https://zuul-ci.org/docs/zuul/4.2.0/reference/drivers/github.html#attr-pipeline.require.%3Cgithub%20source%3E.status | ||
| > | ||
| > May I have an example please? Documentation it's fuzzy in this regards. | ||
| I don't know the answer to your question as we don't do much github integration with our zuul installation. But I do know that github logs all of the hook calls it makes and zuul should similarly log those requests in the zuul web log. Assuming those updates go through that system I would expect those logs to provide hints at what the status values are. | ||
| @clarkb:matrix.org | Looks like this info comes from explicit graphql requests and not the hook callbacks | 15:23 |
| @clarkb:matrix.org | Alessandro Alba: looking at the zuul code https://opendev.org/zuul/zuul/src/branch/master/zuul/driver/github/githubconnection.py#L2076-L2081 may log the info you need. Though I'm not sure the change representation in the logs includes the list of contexts | 15:28 |
| @clarkb:matrix.org | Alessandro Alba: actually I think it will be logged explicitly here: https://opendev.org/zuul/zuul/src/branch/master/zuul/driver/github/githubmodel.py#L566-L567 | 15:30 |
| @clarkb:matrix.org | the easiest thing may be to set some value, then see what the logs look like when they fail, adjust as necessary, then possibly propose improvements to the docs to make it more clear | 15:30 |
| @sandruz:matrix.org | > <@clarkb:matrix.org> I don't know the answer to your question as we don't do much github integration with our zuul installation. But I do know that github logs all of the hook calls it makes and zuul should similarly log those requests in the zuul web log. Assuming those updates go through that system I would expect those logs to provide hints at what the status values are. | 15:32 |
| Thanks Clark I was finally able to solve, by using this format: | ||
| github: | ||
| status: | ||
| - .*pre-commit.*:success | ||
| @sandruz:matrix.org | Clark: Another question if I may. | 15:34 |
| Now that I have this requirement, the reason of the failure it's not visible from outside. | ||
| Is there a way to print out a comment in the PR that says: "Requirement not meet, please ensure "pre-commit" succede"? | ||
| @sandruz:matrix.org | * Clark: Another question if I may. | 15:34 |
| Now that I have this requirement, the reason of the failure it's not visible from outside. | ||
| Is there a way to print out a comment in the PR that says: "Requirement not meet, please ensure "pre-commit" is succeding"? | ||
| @clarkb:matrix.org | No I don't think there is a way to configure that. As mentioned above it should be logged though allowing zuul admins to see what happened at least | 15:35 |
| @clarkb:matrix.org | though maybe FalseWithReason is already going to attempt something like that? | 15:36 |
| @clarkb:matrix.org | no looks like that is only used in the logs | 15:41 |
| @clarkb:matrix.org | https://opendev.org/zuul/zuul/src/branch/master/zuul/manager/__init__.py#L196-L205 there | 15:42 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 921459: Keep project info in repo state keys https://review.opendev.org/c/zuul/zuul/+/921459 | 16:02 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 921460: Use merger_items to get additional repo state projects https://review.opendev.org/c/zuul/zuul/+/921460 | 16:23 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 16:29 | |
| - [zuul/zuul] 919622: Clear files and repo state from scheduler RAM https://review.opendev.org/c/zuul/zuul/+/919622 | ||
| - [zuul/zuul] 920367: Move repo state to blobstore https://review.opendev.org/c/zuul/zuul/+/920367 | ||
| - [zuul/zuul] 921459: Keep project info in repo state keys https://review.opendev.org/c/zuul/zuul/+/921459 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 921460: Use merger_items to get additional repo state projects https://review.opendev.org/c/zuul/zuul/+/921460 | 16:29 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 921466: Remove unecessary azure dependencies https://review.opendev.org/c/zuul/nodepool/+/921466 | 17:32 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 921413: Add cloud driver requriements https://review.opendev.org/c/zuul/zuul/+/921413 | 17:33 | |
| -@gerrit:opendev.org- Tristan Cacqueray https://matrix.to/#/@tristanc_:matrix.org proposed: [zuul/zuul] 921473: web: update to react 16.14.0 https://review.opendev.org/c/zuul/zuul/+/921473 | 19:03 | |
| -@gerrit:opendev.org- Tristan Cacqueray https://matrix.to/#/@tristanc_:matrix.org proposed: [zuul/zuul] 921474: web: update re-ansi to the latest version https://review.opendev.org/c/zuul/zuul/+/921474 | 19:08 | |
| @tristanc_:matrix.org | Albin Vass: ^ 474 should fix the re-ansi usage on arm! I applied the bundle procedure upstream provided. | 19:09 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 21:01 | |
| - [zuul/zuul] 921412: Remove some requirements caps https://review.opendev.org/c/zuul/zuul/+/921412 | ||
| - [zuul/zuul] 921413: Add cloud driver requriements https://review.opendev.org/c/zuul/zuul/+/921413 | ||
| - [zuul/zuul] 921478: Reduce duplicaton when adding identical objects https://review.opendev.org/c/zuul/zuul/+/921478 | ||
| - [zuul/zuul] 921479: Add image configuration object https://review.opendev.org/c/zuul/zuul/+/921479 | ||
| @clarkb:matrix.org | any objections to me approving https://review.opendev.org/c/zuul/zuul-jobs/+/920857/ at this point? There are many +2s | 21:09 |
| @clarkb:matrix.org | this is the change that updates zuul-job's ansible version for testing | 21:09 |
| @jim:acmegating.com | Clark: i think it's gtg | 21:09 |
| @clarkb:matrix.org | I have approved it | 21:11 |
| @sylvass:albinvass.se | tristanC: nice, thanks! I'll see if I can test it tomorrow | 22:07 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 919622: Clear files and repo state from scheduler RAM https://review.opendev.org/c/zuul/zuul/+/919622 | 23:01 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!