| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul-jobs] 929819: Cleanup ansible lint warnings https://review.opendev.org/c/zuul/zuul-jobs/+/929819 | 15:48 | |
| @clarkb:matrix.org | Is there any interest in cleanup like ^ I had a really hard time finding the actual error in 929689 yesterday | 15:49 |
|---|---|---|
| @clarkb:matrix.org | I'm hoping that if we can clear out the warnings we can avoid that difficulty in the future | 15:49 |
| -@gerrit:opendev.org- Fredrik Medley proposed: [zuul/zuul] 929407: Inject queue_item_id and enqueue_time to inventory zuul.items https://review.opendev.org/c/zuul/zuul/+/929407 | 15:52 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 929820: Ignore some recent ansible-list warnings https://review.opendev.org/c/zuul/zuul-jobs/+/929820 | 16:06 | |
| @jim:acmegating.com | Clark: i feel like most of those warnings are, at best, pretty arbitrary and not useful, and at worst, counterproductive (i'm looking at key-order here) | 16:07 |
| @jim:acmegating.com | Clark: i think my preference would be to silence those, and consider fixing the ~10 that remain | 16:07 |
| @clarkb:matrix.org | works for me. Out of curiousity why modify the command line instead of .ansible-lint? | 16:08 |
| @jim:acmegating.com | just the first thing i saw that worked :) | 16:08 |
| @jim:acmegating.com | wonder why we have both | 16:08 |
| @clarkb:matrix.org | I left a note that maybe the idea is to have things overrideable via the env var and then things we feel strongly about in the .ansible-lint file? | 16:09 |
| @clarkb:matrix.org | that is just a guess though | 16:09 |
| @jim:acmegating.com | maybe it was 2 people that didn't know about each others work | 16:11 |
| @jim:acmegating.com | file works just as well, i'll move it there so we can have comments | 16:12 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 929820: Ignore some recent ansible-list warnings https://review.opendev.org/c/zuul/zuul-jobs/+/929820 | 16:16 | |
| @jim:acmegating.com | Clark: ^ moved to dotfile | 16:16 |
| @jim:acmegating.com | i could be convinced pretty easily that we should fix-and-enable the name[casing] one. that one is a good idea, not too hard to fix, and i don't think we regularly violate it. | 16:18 |
| @clarkb:matrix.org | I've just discovered that the haskell/cabal roles only run on fedora and we don't have fedora test nodes anymore. Should we remove the tests for those but keep the roles in case someone is using them with fedora somewhere? | 16:18 |
| @jim:acmegating.com | if you or someone agreed and did a change for that one, i would +2 it | 16:18 |
| @jim:acmegating.com | re haskell: yes i think so; not sure if we should update docs to mention they are untested and "as-is"? also, new tests welcome | 16:19 |
| @clarkb:matrix.org | ya can do that too. I'll work on that update | 16:19 |
| @jim:acmegating.com | tristanC: ping fyi regarding haskell roles ^ | 16:20 |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul-jobs] 929822: Disable testing of haskell roles/jobs https://review.opendev.org/c/zuul/zuul-jobs/+/929822 | 16:25 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul-jobs] 929820: Ignore some recent ansible-list warnings https://review.opendev.org/c/zuul/zuul-jobs/+/929820 | 16:40 | |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul-jobs] 929828: Cleanup remaining Ansible lint warnings https://review.opendev.org/c/zuul/zuul-jobs/+/929828 | 17:28 | |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul-jobs] 929828: Cleanup remaining Ansible lint warnings https://review.opendev.org/c/zuul/zuul-jobs/+/929828 | 17:35 | |
| @clarkb:matrix.org | that fixes the remaining linter warnings but a bunch of functional stuff fails | 17:49 |
| -@gerrit:opendev.org- Fredrik Medley proposed: [zuul/zuul] 929407: Inject queue_item_id and enqueue_time to inventory zuul.items https://review.opendev.org/c/zuul/zuul/+/929407 | 17:56 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 18:33 | |
| - [zuul/zuul] 929356: Add pagination to Github graphql canmerge query https://review.opendev.org/c/zuul/zuul/+/929356 | ||
| - [zuul/zuul] 929833: Support github required conversation resolution https://review.opendev.org/c/zuul/zuul/+/929833 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 929834: Support docker-compose v2 in test setup script https://review.opendev.org/c/zuul/zuul/+/929834 | 18:33 | |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul-jobs] 929822: Disable testing of haskell roles/jobs https://review.opendev.org/c/zuul/zuul-jobs/+/929822 | 21:19 | |
| -@gerrit:opendev.org- Clark Boylan proposed: | 21:35 | |
| - [zuul/zuul-jobs] 929828: Cleanup remaining Ansible lint warnings https://review.opendev.org/c/zuul/zuul-jobs/+/929828 | ||
| - [zuul/zuul-jobs] 929852: Bump node_version default from 6 to 20 https://review.opendev.org/c/zuul/zuul-jobs/+/929852 | ||
| - [zuul/zuul-jobs] 929853: Install doc bindep profile in zuul-jobs-test-tox https://review.opendev.org/c/zuul/zuul-jobs/+/929853 | ||
| @clarkb:matrix.org | I'm hoping that stack is mergeable but we may end up triggering more jobs that need fixing... | 21:35 |
| @clarkb:matrix.org | for those that understand deb repos better we get this error trying to install nodejs packages from nodesource: https://zuul.opendev.org/t/zuul/build/8d8cfb7960de4b4493670ba4d3fb249a. If you hit https://deb.nodesource.com they give you some `curl | bash` nonsense. I've fetched the script and in it they do `echo "deb [arch=$arch signed-by=/usr/share/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$node_version nodistro main" | tee /etc/apt/sources.list.d/nodesource.list > /dev/null` where `$node_version="20.x"`. However you can't browse that nodesource server (I guess its served by object storage?) so I'm not sure how to get that job to be happy | 21:48 |
| @clarkb:matrix.org | I'd like to avoid blindly running `curl | bash` and instead configure things more properly ourselves. Is the issue possibly the nodistro vs jammy thing? | 21:48 |
| @clarkb:matrix.org | * I'd like to avoid blindly running `curl | bash` and instead configure things more properly ourselves. Is the issue possibly the nodistro vs noble thing? | 21:48 |
| @clarkb:matrix.org | Looks like maybe we refer to a different gpg key too. I can try updating the distro and the key and see if that is happier | 21:50 |
| @clarkb:matrix.org | oh neat actually looks like setup_14.x script matches what we do already. So I think 6 went away but 14 still does what we do today. 20 is new | 21:55 |
| @clarkb:matrix.org | 16 and newer appear to use the new stuff. I'll try to update the role to switch based on the version | 21:57 |
| -@gerrit:opendev.org- Clark Boylan proposed: | 22:01 | |
| - [zuul/zuul-jobs] 929852: Modernize ensure-nodejs https://review.opendev.org/c/zuul/zuul-jobs/+/929852 | ||
| - [zuul/zuul-jobs] 929853: Install doc bindep profile in zuul-jobs-test-tox https://review.opendev.org/c/zuul/zuul-jobs/+/929853 | ||
| - [zuul/zuul-jobs] 929828: Cleanup remaining Ansible lint warnings https://review.opendev.org/c/zuul/zuul-jobs/+/929828 | ||
| @clarkb:matrix.org | nice that whole stack is happy now | 22:30 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 929856: WIP: Add vars-files job attribute https://review.opendev.org/c/zuul/zuul/+/929856 | 23:12 | |
| @jim:acmegating.com | Clark: +2 with comment on 852 | 23:29 |
| -@gerrit:opendev.org- Zuul merged on behalf of Clark Boylan: [zuul/zuul-jobs] 929689: Bump the default ensure-kubernetes microk8s version to 1.31/stable https://review.opendev.org/c/zuul/zuul-jobs/+/929689 | 23:29 | |
| @clarkb:matrix.org | corvus: I don't think they have a latest alias | 23:31 |
| @jim:acmegating.com | bummer | 23:31 |
| @clarkb:matrix.org | which means we would have to lookup the current lts somehow and then interpolate that in | 23:31 |
| @jim:acmegating.com | yeah that's probably not worth it | 23:31 |
| @jim:acmegating.com | i mean, if someone wrote that, i would review it | 23:32 |
| @clarkb:matrix.org | we could maybe drop the default entirely then fix whatever testswere relying on it | 23:32 |
| @jim:acmegating.com | oh that's an idea too | 23:32 |
| @jim:acmegating.com | yeah now that you mention it, i think that will have the same effect; maybe we should do that | 23:32 |
| @clarkb:matrix.org | ok I can work on that | 23:32 |
| @jim:acmegating.com | because the reality is that everyone pretty much has to pin that anyway | 23:32 |
| @clarkb:matrix.org | basically remove the default from the role then be explicit in our test jobs. Everyone else has to set something anyway | 23:33 |
| @clarkb:matrix.org | since not 14 is apparently broken | 23:33 |
| @jim:acmegating.com | so if we just make it a required parameter, then we can get out of the business of managing everyone in the world's default nodejs version :) | 23:33 |
| @fungicide:matrix.org | yeah, i too like that idea better | 23:33 |
| @fungicide:matrix.org | there are other places we could adopt a similar approach | 23:34 |
| @fungicide:matrix.org | if a default is only ever at best right for a minority of users, then it's better not to have one | 23:34 |
| @clarkb:matrix.org | so digging into this we're actually setting a lot of defaults at a job level to 14 or 18 etc | 23:45 |
| @clarkb:matrix.org | I'm not going to touch that and only remove the default that is clearly broken from the role underlying all of this | 23:45 |
| -@gerrit:opendev.org- Clark Boylan proposed: | 23:46 | |
| - [zuul/zuul-jobs] 929852: Modernize ensure-nodejs https://review.opendev.org/c/zuul/zuul-jobs/+/929852 | ||
| - [zuul/zuul-jobs] 929853: Install doc bindep profile in zuul-jobs-test-tox https://review.opendev.org/c/zuul/zuul-jobs/+/929853 | ||
| - [zuul/zuul-jobs] 929828: Cleanup remaining Ansible lint warnings https://review.opendev.org/c/zuul/zuul-jobs/+/929828 | ||
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!