| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul] 930521: Replace blockdiag graphs with graphviz graphs https://review.opendev.org/c/zuul/zuul/+/930521 | 00:45 | |
| @clarkb:matrix.org | That took entirely too much time | 00:46 |
|---|---|---|
| @jim:acmegating.com | you're tellin' me :) | 00:55 |
| @clarkb:matrix.org | getting the last graph to align vertically was tricky. I'm not sure i did it properly either but it seems to work | 00:56 |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 929273: Add support for 'min-ready' provider nodes https://review.opendev.org/c/zuul/zuul/+/929273 | 10:43 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 929273: Add support for 'min-ready' provider nodes https://review.opendev.org/c/zuul/zuul/+/929273 | 14:09 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 929273: Add support for 'min-ready' provider nodes https://review.opendev.org/c/zuul/zuul/+/929273 | 14:13 | |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul] 930521: Replace blockdiag graphs with graphviz graphs https://review.opendev.org/c/zuul/zuul/+/930521 | 15:28 | |
| @clarkb:matrix.org | fungi: ^ I think I made the margins around the image better in that patchset | 15:29 |
| @fungicide:matrix.org | thanks!!!\ | 15:48 |
| @fungicide:matrix.org | * thanks!!! | 15:48 |
| @clarkb:matrix.org | https://528b8a200a0edba06989-58a9f5f5793940e036b8abf187f02364.ssl.cf5.rackcdn.com/930521/2/check/zuul-nox-docs/bd1c5a6/docs/gating.html fished out the site preview link. This is with a 1em bottom margin | 16:15 |
| @jim:acmegating.com | i think that actually looks a bit better than the original | 16:17 |
| @fungicide:matrix.org | agreed | 16:20 |
| @fungicide:matrix.org | the new diagrams are considerably more readable on their own than the old, but also the spacing adjustments help even more | 16:21 |
| @clarkb:matrix.org | there might actually be a small bug in the last diagram | 16:26 |
| @clarkb:matrix.org | I'm going to fix that really quickly then we can reapprove | 16:26 |
| @clarkb:matrix.org | heh of course fixing that makes things sad. | 16:28 |
| @clarkb:matrix.org | the issue is the edge between C and B in the dependencies block. That wasn't there in the original | 16:29 |
| @clarkb:matrix.org | its a minor issue and I don't think we should panic halt the approvals if this takes a bit to figure out | 16:29 |
| @fungicide:matrix.org | happy to review it as a followup | 16:31 |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul] 930521: Replace blockdiag graphs with graphviz graphs https://review.opendev.org/c/zuul/zuul/+/930521 | 16:31 | |
| @clarkb:matrix.org | it ended up not being too bad. | 16:31 |
| @clarkb:matrix.org | so I went ahead and updated the existing change | 16:32 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed on behalf of Tobias Henkel: [zuul/zuul] 922450: Add spec for OIDC Workload Identity Federation https://review.opendev.org/c/zuul/zuul/+/922450 | 20:17 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: | 22:14 | |
| - [zuul/zuul] 929356: Add pagination to Github graphql canmerge query https://review.opendev.org/c/zuul/zuul/+/929356 | ||
| - [zuul/zuul] 929833: Support github required conversation resolution https://review.opendev.org/c/zuul/zuul/+/929833 | ||
| -@gerrit:opendev.org- Zuul merged on behalf of Clark Boylan: [zuul/zuul] 930521: Replace blockdiag graphs with graphviz graphs https://review.opendev.org/c/zuul/zuul/+/930521 | 23:14 | |
| @clarkb:matrix.org | woo I think that concludes my Pillow/blockdiag/seqdiag cleanups | 23:20 |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul] 930654: Fix area covered by dependencies cluster in graphviz graph https://review.opendev.org/c/zuul/zuul/+/930654 | 23:41 | |
| @clarkb:matrix.org | I noticed one small thing in the graph and ^ should fix it | 23:41 |
| @clarkb:matrix.org | and then I should stop looking at them | 23:41 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!