| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 920212: Use latest patchset with Gerrit cherry-pick https://review.opendev.org/c/zuul/zuul/+/920212 | 00:24 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 942159: Process gerrit change-merged events before ref-updated https://review.opendev.org/c/zuul/zuul/+/942159 | 01:35 | |
| -@gerrit:opendev.org- Karolina Kula proposed wip: [zuul/nodepool] 934742: DNM Debug glean service failure https://review.opendev.org/c/zuul/nodepool/+/934742 | 08:42 | |
| -@gerrit:opendev.org- Fabien Boucher proposed: [zuul/zuul-jobs] 943586: zuul_log_path: allow override for emit-job-header and upload-logs https://review.opendev.org/c/zuul/zuul-jobs/+/943586 | 09:16 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 943677: Support custom claim and print meta info in zuul-admin create-auth-token https://review.opendev.org/c/zuul/zuul/+/943677 | 12:12 | |
| -@gerrit:opendev.org- Dong Zhang proposed wip: [zuul/zuul] 943677: Support custom claim and print meta info in zuul-admin create-auth-token https://review.opendev.org/c/zuul/zuul/+/943677 | 12:48 | |
| -@gerrit:opendev.org- Dong Zhang proposed wip: [zuul/zuul] 943677: Support custom claim and print meta info in zuul-admin create-auth-token https://review.opendev.org/c/zuul/zuul/+/943677 | 12:49 | |
| @morucci:matrix.org | Hi folks, may I kindly request a code review? we got in trouble with the database limitation of 255 max len for storing the log url. We are using upload-log role that does not provide the way to override zuul_log_path. So this lead us to duplicate the upstream role for our need. This simple change will help us a lot https://review.opendev.org/c/zuul/zuul-jobs/+/943586 | 16:13 |
|---|---|---|
| @clarkb:matrix.org | fbo: I added some notes about testing. I think testing this is important if we can because both affected roles are commonly used in base jobs | 16:30 |
| @clarkb:matrix.org | fbo: I think the first half of the testing is straightforward, but I don't have a good idea for the second half. Details are in my review notes | 16:30 |
| @clarkb:matrix.org | and I guess the motivation here is you'll be able to set a zuul_log_path that is shorter but not consistent with set-zuul-log-path-fact? | 16:37 |
| @morucci:matrix.org | Clark: thanks for the review, I've replied. Yes that's the case our users use really long jobs names and sometime we hit the limitation. Last Zuul release have that patch https://opendev.org/zuul/zuul/commit/c090f99af7e88cc8e2de7172194e7b7ceb694423 but that's not sufficient. So uploaded the scheme is our wait to fix the issue. But better if we could do w/o duplicating the roles (we are doing this today) but I'd like to revert those duplication after this change is merged perhaps. | 16:50 |
| @morucci:matrix.org | * Clark: thanks for the review, I've replied. Yes that's the case our users use really long jobs names and sometime we hit the limitation. Last Zuul release have that patch https://opendev.org/zuul/zuul/commit/c090f99af7e88cc8e2de7172194e7b7ceb694423 but that's not sufficient. So updating the scheme is our wait to fix the issue. But better if we could do w/o duplicating the roles (we are doing this today) but I'd like to revert those duplication after this change is merged perhaps. | 16:51 |
| @clarkb:matrix.org | fbo: I think the idea of testing that upload-logs role in a very minimal way by disabling uploads is workable here since it will cover the portion that is changing | 16:55 |
| @clarkb:matrix.org | not ideal from a test the role perspective but sufficient for our needs | 16:55 |
| @morucci:matrix.org | Clark: ok then I'll go that way | 17:22 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!