| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul] 945907: Make Gerrit Connection Replication Aware https://review.opendev.org/c/zuul/zuul/+/945907 | 00:10 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Simon Westphahl: [zuul/zuul] 946754: Capitalize AWS image filter key/value arguments https://review.opendev.org/c/zuul/zuul/+/946754 | 02:30 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 946864: Slow processing of failed nodescan connections https://review.opendev.org/c/zuul/zuul/+/946864 | 05:42 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 946619: Allow boto3 session to configure itself https://review.opendev.org/c/zuul/zuul/+/946619 | 05:52 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 946619: Allow boto3 session to configure itself https://review.opendev.org/c/zuul/zuul/+/946619 | 05:58 | |
| -@gerrit:opendev.org- Benjamin Schanzel proposed: [zuul/nodepool] 945719: metastatic: Pass tenant_name to backing node request https://review.opendev.org/c/zuul/nodepool/+/945719 | 07:17 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 946864: Slow processing of failed nodescan connections https://review.opendev.org/c/zuul/zuul/+/946864 | 07:51 | |
| -@gerrit:opendev.org- Dong Zhang proposed wip: [zuul/zuul] 946613: test check run https://review.opendev.org/c/zuul/zuul/+/946613 | 08:15 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 946874: Fix default ok traceback for change list refresh https://review.opendev.org/c/zuul/zuul/+/946874 | 08:59 | |
| -@gerrit:opendev.org- Benjamin Schanzel proposed: [zuul/nodepool] 946875: Fix unused/unassined nonlocal vars (F842) https://review.opendev.org/c/zuul/nodepool/+/946875 | 09:13 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 946748: zuul-web: fix traceback in "job" endpoint if a job doesn't exist https://review.opendev.org/c/zuul/zuul/+/946748 | 09:40 | |
| -@gerrit:opendev.org- Dong Zhang proposed wip: [zuul/zuul] 946613: test check run https://review.opendev.org/c/zuul/zuul/+/946613 | 09:52 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 938011: Enforce required length check in config https://review.opendev.org/c/zuul/zuul/+/938011 | 09:52 | |
| -@gerrit:opendev.org- Dong Zhang proposed wip: [zuul/zuul] 946613: test check run https://review.opendev.org/c/zuul/zuul/+/946613 | 09:53 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 938067: QueueItem: Assign event id when logging events https://review.opendev.org/c/zuul/zuul/+/938067 | 09:55 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 946887: Fix use of unparsed branch cache in config cleanup https://review.opendev.org/c/zuul/zuul/+/946887 | 10:58 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 946890: Wake launcher when node is (un-)locked https://review.opendev.org/c/zuul/zuul/+/946890 | 11:38 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 938067: QueueItem: Assign event id when logging events https://review.opendev.org/c/zuul/zuul/+/938067 | 12:15 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 938011: Enforce required length check in config https://review.opendev.org/c/zuul/zuul/+/938011 | 12:21 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 946890: Wake launcher when node is (un-)locked https://review.opendev.org/c/zuul/zuul/+/946890 | 12:56 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 946913: Add general and config cache cleanup tests https://review.opendev.org/c/zuul/zuul/+/946913 | 14:20 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 946917: Ignore F824 https://review.opendev.org/c/zuul/nodepool/+/946917 | 14:39 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed on behalf of Benjamin Schanzel: [zuul/nodepool] 946875: Fix unused/unassined nonlocal vars (F824) https://review.opendev.org/c/zuul/nodepool/+/946875 | 14:39 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed on behalf of Benjamin Schanzel: [zuul/nodepool] 946875: Fix unused/unassigned nonlocal vars (F824) https://review.opendev.org/c/zuul/nodepool/+/946875 | 14:41 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed on behalf of Benjamin Schanzel: [zuul/nodepool] 946875: Fix unused/unassigned nonlocal vars (F824) https://review.opendev.org/c/zuul/nodepool/+/946875 | 14:41 | |
| @jim:acmegating.com | zuul-maint: ^ i'm interested in opinions on the rule in change (see my comment). i don't feel strongly about it, but i'm not convinced it's helpful, and possibly just a little of the opposite. | 14:42 |
|---|---|---|
| @jim:acmegating.com | also speedy review of https://review.opendev.org/946917 while we deliberate would be good i think | 14:43 |
| @clarkb:matrix.org | any idea what the justification for that is? It seems like explicitly marking a var as non local before you use it rather than only before you assign it is useful info to the programmer | 14:54 |
| @fungicide:matrix.org | i thought it was warning about unused entries | 14:55 |
| @jim:acmegating.com | i think it's one of those cases where it's just not needed by the interpreter. because if you only "read" the variable in the inner scope, then it's obvious to the interpreter it needs to bind to the variable in the outer scope | 14:55 |
| @jim:acmegating.com | (only if you write to a variable in the inner scope do you need to tell the interpreter that it should bind that to the var in the outer scope -- because it can't tell if you want to make a new inner-scope variable or use the existing outer-scope one) | 14:55 |
| @jim:acmegating.com | so the reason to remove it is because "it's not needed". a reason to keep it is "it serves as documentation of intent for the programmer" | 14:56 |
| @clarkb:matrix.org | fungi: the nonlocal is "unused" because as corvus points out the var is never assigned so it is obvious to look in nonlocal scope | 14:57 |
| @clarkb:matrix.org | but it is "used" by the programmer to make that scoping clear | 14:57 |
| @clarkb:matrix.org | I think my slight preference is to ignore that rule but I'm fine with fixing it too | 14:58 |
| @jim:acmegating.com | i feel like the first example in that change is an example of "documentation for programmer". i think the last example is one where i don't think it serves a documentation purpose and probably should be removed regardless (it's really super obvious what's going on there). | 14:58 |
| @fungicide:matrix.org | i suppose the style question is whether it's appropriate to leave developer guidance in the form of unused programming language statements instead of solely with comments | 15:07 |
| @fungicide:matrix.org | of course, that's the entire theory behind type annotations (they're unused by the interpreter at runtime), so it seems like a reasonably popular approach | 15:08 |
| @fungicide:matrix.org | i can't come up with any actual bug this cleanup would prevent, except possibly the risk of a developer amending the code later with what they think is a locally-scoped variable with the same name not realizing they won't shadow the outer scope but will instead end up altering it | 15:10 |
| @f2ked:matrix.org | corvus: Re: the tutorial and my difficulties, I was following tutorial. | 15:31 |
| > Copy the following to .zuul.yaml in the root of the project: | ||
| then | ||
| >Zuul will dynamically evaluate proposed changes to its configuration in untrusted projects immediately, so shortly after your change is uploaded, Zuul will run the new job and report back on the change. | ||
| This is what I was operating on and recalled from doing the tutorial (several times 😀 ). | ||
| perhaps something has changed? | ||
| FWIW: I was at `11.0.0` for the tutorial, but I'm at ToT right now. | ||
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/nodepool] 946917: Ignore F824 https://review.opendev.org/c/zuul/nodepool/+/946917 | 15:35 | |
| @clarkb:matrix.org | f2ked: until you merged a configuration only update to the proposed configuration can speculatively test things. That means your comments to trigger things were ignored as they are not forming a speculative state in a new change | 15:40 |
| @clarkb:matrix.org | basically if you give zuul a proposed configuration directly it can take that and run it. But that only happens when you push code | 15:40 |
| @jim:acmegating.com | f2ked: the part you cited is from well after the description of the initial bootstrapping. the whole section i pointed to --https://zuul-ci.org/docs/zuul/latest/tutorials/quick-start.html#configure-zuul-pipelines -- discusses this, but the paragraph that most describes the difficulty you had starts with "Once we have bootstrapped our initial Zuul configuration, we will want to use the gating process on this repository too". and in particular the sentence that includes "and while we will be able to dynamically add jobs to their pipelines, those projects must first be attached to the pipelines in order for that to work" | 15:47 |
| @jim:acmegating.com | (btw, the tutorial is a gating job for zuul, so it's nearly impossible for them to be out of sync) | 15:49 |
| @f2ked:matrix.org | corvus: hmm I thought that exclusively applied to the zuul-conf that defined the pipeline, but I see that now.. thanks | 15:49 |
| @jim:acmegating.com | that's good feedback; perhaps the context switch from zuul-config to "all the other repos" in that paragraph could be made more clear | 15:50 |
| @f2ked:matrix.org | corvus: happy to be of service :) | 15:53 |
| I'm using `comment-added` to precisely control zuul's involvement in a very busy repo. now that the pipelines are in place, I should be able to to test jobs within an existing/configures pipeline without merging BUT with a changeset+`comment-added`, correct? | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 946936: Make tutorial bootstrapping paragraph more clear https://review.opendev.org/c/zuul/zuul/+/946936 | 15:53 | |
| @f2ked:matrix.org | * corvus: happy to be of service :) | 15:53 |
| I'm using `comment-added` to precisely control zuul's involvement in a very busy repo. now that the pipelines are in place, I should be able to test jobs within an existing/configured pipeline without merging BUT with a changeset+`comment-added`, correct? | ||
| @jim:acmegating.com | i wonder if simply breaking the paragraph may be enough to make that switch more clear | 15:54 |
| @jim:acmegating.com | if a comment-added enqueues an untrusted-project, then the zuul config in the project (including job definitions) will be dynamically evaluated | 15:55 |
| @f2ked:matrix.org | I think that a statement/info/tip that explains that (with my poor taxonomy) the pipelines and a projects "membership" to it must be reflected (defined?) in the "merged" state of the projects | 16:04 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 946939: Quickstart: add more explanatory text about attachment https://review.opendev.org/c/zuul/zuul/+/946939 | 16:10 | |
| @jim:acmegating.com | f2ked: ack -- we use the word "attach" for "membership" in the quickstart | 16:11 |
| @f2ked:matrix.org | FYI: unrelated, I wanted to get details on the noop job and there was a problem, the public `https://zuul.opendev.org/t/zuul/job` also exhibits the problem where you click `noop` and I get | 16:35 |
| ``` | ||
| Something went wrong. | ||
| ``` | ||
| @fungicide:matrix.org | oh, i wonder if we need special handling for that since it's a built-in job | 16:35 |
| @jim:acmegating.com | that will be fixed in https://opendev.org/zuul/zuul/commit/5a69b62cba929f22d3397b9972dfd0a30dc94fe2 -- opendev will restart with that overnight on friday/sat | 16:42 |
| @fungicide:matrix.org | oh, indeed i missed that change entirely. was it fixing a recent regression? | 16:44 |
| @jim:acmegating.com | as i argue in the commit message, fixing a recent improvement | 16:50 |
| @jim:acmegating.com | * as i argue in the commit message, fixing a recent improvement, but yes :) | 16:50 |
| @fungicide:matrix.org | got it, was more wondering how long it had been like that, i guess not very | 17:52 |
| @jim:acmegating.com | oh yeah, like a few days | 18:07 |
| @f2ked:matrix.org | I'm setting up a secret for `fileserver` https://zuul-ci.org/docs/zuul-jobs/latest/log-roles.html#rolevar-add-fileserver.fileserver but have a port so the `fdqn` is `hostname:<port>` but ansible `known_hosts.py` uses that as `name` and rejects it with `"Host parameter does not match hashed host field in supplied key"` | 23:41 |
| I think it is expecting `[hostname]:<port>` which is what `ssh-keyscan` gives. | ||
| any tips? | ||
| @f2ked:matrix.org | it is a `ssh-ed25519` key | 23:42 |
| @clarkb:matrix.org | You may need to update that role to update the add_host and known_host tasks to accept a port argument | 23:46 |
| @clarkb:matrix.org | add_host takes a port argument and known_hosts uses the brackets | 23:47 |
| @clarkb:matrix.org | So you'd specify fqdn and an optional port then the role needs to sort out how to use that info | 23:47 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!