| @aureliojargas:matrix.org | Exactly, that was my only motivation for that change: one was not like the others. And they all have the same set of functionality (basically copy/paste from each other). | 05:44 |
|---|---|---|
| @aureliojargas:matrix.org | To be honest, now that we have the `ensure-python-command` role consolidating that set of functionality, all the other `ensure-*` roles that use it are kind of pointless, just wrappers. | 05:45 |
| @aureliojargas:matrix.org | * To be honest, now that we have the `ensure-python-command` role consolidating that set of functionality, all the other `ensure-*` roles that use it are kind of pointless, just empty wrappers adding no extra functionality. | 05:47 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 950454: Fix quickstart example/test for Gerrit 3.12 https://review.opendev.org/c/zuul/zuul/+/950454 | 07:30 | |
| @mhuin:matrix.org | hello zuul-maint, this change has two +2's: https://review.opendev.org/c/zuul/zuul/+/938067 anything preventing a W+1 that I should work on? | 08:48 |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 950506: TenantParser, ConfigLoader: add tenant info, layout id in logs https://review.opendev.org/c/zuul/zuul/+/950506 | 09:50 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 950510: Allow enqueing multiple items for different images https://review.opendev.org/c/zuul/zuul/+/950510 | 10:07 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Simon Westphahl: [zuul/zuul] 948782: Fix issue with config override validators https://review.opendev.org/c/zuul/zuul/+/948782 | 10:26 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Simon Westphahl: [zuul/zuul] 949741: Use non-validated images for image validation jobs https://review.opendev.org/c/zuul/zuul/+/949741 | 10:27 | |
| @dfajfer:fsfe.org | hey guys is there any chance someone from nodepool would look at these: | 10:50 |
| https://review.opendev.org/c/zuul/nodepool/+/933545 | ||
| https://review.opendev.org/c/zuul/nodepool/+/933030 | ||
| Running these for some time already, basically cuts 2/3 cost of using Azure | ||
| @dfajfer:fsfe.org | CI passes, I explicitly tested these out in both test and prod environments | 10:52 |
| -@gerrit:opendev.org- Zuul merged on behalf of Felix Edel: [zuul/zuul] 947805: Improve job result colors on status page https://review.opendev.org/c/zuul/zuul/+/947805 | 12:16 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 950506: TenantParser, ConfigLoader: add tenant info, layout id in logs https://review.opendev.org/c/zuul/zuul/+/950506 | 12:49 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 950536: Fix race in OIDC cache init https://review.opendev.org/c/zuul/zuul/+/950536 | 13:24 | |
| @clarkb:matrix.org | fajfer: it looks like those two changes conflict with one another since they both update the same code locations. They should probably be stacked on top of one another. At first glance they seem fine to me, but I'm not sure what level of testing within nodepool is expected for that driver. Also we may need to incorporate those updates into nodepool in zuul. I'll let corvus weigh in on that. | 15:26 |
| -@gerrit:opendev.org- Antoine Musso proposed: [zuul/zuul] 950562: doc: move components graph to a standalone file https://review.opendev.org/c/zuul/zuul/+/950562 | 15:53 | |
| -@gerrit:opendev.org- Antoine Musso proposed wip: [zuul/zuul] 950563: doc: enhance architecture graph https://review.opendev.org/c/zuul/zuul/+/950563 | 15:53 | |
| @joao15130:matrix.org | Hello Zuulers! | 16:18 |
| I'd like to report the status of my pipelines into Grafana dashboard? Is that possible and how? I saw some reference to statsd that can do the trick but how do I enable/configure it. It's unclear to me in the documentation | ||
| @jim:acmegating.com | Clark: fajfer azure is a very well-tested driver, and should definitely have full testing for any changes. | 16:20 |
| @clarkb:matrix.org | ack I'll update my review as that was the primary bit I was unsure about when +2'ing (I noted that tests may be required in that review too) | 16:21 |
| @jim:acmegating.com | Jean Pierre Roquesalane: the available metrics (and a link to configuration) is here: https://zuul-ci.org/docs/zuul/latest/monitoring.html#statsd-reporting | 16:22 |
| @jim:acmegating.com | Jean Pierre Roquesalane: there are no pre-built dashboards in zuul, but you can take a look at opendev's grafana for some ideas | 16:22 |
| @jim:acmegating.com | https://grafana.opendev.org/ | 16:23 |
| @joao15130:matrix.org | thanks @corvus . but how do I retrieve tthe data coming from statsd into grafana. Also I've added the following to zuul.conf but it doesn't show any metrics. | 16:33 |
| [statsd] | ||
| ``` | ||
| server=x.x.x.x | ||
| port=8125 | ||
| ``` | ||
| @joao15130:matrix.org | * thanks @corvus . but how do I retrieve tthe data coming from statsd into grafana. Also I've added the following to zuul.conf but it doesn't show any metrics. | 16:33 |
| ``` | ||
| server=x.x.x.x | ||
| port=8125 | ||
| ``` | ||
| @joao15130:matrix.org | * thanks @corvus . but how do I retrieve tthe data coming from statsd into grafana. Also I've added the following to zuul.conf but it doesn't show any metrics. | 16:33 |
| ``` | ||
| \[statsd\] | ||
| server=x.x.x.x | ||
| port=8125 | ||
| ``` | ||
| @joao15130:matrix.org | * thanks @corvus . but how do I retrieve tthe data coming from statsd into grafana. Also I've added the following to zuul.conf but it doesn't show any metrics. | 16:33 |
| ``` | ||
| [statsd] | ||
| server=x.x.x.x | ||
| port=8125 | ||
| ``` | ||
| @jim:acmegating.com | opendev uses graphite as a storage backend for statsd: https://github.com/statsd/statsd/blob/master/docs/backend.md | 16:54 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 899767: Add runtime graphs to web https://review.opendev.org/c/zuul/zuul/+/899767 | 17:14 | |
| @joao15130:matrix.org | Ok I need to go deeper into Graphite and statsd | 17:53 |
| @joao15130:matrix.org | corvus: Can you just clarify on how to configure and enable statsd in Zuul? | 17:55 |
| @jim:acmegating.com | the config you have should be all that's needed for zuul. once you have statsd set up with graphite, you should be able to query some metrics directly in graphite to check, then configure grafana to use that. | 17:56 |
| @joao15130:matrix.org | Is there a way I can check in the zuul_scheduler container that statsd is running? | 18:03 |
| @clarkb:matrix.org | the scheduler assumes there is a valid statsd reporting target if you configure a statsd endpoint | 18:05 |
| @clarkb:matrix.org | I think statsd is primarily fire and forget udp so even if it isin't running there may not be errors propogated back (I'm not positive of this) | 18:06 |
| @joao15130:matrix.org | OK I tried to export the port 8125 on the container owning zuul_scheduler but can't get anything if I curl this port. | 18:10 |
| @joao15130:matrix.org | * OK I tried to expose the port 8125 on the container owning zuul\_scheduler but can't get anything if I curl this port. | 18:10 |
| @clarkb:matrix.org | Jean Pierre Roquesalane: the statsd location is a target for the scheduler to emit events to. It does not listen on that port | 18:12 |
| @clarkb:matrix.org | you have to run a service like graphite or a prometheus statsd sink at port 8125 that the scheduler will report to | 18:13 |
| @joao15130:matrix.org | thanks for the clarification, it helps a lot | 18:18 |
| @joao15130:matrix.org | It works! Thanks guys | 18:37 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 950536: Fix race in OIDC cache init https://review.opendev.org/c/zuul/zuul/+/950536 | 19:53 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Matthieu Huin https://matrix.to/#/@mhuin:matrix.org: [zuul/zuul] 938067: QueueItem: Assign event id when logging events https://review.opendev.org/c/zuul/zuul/+/938067 | 19:56 | |
| @aureliojargas:matrix.org | Hey guys, I have this optimization change for the `ensure-python-command` role, only installing pip when really necessary (got a +2 from Clark): https://review.opendev.org/c/zuul/zuul-jobs/+/945278 | 20:44 |
| @jim:acmegating.com | do you think that warrants an announcement since it might break existing usage? | 20:58 |
| @fungicide:matrix.org | i left a comment on the change referencing more concrete examples in opendev | 21:04 |
| @fungicide:matrix.org | i'm pretty sure at least some zuul jobs in various opendev projects will also be impacted | 21:04 |
| @fungicide:matrix.org | opendev-hosted projects i mean (hits in actual opendev-maintained projects so seem to all include_role ensure-pip at least) | 21:06 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 21:11 | |
| - [zuul/zuul-client] 950348: Add manage-events admin commands https://review.opendev.org/c/zuul/zuul-client/+/950348 | ||
| - [zuul/zuul] 950346: Add option to pause tenant event processing https://review.opendev.org/c/zuul/zuul/+/950346 | ||
| - [zuul/zuul] 950347: Add zuul-client pause test https://review.opendev.org/c/zuul/zuul/+/950347 | ||
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: | 21:12 | |
| - [zuul/zuul] 950441: Remove completed/inactive specs https://review.opendev.org/c/zuul/zuul/+/950441 | ||
| - [zuul/zuul] 950451: Fix gerrit replication_timeout docs https://review.opendev.org/c/zuul/zuul/+/950451 | ||
| @aureliojargas:matrix.org | How it's done in Zuul in those cases where a fix breaks the flow of people relying in undocumented side effects? | 21:12 |
| @aureliojargas:matrix.org | The improvements is a nice to have, but if it causes too much breakage I guess it's not worth it | 21:13 |
| @fungicide:matrix.org | typically something like a two-week notice to the zuul-announce mailing list to try and make more people aware such a change is coming | 21:13 |
| @jim:acmegating.com | we (and, i mean, probably "you" in this case) can send a message to zuul-announce informing folks of the potential breakage, with a date that we'll merge the change (usually two weeks out) | 21:13 |
| @fungicide:matrix.org | for example, https://lists.zuul-ci.org/archives/list/zuul-announce@lists.zuul-ci.org/thread/FO5URKLKB6UY54IPCV6D6BPG4AAHOQJO/ | 21:14 |
| @jim:acmegating.com | if we think it's a good improvement, that's okay. we don't have to be too afraid of breaking changes. we don't want to break things all the time, but we don't want to be locked into bad patterns. | 21:15 |
| @aureliojargas:matrix.org | I don't follow that list but I can post a message to it, no problem. But it's hard for me to judge if the change is worth the breakage, or how big would it be. We're talking about saving an unneeded `ensure-pip` call, and possibly breaking flows where people call pip directly or indirectly after running some `ensure-*` role, counting that it installed pip, which won't be the case is the desired tool is already installed "somehow". | 21:30 |
| @aureliojargas:matrix.org | Just by writing that it feels like a corner-case, but I don't have data to back that up | 21:35 |
| @fungicide:matrix.org | yeah, looking back over my codesearch results, i'm not even sure that any of them will break. some don't seem to add include-pip in the playbook where ensure_pip_virtualenv_command is referenced, but may be doing it in a separate play earlier in the job | 21:35 |
| @fungicide:matrix.org | er, don't seem to include_role ensure-pip i mean | 21:35 |
| @aureliojargas:matrix.org | yeah, pip may be there already somehow | 21:36 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!