| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed wip: [zuul/zuul] 952727: Replace Ansible 8 with 11 https://review.opendev.org/c/zuul/zuul/+/952727 | 00:05 | |
| @iwienand:matrix.org | i think checks api is supported, but it's a different model where the plugin essentially would have to call back to Zuul to get the run results for the change and display them. as opposed to gerrit being the "database" by just keeping the run data stamped in a comment. obviously the callback has advantages, like being able to show runs in progress. but also, a ton more complexity to achieve that. it certainly was nice that these autogenerated comments got filtered out of the default display; i remember a time when they weren't and i guess we're going back to that ... everything old is new again 🙄 | 00:18 |
|---|---|---|
| @jim:acmegating.com | i'm not aware of any notable recommendations against the zuul results summary plugin. fwiw, opendev (which hosts zuul's own zuul) uses that plugin and don't have any plans to stop using it any time soon. | 00:22 |
| @jim:acmegating.com | * i'm not aware of any notable recommendations against the zuul results summary plugin. fwiw, opendev (which hosts zuul's own zuul) uses that plugin and doesn't have any plans to stop using it any time soon. | 00:23 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed wip: [zuul/zuul] 952727: Replace Ansible 8 with 11 https://review.opendev.org/c/zuul/zuul/+/952727 | 00:41 | |
| @iwienand:matrix.org | what drives me nuts these days is all these chatty bots posting beautifully crafted MD comments and applying 15,000 tags to everything it comes across. the problem is, in isolation, you can see what each comment is getting at, and I suppose there is some value in each. but it's hotel california that they check in but you can never remove them, and it just builds up into cognitive overload that then has no clear solution | 00:47 |
| @iwienand:matrix.org | https://gitlab.com/gitlab-org/gitlab/-/merge_requests/173644 fixed a typo. i'm glad it has 12 different tags to express that | 00:49 |
| @jim:acmegating.com | ianw: maybe you should talk to the customer satisfaction survey bot ;) | 01:02 |
| @paladox:matrix.org | @corvus that plugin should be migrated to lit. It seems it is built with bazel as opposed to a direct js file you just stick in plugins/. My plan is to finally remove polymer from gerrit (i'm migrating the final uses of polymer (external elemenets)). Although i'm not entirely sure if my plan will fully work, but i'm making progress! | 15:10 |
| @paladox:matrix.org | oh whoops, ping didn't work, corvus ^ | 15:10 |
| @jim:acmegating.com | Paladox: thanks, do you have a good example to model after? | 15:14 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 952905: DNM: use base-test to validate log uploads https://review.opendev.org/c/zuul/zuul-jobs/+/952905 | 15:44 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com marked as active: [zuul/zuul] 952727: Replace Ansible 8 with 11 https://review.opendev.org/c/zuul/zuul/+/952727 | 15:44 | |
| @paladox:matrix.org | corvus: something like https://gerrit-review.googlesource.com/c/plugins/zuul-results-summary/+/485281 although it's untested | 15:56 |
| @jim:acmegating.com | oh, amazing! let me see if we can tweak one of opendev's build test jobs to deploy a gerrit with that... | 15:58 |
| @jim:acmegating.com | Paladox: i don't do this very often, so i'm not sure if this will work, but let's see what this does: | 16:03 |
| remote: https://review.opendev.org/c/opendev/system-config/+/952907 DNM: Test "Lit" version of zuul-results-plugin [NEW] | ||
| @paladox:matrix.org | I'm trying to see if i can generate fake data to test it | 16:06 |
| @paladox:matrix.org | It's not appearing to work for me and it's not because it's not enabled (i removed those parts to test), i added a console.log to connectedCallback to test and it's not executing. | 16:09 |
| @paladox:matrix.org | oh i think i may see the issue | 16:11 |
| @paladox:matrix.org | i got the Zuul Summary tab to show but no content is shown and i don't see my console log either | 16:29 |
| @paladox:matrix.org | oh i got it working now corvus | 16:30 |
| @paladox:matrix.org | https://imgur.com/a/FjUobcC | 16:31 |
| @jim:acmegating.com | Paladox: awesome! | 16:31 |
| @paladox:matrix.org | this is with fake data so it's not fully tested. | 16:31 |
| @jim:acmegating.com | it looks like we have, in fact, never built a depends-on with the zuul-results-plugin; we're missing something in order for it to work with the main branch: https://review.opendev.org/c/openstack/project-config/+/952934 Add gerrit project stanzas [NEW] | 16:32 |
| @jim:acmegating.com | so we'll need to merge that before we can try that out in an opendev test build | 16:33 |
| @paladox:matrix.org | i've published the patchset and should work now corvus | 16:36 |
| @jim:acmegating.com | \o/ thanks! | 16:38 |
| @paladox:matrix.org | corvus: your change has been merged | 17:33 |
| @jim:acmegating.com | yep, i rechecked the other one -- it's running now: https://zuul.opendev.org/t/openstack/status?change=952907%2C1&pipeline=check | 17:37 |
| @paladox:matrix.org | nice! | 17:38 |
| @jim:acmegating.com | that should at least tell us if its builds and installs... if we want to check it out interactively, we can run it again and trigger an autohold | 17:38 |
| @paladox:matrix.org | Also for `# TODO: do we need to change anything about this?`. You don't deploy a .js plugin do you? it's java right? | 17:39 |
| @paladox:matrix.org | because if it's the former, you need to deploy the java version that contains the compiled cocde. | 17:39 |
| @paladox:matrix.org | * because if it's the former, you need to deploy the java version that contains the compiled code. | 17:40 |
| @jim:acmegating.com | i mostly needed to change something in a file that would trigger the job, and happened to be looking at that and wondering if anything about it would need to change. but it's looking like "no" | 17:41 |
| @jim:acmegating.com | Paladox: this build succeeded; does this look right to you? https://zuul.opendev.org/t/openstack/build/81c581cd17c9454cb7de98fccd34960e/console | 17:41 |
| @jim:acmegating.com | | Compiling TypeScript project @//plugins/zuul-results-summary/web:zuul-results-summary-ts [tsc -p plugins/zuul-results-summary/web/tsconfig.json]; 1s disk-cache, linux-sandbox ... (3 actions running) | 17:42 |
| Analyzing: 2 targets (761 packages loaded, 27754 targets configured) | ||
| that seems like it build the new version, yeah? | ||
| @paladox:matrix.org | yes it does i think | 17:42 |
| @jim:acmegating.com | * > Compiling TypeScript project @//plugins/zuul-results-summary/web:zuul-results-summary-ts \[tsc -p plugins/zuul-results-summary/web/tsconfig.json\]; 1s disk-cache, linux-sandbox ... (3 actions running) | 17:42 |
| Analyzing: 2 targets (761 packages loaded, 27754 targets configured) | ||
| that seems like it build the new version, yeah? | ||
| @paladox:matrix.org | yeh | 17:42 |
| @jim:acmegating.com | yay! | 17:42 |
| @jim:acmegating.com | the run jobs will go next; they'll run a gerrit server with the images and i think they check that the plugin is installed | 17:47 |
| @jim:acmegating.com | once those look good, i'll trigger the whole thing again with an induced failure to get it to hold the nodes so we can actually interact with the running gerrit | 17:47 |
| @paladox:matrix.org | nice! | 18:17 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 952943: Add node icons to nodeset requests page https://review.opendev.org/c/zuul/zuul/+/952943 | 18:43 | |
| @jim:acmegating.com | Paladox: i did hold a node... but i didn't actually need to. we get screenshots of the zuul summary plugin in the normal test runs | 22:51 |
| @jim:acmegating.com | Paladox: https://99fe0e35c4a879c3b6d5-38c1c93822110964c15749f1b6ae66e8.ssl.cf2.rackcdn.com/openstack/52e63098669849f09dd91271fbaa5e52/bridge99.opendev.org/screenshots/gerrit-change-page-4.png | 22:51 |
| @jim:acmegating.com | that's from this build: https://zuul.opendev.org/t/openstack/build/52e63098669849f09dd91271fbaa5e52/artifacts | 22:51 |
| @jim:acmegating.com | ianw: ^ fyi and kudos :) | 22:59 |
| @iwienand:matrix.org | oh nice! i'm 99.99% sure it integrated with depends-on at one point as I've fixed things with the screenshot before ... i wonder if it hasn't worked since ... 2023 though? https://review.opendev.org/c/openstack/project-config/+/896595 that could be possible? | 23:11 |
| @iwienand:matrix.org | Paladox: thanks for that update!!!! I see you back here in 5 years when we move to the next framework 🤣 | 23:12 |
| @iwienand:matrix.org | * Paladox: thanks for that update!!!! I'll see you back here in 5 years when we move to the next framework 🤣 | 23:13 |
| @jim:acmegating.com | ianw: yeah, if it worked before, i suspect the issue was related to when we started auto-detecting default branches; we do that for projects with project stanzas, but not ones without. we probably should do it for all projects in a tenant, it's just most situations aren't going to see that defect. :) anyway, with https://review.opendev.org/952934 depends-on for that works again, so all good. | 23:21 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
