| -@gerrit:opendev.org- Damian Fajfer proposed: [zuul/zuul] 956167: Update React version to 17.0.0 https://review.opendev.org/c/zuul/zuul/+/956167 | 11:00 | |
| @dfajfer:fsfe.org | oh I just realized that `node_version` that was set as a `project.var` wasn't honored, it says `node_version: 22` but task `ensure-nodejs: Output node version` says it's actually `v14.21.3` | 11:38 |
|---|---|---|
| @dfajfer:fsfe.org | I set it as 22 and it kinda worked but then I started getting race-condition test failures (1 test at a time) from backend so I'm kinda looking at what I did wrong | 11:43 |
| -@gerrit:opendev.org- Damian Fajfer proposed: [zuul/zuul] 956482: Update node_version for nodejs-run jobs https://review.opendev.org/c/zuul/zuul/+/956482 | 14:02 | |
| -@gerrit:opendev.org- Damian Fajfer proposed: [zuul/zuul] 956482: Update node_version for nodejs-run jobs https://review.opendev.org/c/zuul/zuul/+/956482 | 14:03 | |
| @fungicide:matrix.org | fajfer (@dfajfer:fsfe.org): any idea why it's not picking it up from the project var? is there a job var elsewhere that's kicking in and overriding it? maybe defaults are being done wrong for that? | 14:05 |
| @fajfer:reszka.org | from what I've seen it's just role default | 14:06 |
| @fajfer:reszka.org | https://review.opendev.org/c/zuul/zuul-jobs/+/727774 | 14:07 |
| @fajfer:reszka.org | * https://review.opendev.org/c/zuul/zuul-jobs/+/726900 | 14:08 |
| @fajfer:reszka.org | * https://review.opendev.org/c/zuul/zuul-jobs/+/727774 | 14:08 |
| @fajfer:reszka.org | oh, it's actually job-var | 14:08 |
| @fajfer:reszka.org | * oh, it's actually job.var | 14:09 |
| @fajfer:reszka.org | sorry, I got distracted, so I saw this and I don't know if we want to change it so I made another commit with just specific version | 14:10 |
| @fajfer:reszka.org | what would you suggest I do? Is the lack of defaults raised by Monty a concern? | 14:25 |
| @fajfer:reszka.org | or is it ok if we just put it 4 times like I did here | 14:26 |
| @jim:acmegating.com | i think we should fix zuul-jobs so that the configuration in zuul's zuul.yaml works as currently written | 14:28 |
| @jim:acmegating.com | we've stopped putting version defaults in zuul-jobs at all for new things, we may need to remove the old ones | 14:28 |
| @fungicide:matrix.org | i'm not entirely certain myself, which is why i was asking. if memory serves we stopped setting a default because it quickly got stale, bumping it tended to cause regressions for people not expecting it to increase, et cetera, and so we figured the only reasonable solution was to always expect users to specify the version explicitly. it's been a while though since we switched it though, i think, so worth revisiting that decision | 14:28 |
| @fungicide:matrix.org | ah, yeah, what corvus said | 14:29 |
| @fungicide:matrix.org | so sounds like we have a broader policy about that sort of thing these days | 14:29 |
| @jim:acmegating.com | we'll just need a 2 week notice to zuul-announce letting folks know the date we're removing that | 14:30 |
| @fajfer:reszka.org | ok sure, since I've already started poking zuul-web I can work on proposing a change | 14:30 |
| @fajfer:reszka.org | thank you:) | 14:31 |
| @jim:acmegating.com | thank you for finding that and untangling it :) | 14:31 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 956490: DNM: Test ansible version 11 https://review.opendev.org/c/zuul/zuul-jobs/+/956490 | 14:33 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 17:56 | |
| - [zuul/zuul] 956055: Add uploadplanner https://review.opendev.org/c/zuul/zuul/+/956055 | ||
| - [zuul/zuul] 956507: AWS: implement image copy https://review.opendev.org/c/zuul/zuul/+/956507 | ||
| -@gerrit:opendev.org- Szymon Datko proposed: [zuul/zuul] 956230: Implement reject filter in GitLab driver https://review.opendev.org/c/zuul/zuul/+/956230 | 20:46 | |
| -@gerrit:opendev.org- Szymon Datko proposed: [zuul/zuul] 956230: Implement reject filter in GitLab driver https://review.opendev.org/c/zuul/zuul/+/956230 | 21:43 | |
| -@gerrit:opendev.org- Szymon Datko proposed: [zuul/zuul] 956230: Implement reject filter in GitLab driver https://review.opendev.org/c/zuul/zuul/+/956230 | 21:44 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!