| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: | 02:05 | |
| - [zuul/zuul] 956679: Replace zuul.node variable with zuul_node https://review.opendev.org/c/zuul/zuul/+/956679 | ||
| - [zuul/zuul] 956680: Add executor support for snapshots https://review.opendev.org/c/zuul/zuul/+/956680 | ||
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 956681: Implement AWS snapshot import https://review.opendev.org/c/zuul/zuul/+/956681 | 02:06 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: | 02:15 | |
| - [zuul/zuul] 956682: Add snapshot-expiration setting https://review.opendev.org/c/zuul/zuul/+/956682 | ||
| - [zuul/zuul] 958553: Remove model backwards compat https://review.opendev.org/c/zuul/zuul/+/958553 | ||
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 959228: Fix scheduler openstack memory leak https://review.opendev.org/c/zuul/zuul/+/959228 | 06:52 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 950292: Correctly initialize launcher connection filter https://review.opendev.org/c/zuul/zuul/+/950292 | 07:19 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 959319: Fix provider node tag formatting https://review.opendev.org/c/zuul/zuul/+/959319 | 12:47 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 959321: Fix provider selection for image validation https://review.opendev.org/c/zuul/zuul/+/959321 | 13:39 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 959367: Allow dynamic addition of images, labels, and flavors https://review.opendev.org/c/zuul/zuul/+/959367 | 17:42 | |
| @lecris:matrix.org | [@jim:acmegating.com](https://matrix.to/#/@jim:acmegating.com) I have tried the trick you've mentioned about `set_fact` propagating to `post-run` but it did not work. Am I missing something? | 17:59 |
|---|---|---|
| @jim:acmegating.com | Cristian Le: if you'd like a reference, there are a number of roles in the zuul-jobs repo that set cacheable facts; you can grep for `cacheable` | 18:12 |
| @diablo_rojo:matrix.org | Hello folks. I have a professor wondering if Zuul would want some students to work on some things for the school year. The students are largely self sufficient, but might need some kickoff pointers to get the ball rolling. If its not a good fit, no worries, I can have him skip adding Zuul and just stick to OpenStack. | 18:27 |
| @lecris:matrix.org | > <@jim:acmegating.com> Cristian Le: if you'd like a reference, there are a number of roles in the zuul-jobs repo that set cacheable facts; you can grep for `cacheable` | 18:29 |
| Ah, I guess it actually needs to add the `cacheable: true` | ||
| @sean-k-mooney:matrix.org | hum im undecied if i just encouunetered a zuul bug or if its a sideefect of doing someting ill adviced with zuul | 18:57 |
| @sean-k-mooney:matrix.org | the thing that we defintly shoudl not be doign downstream is having 2 zuul tenatn with merge/submit approval on the same repo | 18:58 |
| @sean-k-mooney:matrix.org | because as you can expect if either build set passes the first to pass merges teh change without waiting for the other | 18:58 |
| @sean-k-mooney:matrix.org | taht i qualify as user error nto a zuul bug | 18:59 |
| @sean-k-mooney:matrix.org | the bug is as follows. if i triger a pipeline based on requried lables https://zuul-ci.org/docs/zuul/latest/drivers/gitlab.html#requirements-configuration | 18:59 |
| @sean-k-mooney:matrix.org | in this case in the gitlab driver | 18:59 |
| @sean-k-mooney:matrix.org | if i then remove those lables i woudl not expecced the susess action to happen even if the job passes | 19:00 |
| @sean-k-mooney:matrix.org | require: | 19:00 |
| gitlab.....: | ||
| open: true | ||
| approved: true | ||
| labels: | ||
| - workflow | ||
| @sean-k-mooney:matrix.org | we have that in one of our pipleine | 19:01 |
| @sean-k-mooney:matrix.org | but 1 addign workflow even without adding approved was enough to trigger the job | 19:01 |
| @sean-k-mooney:matrix.org | and second removing appoved and workflow still reuslted int eh patch merging | 19:01 |
| @sean-k-mooney:matrix.org | in gerrit i thik if i remove the workflow lable it will not merge. and it migth abort? not 100% sure about the abort but if i remove +workflow it wont actully merge | 19:02 |
| @sean-k-mooney:matrix.org | this feel like a bug to me but am i mssing something? | 19:03 |
| @sean-k-mooney:matrix.org | https://pb.teim.app/?e650cb54514ba102#E2WyHGacNjq7EkhFBR7DPpvgdKxM763wLZALH1UbinTY is effectivly the gate pipelien config in question - the connection hostname | 19:07 |
| @sean-k-mooney:matrix.org | if i compare this to openstack more battelhardend gate config https://github.com/openstack/project-config/blob/master/zuul.d/pipelines.yaml#L61-L103 obvioulsy the superceed check is diffent, (and wrong in that it does not enforce clean check) but if we focus on how requries and sucess are configred | 19:11 |
| @sean-k-mooney:matrix.org | success: | 19:11 |
| gerrit: | ||
| Verified: 2 | ||
| submit: true | ||
| @sean-k-mooney:matrix.org | i dont realy see much diffent between that and | 19:11 |
| success: | ||
| <gitlab connection>: | ||
| comment: true | ||
| approval: true | ||
| merge: true | ||
| @sean-k-mooney:matrix.org | i guess i was expecting zuul to decue the gate jobs when the lable/workflow was removed form the mr or let them finish but not trigger the sucssses action | 19:15 |
| @sean-k-mooney:matrix.org | which is how i tought the gerrit connection worked and hwo require was intended to funciton | 19:16 |
| @clarkb:matrix.org | sean-k-mooney: I think you're getting confused by gerrit here more than anything else | 19:21 |
| @clarkb:matrix.org | sean-k-mooney: gerrit enforces submit requirements eg verified +2, code review +2 and workflow +1. It does so at the time you try to hit the submit button. This is what prevents merging in the Gerrit case. Zuul still tries to push the button | 19:22 |
| @clarkb:matrix.org | sean-k-mooney: on the zuul side of things triggers either trigger or they don't. Once they are triggered the downstream actions are performed. If one of those actions is "try to merge" then it will attempt to do so | 19:22 |
| @clarkb:matrix.org | if your code review system isn't configured to prevent that then it will liekly succeed | 19:23 |
| @sean-k-mooney:matrix.org | hum ok | 19:23 |
| @sean-k-mooney:matrix.org | so to fix that we need to confire the merge requirement on gitlab | 19:23 |
| @sean-k-mooney:matrix.org | so that gitlab will ignore zuuls attempt to merge | 19:23 |
| @sean-k-mooney:matrix.org | basiclly set up branch protection rules and have gitlab enforce that the right labels are present and approvals right | 19:23 |
| @sean-k-mooney:matrix.org | ok so not a zuul bug then just another issue with our downstream repo config | 19:24 |
| @sean-k-mooney:matrix.org | to be fair to zuul | 19:25 |
| @sean-k-mooney:matrix.org | the docs say that require is the requiremetn to enqueue | 19:26 |
| @sean-k-mooney:matrix.org | so it never claimed to do anything with those values after that point | 19:26 |
| @sean-k-mooney:matrix.org | so ya its the fact that this was enforce by gerrit that i was missing | 19:26 |
| @clarkb:matrix.org | corvus: may have ideas. My initial thought is there are probably improvements that can be made to the zuul-jobs library of CI jobs/roles/etc that may be a good fit. But I'm not sure how compelling that is to students either. Its also possible that Zuul just isn't in a good position to support such a thing with the size of the team etc. | 19:38 |
| -@gerrit:opendev.org- Nicolas Hicher https://matrix.to/#/@nhicher:matrix.org proposed: [zuul/zuul-jobs] 959393: Refactor: multi-node-bridge to use linux bridge https://review.opendev.org/c/zuul/zuul-jobs/+/959393 | 21:36 | |
| @jangutter:matrix.org | Cristian Le: before I forget, also make sure you're running it on the _same hosts_ in both plays. On our side I did a check and successfully persisted a variable from one pre playbook into a run playbook (did not check any post, but I'm reasonably sure it would work). I got tripped up when I forgot that `localhost` is not in `all` | 21:42 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 959397: WIP: Don't apply provider defaults upwards https://review.opendev.org/c/zuul/zuul/+/959397 | 22:37 | |
| -@gerrit:opendev.org- Nicolas Hicher https://matrix.to/#/@nhicher:matrix.org proposed: [zuul/zuul-jobs] 959393: Refactor: multi-node-bridge to use linux bridge https://review.opendev.org/c/zuul/zuul-jobs/+/959393 | 23:23 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!