13:00:35 #startmeeting barbican 13:00:35 Meeting started Tue Jun 15 13:00:35 2021 UTC and is due to finish in 60 minutes. The chair is redrobot. Information about MeetBot at http://wiki.debian.org/MeetBot. 13:00:35 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 13:00:35 The meeting name has been set to 'barbican' 13:00:42 #topic Roll Call 13:00:51 Courtesy ping for ade_lee dave-mccowan hrybacki jamespage Luzi lxkong mhen moguimar raildo rm_work tosky xek nearyo oleksandry 13:01:02 o/ 13:01:09 Hi rosmaita 13:01:23 hello 13:01:23 As usual the agenda can be found here: 13:01:31 #link https://etherpad.opendev.org/p/barbican-weekly-meeting 13:02:32 o/ 13:03:10 redrobot: https://review.opendev.org/c/openstack/barbican/+/796284 has finally passed zuul, if you could look when you have time, it's blocking some of the cinder gates 13:03:29 took 3 rechecks, but looks like that was due to mirroring problems for dependencies where the jobs landed 13:03:38 #topic Barbican Gates 13:03:49 Thanks for working ont hat patch rosmaita. 13:04:02 that was all Gorka, i am just following up 13:04:07 gotcha 13:04:19 Yeah, I'm not sure how so much SQLAlchemy broke all at once 13:04:36 well, the "major" projects got advance notice a few months ago 13:04:47 heh 13:04:54 i left a comment on the patch that more projects should be notified, but it got lost 13:05:12 anyway, 1.4 intentionally introduced some backward incompatibilities 13:05:16 to prepare for 2.0 13:05:33 I'll take a look at the patch right after this meeting and try to catch ade_lee for a second review when he comes online 13:05:39 cool, ty 13:06:06 i have one more "none of my business, but" comment (or i can wait for open discussion later) 13:06:17 shoot 13:06:43 i noticed that there's a place in the barbican code where you have deleted=1 in a sqlalchemy query 13:06:52 'deleted' is boolean in the model, though 13:07:08 i believe it's not a problem for mysql/mariadb 13:07:21 but might be worth using boolean to be consistent 13:07:32 (since db use is kind of important for barbican) 13:07:40 Ah yeah, that's a good catch 13:07:54 hi 13:08:04 hi tosky 13:08:05 we got burned once by that in glance when someone was using postgresql 13:08:08 I see the main topic I was going to raise has been taken care of already 13:08:14 :) 13:08:17 (i.e. broken gates for everyone!) 13:08:39 😅😅😅 13:08:52 I'm hoping we can get everything back online in the next couple of hours 13:09:51 i wonder whether we should propose that the cinder-tempest-plugin tests be run in the requirements gate -- currently it's just unit tests for select projects 13:10:00 that way barbican would get a workout 13:10:33 i was going to propose that barbican unit tests should be added, but that wouldn't have caught this event 13:11:02 anyway, something to think about ... i will be happy to help push this if you think it's a good idea 13:11:15 More testing is always good IMO 13:11:53 and actually, i am wrong about the barbican UTs not catching a problem, so maybe those would be sufficient 13:12:23 let's propose a patch and see what the requirements folks have to say abou tit 13:13:56 sounds good 13:14:15 OK, moving on ... 13:14:20 #topic Liaison Updates 13:14:26 tosky anything else you want to talk about? 13:17:40 nothing else (usual stuff about grenade still pending) 13:18:34 cool, thanks tosky 13:18:40 #topic Kanban Review 13:18:50 #link https://tree.taiga.io/project/dmend-openstack-barbican/kanban 13:19:23 I have a WIP patch to fix the unicode error when using the Vault backend: https://review.opendev.org/c/openstack/barbican/+/796065 13:20:08 the patch works for a new deployment, but I still need to add the logic to handle inconsistent encodings for existing deployments 13:21:21 #topic Bug Review 13:21:34 #link https://storyboard.openstack.org/#!/project_group/barbican 13:22:09 We have one new bug for the db migration that was broken by sqlachemy https://storyboard.openstack.org/#!/story/2008967 13:22:37 #link https://bugs.launchpad.net/castellan/+bugs?orderby=-id&start=0 13:22:43 No new Castellan bugs 13:22:54 #link https://bugs.launchpad.net/cursive/+bugs?orderby=-id&start=0 13:23:00 And no new Cusrvie bugs 13:23:22 #topic Wayward Reviews 13:23:52 usually me and moguimar would look at reviews now, but he won't be around very much anymore :( 13:24:13 That said, if anyone here is interested in being a core reviewer let me know and we can work on a plan to get you there. ;) 13:24:33 #topic Open Discussion 13:24:41 Anything else y'all want to talk about? 13:28:12 redrobot: will you propose a patch to add barbican UTs to the requirements check? 13:28:30 rosmaita yeah, I can do that 13:28:44 #action redrobot to propose patch for requirements check to include barbican unit tests 13:28:47 cool, ping me in #openstack-cinder and I will leave a comment on it 13:29:11 i will talk offline with tosky about the advisibility of proposing cinder-tempest-plugin jobs for requirements 13:29:34 if we put up a patch, i will ping you 13:29:42 ack, sounds good 13:29:49 excellent, thank you 13:32:00 Thanks for joining, everyone! 13:32:03 #endmeeting