09:00:01 <priteau> #startmeeting blazar
09:00:02 <openstack> Meeting started Tue Dec 11 09:00:01 2018 UTC and is due to finish in 60 minutes.  The chair is priteau. Information about MeetBot at http://wiki.debian.org/MeetBot.
09:00:03 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
09:00:05 <openstack> The meeting name has been set to 'blazar'
09:00:07 <tetsuro> o/
09:00:59 <priteau> #topic Roll call
09:01:04 <priteau> Hello tetsuro
09:01:08 <tetsuro> Hi
09:02:04 <priteau> Is masahito going to join?
09:02:56 <tetsuro> No idea. Let me ping to him in our NTT internal chat.
09:03:44 <bertys> o/
09:03:51 <priteau> Hi bertys
09:05:05 <priteau> We're waiting for masahito
09:07:53 <priteau> Today we're supposed to do code review
09:08:08 <priteau> Anyone has comments on the floating IP reservations spec? https://review.openstack.org/#/c/609302/
09:08:26 <priteau> I am very happy to see this new approach that Masahito learned at the summit
09:09:41 <masahito> hi. sorry late.
09:10:01 <priteau> Hello masahito
09:10:42 <priteau> We can start!
09:10:45 <priteau> #topic Code review
09:11:27 <priteau> I was asking comments about the floating IP reservation spec: https://review.openstack.org/#/c/609302/
09:11:53 <priteau> I reviewed the diff against patch set #4, the new approach sounds great to me
09:12:06 <priteau> I added a small comment about what we store in the DB
09:13:11 <masahito> One network can have multi subnets. That's why I added column in the floating ip table.
09:14:30 <masahito> So I'm wondering whether the floating IP APIs and floating ip resource_type should have subnet_id or not.
09:16:14 <priteau> Do we need it for allocation / deallocation later?
09:18:26 <priteau> I also see `subnet_id` is not in any of the API queries and requests, does it need to be included?
09:20:20 <tetsuro> masa says he's disconnected due to the network
09:20:40 <tetsuro> he's at Kubernetes summit
09:21:34 <priteau> Oh, I didn't realize he was on travel this week too
09:21:46 <priteau> He's a busy guy :-)
09:22:21 <masahito> sorry, disconnected.
09:22:41 <priteau> masahito: If network is not good we can continue discussion on Gerrit. I think the new approach is very good and we're just discussing implementation details now.
09:22:58 <masahito> priteau: thanks.
09:23:42 <priteau> I also took a quick look to your resource allocation series but some patches are not passing tests, looks like they still need to be updated?
09:24:22 <priteau> We lost him again :(
09:24:26 <masahito> I try to create a PoC in this year and push the patch to the gerrit.
09:24:33 <priteau> Sounds great
09:24:43 <priteau> Not sure if you saw my other message
09:24:44 <priteau> I also took a quick look to your resource allocation series but some patches are not passing tests, looks like they still need to be updated?
09:25:41 <masahito> I'm seeing the meeting logs.
09:27:16 <masahito> looks like so. I'll update it again.
09:27:27 <priteau> Thank you
09:29:30 <priteau> We have one open patch from tetsuro, I left a comment on it: https://review.openstack.org/#/c/584744/
09:30:57 <priteau> tetsuro: What are your thoughts on the issue?
09:31:16 <tetsuro> Looking, will have a comment back or have a new PS.
09:31:31 <priteau> Thank you
09:32:58 <priteau> masahito: I know you have an issue with this small patch on python-blazarclient, but would be OK with merging it so we can clear the pending patch queue? https://review.openstack.org/#/c/591971/
09:35:48 <priteau> Easy +2s: https://review.openstack.org/#/c/621859 https://review.openstack.org/#/c/621849/
09:36:09 <priteau> https://review.openstack.org/#/c/621925/1
09:36:20 <tetsuro> About https://review.openstack.org/#/c/584744/, this seems to be my mistake, will submit another PS soon.
09:36:32 <priteau> https://review.openstack.org/#/c/622566/1
09:36:52 <priteau> https://review.openstack.org/#/c/622556/
09:37:12 <priteau> Those are all openstack-dev -> openstack-discuss patches, please approve so we can get them out of the way
09:37:22 <priteau> Thanks tetsuro, I am looking forward to your next patch
09:38:40 <priteau> It would be good to review https://review.openstack.org/#/c/621488/ as well. Asmita has been contributing to Blazar, she need to encourage it!
09:44:44 <masahito> I've reviewed the ML change pathces.
09:45:46 <priteau> Thanks masahito
09:45:50 <bertys> priteau: regarding 621488, I will check as I remember having some discussion with OSA team few months ago
09:47:30 <priteau> OK, thanks bertys
09:48:08 <priteau> I think we've reviewed most of the open patches that are passing Zuul checks
09:51:28 <priteau> Anything else to discuss?
09:52:58 <priteau> masahito: I didn't realize you were on travel and just saw that you are in Seattle! It's very late for you, you should go!
09:54:11 <priteau> I think we can end the meeting early for this week. Thanks for joining!
09:54:14 <masahito> I completely forgot telling you all I'm in travel. Never mind, I'm in jet lag :-)
09:55:51 <priteau> Enjoy the conference!
09:57:03 <priteau> That's all for today folks, let's continue on Gerrit.
09:57:04 <priteau> #endmeeting