09:00:07 <priteau> #startmeeting blazar
09:00:08 <openstack> Meeting started Tue Jun  4 09:00:07 2019 UTC and is due to finish in 60 minutes.  The chair is priteau. Information about MeetBot at http://wiki.debian.org/MeetBot.
09:00:09 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
09:00:11 <openstack> The meeting name has been set to 'blazar'
09:00:44 <priteau> #topic Roll call
09:03:13 <priteau> Good morning bertys
09:03:16 <bertys> o/
09:03:23 <bertys> Hi all
09:03:53 <priteau> We're waiting for tetsuro and masahito
09:04:04 <tetsuro> o/
09:04:07 <priteau> Hi tetsuro
09:04:39 <tetsuro> Thank you for the mention
09:04:51 <priteau> Do you know if masahito is planning to join today?
09:05:04 <tetsuro> I don't know...
09:05:20 <tetsuro> Let me see if he's on internal chat
09:08:22 <tetsuro> No, he does not respond.
09:08:37 <priteau> Thanks for trying
09:08:41 <priteau> Let's start then
09:08:46 <priteau> #topic Code review priorities
09:09:40 <priteau> I'd like to highlight patches that require attention from the team
09:09:58 <priteau> Folks from NTT Data have submitted several interesting patches
09:10:31 <priteau> Some of these patches have been up for a while, but didn't get much attention due to focus on other areas for the Stein release.
09:10:42 <priteau> Hi asmita, we were just discussing your patches :-)
09:10:52 <asmita> Hi
09:11:11 <asmita> Thank you so much for your review.
09:11:40 <priteau> In particular I would like to get more reviews of these two: https://review.opendev.org/#/c/637140/ and https://review.opendev.org/#/c/655837/
09:13:13 <priteau> asmita: Sorry it took so long. I think they're good patches, just need a bit of improvement
09:13:30 <priteau> Did you try adding microversion support to python-blazarclient already?
09:14:49 <asmita> Thanks Pierre. I will work on your review comments. Not yet,  haven't worked on adding microversion support in client.
09:15:41 <priteau> OK. I will try to test it with curl soon.
09:17:16 <tetsuro> Will have a look on the branch this week. Sorry to keep you waiting, asmita, but thank you very much
09:18:40 <priteau> asmita: Do you know if Neha Alhat will be able to revisit their request_id patch?
09:18:59 <asmita> Yes , we can add "OpenStack-API-Version:reservation 1.0" in headers of curl..
09:19:20 <asmita> request_id patch will be addressed by me
09:19:32 <priteau> Great, thanks!
09:19:48 <asmita> Fixing the review comments of request _id patch is in progress
09:20:17 <priteau> Sorry for taking so long to review this patch. It wasn't a priority for Stein so I focused on other patches first.
09:20:17 <asmita> Tetsuro san, Thank you so much.
09:21:06 <asmita> Better late than never, Pierre:)
09:21:20 <masahito_> hi. sorry late
09:21:34 <priteau> Hi masahito_
09:21:46 <asmita> Hi masahito san
09:23:13 <masahito_> hi priteau, asmita
09:23:15 <priteau> masahito_: We're discussing patches that should be reviewed as a priority. I highlighted the patches from NTT Data with topic bug/1740091
09:23:19 <priteau> https://review.opendev.org/#/q/status:open+project:openstack/blazar+topic:bug/1740091
09:24:40 <priteau> It would be good to get your input, as you know well the API layer.
09:25:13 <masahito_> okay
09:25:31 <masahito_> I'll check it.
09:26:11 <priteau> Are there other patches that you want to highlight for review?
09:29:00 <priteau> This one is an easy +2:  https://review.opendev.org/#/c/662777/
09:29:11 <priteau> Sorry, wrong link
09:29:14 <priteau> https://review.opendev.org/#/c/628469/
09:30:46 <priteau> masahito_: Is https://review.opendev.org/#/c/606875/ something we should add with a microversion?
09:32:15 <masahito_> Yes, if blazar supports microversion.
09:32:38 <priteau> That's what asmita implemented ;-)
09:32:45 <masahito_> The asmita's patches support the microvesion from V1?
09:33:16 <asmita> Yes  V1
09:33:49 <masahito_> I didn't read the previous discussion yet. One of my concern is should blazar support microversion from V1? or should start from V3?
09:34:48 <priteau> I think it's fine to add it to v1. If you don't provide the microversion header, you would get the regular v1 API
09:36:00 <masahito_> okay, just for clarification. Is the regular v1 API latest microversion? or oldest version?
09:36:34 <priteau> oldest version
09:37:04 <priteau> see e.g. https://review.opendev.org/#/c/655838/1/blazar/api/v1/api_version_request.py
09:38:09 <masahito_> got it. LGTM :-)
09:38:51 <priteau> My understanding is that it is modelled after Nova's microversions
09:39:21 <asmita> yes exactly.
09:40:03 <asmita> Nova and Cinder have microversion support
09:41:24 <priteau> asmita: If you have some time to implement the client support, it would be good to see how it all works together.
09:41:53 <asmita> Sure thing Pierre.
09:42:08 <priteau> Thank you
09:42:51 <asmita> I would like some suggestions regarding patch https://review.opendev.org/#/c/625783.
09:43:15 <asmita> any suggestion will help.
09:44:43 <priteau> I think masahito_ has a relevant comment here, specifically about the help message
09:44:57 <priteau> I would also say "reduce" is not the right term
09:45:31 <priteau> Why not use "defer" like for the lease start/end time?
09:46:26 <asmita> Right.
09:47:28 <priteau> I added it to Gerrit
09:47:43 <priteau> Any other patches that we should be focusing on?
09:48:49 <tetsuro> https://review.opendev.org/#/c/661680/ can go if no objection is made
09:49:11 <priteau> Good point, do we have a +2 from masahito_ or bertys?
09:50:32 <masahito_> masahito_ is reading it
09:54:01 <priteau> We're almost out of time. Let's continue discussion on Gerrit.
09:54:06 <priteau> #topic AOB
09:54:17 <priteau> Anything else to discuss today?
09:55:04 <asmita> For this patch: https://review.opendev.org/#/c/625783, masahito san is suggesting that: The 2 options should be a relative value from the previous before_end_date, but before_end_date is not in response of lease get api. so in that patch Neha Alhat has calculated from start date and end date.
09:55:23 <masahito_> LGTM for the validation spec
09:56:11 <asmita> If we have to calculate it from previous before_end_date then we can return before_end_date in lease response under particular microversion. Kindly suggest.
09:57:21 <priteau> asmita: I'll have to take a look at the API again. Let's discuss on Gerrit.
09:57:49 <asmita> Sure thing. Thanks.
09:58:12 <shilpasd> priteau, Tetsuro, masahito_: thank you for spec review
09:59:25 <priteau> Thanks all for the good discussion today
09:59:34 <priteau> Talk to you next week and until then on Gerrit
09:59:38 <priteau> #endmeeting