15:00:06 <priteau> #startmeeting blazar
15:00:06 <opendevmeet> Meeting started Thu Aug 22 15:00:06 2024 UTC and is due to finish in 60 minutes.  The chair is priteau. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:06 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:06 <opendevmeet> The meeting name has been set to 'blazar'
15:00:09 <priteau> #topic Roll call
15:00:56 <markpowers> o/
15:01:05 <mattcrees> o/
15:02:51 <priteau> Hello both
15:02:55 <priteau> Let's start
15:03:02 <priteau> #topic Dalmatian release
15:04:03 <priteau> Feature freeze is next week :o
15:04:38 <priteau> The main priority is to review the flavor plugin implementation: https://review.opendev.org/q/topic:%22flavor_plugin%22
15:04:57 <mattcrees> That's crept up quickly
15:04:59 <priteau> I have updated several patches from John Garbutt
15:05:04 <priteau> And gave +2 to them
15:05:13 <priteau> However I still need to work on the main plugin code patch
15:05:40 <priteau> I was off last week and playing catch up at the beginning of the current one, I haven't resumed work on this yet
15:06:48 <mattcrees> I'll prioritise reviewing the patches you've updated already
15:06:56 <priteau> Thanks
15:07:15 <markpowers> I can take a look now as well, I was also out
15:07:56 <priteau> Thanks markpowers, that would be helpful
15:08:09 <mattcrees> I've also got the affinity patch in good shape, I reckon we could get this into Dalmatian too: https://review.opendev.org/c/openstack/blazar/+/923413
15:08:17 <priteau> I would like to ship something in this release, even if the implementation has some shortcomings
15:08:36 <priteau> And we can finalise the code in Epoxy
15:09:10 <mattcrees> Sounds like a good plan.
15:09:11 <priteau> mattcrees: I am planning to look at your code soon
15:09:23 <priteau> Do you know if it will require changes if flavor-plugin merges?
15:10:19 <mattcrees> It shouldn't break flavor reservations, the only changes are to instance ones. But it would be good to follow-up with changing the flavor plugin affinity behaviour to match
15:12:07 <priteau> The flavor plugin reuses some functions from the instance one
15:13:02 <priteau> There even this code around server_group_id: https://review.opendev.org/c/openstack/blazar/+/917995/11/blazar/plugins/instances/instance_plugin.py
15:13:18 <mattcrees> Oh right
15:13:48 <priteau> Can you check if either patch needs some changes?
15:13:53 <mattcrees> Sure
15:15:40 <priteau> This client patch needs to be finalised first, as this is releasing next week: https://review.opendev.org/c/openstack/python-blazarclient/+/920689
15:16:31 <priteau> What do you think of the naming that John used for the resource type? We had physical:host, virtual:instance, virtual:floatingip and now flavor:instance
15:16:47 <priteau> They are not really consistent with each other
15:17:17 <priteau> But I don't really have a good alternative to propose without changing the existing ones
15:18:53 <priteau> If I would do it over again I would probably drop these physical/virtual prefixes
15:19:09 <mattcrees> Yeah I don't feel that those help really.
15:19:34 <mattcrees> I guess virtual:flavor would be more consistent? Doesn't feel great though
15:20:33 <priteau> We're not reserving a flavor though
15:21:04 <priteau> We are still reserving an instance (or instances), just based on a flavor instead of specific amounts of resources
15:21:48 <priteau> Originally we wanted to extend the existing instance plugin to support this feature
15:22:00 <priteau> John opted to use a separate plugin to ease development
15:22:27 <priteau> Maybe we can keep this feature as "preview-only" and in the future merge the two plugins
15:22:51 <mattcrees> That would be good. There's a lot of repeated code right now
15:23:06 <priteau> This way you could use virtual:instance, but with a flavor_id argument instead of vcpus/memory_mb/disk_gb
15:23:58 <mattcrees> Sounds ideal. I suppose for now we can keep flavor:instance as the name, I'm not thinking of any better options
15:24:19 <priteau> Yes. It wouldn't hurt much to keep the flavor:instance support in blazarclient for a while, it's just a couple of lines.
15:24:57 <priteau> Are you both OK with releasing this as "preview" for the Dalmatian release, so we can feel free to make breaking changes in E?
15:27:19 <mattcrees> Yes I'm fine with that. Will need to make sure there's a warning in any docs :)
15:28:23 <priteau> I don't think we have any docs patch yet. Would you have time to propose one?
15:29:14 <mattcrees> Sure I'll get some up
15:30:38 <priteau> Specifically this: https://docs.openstack.org/blazar/latest/cli/index.html
15:30:54 <mattcrees> Yep, that's the one I had in mind
15:31:06 <priteau> Let's call this feature "Flavor-based Instance Reservation"
15:31:12 <priteau> I think this is the most accurate description
15:32:07 <priteau> markpowers: Is there anything from Chameleon that you really wanted to ship in this release? Sorry, I didn't manage to spend any time on Anish's patch
15:32:30 <mattcrees> Sounds good
15:32:56 <markpowers> There is not, we are quite busy with other stuff at the moment, but I should be able to have time to look over the flavor plugin changes
15:35:50 <priteau> Thanks
15:35:59 <priteau> #topic AOB
15:36:13 <priteau> Anything else to discuss apart from Dalmatian priorities?
15:36:14 <mattcrees> On the affinity patch: John hasn't added any support for affinity so there's no behaviour to fix here. There shouldn't be a merge conflict either in the instance plugin
15:36:37 <priteau> Great
15:37:45 <mattcrees> I've got nothing else to discuss right now
15:39:36 <priteau> Our next meeting is in two weeks after the Dalmatian-3 milestone, so if you need to reach me before, please use email.
15:39:49 <priteau> I also idle here but don't always have IRC open
15:40:46 <markpowers> nothing else from me
15:41:51 <priteau> Thanks both for joining today
15:41:55 <priteau> Talk to you soon
15:41:57 <priteau> #endmeeting