16:00:39 <jungleboyj> #startmeeting Cinder
16:00:40 <openstack> Meeting started Wed Feb 13 16:00:39 2019 UTC and is due to finish in 60 minutes.  The chair is jungleboyj. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:41 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:43 <openstack> The meeting name has been set to 'cinder'
16:00:50 <whoami-rajat> Hi
16:00:55 <yikun> hello
16:00:58 <jungleboyj> courtesty ping jungleboyj diablo_rojo, diablo_rojo_phon, rajinir tbarron xyang xyang1 e0ne gouthamr thingee erlon tpsilva ganso patrickeast tommylikehu eharney geguileo smcginnis lhx_ lhx__ aspiers jgriffith moshele hwalsh felipemonteiro lpetrut lseki _alastor_ whoami-rajat yikun rosmaita enriquetaso hemna _hemna
16:01:07 <rosmaita> o/
16:01:17 <eharney> hi
16:01:17 <rajinir> o/
16:01:36 <enriquetaso> o/
16:01:40 <smcginnis> o/
16:01:45 <xyang> hi
16:02:03 <ganso> hi
16:02:06 <erlon> hola!
16:02:13 <jungleboyj> @!
16:02:14 <carlos_silva> hi
16:02:14 <_pewp_> jungleboyj ＼( ･_･)
16:02:42 <lseki> hello
16:03:04 <e0ne_> hi
16:03:19 <jungleboyj> Nice.  Have a good number of people showing up.
16:03:58 <jungleboyj> Ok.  Lets get started then.
16:04:12 <jungleboyj> #topic announcements
16:04:35 <jungleboyj> We had a great mid-cycle last week.
16:05:01 <jungleboyj> It was a small team on site and had some good remote participation.
16:05:22 <jungleboyj> Thank you to all who participated.
16:05:32 <jungleboyj> #link https://etherpad.openstack.org/p/cinder-stein-mid-cycle-planning
16:05:42 <jungleboyj> Notes from the event are available above.
16:05:58 <jungleboyj> I will work on doing the usual summary out in our Wiki for future reference.
16:06:40 <jungleboyj> If you are a vendor, please take some time to look through the notes as there were topics that will impact all of you in there.
16:07:43 <jungleboyj> And from the past to the future.
16:08:02 <jungleboyj> Our participation at Denver PTG has been confirmed.
16:08:24 <enriquetaso> \o/
16:08:39 <jungleboyj> I hope that we will have a good group there again.
16:08:45 <jungleboyj> How many are hoping to be there?
16:08:49 <smcginnis> I'll be there.
16:09:12 <jungleboyj> :-)
16:09:17 <rosmaita> me too
16:09:25 <e0ne_> I hope, I'll be there
16:09:25 <jungleboyj> rosmaita: Awesome.
16:09:40 <enriquetaso> I'll be there too
16:09:43 <jungleboyj> e0ne_:  Good.  That will be good.  Appreciate all your efforts to make the mid-cycle remotely.
16:09:57 <jungleboyj> enriquetaso:  Awesome.  Will be good to meet you.
16:10:08 <e0ne_> jungleboyj: thanks for organizing it!
16:10:24 <jungleboyj> e0ne_:  Welcome.  I am glad it went smoother than the last one I organized.  ;-)
16:10:31 <smcginnis> hah
16:11:04 <jungleboyj> Though smcginnis initially scared me trying to get on the wifi.  Thankfully it was PEBKAC
16:11:33 <smcginnis> Or poor user interface design. :P
16:11:45 <jungleboyj> Anyway, hope to see many of you in Denver.  Please try to plan for it.
16:11:51 <jungleboyj> smcginnis:  It made sense to me.  ;-)
16:12:16 <jungleboyj> Ok, that was all I had for announcements.
16:12:33 <jungleboyj> #topic Change in multi-attach test enablement may cause 3rd Party CIs to fail
16:12:46 <jungleboyj> #link http://lists.openstack.org/pipermail/openstack-discuss/2019-February/002536.html
16:13:10 <jungleboyj> mriedem: Sent this out to the mailing list and mentioned it on our IRC channel.  Just wanted to make one last note of it.
16:13:33 <jungleboyj> If you own a CI, please make sure that it is not failing due to the changes in the multi-attach tests.
16:13:59 <jungleboyj> I haven't had a chance to go through and audit who all is hit by this.  Will be trying to do that soon though.
16:14:20 <jungleboyj> So, please take time to make sure you are not impacted.
16:15:17 <jungleboyj> Also, a general note that we are going to be going through and taking a look at CIs and how they are running in the last part of Stein here.  So, be aware.  :-)
16:15:46 <jungleboyj> #topic Planning for Train Mid-Cycle
16:15:59 <jungleboyj> #link https://etherpad.openstack.org/p/cinder-train-mid-cycle-planning
16:16:30 <jungleboyj> So, we decided at the mid-cycle to just start planning the next one.  It was productive as the previous ones had been.
16:16:30 <smcginnis> For those that were not able to participate in this last one - I found it very productive and we were able to make a lot of decisions and work through things.
16:16:46 <jungleboyj> We are hoping that if we start planning early people will be more likely to be able to attend.
16:16:46 <smcginnis> Hopefully this is enough time to make an argument to your management to be able to be a part of the next one.
16:16:52 <smcginnis> The more people we have involved, the better.
16:16:56 <jungleboyj> smcginnis:  ++
16:17:27 <jungleboyj> We have proposed a number of dates in the etherpad.  If you are available for the dates and would like to come, please indicate your availability.
16:17:47 <jungleboyj> You don't have to have approval, just want to try to schedule it when the most people are likely to be available.
16:18:37 <jungleboyj> Lenovo is willing to host again as it worked quite well, but if others are interested in hosting, that is ok as well.
16:18:57 <jungleboyj> Don't need all the details now but would like to do some initial planning.
16:20:02 * e0ne_ wants mid-cycle/ptg in Europe
16:20:17 <jungleboyj> e0ne_:  Want to host?  :-)
16:20:37 <e0ne_> :)
16:20:58 <jungleboyj> We also talked about when in the week it was scheduled.  It sounds like some people would prefer to have it at the beginning or end of the week, rather than the middle.
16:21:09 <jungleboyj> We are open to changing things there.
16:22:10 <jungleboyj> e0ne_ did us being on the east coast of the USA time wize at least make things a little better?
16:22:45 <e0ne_> jungleboyj: absolutely
16:22:52 <jungleboyj> Ok.  Good.
16:22:59 <jungleboyj> smcginnis: or rosmaita Anything to add there?
16:23:46 <smcginnis> Nope
16:23:57 <e0ne_> jungleboyj: I'm going read mid-cycle this week, maybe I'll add few comments
16:24:46 <jungleboyj> e0ne_:  Great.  Thank you!
16:25:08 <jungleboyj> Ok.  So, that was all I had on the agenda for today.
16:25:16 <jungleboyj> #topic Open Discussion
16:25:18 <rosmaita> just thanks to Lenovo for great hosting
16:25:46 <jungleboyj> rosmaita:  Welcome.  I am really glad it worked so well.
16:25:49 <smcginnis> Yes, thanks!
16:26:02 <smcginnis> jungleboyj: Hope you got some good work time out there too.
16:26:04 <jungleboyj> whoami-rajat:  How was the remote connection?
16:26:12 <jungleboyj> Were you able to follow pretty well?
16:26:26 <whoami-rajat> jungleboyj: Yes. it was great. Thanks for hosting.
16:26:47 <jungleboyj> Good.  I feel like we are getting better at the remote hosting.
16:26:55 <smcginnis> Thanks everyone that attended remotely. I know sometimes that can be difficult.
16:26:58 <enriquetaso> +1
16:26:58 <jungleboyj> Though next time it would be good to try Zoom or something.
16:27:24 <jungleboyj> I was thankful we had that PolyCom phone.  I think that worked well.
16:27:33 <jungleboyj> enriquetaso: You were able to follow too?
16:27:37 <e0ne_> sound quality was good this time
16:27:44 <whoami-rajat> jungleboyj: the sound was better than the last PTG.
16:27:53 <jungleboyj> Ok.  Cool.
16:27:53 <enriquetaso> jungleboyj, yup
16:28:01 <jungleboyj> That is great.
16:28:28 <jungleboyj> Room was better and we had a PolyCom that works as just a speaker/mic.
16:29:22 <jungleboyj> Anyway, anything else that people want to discuss today?
16:29:30 <whoami-rajat> if i'm not interrupting the open discussion, i would appreciate feedback on this patch https://review.openstack.org/#/c/627359/ .
16:29:46 <jungleboyj> whoami-rajat:  That is what OpenDiscussion is for.  :-)
16:30:11 <whoami-rajat> jungleboyj: Thanks :)
16:30:43 <jungleboyj> whoami-rajat:  I think eharney needs to see your response there.
16:30:51 <eharney> yeah we were just chatting on #openstack-cinder
16:31:00 <whoami-rajat> jungleboyj: we had a continuation on the channel.
16:31:03 <eharney> it seems this may be exposing a bug around how we handle shell parameters already
16:31:29 <jungleboyj> Ok.
16:31:38 <eharney> i'm not convinced it's reasonable to have the client throw away arguments like "--all-tenants 0" when they are explicitly requested by the user
16:31:52 <eharney> which is what this patch hinges on, but also what we apparently already do
16:32:14 <smcginnis> --all-tenants 0 means not all tenants, right?
16:32:33 <eharney> yes, but if you request --all-tenants 0 as non-admin, the server rejects the request
16:32:41 <smcginnis> Isn't that the default? So wouldn't it be safe to ignore that?
16:33:14 <eharney> the server should be the one ignoring it -- if we code the client to make that decision, and then do something later in the server like add a policy flag to control this behavior... the client will no longer do the right thing
16:33:20 <whoami-rajat> eharney: also the rejection isn't handled properly (against admin non-admin)
16:34:04 <eharney> or, nobody can ignore it and we can just fail when the caller isn't admin, which is also reasonable
16:34:27 <eharney> the messy part comes in with the current patch where the client decides "this arg probably isn't allowed by the server so i'll just throw it away even though the user requested it"
16:35:21 <whoami-rajat> it's not only in regard of all-tenant but all boolean parameters that are passed as 0 are rejected. https://github.com/openstack/python-cinderclient/blob/master/cinderclient/base.py#L143-L145
16:36:23 <jungleboyj> Hmmm, that seems bad.
16:36:57 <smcginnis> I would think as long as it passes when the argument is 1, then that should cover policy changes. But if 0 is the default and passing 0 sometimes would cause errors, then it's probably safer to drop it.
16:37:23 <eharney> the fix for the immediate bug here should just be to not pass all-tenants by default
16:38:27 <eharney> also, why does this problem appear for non-admin on group-list and not other list calls?
16:39:29 <whoami-rajat> eharney: because the reject_invalid_filters function is only added in groups group_snapshots and messages.
16:40:27 <eharney> hmm
16:40:54 <eharney> so volume list thinks all_tenants=0 is valid for non-admins and group-list doesn't
16:41:10 <whoami-rajat> https://github.com/openstack/cinder/blob/master/cinder/api/v3/groups.py#L160-L161
16:41:51 <whoami-rajat> eharney: looking at the code seems to have this behaviour.
16:42:01 <eharney> it kind of sounds like we should establish a consistent policy around this on the server before worrying about fixing client usability issues around it
16:42:24 <smcginnis> Yeah, looks like we can improve things on the server side.
16:42:37 <smcginnis> We can probably continue this outside the meeting.
16:43:06 <jungleboyj> Sounds good.
16:44:01 <jungleboyj> Any other discussion required today?
16:44:20 <whoami-rajat> eharney:  IMO atleast we can have this fixed on the client side as other resources as bugs are being reported for the same.
16:45:27 <jungleboyj> So, doesn't appear that we have other topics for today.
16:46:01 <jungleboyj> Should we wrap up the meeting and whoami-rajat and eharney can take this to the Cinder channel/
16:46:12 <rosmaita> jungleboyj: need you to look at https://review.openstack.org/#/c/636425/ to approve cinderclient release 3.1.1
16:46:16 <whoami-rajat> jungleboyj: sure
16:47:01 <jungleboyj> rosmaita:  Thanks for updating that.  Looks good.
16:47:06 <rosmaita> np
16:47:33 <jungleboyj> Ok.  I think we are good for today then.
16:47:42 <jungleboyj> Thanks everyone for attending.
16:47:55 <smcginnis> Thanks!
16:47:56 <jungleboyj> #endmeeting