16:00:23 <jungleboyj> #startmeeting Cinder
16:00:23 <openstack> Meeting started Wed Sep 25 16:00:23 2019 UTC and is due to finish in 60 minutes.  The chair is jungleboyj. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:24 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:26 <openstack> The meeting name has been set to 'cinder'
16:00:39 <davidsha> o/
16:00:42 <lseki> o/
16:00:45 <rosmaita> o/
16:00:56 <jungleboyj> courtesy ping:  jungleboyj whoami-rajat rajinir lseki carloss pots woojay erlon geguileo eharney rosmaita enriquetaso e0ne smcginnis davidsha walshh_ xyang hemna _hemna tosky sfernand
16:01:00 <jungleboyj> @!
16:01:01 <_pewp_> jungleboyj ヾ(-_-;)
16:01:08 <whoami-rajat> Hi
16:01:15 <walshh_> Hi
16:01:18 <jungleboyj> Oh pewp bot.  I guess you know how my week is going.
16:01:32 <woojay> o/
16:01:59 <e0ne> hi
16:02:14 <rosmaita> e0ne: you have been a reviewing maniac, thank you
16:02:32 <jungleboyj> e0ne:  ++
16:03:11 <jungleboyj> Though the mental image of e0ne being a maniac is a little scary.
16:04:02 <jungleboyj> Ok.  It looks like we have the usual crowd here.
16:04:18 <jungleboyj> #topic announcements
16:04:32 <jungleboyj> Not a lot to say other than the fact that we are at RC week for Train.
16:04:49 <jungleboyj> #link https://etherpad.openstack.org/p/cinder-train-RC-time
16:05:10 <rosmaita> there's nothing unreviewed on there, just things that need another review
16:05:12 <jungleboyj> Oooh, look at the PTL to be being organized!
16:05:19 * jungleboyj is happy
16:05:27 <rosmaita> :D
16:05:39 <rosmaita> hopefully the stuff in the gate will merge OK
16:05:53 <rosmaita> there's a small problem with the default types patch, i think
16:05:57 <jungleboyj> I will take a look through all of these after the meeting.
16:06:03 <rosmaita> cool
16:06:19 <rosmaita> the release note needs a revision, but that patch is so big, i don't want to request a change
16:06:28 <jungleboyj> rosmaita:  I see you comments.
16:06:33 <rosmaita> so i think it would be good to merge it and then do a followup
16:06:38 <jungleboyj> @whoami-rajat  Any concerns with the plan there?
16:06:55 <rosmaita> but it will have to be quick because once the stable branch is created, the release notes behave weirdly
16:07:28 <rosmaita> my proposal would be to propose the RC-1 release tomorrow afternoon?
16:07:37 <davee__> o/
16:07:40 <whoami-rajat> rosmaita: jungleboyj that sounds good, thanks, i've been trying to get zuul+1 since past few days and if the update is releasenotes related, i would be glad to do it in a followup
16:07:42 <rosmaita> which is a day later than usual for cinder, but i think it is still within legal time
16:07:53 <e0ne> rosmaita, jungleboyj: thanks. I'm doing my best to make cinder better
16:08:02 <jungleboyj> whoami-rajat:  Ok.  Cool.  Lets do that instead of complicating things.
16:08:13 <rosmaita> e0ne: ++
16:09:00 <rosmaita> whoami-rajat: that would be great
16:09:28 <rosmaita> i will put more notes on your current patch about what i think is needed
16:09:33 <jungleboyj> Are there any bug fixes that are not on Brian's list?
16:09:45 <whoami-rajat> jungleboyj: rosmaita thanks, also i would like to ask when is cinderlib release planned?
16:10:00 <e0ne> jungleboyj, rosmaita, smcginnis: fyi, https://review.opendev.org/#/c/684050/
16:10:02 <rosmaita> i didn't look at the unmerged changes, i just pulled the FFEs and bugs i knew about
16:10:36 <rosmaita> whoami-rajat: cinderlib is a cycle-trailing release, so probably within a month after actual Train release
16:11:04 <rosmaita> it can wait longer, but i think gorka will want to release as soon as it makes sense
16:11:19 <jungleboyj> e0ne:  Thank you.  I just put a hold on that.
16:11:38 <rosmaita> yes, thanks!
16:11:46 <whoami-rajat> rosmaita: great, i've a dependent patch of the same feature in cinderlib so i think it will be in on time.
16:11:50 <walshh_> I have a few driver rev
16:12:09 <walshh_> I have a few driver reviews not on the list above
16:12:12 <jungleboyj> walshh_:  I looked at the one this morning you sent.  Can you add yours to the list in the etherpad?
16:12:27 <jungleboyj> That way everyone can take a look.
16:12:38 <jungleboyj> Not just me.  :-)
16:12:39 <walshh_> thank you.  Just a few more, all have clean CI now, minor fixes
16:12:51 <jungleboyj> Okie Dokie.
16:12:58 <jungleboyj> Bug fixes are good.
16:13:07 <jungleboyj> Must mean people are actually using your driver?  :-)
16:14:15 <e0ne> :)
16:14:21 <walshh_> one or two :-)
16:14:37 <jungleboyj> That is a good thing.
16:14:51 <jungleboyj> Ok, if you can add your reviews in the etherpad that would be great and we will review.
16:15:01 <walshh_> I will, thank you
16:15:11 <jungleboyj> Otherwise testing of the RC would be good if anyone is able to do that.
16:15:18 <rosmaita> ok, i am in prague time zone this week, so let's say to be in RC-1, stuff must be merged by 22:00 UTC tomorrow (26 Sept)
16:15:32 <rosmaita> i will also commit to looking at walshh_'s patches
16:15:50 * jungleboyj would like to go to Prague some time.
16:16:01 <hemna> any pressing reviews?
16:16:14 <jungleboyj> hemna: https://etherpad.openstack.org/p/cinder-train-RC-time
16:16:15 <e0ne> jungleboyj: +1
16:16:20 <jungleboyj> Where you been man?  ;-)
16:16:27 <hemna> this job thing....
16:16:29 <jungleboyj> hemna: ^^
16:16:37 <jungleboyj> hemna: Yeah, I feel your pain.
16:16:40 <hemna> kinda gets in the way of cinder sometimes
16:17:10 <jungleboyj> rosmaita:  Anything else on RC discussion?
16:17:24 <rosmaita> i don't mean to be a jerk, but i think we need someone to commit to reviewing the default types patch
16:17:30 <rosmaita> (it's a bit of a monster)
16:17:41 <rosmaita> code looks pretty clean, just a lot of files are touched
16:17:44 <hemna> heh
16:17:51 <hemna> yah that's a big one the last time I looked
16:17:56 <jungleboyj> rosmaita:  I have been through it before.
16:18:07 <jungleboyj> So, not sure that I am going to have additional input.
16:18:26 <rosmaita> i don't think it has changed too much since your last comments
16:18:31 <hemna> so this is a new feature
16:18:47 <hemna> are we ok with merging this at this stage of the game?
16:18:53 <rosmaita> yes, it got a FFE last week
16:18:59 <hemna> what could go wrong?
16:19:01 <hemna> :P
16:19:37 <davee__> It could provide an excuse to drink lots of caffeine
16:19:37 <rosmaita> well, if people have set CONF.default_type already, i don' think there will be any problems
16:19:39 <whoami-rajat> hemna: it's adding a volume type with db migration, migrating all existing untyped volumes/snapshots to the default type, that's it :)
16:20:14 <jungleboyj> :-)  What could possibly go wrong.  :-)
16:20:28 <hemna> well if we are going to merge it, it's best to merge early
16:20:31 <hemna> and test it
16:20:37 <hemna> we can always back it out...
16:20:39 <whoami-rajat> rosmaita: that's the aim :)
16:20:43 <hemna> theoretically
16:20:46 <jungleboyj> hemna:  Agreed.
16:21:43 <rosmaita> or, more positively, we can backport a minor bugfix :)
16:21:52 <jungleboyj> rosmaita:  Agreed.
16:21:54 <hemna> ok I'll take a look today
16:22:02 <jungleboyj> hemna:  Thank you.
16:22:08 <rosmaita> hemna: ty!
16:22:13 <jungleboyj> Is there anyone planning to test it?
16:22:21 <whoami-rajat> hemna: thank you!
16:22:35 <rosmaita> i won't have time until after RC to really test it out
16:22:53 <hemna> so we need to create a bunch of vols/snaps w/o a type
16:23:15 <hemna> I presume there is a migration script that has to be run to migrate those ?
16:24:15 <whoami-rajat> hemna: the type migration of existing vols/snaps is done with online migration
16:24:42 <whoami-rajat> https://review.opendev.org/#/c/639180/41/cinder/db/sqlalchemy/api.py
16:25:55 <jungleboyj> whoami-rajat:  Is there a way to do it without having to install Stein and try to upgrade?
16:26:44 <jungleboyj> To test it?
16:27:02 <whoami-rajat> jungleboyj: we can run the db migrations (cinder-manage db sync) and online migrations (cinder-manage db online_data_migrations)
16:27:39 <jungleboyj> Ok.  Cool and then it should deal with the untyped volumes?
16:28:25 <whoami-rajat> jungleboyj: untyped volumes and snapshots and if any new volume is created without any provided type will be assigned `__DEFAULT__`
16:28:40 <jungleboyj> whoami-rajat:  Cool.
16:29:27 <jungleboyj> Will try to test but not promising I will get to it right away.
16:30:01 <rosmaita> whoami-rajat: you aren't going on vacation during the next 2 weeks, are you?
16:30:11 <jungleboyj> rosmaita:  :-)  Good question.
16:30:14 <hemna> ok so most of the filed changed in that patchset are unit tests
16:30:21 <hemna> te rest looks ok I guess
16:30:27 <whoami-rajat> jungleboyj:  thanks for the help :)
16:30:42 <jungleboyj> Yep.
16:31:03 <whoami-rajat> rosmaita: no
16:31:19 <rosmaita> ok, great
16:31:20 <jungleboyj> Ok.  That is good.
16:31:38 <rosmaita> hemna: before you arrived, we agreed to do the release note changes in a follow up patch
16:31:51 <rosmaita> the gate has been really slow, don't want to hold up the main patch
16:31:59 <hemna> ugh ok
16:32:36 <hemna> ok, it's on it's way
16:33:18 <whoami-rajat> jungleboyj: rosmaita hemna thanks for the reviews!
16:33:32 <jungleboyj> hemna:  Thanks.
16:33:52 <jungleboyj> whoami-rajat:  Let me know when you have the updates for the release note done.
16:34:01 <rosmaita> whoami-rajat: what jungleboyj said
16:34:50 <whoami-rajat> jungleboyj: rosmaita sure, will do it quickly after the meeting
16:35:03 <rosmaita> thanks, please add it to the etherpad when you post it
16:35:19 <jungleboyj> Sounds good!
16:35:27 <whoami-rajat> rosmaita: ok
16:35:34 <whoami-rajat> will do
16:35:41 <jungleboyj> Added notes to the patch on what we have discussed today for documentation purposes.
16:36:10 <jungleboyj> So, anything else we need to discuss?
16:36:36 <rosmaita> nothing from me
16:36:52 <jungleboyj> A friendly reminder to add topics to the etherpad for the Stein PTG:  https://etherpad.openstack.org/p/cinder-shanghai-ptg-planning
16:36:55 <whoami-rajat> jungleboyj: i think there is one thing to discuss
16:37:08 <jungleboyj> whoami-rajat:  Ok.  Go ahead.
16:37:21 <whoami-rajat> it's regarding the tempest schema validation
16:37:29 <jungleboyj> Oh yeah.
16:37:33 <whoami-rajat> it seems to be breaking cinder in stable branches
16:37:43 <rosmaita> well, that is because they aren't testing first
16:37:43 <whoami-rajat> https://145b0d5be77f0cbe05ff-d67a6226f6eb6d34ab4efd951744a16f.ssl.cf5.rackcdn.com/684658/1/check/tempest-full/9e1de42/testr_results.html.gz
16:37:56 <rosmaita> it happened in O and now it's happening in P.
16:38:03 <rosmaita> guess it will happen in Q next week
16:38:09 <whoami-rajat> i checked the cinder stable/pike code and seems fine
16:38:32 <whoami-rajat> rosmaita: hah :)
16:38:34 <rosmaita> yes, my vote is we ignore it, matt has a patch up to pin tempest
16:38:51 <rosmaita> hopefully they will pin Q also before anything breaks
16:40:38 <rosmaita> #link http://lists.openstack.org/pipermail/openstack-discuss/2019-September/009674.html
16:40:51 <rosmaita> just realized that people may not know what i am talking about
16:41:46 <whoami-rajat> the question is, is the schema validation really necessary for stable branches ? a lot of code is added removed until the introduction of MV's so IMO it will be valid to do the testing after v3
16:42:25 <whoami-rajat> rosmaita: i should've started with the thread link, thanks
16:42:36 <jungleboyj> rosmaita:  We had asked why they were doing this right?
16:42:41 <jungleboyj> I don't remember the answer though.
16:42:53 <rosmaita> well, i thought eharney had a well-reasoned discussion going on this last time
16:42:59 <rosmaita> but it wasn't really followed up on
16:43:42 <rosmaita> so, in my capacity of being a general PITA, i am inclined to not worry about this and let the qa team keep breaking the stable branches and then having to pin tempest to fix it
16:44:06 <rosmaita> but it is distressing that they are merging stuff without checking to see what they will break
16:44:11 <whoami-rajat> there are different reasons for failures, last one was because of not doing an MV bump/ testing a dynamic response in tempest
16:44:11 <rosmaita> and with that, i will shut up
16:44:43 <whoami-rajat> rosmaita: seems valid
16:45:19 <jungleboyj> rosmaita:  ++
16:47:23 <jungleboyj> So, any further discussion required there?
16:47:40 <whoami-rajat> not from my side
16:48:18 <jungleboyj> Ok cool.
16:48:48 <jungleboyj> For those who didn't see, they have announced that the next event after Shanghai will be a PTG like event in Vancouver.
16:48:51 * jungleboyj is happy!
16:49:14 <jungleboyj> Then a summit like event later next year.  Location still not determined.
16:49:38 <e0ne> jungleboyj: sounds good
16:50:01 <jungleboyj> :-)
16:50:26 <jungleboyj> Also, if you know anyone that might be new to OpenStack and in Shanghai please let them know about OpenStack Upstream Institute.
16:50:32 <jungleboyj> Would like to see more interest there.
16:51:32 <whoami-rajat> jungleboyj:  ++
16:52:31 <jungleboyj> Ok.  That is all I had for this week then.  Please go review the outstanding train patches.
16:54:01 <whoami-rajat> jungleboyj: Thanks!
16:54:56 <jungleboyj> Yep.  Thanks everyone.
16:55:03 <jungleboyj> #endmeeting