14:00:00 <rosmaita> #startmeeting cinder
14:00:01 <openstack> Meeting started Wed Mar 11 14:00:00 2020 UTC and is due to finish in 60 minutes.  The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:02 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:04 <openstack> The meeting name has been set to 'cinder'
14:00:10 <rosmaita> #topic roll call
14:00:21 <whoami-rajat> Hi
14:00:46 <LiangFang> o/
14:00:51 <jungleboyj> I am traveling today so I won't really be tuned in.
14:01:02 <sfernand> hi
14:01:08 <enriquetaso> o/
14:01:10 <rosmaita> jungleboyj: ok, thanks for the notice
14:01:13 <kaisers> o/
14:01:15 <eharney> hi
14:01:27 <tosky> o/
14:01:50 <rosmaita> looks like a good turnout
14:02:03 <rosmaita> #link https://etherpad.openstack.org/p/cinder-ussuri-meetings
14:02:28 <lseki> o/
14:02:37 <rosmaita> #topic announcements
14:03:04 <rosmaita> ok, first one is virtual midcycle coming up on monday
14:03:15 <rosmaita> Monday 16 March, 1200-1400 UTC
14:03:24 <rosmaita> #link https://etherpad.openstack.org/p/cinder-ussuri-mid-cycle-planning
14:03:24 <e0ne> hi
14:03:32 <smcginnis> o/
14:03:37 <rosmaita> there's still time to add topics
14:03:47 <rosmaita> meeting will be in bluejeans video conf system
14:03:52 <rosmaita> link is on the etherpad
14:04:06 <rosmaita> looking forward to seeing everyone there
14:04:12 <rosmaita> will be a nice way to start the week
14:04:25 <rosmaita> ok, some less nice news
14:04:48 <rosmaita> the foundation has set up a page to track openstack/opendev events and the coronavirus impact
14:04:58 <rosmaita> #link https://www.openstack.org/events/covid-19-coronavirus-disease-updates
14:05:14 <rosmaita> it was last updated on 2 march
14:05:33 <rosmaita> as of now, the vancouver PTG and berlin summit are still ON
14:06:04 <rosmaita> there was some more info in the email announcing the webpage:
14:06:14 <rosmaita> #link http://lists.openstack.org/pipermail/foundation/2020-March/002852.html
14:07:10 <rosmaita> worst case, we can hold a virtual ptg
14:07:18 <rosmaita> so please keep those dates open
14:07:43 <rosmaita> although i guess if the vancouver ptg gets cancelled, the world will be in such a state that no one will be going anywhere
14:08:05 <rosmaita> ok, some good news
14:08:22 <rosmaita> ussuri community goals are completed for Cinder and all its deliverables!
14:08:32 <rosmaita> thanks to everyone who reviewed and did stuff
14:08:48 <rosmaita> tosky was especially helpful with the remove py2 changes
14:09:14 <rosmaita> finally, i want to give an update on the devstack-plugins situation
14:09:26 <rosmaita> cinder-core now in both devstack-plugin-ceph-core and devstack-plugin-nfs-core
14:09:44 <eharney> excellent
14:09:49 <rosmaita> you may have seen on the ML that manila-core is also going to be in the ceph plugin
14:10:00 <rosmaita> so it should be easy to get things done
14:10:10 <e0ne> great!
14:10:22 <rosmaita> also, moving the nfs plugin to 'openstack' namespace (out of 'x') has been approved
14:10:34 <whoami-rajat> is -core in the name somewhere? i couldn't find it
14:10:36 <rosmaita> it can't happen until a gerrit maintenance window, though
14:10:53 <whoami-rajat> okay, it's the core list i think
14:11:09 <rosmaita> whoami-rajat: right
14:11:25 <rosmaita> what we did was add cinder-core to the plugin core team
14:11:34 <rosmaita> that way, updates happen automatically
14:11:59 <rosmaita> i did leave eharney in the devstack-plugin-nfs-core group though
14:12:14 <rosmaita> just thought there should be at least one real person in addition to the groups
14:12:30 <rosmaita> (only because i'm vague on how the gerrit group permissions work)
14:13:07 <rosmaita> that's all the announcements unless anyone has a comment?
14:14:02 <rosmaita> oh, i should mention that i added that openstack coronavirus page to our "spotlight links" at the top of the agenda etherpad
14:14:15 <rosmaita> so  you'll be able to find it easily
14:14:23 <rosmaita> ok, on to the topics
14:14:36 <rosmaita> #topic request for consultation on an os-brick patch
14:15:04 <rosmaita> this is on behalf of josephine who's irc nick i'm forgetting at the moment
14:15:18 <rosmaita> #link https://review.opendev.org/#/c/709432/
14:15:45 <rosmaita> it's marked WIP, but she's requesting reviews because she's not a regular cinder contributor and could use the feedback
14:16:05 <rosmaita> this is about adding code for the on-the-fly encryption effort
14:16:13 <rosmaita> they're adding code to os-brick
14:16:28 <rosmaita> as was agreed on for the spec
14:16:48 <rosmaita> so, anyone interested in that, or in os-brick stability in general, please take a look
14:17:12 <rosmaita> #topic make cinder-plugin-ceph-tempest job voting?
14:17:36 <rosmaita> eric pointed out that the ceph job has been pretty stable for a long time now
14:17:47 <rosmaita> #link http://zuul.openstack.org/builds?job_name=cinder-plugin-ceph-tempest
14:17:58 <e0ne> +1 to make this job voting (again)
14:18:30 <eharney> yeah, this used to be voting, i think it would be good to do that again if we can
14:18:37 <rosmaita> i meant to pull more data from logstash, but i forgot
14:18:52 <rosmaita> but the runs on the link above look good
14:19:21 <rosmaita> let's do a vote (mainly since i've never done one)
14:20:01 <rosmaita> #startvote should the cinder-plugin-ceph-tempest job be voting (again)?
14:20:02 <openstack> Begin voting on: should the cinder-plugin-ceph-tempest job be voting (again)? Valid vote options are Yes, No.
14:20:03 <openstack> Vote using '#vote OPTION'. Only your last vote counts.
14:20:05 <jungleboyj> +1 for voting.
14:20:18 <rosmaita> #vote Yes
14:20:23 <jungleboyj> #vote yes
14:20:28 <e0ne> #vote yes
14:20:41 <eharney> #vote Yes
14:20:49 <whoami-rajat> #vote Yes
14:21:33 <smcginnis> #vote Yes
14:22:33 <rosmaita> anyone else? will close the voting in 45 seconds
14:22:35 <geguileo> #vote Yes
14:23:38 <rosmaita> ok. looks like that's everyone who wanted to vote
14:23:41 <rosmaita> #endvote
14:23:42 <openstack> Voted on "should the cinder-plugin-ceph-tempest job be voting (again)?" Results are
14:24:16 <rosmaita> i think the bot crashed trying to do the computation
14:24:18 <smcginnis> Hah, first vote and it looks like the bot's broken.
14:24:38 <rosmaita> ok, i will scroll back manually
14:24:38 <smcginnis> I think that ones pretty easy to do a recount. ;)
14:24:44 <e0ne> :)
14:25:01 <rosmaita> i get yes: 7, no: 0
14:25:28 <rosmaita> #action rosmaita put up a patch to restore ceph job as voting
14:25:45 <rosmaita> ok, that was easy
14:26:00 <rosmaita> #topic New repo: devstack-plugin-open-cas
14:26:16 <rosmaita> LiangFang: that's you
14:26:41 <LiangFang> hi rosmaita, I have created the repo, and added cinder-core and devstack-core as core group
14:26:51 <rosmaita> great!
14:27:05 <LiangFang> https://review.opendev.org/#/c/711878/
14:27:30 <LiangFang> Now Andreas want QA PTL and Cinder PTL to review and give +1
14:27:53 <rosmaita> looks like gmann already +1'd it, i'll do it right after the meeting
14:28:01 <LiangFang> thanks
14:28:10 <LiangFang> https://review.opendev.org/#/c/711902/ is depends on this review
14:28:42 <LiangFang> this is to add this repo as an official OpenStack repo
14:29:11 <rosmaita> ok, i'll put a note on that as well
14:29:25 <LiangFang> Andreas requires this repo to be an official repo
14:29:30 <LiangFang> thanks rosmaita
14:29:49 <rosmaita> eharney: you've had some experience with this kind of thing from the nfs plugin
14:29:51 <rosmaita> my question is
14:30:08 <rosmaita> should we add LiangFang as a core on the plugin repo
14:30:42 <eharney> yes, that makes sense
14:31:08 <rosmaita> ok, once those patches are merged, i think i'll be able to add you manually LiangFang
14:31:16 <rosmaita> don't let the power go to your head :D
14:31:23 <LiangFang> I don't know how to add my Name:)
14:31:41 <rosmaita> i think once the group is created, it can be done directly in gerrit
14:31:52 <LiangFang> I need google to translate this:)
14:32:43 <rosmaita> thanks for keeping this moving, it will be nice to have this plugin to test the caching code
14:33:00 <LiangFang> thanks rosmaita
14:33:25 <rosmaita> OK, that's all of the agenda topics
14:33:30 <rosmaita> #topic open discussion
14:34:21 <e0ne> just a follow-up from the previous meeting: https://review.opendev.org/712301 - Backup Backends Configuration
14:34:43 <e0ne> I've got nothing to discuss here, just a friendly ask for feedback
14:34:52 <rosmaita> great!
14:35:36 <e0ne> I didn't finish the code yet, still working on it
14:36:10 <e0ne> I'm going to publish a patch asap even if it'll be merged in Victory only
14:36:27 <e0ne> that's all update from me on this topic
14:37:25 <whoami-rajat> as i was going through my open commits i found 2 commits that would finish a bp, i would appreciate reviews on those
14:37:26 <whoami-rajat> https://review.opendev.org/#/c/685046/
14:37:33 <whoami-rajat> https://review.opendev.org/#/c/685652/
14:38:12 <rosmaita> wow, those have been sitting for a while
14:38:26 <whoami-rajat> yep, so long i also forgot about them :P
14:39:00 <rosmaita> gerrit is showing them as not needing a rebase, too!
14:39:21 <whoami-rajat> these add functional tests for api-ref samples and also generate api-ref responses automatically
14:39:34 <rosmaita> i'll try to get to those today, would be good to get that project finished
14:39:49 <whoami-rajat> rosmaita, thanks, that would be great!
14:39:52 <rosmaita> feel free to bug me if you don't see any reviews by friday morning
14:40:34 <whoami-rajat> rosmaita, sure :D
14:43:05 <rosmaita> i have a question if no one else wants to talk
14:44:28 <rosmaita> what's our policy on drivers having a revision history?
14:44:43 <rosmaita> https://wiki.openstack.org/wiki/Cinder/how-to-contribute-a-driver
14:44:54 <rosmaita> i was looking at that but didn't see anything
14:45:12 <eharney> some drivers do it but it's totally optional
14:45:35 <rosmaita> ok, so it would be ok to keep it in a separate text file if they didn't want to clutter up the code?
14:45:59 <rosmaita> (because i think it's a good idea to have it)
14:46:28 <eharney> i'm not sure it would ever be read if it was in a separate text file
14:46:53 <eharney> is the target mostly for cinder maintainers or deployers?
14:47:03 <rosmaita> probably not, but it would make me feel better knowing it was there!
14:47:16 <rosmaita> that's a good question, i'm not sure
14:48:11 <eharney> i would argue that git history is sufficient for most needs in this area, but i'm not sure about others
14:48:16 <rosmaita> probably deployers, i'd think they'd want to know what version they're using and what's changed in case they find a bug
14:48:20 <e0ne> eharney: +1
14:49:17 <rosmaita> i guess i might as well be specific
14:49:23 <rosmaita> take a look at this:
14:49:31 <rosmaita> https://review.opendev.org/#/c/704153/13/cinder/volume/drivers/datera/datera_iscsi.py
14:49:54 <smcginnis> We want to have it for documentation purposes here: https://docs.openstack.org/cinder/latest/drivers.html
14:50:16 <smcginnis> I don't feel strongly about it, but that was the argument for pushing for it.
14:50:59 <smcginnis> The main thing is the VERSION number I think, so debugging can make sure everyone is looking at the same version of the code if deployed without git history available.
14:51:02 <rosmaita> smcginnis: i missed that, so that gets pulled directly from the code
14:51:07 <smcginnis> Yep
14:51:39 <smcginnis> Not really liking all the config options pulled into there now, but I know hemna really wanted that.
14:52:12 <jungleboyj> We should give better guidance on versioning but also, it is their driver.
14:52:23 <jungleboyj> I feel like we have had this discussion before though.
14:52:23 <hemna> I like having the history in the code
14:52:34 <rosmaita> ok, in that case i think it makes sense for them to just dump https://github.com/Datera/cinder-driver/blob/master/VERSION_HISTORY in there (except it's so long!)
14:52:39 <jungleboyj> hemna: ++
14:52:46 <hemna> otherwise when I'm debugging a driver, I'd have to hunt that history down elsewhere.
14:53:15 <eharney> maybe we should leave the history in the code but do it in a format that can autogenerate some doc files if desired?
14:53:32 <smcginnis> Isn't that kind of what we have?
14:53:45 <eharney> maybe
14:53:53 <hemna> what's the issue?
14:54:05 <hemna> the history looks ok in the drivers.html output ?
14:54:23 <rosmaita> this one has a pretty long history: https://docs.openstack.org/cinder/latest/drivers.html#hpe3parfcdriver
14:55:14 <rosmaita> hemna: i think the issue is just that it takes up a lot of space in the docstring and you have scroll way down to get to the business part
14:57:12 <rosmaita> alright, thanks for the feedback
14:58:59 <rosmaita> anything else?
14:59:13 <rosmaita> don't forget: virtual midcycle on monday!
14:59:18 <jungleboyj> Hope everyone is staying safe and healthy!
14:59:44 <whoami-rajat> Thanks!
15:00:00 <rosmaita> #endmeeting