14:00:39 <rosmaita> #startmeeting cinder
14:00:40 <openstack> Meeting started Wed Jan  6 14:00:39 2021 UTC and is due to finish in 60 minutes.  The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:42 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:44 <openstack> The meeting name has been set to 'cinder'
14:00:48 <rosmaita> #topic roll call
14:00:49 <jungleboyj> o/
14:00:50 <whoami-rajat__> Hi
14:00:54 <walshh_> Hi
14:00:56 <sfernand> hi
14:01:02 <michael-mcaleer> hi
14:01:08 <enriquetaso> hi
14:01:32 <eharney> hi
14:01:44 <rosmaita> i was late with the reminder this morning, so we can wait another minute
14:03:44 <rosmaita> ok, let's go
14:03:50 <rosmaita> #topic announcements
14:04:05 <rosmaita> #link https://etherpad.opendev.org/p/cinder-wallaby-meetings
14:04:16 <rosmaita> i am a bit disorganized in 2021
14:04:33 <rosmaita> ok, this is week Release-minus-14
14:04:51 <rosmaita> next week: cinderlib release
14:05:00 <rosmaita> whoami-rajat__ has a patch up for it
14:05:11 <rosmaita> #link https://review.opendev.org/c/openstack/releases/+/768766
14:05:24 <rosmaita> but i'm waiting to see whether we should include requirements changes first
14:05:44 <rosmaita> gorka will be back on Monday, so we'll figure it out then
14:06:13 <rosmaita> R-12 (2 weeks) is Wallaby-2 Milestone .. new driver merge deadline
14:06:29 <rosmaita> so obviously the priority in the next 2 weeks is new driver reviews
14:06:42 <rosmaita> so let's take a look at what's being tracked by blueprints
14:06:52 <rosmaita> #link https://blueprints.launchpad.net/cinder/wallaby
14:07:29 <rosmaita> i don't know how to make launchpad sort via url, so click on the "Milestone" heading in the table
14:08:05 <rosmaita> the two BPs with no milestone ... not sure what LiangFang is up to, i will follow up
14:08:22 <rosmaita> the support-different-policy is going to be turned into a bug, so don't worry about that one either
14:09:24 <rosmaita> also, abishop noticed yesterday that he had an approved spec for wallaby but the BP was not showing up in this list
14:09:50 <rosmaita> so if you have an approved wallaby spec, please check the list and let me know if it's missing here
14:10:01 <rosmaita> ok, the drivers
14:10:36 <rosmaita> i just noticed that the ceph iscsi driver isn't listed here
14:10:46 <rosmaita> i'll make sure something is added
14:11:08 <rosmaita> so as far as i know, we have:
14:11:12 <enriquetaso> i think my spec is missed
14:11:17 <rosmaita> 1 - ceph iscsi
14:11:26 <enriquetaso> the sizing volumes when retype
14:11:26 <rosmaita> 2 - kumoscale
14:11:46 <whoami-rajat__> i don't see my spec BP in the list, https://blueprints.launchpad.net/cinder/+spec/add-support-store-volume-format-info
14:11:50 <rosmaita> 3 - dell/emc me driver
14:11:57 <enriquetaso> sorry, i'll ask again after the meeting
14:12:07 <rosmaita> np, i'll take a note
14:12:29 <rosmaita> meaning, enriquetaso and whoami-rajat__ i will look for your BPs after the meeting
14:12:39 <whoami-rajat__> thanks rosmaita
14:12:46 <rosmaita> am i correct that these are the only new drivers (the 3 mentioned above?)
14:13:11 <rosmaita> (jovian dss is already implemented)
14:14:09 <rosmaita> OK, so the review priority the next 2 weeks are drivers
14:14:26 <rosmaita> remember, you don't need to be a core to review these
14:14:42 <rosmaita> in fact, it is very helpful for maintainers of other drivers to review these new drivers
14:14:55 <jungleboyj> ++
14:15:43 <rosmaita> but all cores need to make reviewing these soon a priority
14:16:05 <rosmaita> kumoscale also has os-brick changes, so there's a lot there to review
14:16:31 <rosmaita> ok, that's all the announcements from me
14:16:49 <rosmaita> #topic requirements changes (pip resolver issue)
14:17:11 <rosmaita> ok, as you may recall, the pip update broke a bunch of stuff
14:17:25 <rosmaita> #link https://review.opendev.org/q/hashtag:fix-l-c
14:18:04 <rosmaita> actually, i meant this one: https://review.opendev.org/q/hashtag:fix-l-c+branch:master
14:18:35 <rosmaita> so we are covered except for brick-cinderclient-ext and cinderlib
14:18:57 <rosmaita> cinderlib isn't actually broken, though, but could still use an eyeball or two
14:19:27 <rosmaita> the other releaseable branches have some fixes merged, some not
14:19:38 <rosmaita> #link https://review.opendev.org/q/hashtag:fix-l-c+-branch:master
14:20:03 <rosmaita> so stable-maint cores, ^^
14:20:27 <rosmaita> e0ne has been working on some of the EM branches
14:20:50 <rosmaita> but i don't have a link to his patches ATM
14:21:25 <rosmaita> I think that's all about that topic, just need some quick reviews to get these merged and unblock the gates
14:21:50 <rosmaita> #topic use of topic vs hashtags in gerrit
14:22:17 <rosmaita> ok, the gerrit links above are using the "hashtag" feature of gerrit 3
14:22:48 <rosmaita> right now, though, only the review owner can set hashtags
14:22:58 <rosmaita> which i didn't know when i started using them
14:23:33 <rosmaita> it's configurable, though, so i will follow up with opendev infra team to get the same permissions on them as on topic changes
14:24:06 <rosmaita> but we want to use these things consistently to make it easy for people to find stuff
14:24:15 <tosky> configurable by project? Is there a general guideline OpenStack-wise?
14:24:19 <eharney> i suspect we want to stick mostly to using topics
14:24:26 <whoami-rajat__> rosmaita: is the goal to make them both usable as alternatives?
14:24:32 <rosmaita> the main difference is there can be only one topic per review
14:24:40 <rosmaita> but multiple hashtags per review
14:24:40 <tosky> most likely common goals and cross-project changes will still use topics for now, until new guidelines are approved
14:24:56 <eharney> git-review doesn't support hashtags
14:25:09 <eharney> also not sure if they behave the same way as topics when you submit follow-up patches to an existing review
14:25:31 <jungleboyj> Is there any documentation or guideline on hashtags?  First I am hearing of it.
14:25:37 <eharney> also, topics work fine :)
14:25:55 <rosmaita> jungleboyj: no guidance, they are a new thing
14:26:22 <rosmaita> #link https://review.opendev.org/Documentation/intro-user.html#hashtags
14:26:49 <rosmaita> ok, well eharney's point that git-review doesn't support them yet is a good one
14:27:24 <rosmaita> so let's continue to use topics
14:28:01 <jungleboyj> Agreed.
14:28:08 <rosmaita> i will go back and set topic on all those requirements changes and send out an email later
14:28:31 <rosmaita> ok, that was easy
14:28:34 <jungleboyj> If we can get access for everyone to add hashtags it could help us with review but doesn't sound like something we want to set a formal stance on.
14:28:56 <rosmaita> exactly
14:29:05 <eharney> they could be useful for something like #target-milestone3 but i don't think we should just replace topics w/ them
14:29:27 <rosmaita> ok, i will follow up with opendev about the permissions issue
14:29:46 <rosmaita> i'm not the only one, it was already on the gerrit update issues etherpad
14:29:59 <rosmaita> #link https://etherpad.opendev.org/p/gerrit-3.2-post-upgrade-notes
14:30:09 <rosmaita> line 23
14:30:20 <rosmaita> ok, we can move along
14:30:33 <rosmaita> #topic Wallaby R-16 to R14 Bug Review
14:30:39 <michael-mcaleer> thanks rosmaita
14:30:41 <rosmaita> #link https://etherpad.opendev.org/p/cinder-wallaby-r16r14-bug-review
14:30:59 <michael-mcaleer> this weeks review covers the period of a few weeks over the break, it was quiet so not a lot to report
14:31:16 <rosmaita> \o/
14:31:18 <michael-mcaleer> ill follow same format as last time, ill post bug title and link
14:31:37 <michael-mcaleer> we can disucss each then where necessary, no point copy/pasting whats already in the etherpad
14:31:42 <michael-mcaleer> bug_1: Manage to encrypt volume_type #link https://bugs.launchpad.net/cinder/+bug/1909207
14:31:43 <openstack> Launchpad bug 1909207 in Cinder "manage to encrypt volume_type" [High,Confirmed] - Assigned to xuanyandong (xuanyandong)
14:32:02 <eharney> this one definitely is worth investigating, i glanced at it but not sure what is going on there yet
14:32:06 <michael-mcaleer> ive set this to high because potential of data loss
14:32:32 <eharney> good call
14:32:55 <michael-mcaleer> its been confirmed by someone else other than submitter too
14:33:20 <michael-mcaleer> any more comments before I move on?
14:33:49 <eharney> no
14:33:54 <michael-mcaleer> bug_2: Invalid quota resource when update volume type name #link https://bugs.launchpad.net/cinder/+bug/1909630
14:33:56 <openstack> Launchpad bug 1909630 in Cinder "invalid quota resource when update volume type name" [Medium,Triaged] - Assigned to haixin (haixin77)
14:34:50 <michael-mcaleer> this one took a few reads to decipher what was going on
14:36:00 <michael-mcaleer> further summary available in the launchpad, I just summarised in the etherpad, looks like we have an incorrect call to db.quota_class_update_resource in QUOTAS.update_quota_resource when a volume type name is updated
14:37:15 <michael-mcaleer> moving on...
14:37:16 <michael-mcaleer> bug_3: Testcase failed due to real ceph cluster #link https://bugs.launchpad.net/cinder/+bug/1909109
14:37:18 <openstack> Launchpad bug 1909109 in Cinder "Testcase failed due to real ceph cluster" [Low,Triaged]
14:37:43 <michael-mcaleer> issue here is file exists in real ceph environment and causes unit test to fail
14:38:06 <michael-mcaleer> /etc/ceph/ceph.client.admin.keyring already exists
14:38:18 <michael-mcaleer> seems pretty straight forward
14:38:50 <eharney> yes
14:39:03 <michael-mcaleer> three remaining bugs are all driver related
14:39:05 <enriquetaso> i thought tox isolate everything
14:39:16 <eharney> enriquetaso: this is a failure to mock something correctly in the unit tests
14:40:17 <michael-mcaleer> next bug...
14:40:19 <michael-mcaleer> bug_4: Pure Storage driver broken with ipv6 iscsi addresses #link https://bugs.launchpad.net/cinder/+bug/1910143
14:40:20 <openstack> Launchpad bug 1910143 in Cinder "Pure Storage driver broken with ipv6 iscsi addresses" [Medium,In progress] - Assigned to Simon Dodsley (simon-dodsley)
14:40:38 <michael-mcaleer> looks like an issue was introduced in Train for ipv6 addressing
14:40:54 <michael-mcaleer> in progress already
14:41:00 <michael-mcaleer> backports will be required
14:41:06 <michael-mcaleer> next...
14:41:10 <michael-mcaleer> bug_5: Feature: include/exclude cidrs in iscsi pure driver #link https://bugs.launchpad.net/cinder/+bug/1909010
14:41:11 <openstack> Launchpad bug 1909010 in Cinder "feature: include/exclude cidrs in iscsi pure driver" [Wishlist,Fix released] - Assigned to Christophe Drevet-Droguet (aa-cdr)
14:41:50 <michael-mcaleer> Pure driver again, this is opened as a launchpad but its a feature not a bug, marked as wishlist and asked submitter to create blueprint, they want include/exclude CIDR ranges impleneted in pure driver
14:42:29 <rosmaita> sounds right
14:42:40 <michael-mcaleer> not sure if submitter is part of driver mainters for pure, he is working on it in his own github so might just be an external contributor
14:42:56 <michael-mcaleer> and lastly...
14:42:59 <michael-mcaleer> bug_6: SolidFire driver: Efficiency calculations differs from Element Software 12 documentation #link https://bugs.launchpad.net/cinder/+bug/1910123
14:43:02 <openstack> Launchpad bug 1910123 in Cinder "SolidFire driver: Efficiency calculations differs from Element Software 12 documentation" [Low,Triaged] - Assigned to Fernando Ferraz (fernando-ferraz)
14:43:36 <rosmaita> looks like netapp is already on the case
14:43:37 <michael-mcaleer> solidfire have new methods for calculating efficiency in there recent releases, this is to track that work
14:43:52 <sfernand> I will propose a patch for that today
14:44:04 <michael-mcaleer> ok, it wasnt assigned yesterday when I was going through them
14:44:07 <rosmaita> cool
14:44:18 <michael-mcaleer> thats it from me everyone, thanks!
14:44:25 <rosmaita> thanks michael-mcaleer
14:44:31 <rosmaita> #topic open discussion
14:44:45 <rosmaita> going back to https://bugs.launchpad.net/cinder/+bug/1909207
14:44:47 <openstack> Launchpad bug 1909207 in Cinder "manage to encrypt volume_type" [High,Confirmed] - Assigned to xuanyandong (xuanyandong)
14:45:16 <rosmaita> if we aren't going to have a quick fix for that, i wonder whether we should send something to the operators list
14:45:20 <rosmaita> warning them not to do that
14:45:42 <eharney> yeah, i imagine this is going to take a bit of effort to fix, so that might be a good idea
14:46:11 <rosmaita> ok, i will draft something and then run it by eharney in his capacity of encrypted volume type expert
14:46:19 <eharney> maybe we can figure out if it varies based on backend/protocol  (i think it might)
14:47:06 <whoami-rajat__> I would like to request review for this patch (which will be required to make my format info feature work) https://review.opendev.org/c/openstack/cinder/+/763181
14:47:28 <jungleboyj> eharney: rosmaita ++
14:51:50 <eharney> whoami-rajat__: i can help w/ review there
14:52:00 <whoami-rajat__> thanks eharney
14:53:06 <rosmaita> i see eharney already has a patch up for https://launchpad.net/bugs/1909109
14:53:08 <openstack> Launchpad bug 1909109 in Cinder "Testcase failed due to real ceph cluster" [Low,Triaged] - Assigned to Eric Harney (eharney)
14:53:18 <rosmaita> https://review.opendev.org/c/openstack/cinder/+/769549
14:53:31 <michael-mcaleer> that was quick :P
14:54:04 <rosmaita> anything else?
14:54:08 <eharney> https://review.opendev.org/c/openstack/os-brick/+/763784   should be an easy review for someone
14:55:22 <rosmaita> yeah, that's a good one, i completely missed that in review of the original change
14:55:50 <eharney> me too
14:56:20 <rosmaita> ok, if no more discussion, remember that the review priority for the next 2 weeks is drivers, drivers, drivers
14:56:54 <jungleboyj> What is it?
14:56:58 <jungleboyj> ;-)
14:57:15 <rosmaita> drivers, drivers, drivers!!!
14:57:38 <rosmaita> ok, thanks everyone, see you next week
14:57:40 <eharney> channeling ballmer?  lol
14:57:49 <whoami-rajat__> thanks!
14:57:52 <michael-mcaleer> thanks rosmaita!
14:57:53 <jungleboyj> Thanks everyone!
14:58:15 <rosmaita> #endmeeting