14:00:02 <whoami-rajat> #startmeeting cinder
14:00:02 <opendevmeet> Meeting started Wed Sep 14 14:00:02 2022 UTC and is due to finish in 60 minutes.  The chair is whoami-rajat. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:02 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:02 <opendevmeet> The meeting name has been set to 'cinder'
14:00:04 <whoami-rajat> #topic roll call
14:00:09 <simondodsley> o/
14:00:14 <jungleboyj> o/
14:00:20 <enriquetaso> hi
14:00:20 <rosmaita> o/
14:00:52 <eharney> hi
14:01:00 <luizsantos[m]> o/
14:01:06 <caiquemello[m]> hi
14:01:15 <MatheusAndrade[m]> o/
14:01:34 <felipe_rodrigues> o/
14:01:37 <whoami-rajat> #link https://etherpad.openstack.org/p/cinder-zed-meetings
14:02:00 <nahimsouza[m]> o/
14:03:02 <whoami-rajat> good turnout, let's get started
14:03:09 <whoami-rajat> #topic announcements
14:03:18 <whoami-rajat> first, new stable cores - Walt and Sofia
14:03:27 <whoami-rajat> #link https://lists.openstack.org/pipermail/openstack-discuss/2022-September/030446.html
14:03:33 <enriquetaso> thanks :D
14:03:35 <rosmaita> congratulations!
14:03:43 <simondodsley> congrats.
14:03:48 <jungleboyj> \o/ Welcome!
14:04:06 <whoami-rajat> I've added Walt and Sofia to the stable cores list, they've been contributing to the project since a long time and would be a good addition to the stable core team
14:04:12 <whoami-rajat> welcome enriquetaso and hemna !!
14:04:20 <hemna> mep
14:04:55 <whoami-rajat> great
14:04:59 <whoami-rajat> moving on
14:05:02 <whoami-rajat> next, Propose topics for Antelope PTG
14:05:17 <whoami-rajat> so I've prepared the etherpad for Antelope PTG planning
14:05:18 <whoami-rajat> #link https://etherpad.opendev.org/p/antelope-ptg-cinder-planning
14:05:32 <TusharTgite> hi
14:05:52 <whoami-rajat> Please add topics and don't want for last moment else it will be hard to allocate time for it
14:06:05 <whoami-rajat> I will send out an email highlighting this as well
14:06:06 <whoami-rajat> s/want/wait
14:06:34 <whoami-rajat> on the same note, I've allocated 1400 UTC on tuesday for operator hour
14:06:58 <whoami-rajat> wanted to know if 1 hour will be enough or should i schedule another slot?
14:07:16 <whoami-rajat> this is the first time we're having this kind of meetup in the PTG so not really sure
14:07:34 <hemna> it might :P
14:07:45 <rosmaita> i think one hour is good, and we will have some slack space at the end of the week to revisit issues
14:08:14 <whoami-rajat> ack, sounds good then
14:08:35 <whoami-rajat> next, PTL + TC elections
14:08:38 <rosmaita> hemna: separate from the operator's hour, i know you've been thinking about more info that cinder can surface to operators ... would be good if you could talk about that at the ptg
14:09:23 <hemna> coolio.  I have some ideas for other features I haven't mentioned yet as well and some github PRs that I am working on for our fork
14:10:02 <rosmaita> yeah, would be good to mainstream this stuff
14:10:40 <whoami-rajat> ok, so for PTL, the only election that will be held for Ironic, for cinder since no one else nominated themselves, I'm the PTL again :)
14:11:02 <whoami-rajat> and there will be TC elections, so you can vote
14:11:13 <whoami-rajat> but you will need to opt into CIVS portal
14:11:20 <whoami-rajat> look at the mail sent out by jungleboyj for details
14:11:22 <whoami-rajat> #link https://lists.openstack.org/pipermail/openstack-discuss/2022-September/030433.html
14:12:09 <jungleboyj> Yes, please!  We are seeing that a lot of eligible voters have not opted in.  So, please see my note and make sure you have done that.
14:12:41 <whoami-rajat> thanks jungleboyj
14:12:47 <rosmaita> jungleboyj: so it is not too late to opt in?
14:12:57 <rosmaita> and how can someone know if the opt-in worked?
14:13:26 <whoami-rajat> rosmaita, when you enter your email, they send a code for verification
14:13:29 <jungleboyj> rosmaita:  Not 100% sure.
14:13:35 <jungleboyj> whoami-rajat:  ++
14:13:47 <whoami-rajat> after that it will start showing the pending polls
14:13:49 <hemna> I just opted in and voted
14:13:58 <whoami-rajat> at least that is what i did
14:14:08 <whoami-rajat> great
14:14:30 <rosmaita> sounds good
14:15:23 <whoami-rajat> cool, so please opt in and vote
14:15:25 <whoami-rajat> everyone ^
14:15:29 <whoami-rajat> next, Zed cycle highlights
14:15:34 <whoami-rajat> #link https://releases.openstack.org/zed/highlights.html#cinder
14:15:42 <whoami-rajat> I've added highlights for the Zed cycle
14:16:07 <whoami-rajat> if anyone thinks something is missing/needs update, let me know and I can propose a patch for it
14:16:28 <whoami-rajat> at least that's my understanding that we can still update it right rosmaita ?
14:16:43 <jungleboyj> Awesome.  hemna Thanks for confirming.
14:17:02 <rosmaita> yes, we can update at any time, but as to whether anyone will pay attention, who knows?
14:17:21 <rosmaita> what i mean is that the marketing people apparently look at the highlights to prepare stuff
14:17:33 <rosmaita> and not sure when they look
14:17:59 <whoami-rajat> ok, let's see if an update request comes or not, else these are the final highlights we have
14:18:09 <rosmaita> so, better to make corrections earlier rather than later is what i'm saying
14:18:29 <whoami-rajat> rosmaita, got it, thanks for the info!
14:18:54 <whoami-rajat> next, RC1 (September 15)
14:19:06 <whoami-rajat> which is tomorrow and I will go through some topics that are related to it
14:19:29 <whoami-rajat> but before that, does anyone have anything else to announce?
14:20:11 <hemna> can still get bugs in?
14:20:22 <whoami-rajat> yes
14:20:43 <whoami-rajat> before RC1 it won't require backport and after RC1 we will need to backport and do RC2
14:21:11 <whoami-rajat> i.e. after RC1, stable/zed will be cut and master will move to antelope or 2023.1
14:22:22 <whoami-rajat> ok, if there isn't anything else, let's move to topics
14:22:39 <whoami-rajat> #topic Features remaining
14:23:02 <whoami-rajat> so we're way past any deadline but I'm still OK to merge things till today EOD since RC1 will be cut tomorrow
14:23:06 <whoami-rajat> we've 3 features remaining
14:23:28 <whoami-rajat> 1st, Infinidat manage/unmanage support: https://review.opendev.org/c/openstack/cinder/+/852009
14:23:48 <whoami-rajat> rosmaita, and I have already reviewed it but waiting for an answer from author
14:23:51 <whoami-rajat> so it's looking good
14:24:07 <whoami-rajat> second, RBD QoS:  https://review.opendev.org/c/openstack/cinder/+/820027
14:24:23 <whoami-rajat> which i had no idea about and it wasn't in our tracker but geguileo pinged about it yesterday
14:24:29 <whoami-rajat> and looks kind of good to get it in
14:24:46 <hemna> was just chatting with him about it and according to him straight migrations will keep the qos settings fwiw
14:24:48 <whoami-rajat> it already has a +2 from Gorka, I will take a look at it later tonight but feel free to review it
14:25:22 <whoami-rajat> ack
14:25:48 <whoami-rajat> so this is also looking good
14:25:57 <whoami-rajat> third, Fix and unify capacity calculations: https://review.opendev.org/c/openstack/cinder/+/831247
14:26:13 <whoami-rajat> this also wasn't in our tracker doc and i saw it in the morning, but we did have a spec for it
14:26:39 <whoami-rajat> although I'm not an expert on the scheduler area and don't want anything to break/change this close to the release
14:27:19 <whoami-rajat> anyone would like to volunteer reviewing the patch?
14:27:42 <hemna> rosmaita had reviewed it previously and I fixed some documentation issues with it.  fwiw
14:28:03 <rosmaita> yeah, i need to return to it and look over the actual computations
14:28:13 <rosmaita> but it mostly looks fine
14:28:20 <jungleboyj> I was looking at it too.
14:28:36 <jungleboyj> How high is the risk of trying to get this in?
14:28:57 <hemna> I'm using it in production in all of my deployments
14:29:30 <jungleboyj> *Laughing*  Ok.  So, that is a good data point.  :-)
14:30:08 <whoami-rajat> does it change any existing behavior which, might be wrong currently, but would customers notice it?
14:30:49 <rosmaita> i think operators will get fewer problems because the computations will be more accurate
14:31:31 <whoami-rajat> if that's the case, it looks good to get in
14:31:49 <whoami-rajat> so i guess rosmaita and jungleboyj volunteered to review it? :)
14:31:58 <rosmaita> apparently so
14:31:58 <hemna> if fixes the math and breaks out each factor into it's own piece and it unifies the calculations between the capacity filter and the weigher, which had 2 different ways of doing it and getting different values.
14:32:03 <jungleboyj> :-)
14:32:42 <whoami-rajat> ok, sounds good then
14:33:03 <whoami-rajat> looks like we're good on the features part
14:33:27 <whoami-rajat> #topic Driver followups
14:33:49 <whoami-rajat> so we merged some drivers with followups requested
14:34:02 <whoami-rajat> and there are two (that I'm aware of) which would be good to get in
14:34:13 <whoami-rajat> first, Tatlin improving test coverage: https://review.opendev.org/c/openstack/cinder/+/853315
14:34:24 <whoami-rajat> this adds more UT coverage and removes some unnecessary code from driver
14:34:43 <whoami-rajat> overall it's kind of a refactoring + improving testing effort
14:34:59 <whoami-rajat> second, PowerStore NFS Driver - followup: https://review.opendev.org/c/openstack/cinder/+/852024
14:35:30 <whoami-rajat> this had some issues in the original driver implementation which are fixed here
14:35:37 <whoami-rajat> but currently the CI is failing on this
14:35:56 <whoami-rajat> so would be good to get these in since these drivers are also merged in Zed
14:36:56 <whoami-rajat> moving on to the final topic by me
14:37:01 <whoami-rajat> #topic DB changes
14:37:08 <whoami-rajat> #link https://review.opendev.org/q/topic:remove-legacyfacade+project:openstack/cinder+is:open
14:37:19 <whoami-rajat> so Stephen proposed some DB changes
14:37:38 <whoami-rajat> I looked at the initial ones and they looked good but the later ones are big changes
14:37:50 <whoami-rajat> removing the DB-sqlalchemy abstraction layer
14:37:57 <whoami-rajat> which i think is not a good idea to get in at this time
14:38:06 <whoami-rajat> so my opinion is to move this to next cycle
14:38:52 <rosmaita> that is probably a good idea
14:39:00 <rosmaita> we should put this on the PTG agenda
14:39:05 <jungleboyj> Agreed.
14:39:17 <rosmaita> we have been lucky that no DB changes have been required the past few cycles
14:39:39 <whoami-rajat> rosmaita, sounds good, will add it
14:39:42 <rosmaita> we need to make sure everything is working properly early in 2023.1
14:40:16 <whoami-rajat> yeah
14:40:31 <rosmaita> there's a nova patch we can use as an example to do a change to test things out, though i am not sure of the details
14:40:34 <hemna> I think it's a good idea, just not at the end of the cycle.  I think if we are going to merge it, if it's zuul happy, it should be early in the cycle
14:40:48 <jungleboyj> ++
14:41:23 <whoami-rajat> great, sounds like everyone is in agreement
14:41:39 <whoami-rajat> will target it for the next cycle
14:42:06 <whoami-rajat> moving on to the final topic of the day
14:42:09 <whoami-rajat> #topic Merging FIPS  jobs please
14:42:24 <whoami-rajat> afaranha, that's you
14:42:33 <whoami-rajat> alee doesn't seem to be around, at least in this channel
14:43:45 <whoami-rajat> seems like afaranha is also not around ...
14:43:49 <rosmaita> my major concern is the reliance on centos-9-stream, though i guess since the job is non-voting, maybe that's not a big deal
14:43:53 <whoami-rajat> i think the ask is for reviews on the FIPS patches
14:44:31 <tosky> they are not around
14:44:32 <rosmaita> openstack-infra has talked about making rocky linux images available for CI, that would be a better target, imo
14:44:59 <tosky> they would like to have the job as non-voting at least so that it's easier to compare the results
14:45:21 <afaranha> sorry, me and ade are on meetings now
14:45:39 <tosky> so while waiting for those images to land, it would make sense to have the jobs anyway
14:46:21 <afaranha> the dependencies and the main patch have the tests passing now
14:46:51 <whoami-rajat> ack, I'm OK with n-v jobs getting in
14:47:57 <whoami-rajat> so yeah, please review the changes for FIPS
14:48:02 <whoami-rajat> #link https://review.opendev.org/c/openstack/cinder/+/790535
14:48:02 <afaranha> ack
14:48:09 <whoami-rajat> #link https://review.opendev.org/c/openstack/devstack-plugin-nfs/+/847087
14:48:15 <whoami-rajat> #link https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/847086
14:48:53 <rosmaita> just a reminder, all cinder core are also devstack-plugin-nfs cores too
14:49:22 <whoami-rajat> yep, so all changes can be reviewed by cinder cores ^
14:49:57 <enriquetaso> ++
14:50:10 <whoami-rajat> that's all the topics we had for today
14:50:14 <whoami-rajat> let's move to open discussion
14:50:19 <whoami-rajat> #topic open discussion
14:50:23 <inori> Excuse me, I'd like to bring attention in this patch here. Missing one +2 from a core reviewer.
14:50:32 <inori> https://review.opendev.org/c/openstack/cinder/+/847730
14:50:42 <inori> Could you please take a look at this patch？
14:51:20 <whoami-rajat> another feature ...
14:52:20 <whoami-rajat> inori, is this urgent for the Zed cycle or can we move it to the next cycle? we're already overloaded and tomorrow the zed release will cut
14:53:39 <enriquetaso> that patch needs at least a release note
14:54:43 <inori> It means that this patch can't be reviewed in this cycle?
14:55:43 <whoami-rajat> doesn't seem likely, we don't have review bandwidth + no time left in the cycle
14:55:53 <whoami-rajat> we can prioritize this next cycle
14:56:01 <inori> fine, move it to the next cycle should be ok.
14:56:11 <inori> Thanks for your reply.
14:56:26 <whoami-rajat> great, thanks!
14:57:10 <akawai> Cores : pls one more review "856385: Hitachi: fix to output resource lock message correctly | https://review.opendev.org/c/openstack/cinder/+/856385".
14:57:21 <akawai> The XS patch fixes a bug in Hitachi driver which is reported in "[cinder] Bug Report 09-14-2022". It's already got one +2.
14:58:40 <whoami-rajat> akawai, we will be having festival of XS reviews this friday but probably good to get this in before that to avoid backport
14:59:05 <whoami-rajat> everyone ^ we will be having festival of xs reviews this friday
14:59:26 <akawai> whoami-rajat: ty. i see.
14:59:54 <whoami-rajat> np
14:59:58 <whoami-rajat> and we're out of time
15:00:02 <whoami-rajat> thanks everyone for attending
15:00:05 <whoami-rajat> #endmeeting