14:00:14 <whoami-rajat> #startmeeting cinder 14:00:14 <opendevmeet> Meeting started Wed Sep 21 14:00:14 2022 UTC and is due to finish in 60 minutes. The chair is whoami-rajat. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:00:14 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:00:14 <opendevmeet> The meeting name has been set to 'cinder' 14:00:19 <whoami-rajat> #topic roll call 14:00:23 <simondodsley> o/ 14:00:39 <jungleboyj> o/ kind of. 14:00:41 <hemna> mep 14:01:10 <aneeeshp1> o/ 14:01:17 <rosmaita> o/ 14:01:31 <HappyStacker> hello 14:02:21 <yuval> 0/ 14:02:21 <tosky> o/ 14:02:46 <whoami-rajat> #link https://etherpad.openstack.org/p/cinder-zed-meetings 14:02:51 <felipe_rodrigues> o/ 14:03:31 <enriquetaso> hello 14:04:16 <whoami-rajat> I can see the usual people 14:04:19 <whoami-rajat> let's get started 14:04:26 <whoami-rajat> #topic announcements 14:04:34 <whoami-rajat> first, RC-1 Released 14:04:40 <whoami-rajat> #link https://review.opendev.org/c/openstack/releases/+/857102 14:04:48 <whoami-rajat> we released RC1 this monday 14:05:06 <whoami-rajat> so now the master is updated to 2023.1 (or as we would like to call it Antelope) 14:05:10 <whoami-rajat> and a stable/zed branch is created 14:05:18 <whoami-rajat> any fix merged now will be in the antelope release 14:05:39 <whoami-rajat> and if it's critical for the zed release then needs to be backported to stable/zed 14:05:45 <whoami-rajat> which brings me to the second announcement 14:05:47 <whoami-rajat> Cinder RC-2 14:05:57 <whoami-rajat> We're planning to have an RC-2 release 14:06:01 <whoami-rajat> deadline is next week 14:06:24 <whoami-rajat> I've created an etherpad for pontential fixes that would be good to get in into the zed release (RC-2) 14:06:26 <whoami-rajat> #link https://etherpad.opendev.org/p/cinder-zed-rc2-bugfix 14:06:43 <whoami-rajat> if you think you've a patch that needs to get in the zed release, please add it to the etherpad 14:07:21 <whoami-rajat> I've already added some patches that i think are good for the release 14:07:43 <whoami-rajat> next, Ubuntu Summit 14:07:52 <whoami-rajat> #link https://lists.openstack.org/pipermail/openstack-discuss/2022-September/030533.html 14:08:11 <whoami-rajat> I'm not sure how many people are interested in this but they're planning to have a physical as well as virtual summit 14:08:21 <whoami-rajat> read the email thread for more details 14:08:40 <whoami-rajat> next, Election results: TC and PTL 14:08:51 <whoami-rajat> #link https://lists.openstack.org/pipermail/openstack-discuss/2022-September/030541.html 14:09:03 <whoami-rajat> we've the list of newly elected TC members and all the PTLs 14:09:32 <whoami-rajat> that's all i had for announcements, anyone has anything else? 14:10:27 <enriquetaso> congrats whoami-rajat ! 14:10:42 <whoami-rajat> thanks :) 14:10:48 <enriquetaso> and thanks for PTL again 14:11:28 <whoami-rajat> it's a good opportunity! 14:11:29 <jungleboyj> ++ 14:12:12 <rosmaita> ++ 14:12:12 <whoami-rajat> okay, let's move to topics then 14:12:34 * whoami-rajat feels glad to have the team support 14:12:47 <whoami-rajat> #topic cinder tempest plugin release 14:12:55 <whoami-rajat> #link https://review.opendev.org/c/openstack/releases/+/858401 14:13:01 <HappyStacker> congrats Rajat! 14:13:18 <whoami-rajat> this is more kind of an announcement but wanted to discuss this 14:13:31 <whoami-rajat> does anyone have any patches they would like to get in for the cinder tempest plugin release? 14:13:35 <whoami-rajat> the deadline is this week 14:13:38 <whoami-rajat> thanks HappyStacker 14:14:12 <whoami-rajat> tosky, ^ you've any patch in mind that would be good for the release? 14:14:50 <enriquetaso> i have one, but i'd like to know what you think about 14:15:00 <whoami-rajat> sure 14:15:08 * enriquetaso looking for the enabling RBD min client to mimic 14:15:31 <tosky> uhm, not on top of my head 14:16:01 <rosmaita> maybe https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/852675 ? 14:16:05 <whoami-rajat> ok, let me know if something comes up and we can try to get that in else I will +1 the release patch on friday 14:16:08 <rosmaita> tests a functionality introduced in zed 14:16:13 <tosky> enriquetaso: cinder-tempest-plugin is branchless, so it could be enabled later in a job if all pieces are in place in cinder 14:16:20 <tosky> we can also release it 14:16:23 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder/+/848013 14:16:29 <whoami-rajat> rosmaita, oh yeah that is a good one 14:16:34 <enriquetaso> true :P ok 14:16:48 <tosky> we have a few SRBAC pending patches, at least one which refactors the code a bit 14:17:21 <whoami-rajat> enriquetaso, that is a cinder patch. we are referring to changes in cinder-tempest-plugin 14:17:30 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/823719 14:18:06 <whoami-rajat> this one is failing zuul as of now 14:18:24 <whoami-rajat> tosky, are you referring to this? https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/842954 14:19:39 <whoami-rajat> I can see i also have a patch that fixes a problem with idempotent IDs, if anyone would like to review https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/839301 14:20:06 <tosky> yes, that refactor patch 14:20:28 <tosky> and yes, the idempotent ID has a review priority+1 from me 14:21:23 <whoami-rajat> ack, will keep an eye on the 3 patches 14:22:02 <whoami-rajat> that's all from my side 14:22:04 <whoami-rajat> moving on 14:22:16 <whoami-rajat> #topic Outreachy December 2022 to March 2023 internship round 14:22:18 <whoami-rajat> enriquetaso, that's you 14:22:39 <enriquetaso> Outreachy provides internships in open source and opens science to people impacted by underrepresentation in the technology industry. 14:22:48 <enriquetaso> Openstack has funding for 3 interns in December 2022 to March 2023 internship round. Mentors can submit projects for Outreachy applicants until Sept. 29, 2022, at 4 pm UTC. 14:23:07 <enriquetaso> I plan to proposed myself as a mentor for this round 14:23:15 <enriquetaso> The intern goal would be "extending the API reference to handle microversions". The work was started by Gorka and Rajat so the plan would be to break what is missing (I did a quick check and I think is the newest microversions, right?) into smaller work items, maybe based on microversion. 14:24:46 <enriquetaso> Maybe we can talk about it whoami-rajat after the cinder meeting 14:24:48 <rosmaita> sounds like a useful task, we need some suggestions for making this sound sexy, though 14:25:07 <enriquetaso> rosmaita, yes... it doesn't sounds sexy now lol 14:25:09 <whoami-rajat> sure, thanks for bringing this up enriquetaso 14:25:39 <enriquetaso> maybe y can create a etherpad or a google doc and share with you to suggest and review the proposal ? 14:25:56 <enriquetaso> I can* 14:25:57 <whoami-rajat> would be good to get the gaps addressed we've in our api-ref with the addition of functional tests 14:26:00 <rosmaita> i mean, you can learn a lot doing this, just need to spell this out a bit 14:26:55 <rosmaita> etherpad sounds good 14:26:57 <whoami-rajat> yeah, we would need to divide the work items and for that we would need to see what is currently missing 14:27:19 <enriquetaso> whoami-rajat++ 14:27:25 <enriquetaso> rosmaita++ 14:27:51 <enriquetaso> OK, thanks. If another member would like to proposed a project the link is: 14:27:58 <enriquetaso> #link https://www.outreachy.org/communities/cfp/openstack/ 14:28:18 <rosmaita> enriquetaso: thank you for doing this 14:28:46 <enriquetaso> I'm positive about it :D 14:28:49 <whoami-rajat> thanks enriquetaso ! 14:29:30 <whoami-rajat> so we don't have any other topics for today 14:29:34 <whoami-rajat> let's move to open discussion 14:29:37 <whoami-rajat> #topic open discussion 14:29:45 <whoami-rajat> HappyStacker, you had an issue to discuss? 14:29:59 <HappyStacker> yes 14:30:25 <HappyStacker> so initially we have an issue with Powerflex and the way it handles the volume creation and extension 14:30:39 <HappyStacker> as you may know, it rounds the capacity by 8GB multiplier 14:31:22 <HappyStacker> up until this patch, every time a volume is creatd it gets a model update and update cinder DB accordingly 14:31:49 <HappyStacker> so if the user creates a 2GB volume, cinder will reflect 8GB as for the powerflex backend 14:32:10 <HappyStacker> We had a discussion a few months agos and we agreed this should NEVER happened 14:32:38 <HappyStacker> as cinder expects to show the size requested by the user not what happens in the backend 14:32:50 <HappyStacker> so the devs removed this piece of code 14:33:15 <HappyStacker> and now all of our CI are broken 14:33:23 <enriquetaso> DELL PowerFlex :are we talking about https://bugs.launchpad.net/cinder/+bug/1952355 ? 14:33:32 <whoami-rajat> I don't think there was any problem with the create volume 14:33:37 <whoami-rajat> the main problem is with extend volume which doesn't return a model_update, hence the difference between size in cinder DB and backend LUN 14:34:03 <HappyStacker> https://review.opendev.org/c/openstack/cinder/+/836973 14:34:06 <HappyStacker> this patch 14:34:22 <HappyStacker> related to this bug https://bugs.launchpad.net/cinder/+bug/1968164 14:34:25 <whoami-rajat> and if we were to return the model update, we have to update our driver interface and every backend would need to have the same return type 14:34:40 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1968164 14:34:41 <HappyStacker> so we're kind of stucked here 14:34:49 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder/+/836973 14:35:49 <rosmaita> I think cinder should have the real size in the DB, i.e., even if user asks for 2 GB, cinder says 8GB ... because once the volume is attached, there is no way to prevent the user from filling all 8GB, right? 14:36:37 <whoami-rajat> rosmaita, yes 14:37:07 <HappyStacker> I know we need to work on how to manage it but it'll take time to write the specs and code it 14:37:41 <whoami-rajat> I think for now the problem is how to revert the patch to fix the CI 14:37:42 <HappyStacker> without this patch if the user asks 2, cinder says 2 but powerflex has 8 14:37:47 <whoami-rajat> the patch is also part of zed RC1 14:37:52 <whoami-rajat> so need to revert in stable/zed as well 14:38:17 <HappyStacker> when you want to extend to 4 , cinder says ok, but powerflex doesn't understand as the size is already 8 14:38:23 <whoami-rajat> HappyStacker, i don't think that's the case, create volume should work fine, the extend volume should report different values right? 14:38:24 <HappyStacker> and thus failing 14:38:34 <HappyStacker> yes create works fine 14:39:03 <whoami-rajat> in create call, we return the rounded up size in the model_update so it always returns the right size to cinder 14:39:13 <rosmaita> gotcha 14:39:13 <whoami-rajat> but extend doesn't return anything 14:39:24 <HappyStacker> well fine, if we consider having discrepencies between cinder and powerflex are ok 14:40:08 <HappyStacker> so I'm asking your recommendation on how we can proceed 14:40:24 <whoami-rajat> I think we should fix it but we can't do anything about it right now 14:40:32 <whoami-rajat> currently the requirement is to fix the dell CI right? HappyStacker 14:40:53 <HappyStacker> if we let it as is, PowerFlex CI will alsway fail 14:41:19 <HappyStacker> or we can skip the cases which extends a volume 14:41:39 <rosmaita> the patch only touches powerflex, so i think revert change in master, and backport the revert to stable/zed 14:41:51 <rosmaita> (and re-open the bug) 14:41:59 <whoami-rajat> rosmaita, that's what i was thinking about 14:42:35 <rosmaita> then fix in master soon, and backport 14:42:40 <enriquetaso> ++ 14:43:03 <HappyStacker> so plan is First: revert change in master, and backport the revert to stable/zed 14:43:32 <HappyStacker> Second: work on the implementation of this 8GB support in master then backport 14:43:45 <HappyStacker> Is that correct? 14:44:03 <whoami-rajat> correct 14:44:35 <enriquetaso> after the revert, I'll reset the launchpad bug 14:44:53 <HappyStacker> ok thks I'll certainly need your help on scoping the work for the new feature 14:45:17 <HappyStacker> How can I revert the change? 14:45:23 <whoami-rajat> good that it got flagged before the official release 14:45:34 <whoami-rajat> HappyStacker, there is an option on the top right 14:45:46 <HappyStacker> I just saw it 14:45:47 <whoami-rajat> you will need to mention the reason for revert in the commit message 14:46:20 <HappyStacker> ok 14:46:44 <HappyStacker> that's for reverting the change, what about backporting it to Zed? 14:47:02 <whoami-rajat> cherry pick it after it merges 14:47:36 <HappyStacker> OK I'll sort it out and get back to you in case I have questions 14:47:40 <enriquetaso> i think there's a option on the top right menu 'cherry pick' 14:48:04 <enriquetaso> i think you may cherry pick it to stable/zed 14:48:25 <enriquetaso> but, i'm not sure 14:48:38 <whoami-rajat> yep, that's it 14:48:38 <HappyStacker> So click on cherry-pick and choose stable/Zed 14:48:52 <HappyStacker> after reverting it 14:48:56 <HappyStacker> right? 14:49:07 <whoami-rajat> yeah but cherry pick after the revert patch merges 14:49:14 <HappyStacker> yep roger that 14:49:38 <HappyStacker> thank you all! 14:49:49 <whoami-rajat> no problem 14:49:51 <HappyStacker> I was so confused on the way to handle it 14:50:05 <HappyStacker> Glad we all agreed 14:50:25 <HappyStacker> This is a community! revert change in master, and backport the revert to stable/zed 14:50:27 <rosmaita> HappyStacker: put this on the agenda for the PTG, and we can discuss the fix 14:50:32 <HappyStacker> ok 14:50:37 <HappyStacker> will do 14:50:54 <whoami-rajat> good to sort that out, do we have anything else for open discussion? 14:50:57 <whoami-rajat> rosmaita, +1 14:51:03 <jhartkopf> Hey, I have added a test to cinder-tempest-plugin for the Ceph backup driver patch (see https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/855876). Some questions: How can I ensure this test only runs with Ceph driver? How can I set Cinder config options to specific values? 14:51:41 <whoami-rajat> jhartkopf, it currently has some pep8 failures that needs to be addressed 14:52:10 <whoami-rajat> I don't think there is a driver specific option as of now 14:52:15 <whoami-rajat> tosky, ^ 14:53:11 <jhartkopf> yes, pep8 failures will be addressed 14:54:47 <jhartkopf> Problem is the test only works with Ceph and obviously only makes sense with Ceph. And it requires a specific config value. 14:54:48 <whoami-rajat> jhartkopf, the way that gate works currently is you can only set devstack variables and those variables need to enable project specific config options 14:55:50 <enriquetaso> i think we have some decorators to skip drivers, but i'm not sure to only run one driver, i'll review 14:55:56 <rosmaita> well, there's also a post_config (i think it's called) section you can put in zuul.yaml that allows you to modify the cinfog file 14:55:57 <tosky> jhartkopf: there are a few tests which explicitly set a skip if the plugin is ceph, even though that doesn't work well for clusters with multiple cinder backends 14:57:26 <jhartkopf> enriquetaso: a review would be welcome, thank you 14:58:01 <jhartkopf> so basically a mixture of skip everything except Ceph (maybe) and Zuul post_config, right? 14:58:45 <yuval> Before the meeting ends, is anyone running openstack redhat platform system and I can ask him few questions? 14:59:02 <whoami-rajat> maybe a devstack + tempest config option would be useful for these kind of scenarios but too much work for a single test 15:00:03 <whoami-rajat> yuval, the meeting is over basically but questions are welcome in #openstack-cinder 15:00:09 <whoami-rajat> we're out of time 15:00:16 <whoami-rajat> thanks everyone for joining 15:00:21 <enriquetaso> thanks 15:00:22 <whoami-rajat> #endmeeting