14:00:57 <whoami-rajat> #startmeeting cinder 14:00:57 <opendevmeet> Meeting started Wed Mar 15 14:00:57 2023 UTC and is due to finish in 60 minutes. The chair is whoami-rajat. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:00:57 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:00:57 <opendevmeet> The meeting name has been set to 'cinder' 14:01:01 <whoami-rajat> #topic roll call 14:01:49 <nahimsouza[m]> o/ 14:01:52 <thiagoalvoravel> o/ 14:01:58 <HelenaDantas[m]> o/ 14:02:11 <keerthivasansuresh> o/ 14:02:11 <luizsantos[m]> o/ 14:02:31 <enriquetaso> hi 14:02:45 <rosmaita> o/ 14:02:51 <whoami-rajat> #link https://etherpad.opendev.org/p/cinder-antelope-meetings 14:02:54 <Tony_Saad> o/ 14:03:07 <MatheusAndrade[m]> o/ 14:03:17 <lucasmoliveira059> \o 14:03:39 <tosky> o/ 14:04:09 <caiquemello[m]> o/ 14:04:29 <whoami-rajat> hello 14:04:35 <whoami-rajat> good turnout, let's get started 14:04:40 <whoami-rajat> #topic announcements 14:04:44 <whoami-rajat> RC2 this week 14:04:54 <whoami-rajat> 17 March 14:05:30 <felipe_rodrigues> o/ 14:05:35 <whoami-rajat> we did release RC1 last week but we still have changes to get in into 2023.1 release 14:05:42 <whoami-rajat> so we are planning to do RC2 14:05:51 <whoami-rajat> #link https://etherpad.opendev.org/p/cinder-antelope-fixes-rc 14:06:19 <whoami-rajat> I was reviewing the remaining patches and all are approved as of now except one 14:06:31 <whoami-rajat> #link https://review.opendev.org/c/openstack/cinder/+/852654 14:06:57 <whoami-rajat> I need to review it again after my comments were addressed, will do it after the meeting 14:07:10 <whoami-rajat> in the meantime please review the above patch since that's the only one remaining 14:07:20 <whoami-rajat> and zaitcev is fast in addressing comments 14:07:39 <whoami-rajat> also thanks everyone for reviewing the other changes! 14:08:24 <whoami-rajat> there is also my patch related to multiattach but it has conflicts on tempest side so nothing remaining from cinder side 14:08:38 <whoami-rajat> that's it for RC2 14:08:53 <whoami-rajat> next, 2023.2 (Bobcat) PTG 14:09:03 <whoami-rajat> #link https://etherpad.opendev.org/p/bobcat-ptg-cinder-planning 14:09:18 <whoami-rajat> we've Bobcat PTG in less than 2 weeks 14:09:31 <jungleboyj> o/ 14:09:35 <whoami-rajat> so please add topics to the etherpad if you would like them to be discussed 14:10:23 <whoami-rajat> i still don't see a lot of topics and it would take time to arrange them day wise (also there are cross project things) so please add them timely 14:10:44 <whoami-rajat> next, OpenInfra live: Cinder update 14:10:51 <whoami-rajat> #link https://lists.openstack.org/pipermail/openstack-discuss/2023-March/032638.html 14:11:18 <whoami-rajat> we will be having project updates for 2023.1 release and i signed up for providing the cinder update 14:11:26 <rosmaita> \o/ 14:11:32 <whoami-rajat> so if you would like to see it, it should be live on youtube on Thursday, March 23 at 1500 UTC 14:11:45 <jungleboyj> \o/ 14:12:07 <whoami-rajat> rosmaita, did a great update for Yoga and I missed it for Zed so this time I didn't forget about it 14:12:41 <whoami-rajat> next, Cancel next weeks meeting? 14:12:58 <whoami-rajat> we're close to PTG and next week is 2023.1 release 14:13:13 <whoami-rajat> I don't think we will have a lot of topics, and if we do then better to discuss them at PTG 14:13:27 <enriquetaso> yay 14:13:33 <whoami-rajat> but wanted to know what the team thinks, should we cancel meeting next week? 14:13:57 <rosmaita> no objections from me 14:14:08 <whoami-rajat> btw, i really like the enthusiasm in today's meeting! 14:14:43 <jungleboyj> That is good for me. 14:15:04 <jungleboyj> whoami-rajat: It is so much better when people respond, isn't it. :-) 14:16:07 <whoami-rajat> jungleboyj, that's true, sometimes I feel I got disconnected when I'm the only one typing 14:16:22 <jungleboyj> :-) Been there. 14:16:33 <whoami-rajat> :) 14:16:57 <whoami-rajat> so I don't see any objections, I will send a mail to ML regarding canceling next week's meeting 14:17:04 <rosmaita> sounds good! 14:17:20 <whoami-rajat> that's all for the announcements 14:17:28 <whoami-rajat> let's move to topics 14:17:33 <whoami-rajat> #topic Outreachy update 14:17:35 <whoami-rajat> enriquetaso, that's you 14:17:37 <enriquetaso> hi 14:18:00 <enriquetaso> I wanted to give an update regarding the outreachy applicants on the mailing list. I want to thank Jeremy Stanley and everyone who has taken the time to reply to their questions. 14:18:04 <whoami-rajat> just wanted to mention, I see a lot of participation of outreachy members on the ML which is really good 14:18:18 <enriquetaso> true! 14:18:22 <enriquetaso> So far, this round of applicants looks good, and we have received a few contributions. As outreachy is often the first job in tech for many applicants, if you review these patches, please keep this in mind. Please highlight good practices or anything you think can help the applicants with their careers. 14:18:52 <enriquetaso> The deadline for this round is this month, and applicants need at least one patch merged in order to apply. So, if you could review these patches as soon as possible, it would be greatly appreciated. 14:18:57 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder/+/877185 14:19:01 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/876905/ 14:19:05 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder/+/877070 14:19:59 <whoami-rajat> a lot of contribution which I wasn't aware about 14:20:14 <rosmaita> i will commit to looking at those 14:20:17 <rosmaita> today 14:20:24 <whoami-rajat> enriquetaso, can you add these to the review request section so we've more visibility? 14:20:35 <enriquetaso> Yes.. most of them forgot to link the launchpad bug to the patches, maybe that's why, not sure 14:20:50 <enriquetaso> sure whoami-rajat 14:20:58 <rosmaita> on that note, who has committed to looking at pete's restore-sparse patch? I know whoami-rajat said he will re-review, but who else? 14:20:59 <whoami-rajat> I will take a look at the patches by this week (after I'm free from RC2 stuff) 14:21:20 <enriquetaso> thank whoami-rajat, and thanks everyone on the cinder team 14:21:22 <whoami-rajat> I will do a review pass by today 14:21:28 <enriquetaso> rosmaita++ 14:21:43 <whoami-rajat> enriquetaso++ for the great work on outreachy side! 14:22:02 <enriquetaso> sure, no worries :D 14:22:05 <rosmaita> i agree, thanks enriquetaso 14:22:06 <fungi> enriquetaso: i was just glad to be of help 14:22:39 <whoami-rajat> I would really like rosmaita's question to be answered, anyone up for taking ownership of zaitcev's patch? 14:22:48 <whoami-rajat> as the second core 14:23:01 <whoami-rajat> I remember Jon reviewed it a couple of times 14:23:03 <rosmaita> i can make time to review, but it might be better for someone who's already reviewed it 14:23:08 <zaitcev> It's this: https://review.opendev.org/c/openstack/cinder/+/852654 14:23:29 <fungi> there weren't a lot of folks around to answer question on the mailing list over the weekend, which seemed to be when some of the interns were trying to learn the workflow 14:23:31 <whoami-rajat> and he's a core now, so he would be best 14:23:58 <rosmaita> that's right, congratulations jbernard! 14:24:31 <rosmaita> fungi: thanks for stepping up to answer, that was really helpful 14:25:02 <whoami-rajat> rosmaita, ... I totally forgot to announce that 14:25:15 <rosmaita> i saw it on the ML 14:25:20 <rosmaita> at least i think so 14:25:58 <whoami-rajat> sorry enriquetaso, we've totally mixed up multiple discussions with your topic 14:26:07 <whoami-rajat> I will let that finish first 14:26:18 <enriquetaso> lol 14:26:22 <whoami-rajat> thanks fungi for helping the outreachy interns out! 14:26:30 <jungleboyj> ++ 14:26:32 <enriquetaso> my topic is finish! 14:26:39 <enriquetaso> nothing else for my side 14:26:43 <rosmaita> we went from no participation to too much participation! 14:26:49 <enriquetaso> fungi++ 14:27:18 <enriquetaso> yes, rosmaita, I'm shocked, i think leaving devstack aside for the first contribution maybe related 14:27:36 <rosmaita> :D 14:27:54 <fungi> that pytest/tox conflict is really troubling though 14:28:54 <fungi> and further evidence we should be showing contributors how to use some sort of isolation like a venv rather than pip installing random tools into the system python context 14:29:05 <enriquetaso> yes.. it think devstack is having some problems with tox 4 as well 14:29:06 <whoami-rajat> yeah, even I struggled with devstack recently and the issue faced by me was only faced by one other person dansmith who helped me resolve it 14:29:37 <enriquetaso> maybe it's the same issue i'm facing running tox whoami-rajat 14:29:41 <fungi> clarkb has a change up to switch devstack to using venvs, i gether it's still mostly in good shape despite having sat unmerged for several years now 14:30:07 <fungi> pep 668 is going to pretty much force our hand in implementing something like that anyway 14:32:30 <whoami-rajat> so looks like outreachy interns are doing good progress and we need to review their changes actively 14:32:31 * enriquetaso fingercrossed 14:33:52 <whoami-rajat> ok we've 2 more topics, anything else on this one enriquetaso ? 14:34:15 <enriquetaso> nop 14:34:24 <whoami-rajat> great, thanks for the update! 14:34:40 <whoami-rajat> #topic Discuss patch https://review.opendev.org/c/openstack/cinder/+/868485 that changes schema validation 14:34:44 <whoami-rajat> #link https://review.opendev.org/c/openstack/cinder/+/868485 14:34:50 <whoami-rajat> drencrom, that's you 14:34:52 <drencrom> hi o/ 14:35:09 <drencrom> I added this to the topics as I got a -1 telling that it should be discussed here 14:35:28 <drencrom> It already has a +2 14:36:32 <rosmaita> i have a question about your schema definition ... i thought glance allowed arbitrary UTF-8 as property names? or is that only for values? 14:36:41 <whoami-rajat> the commit message makes sense since that information is coming from glance 14:36:43 <enriquetaso> hi, sorry that was me, because I'm just raising attention because the patch is changing api/schemas 14:37:09 <whoami-rajat> not sure why we're using extra_specs parameter type for validating glance image metadata, the change might modify extra_specs validation as well, I will add a comment 14:37:19 <rosmaita> whoami-rajat: ++ 14:38:06 <drencrom> I did not change anything on the properties names actually, just made the values larger 14:38:45 <drencrom> I'm not sure about glance spacification for keys, I'd have to check 14:39:10 <rosmaita> well, tbh, i guess cinder has never allowed UTF-8 for that, and no one has complained 14:41:45 <drencrom> I think extra_specs is also used in other places, that is why I added a new one 14:42:12 <rosmaita> i suggest not calling it extra_specs at all 14:42:54 <whoami-rajat> yeah, I'm not referring to your change but the convention we're using, extra_specs for volume, backup, image metadata doesn't look right 14:43:31 <whoami-rajat> as rosmaita said, would be better to call it volume_image_metadata or something 14:45:08 <whoami-rajat> rosmaita, or I can add a comment later but i think the discussion was about if the intent of the patch is correct 14:45:32 <whoami-rajat> that is to allow metadata values greater than 255 characters 14:45:50 <whoami-rajat> which IMO, if glance allows it, we should too 14:46:01 <whoami-rajat> it's their image metadata after all 14:46:23 <fungi> characters or bytes? if you get into multi-byte encodings that will make a difference 14:46:24 <rosmaita> i was looking at the glance schema, some metadata is limited, but some are just JSON "string" type 14:46:49 <drencrom> Yes, that was how I found the bug. Dealing with large metadata from Glance. 14:47:31 <rosmaita> a reviewer just needs to verify that we don't need a db change for this, and then it sounds ok to me 14:47:50 <rosmaita> alternative would be to truncate glance metadata values at 255 chars 14:48:12 <rosmaita> fungi: good question, i think mysql text is char count 14:48:34 <rosmaita> i mean, we would truncate when we record them in cinder 14:48:40 <fungi> for mysql it will depend on the field type and encoding specified in the schema 14:49:19 <rosmaita> i can't remember if the encoding is real utf-8 or that weird mysql utf-8 14:49:27 <fungi> there are at least a couple of utf8 types in mysql, for 3-byte and 4-byte 14:49:49 <drencrom> The DB is OK IIRC, there were cases where the metadata values where larger that 255 14:49:53 <fungi> it gets confusing, especially for users who created the table with one and then the software tries to write in another 14:50:45 <rosmaita> drencrom: yeah, but you are going to allow 65535 arbitrary unicode chars now 14:50:46 <fungi> and yes, mysql field width limits are in bytes not characters, so the utf8 encodings basically shrink the allowed widths proportionally to their character sizes 14:51:16 <rosmaita> so if it's 65535 bytes, we need to make the char count in the schema smaller 14:51:28 <rosmaita> it can still be very large 14:52:16 <drencrom> don't we have the sam issue with the 255 limit? 14:52:43 <rosmaita> probably, but it's limited ... so the schema rejects before the database barfs 14:53:27 <rosmaita> like the keys are limited to basically a subset of ascii, which in utf-8 are all only one byte each 14:53:53 <rosmaita> so char count == byte count for those 14:55:25 <drencrom> What about the other cases where extra_specs is used? Is the database size always larger that 255? 14:56:17 <rosmaita> i don't know, tbh, but we have pretty tight control on what are used in extra_specs 14:56:51 <whoami-rajat> we've 4 minutes left and one more topic, so let's continue this discussion on the patch or in #openstack-cinder channel 14:56:55 <whoami-rajat> after the bug squad meeting 14:57:04 <whoami-rajat> let's discuss the final topic 14:57:07 <drencrom> ok 14:57:17 <whoami-rajat> #topic stable/rocky status 14:57:20 <whoami-rajat> rosmaita, that's you 14:57:33 <rosmaita> py27 unit tests have been failing for a month 14:57:49 <rosmaita> let's talk about EOL at the vPTG 14:58:13 <rosmaita> instead, i want to ask any cinder-coresec members to take a quick look at https://bugs.launchpad.net/cinder/+bug/2008705 14:58:28 <whoami-rajat> rosmaita, sure, please add the topic to the planning etherpad https://etherpad.opendev.org/p/bobcat-ptg-cinder-planning 14:58:30 <rosmaita> just need feedback on whether it's really a security issue, or we can work on it in the open 14:58:45 <rosmaita> if not a security issue, we can discuss at the PTG also 14:58:52 <rosmaita> whoami-rajat: will do 14:59:01 <whoami-rajat> thanks 14:59:25 <whoami-rajat> will take a look at the security issue though I'm not super familiar with it 14:59:41 <fungi> thanks for the reminder. more generally, cinder-coresec feedback is encouraged on the other private security bugs for cinder and its deliverables 14:59:41 <whoami-rajat> we've 3 review patches from otureachy members in the review request section 14:59:45 <whoami-rajat> please take a look at them 15:00:37 <whoami-rajat> we're out of time now, thanks everyone for attending and also making 2023.1 a successful cycle 15:00:40 <whoami-rajat> see you all at the PTG! 15:00:43 <whoami-rajat> #endmeeting