14:00:40 <whoami-rajat> #startmeeting cinder
14:00:40 <opendevmeet> Meeting started Wed Sep 20 14:00:40 2023 UTC and is due to finish in 60 minutes.  The chair is whoami-rajat. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:40 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:40 <opendevmeet> The meeting name has been set to 'cinder'
14:00:44 <whoami-rajat> #topic roll call
14:00:55 <jayaanand> hi
14:00:55 <simondodsley> o/
14:00:58 <Saikumar> o/
14:00:59 <happystacker> o/
14:00:59 <felipe_rodrigues> o/
14:01:11 <thiagoalvoravel> o/
14:01:14 <msaravan> o/
14:01:19 <rosmaita> o/
14:01:25 <eharney> o/
14:01:28 <jungleboyj> o/
14:02:08 <whoami-rajat> #link https://etherpad.opendev.org/p/cinder-bobcat-meetings
14:03:39 <whoami-rajat> hello everyone
14:03:53 <whoami-rajat> let's get started
14:03:57 <whoami-rajat> #topic announcements
14:04:02 <whoami-rajat> first, RC1 released
14:04:07 <whoami-rajat> #link https://review.opendev.org/c/openstack/releases/+/894649
14:04:13 <whoami-rajat> #link https://pypi.org/project/cinder/23.0.0.0rc1/
14:04:58 <whoami-rajat> we have released RC1 but we have patches that we are targeting for RC2, which will we discuss later during the meeting
14:05:10 <whoami-rajat> next, TC + PTL elections voting (last day)
14:05:15 <whoami-rajat> #link https://lists.openstack.org/pipermail/openstack-discuss/2023-September/035150.html
14:05:48 <whoami-rajat> today is the last day for voting
14:05:56 <whoami-rajat> since the email with voting link is personalized, you might have receive a mail from civs@cornell.edu
14:06:09 <whoami-rajat> the deadline is Sep 20, 2023 23:45 UTC
14:06:53 <whoami-rajat> so timely vote for the TC members and openstack Helm PTL (if you actively contribute to that project)
14:07:58 <whoami-rajat> next, Created 2024.1 spec directory
14:08:03 <whoami-rajat> #link https://review.opendev.org/c/openstack/cinder-specs/+/895889
14:08:37 <whoami-rajat> we still have time for 2023.2 release but I've pro actively created the spec dir (since i was planning to re propose the quota spec)
14:09:11 <whoami-rajat> i think there shouldn't be any concerns merging this before the release since it's branchless and the patch just creates a new directory
14:09:23 <liuc49_> `1zjbj9mhm9nhn8**--+
14:09:24 <liuc49_> \
14:09:37 <liuc49_> +-++++++++++++++++++
14:09:46 <whoami-rajat> once that merges, we can start proposing specs for 2024.1 caracal in that directory
14:10:39 <whoami-rajat> liuc49_, i am assuming that wasn't intended for this channel :)
14:11:02 <whoami-rajat> so yeah if the patch looks good, cores can take a look ^
14:11:18 <liuc49_> sorry, my keyboard has some problem.
14:11:52 <whoami-rajat> also while adding the 2024.1 directory, i found out that the placeholder was never removed from the 2023.2 dir and we had specs merged into it
14:11:56 <whoami-rajat> so here is a patch to clean up that
14:11:58 <whoami-rajat> #link https://review.opendev.org/c/openstack/cinder-specs/+/895890
14:12:02 <whoami-rajat> liuc49_, no worries!
14:12:36 <rosmaita> wow, did we really have no specs proposed for 2023.1 ?
14:13:02 <simondodsley> OK - I just approved and +W that spec cleanup patch
14:14:06 <whoami-rajat> rosmaita, looks like it
14:14:08 <whoami-rajat> simondodsley, thanks!
14:15:25 <rosmaita> simondodsley: go ahead and hit the other one, too, no reason to wait
14:16:05 <whoami-rajat> wow, that was quick, thanks rosmaita and simondodsley
14:16:26 <rosmaita> :D
14:16:29 <simondodsley> Happy to oblige
14:16:37 <jungleboyj> :-)
14:17:05 <whoami-rajat> ok, finally we have some upcoming deadlines
14:17:06 <whoami-rajat> Final RC deadline: September 28th, 2023 (R-1 week)
14:17:07 <whoami-rajat> Final 2023.2 Bobcat release: October 4th, 2023
14:17:07 <whoami-rajat> 2024.1 Caracal Virtual PTG - October 23-27, 2023
14:17:28 <whoami-rajat> we have some work for RC2 but nothing much for the others, just a reminder
14:18:05 <whoami-rajat> another thing I'm planning to do every week is a reminder for adding topics for PTG so people don't forget we have an upcoming PTG
14:18:30 <simondodsley> The 2 Pure patches now have 2023.2 backports now - Is there an etherpad with 2023.2 backports to review?
14:18:45 <whoami-rajat> here is the link to the planning etherpad
14:18:47 <whoami-rajat> #link https://etherpad.opendev.org/p/caracal-ptg-cinder-planning
14:19:34 <whoami-rajat> simondodsley, it's on the same etherpad, see line 36 and 41
14:19:36 <whoami-rajat> https://etherpad.opendev.org/p/cinder-bobcat-rc-patches
14:19:57 <whoami-rajat> we are going to discuss that in the topic but before that
14:20:03 <whoami-rajat> does anyone have anything else to announce?
14:23:06 <whoami-rajat> ok, let's move to topics
14:23:28 <whoami-rajat> #topic Patches for RC2
14:23:34 <whoami-rajat> #link https://etherpad.opendev.org/p/cinder-bobcat-rc-patches
14:24:10 <whoami-rajat> Following patches have merged but no backports for 2023.2 have been proposed
14:24:20 <whoami-rajat> the first 2 pure patches have a backport now
14:24:28 <whoami-rajat> we still need backport for
14:24:28 <whoami-rajat> Dell: Dell PowerStore [DOC] : Correct PowerStore NFS driver document to support extending volume
14:24:29 <whoami-rajat> https://review.opendev.org/c/openstack/cinder/+/893330
14:24:29 <whoami-rajat> [Nimble] Enable thin provisioning as default
14:24:29 <whoami-rajat> https://review.opendev.org/c/openstack/cinder/+/883184
14:25:18 <happystacker> I have one patch which keeps on failing https://review.opendev.org/c/openstack/cinder/+/887081
14:25:22 <whoami-rajat> simondodsley, I've added the backports to the patches on L#36 and L#41
14:26:21 <raghavendrat> i will submit backport for: [Nimble] Enable thin provisioning as default
14:26:25 <whoami-rajat> happystacker, we can discuss that but i was planning to address the patches one by one
14:26:50 <whoami-rajat> raghavendrat, thanks
14:27:07 <happystacker> ok whoami-rajat
14:27:50 <whoami-rajat> now the following patches need review
14:27:55 <whoami-rajat> 1. Dell:Generic NFS - Implement disk format validation in volume metadata
14:27:59 <whoami-rajat> #link https://review.opendev.org/c/openstack/cinder/+/887081
14:29:25 <whoami-rajat> happystacker, as i can see in the logs, the error is introduced by your patch
14:29:26 <whoami-rajat> Sep 20 11:20:53.699478 np0035300348 cinder-volume[87445]: ERROR oslo_messaging.rpc.server sqlalchemy.exc.InvalidRequestError: Invalid expression type: 'admin_metadata'
14:29:28 <eharney> i pointed out an issue in this one, need to follow up on the state of that now
14:30:00 <happystacker> where did you get that error from?
14:30:11 <whoami-rajat> eharney, ack, sounds good
14:30:15 <happystacker> wasn't unable to root cause it
14:30:15 <whoami-rajat> happystacker, c-vol logs
14:30:20 <whoami-rajat> https://f0a7a1b83275e65c79fc-5b3bf89a3c3f441361bcb66efd5a8121.ssl.cf2.rackcdn.com/887081/6/check/devstack-plugin-nfs-tempest-full/7bac588/controller/logs/screen-c-vol.txt
14:30:25 <happystacker> oh ok let me see
14:32:50 <happystacker> did you see that patch from sofia's which was skipped?
14:35:10 <whoami-rajat> happystacker, which patch? -- not sure if the message was for me
14:35:36 <happystacker> https://review.opendev.org/c/openstack/cinder/+/749155
14:36:31 <happystacker> this was about luks encryption when creating an volume from image which sets the img as luks
14:36:56 <happystacker> instead a luks device encapsultaed into a qcow2 img
14:37:05 <liuc49_> I have one patch that needs one core reviewer: https://review.opendev.org/c/openstack/os-brick/+/885772
14:38:25 <whoami-rajat> happystacker, ok, I'm not sure about that
14:38:47 <happystacker> it seems that we missed it and I hit the issue while testing my patch
14:41:21 <whoami-rajat> ok, i can see the discussion on the patch
14:41:42 <whoami-rajat> let's first quickly go through other patches since we have limited time
14:41:54 <happystacker> np whoami-rajat
14:42:12 <whoami-rajat> 2. Dell: Dell PowerFlex : password appears in plain text when creating a volume from an image
14:42:14 <whoami-rajat> #link https://review.opendev.org/c/openstack/os-brick/+/885979
14:42:40 <whoami-rajat> I've reviewed it and looks good, need another reviewer to take a look
14:42:48 <eharney> i've looked over this, but never voted on it, i can do that
14:42:57 <whoami-rajat> great, thanks eharney !
14:43:10 <happystacker> thks eharney
14:44:34 <eharney> should abandon the related oslo.privsep change that isn't needed: https://review.opendev.org/c/openstack/oslo.privsep/+/884344
14:45:31 <happystacker> I'll ask the owner to do it
14:46:05 <whoami-rajat> great, moving on
14:46:07 <whoami-rajat> 3. Dell PowerFlex: Unnecessary login happen
14:46:11 <whoami-rajat> #link https://review.opendev.org/c/openstack/os-brick/+/876284
14:46:28 <whoami-rajat> this had a comment from rosmaita which i think is addressed in a new PS
14:46:32 <whoami-rajat> at least the PS is updated
14:46:36 <whoami-rajat> so need another look
14:46:42 <rosmaita> yeah, i have a question about that whole patch though
14:46:58 <rosmaita> maybe it could be addressed by a comment in the launchpad bug
14:47:28 <rosmaita> i don't see how the patch addresses the bug
14:47:33 <rosmaita> "During an API Call, os-brick never saved the token used for authentication which triggers unnecessary login to PowerFlex storage system. This token needs to be tested and if it exists, it is saved for future usage."
14:48:01 <rosmaita> i haven't had time to dig in and see how this caching is happening
14:48:15 <rosmaita> must be somewhere else, because the code change is just a one line thing on the latest PS
14:48:31 <rosmaita> would be helpful to have a pointer to how/why this fixes the issue
14:48:45 <rosmaita> would speed up my reviewing process
14:49:00 <rosmaita> (that's all from me)
14:49:41 <whoami-rajat> thanks rosmaita
14:49:48 <whoami-rajat> I've left a comment on the patch in the meantime
14:50:09 <whoami-rajat> but i agree, it's better to explain how we are fixing the actual issue of caching
14:51:26 <whoami-rajat> so currently the ask is to update the commit message to point out how we are actually fixing the issue with the current changes
14:51:41 <rosmaita> yeah, this is one of those tiny patches that eats a lot of review time
14:52:20 <happystacker> it shouldn't, I'll take care of this moving forward
14:53:56 <rosmaita> thanks!
14:53:59 <whoami-rajat> yes, and it's a good point to highlight that this is a vendor specific connector, which is not part the core cinder code that we deal with most of the time
14:54:00 <whoami-rajat> so the workflow is not known to us, to avoid review time, it's best to be verbose about the problem and solution
14:54:19 <whoami-rajat> thanks happystacker and thanks rosmaita
14:54:27 <whoami-rajat> moving on
14:54:31 <whoami-rajat> 4. [HPE 3par] Fix issue seen during retype/migrate
14:54:35 <whoami-rajat> #link https://review.opendev.org/c/openstack/cinder/+/887559
14:54:44 <raghavendrat> hi
14:54:51 <whoami-rajat> hey
14:55:57 <whoami-rajat> so this is a big patch
14:56:11 <raghavendrat> hhmm. i tried to address comments in new patch set. zuul has passed
14:56:18 <whoami-rajat> which is addressing multiple cases
14:56:28 <whoami-rajat> raghavendrat, thanks i will take another look
14:56:48 <whoami-rajat> so yeah, this needs reviews
14:57:11 <whoami-rajat> let's quickly go through the final patch
14:57:12 <whoami-rajat> 5. Dell: Dell PowerFlex [os-brick] - Rescue instance failing with PowerFlex 4.x
14:57:17 <whoami-rajat> #link https://review.opendev.org/c/openstack/os-brick/+/885772
14:57:38 <whoami-rajat> the patch looks good, it's handling a new error code returned from the powerflex 4.x array
14:57:44 <whoami-rajat> though I'm skeptical about the UTs
14:57:53 <whoami-rajat> since the one with disconnect also worked
14:58:27 <eharney> disconnect?
14:58:28 <whoami-rajat> but the code looks good and is being tested with the dell powerflex CI
14:58:51 <whoami-rajat> eharney, it was on a previous PS, https://review.opendev.org/c/openstack/os-brick/+/885772/1/os_brick/tests/initiator/connectors/test_scaleio.py#315
15:00:27 <whoami-rajat> we are out of time
15:00:35 <whoami-rajat> please add topics for the 2024.1 caracal PTG
15:00:45 <whoami-rajat> and also take a look at the review request section
15:00:48 <whoami-rajat> thanks everyone for attending
15:00:51 <whoami-rajat> have a great day!
15:00:54 <whoami-rajat> #endmeeting