15:02:16 <enriquetaso> #startmeeting cinder_bs
15:02:17 <openstack> Meeting started Wed Mar 24 15:02:16 2021 UTC and is due to finish in 60 minutes.  The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:02:18 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:02:20 <openstack> The meeting name has been set to 'cinder_bs'
15:02:23 <enriquetaso> #topic roll call
15:02:31 <enriquetaso> o/
15:02:54 <enriquetaso> :P
15:02:59 <enriquetaso> #link https://etherpad.opendev.org/p/cinder-bug-squad-meeting
15:03:08 <rosmaita> o/
15:03:18 <enriquetaso> nobody is around ha
15:03:27 <enriquetaso> Today we have a short meeting therefore I would like to resume the discussion at the meeting earlier.
15:03:43 <rosmaita> well, geguileo and whoami-rajat need to fight it out over that volume-show by name bug
15:03:48 <enriquetaso> #topic bug_1: "Cannot show volumes with name for non-admins"
15:04:04 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1917574
15:04:06 <openstack> Launchpad bug 1917574 in Cinder "cannot show volumes with name for non-admins" [High,In progress] - Assigned to Rajat Dhasmana (whoami-rajat)
15:04:13 <enriquetaso> Summary:  client doesn't know if the user is admin or not.  We've fixed similar issues before for reverting to snapshot and transfer show by name.
15:04:22 <enriquetaso> whoami-rajat, geguileo Would you like to add some comments so that it is clearer to review the patch?
15:06:01 <enriquetaso> probably looking for coffee, the previous meeting was very interesting :P
15:06:07 <rosmaita> :D
15:07:12 <enriquetaso> In the meantime, I was looking at old bugs and closing those that were already fixed a while ago. As the case of: https://bugs.launchpad.net/python-cinderclient/+bug/1866376. But there is still a lot of work to do.
15:07:14 <openstack> Launchpad bug 1866376 in python-cinderclient "doc: Functional Tests in python-cinderclient" [Low,Fix released] - Assigned to Tushar Trambak Gite (tushargite96)
15:08:19 <whoami-rajat> enriquetaso: sorry i got involved somewhere
15:08:30 <enriquetaso> :D
15:09:01 <whoami-rajat> the basic summary is, cinderclient sends all_tenants=1 for admins/non-admins
15:09:20 <whoami-rajat> i don't exactly remember why we're not removing that from client side but the API side fix is the one I've proposed
15:09:26 <whoami-rajat> and we've followed the same approach before
15:12:53 <enriquetaso> OK, guess that gorka can comment on the patch later
15:13:21 <enriquetaso> thanks whoami-rajat
15:13:24 <rosmaita> i left some comments on the patch
15:13:58 <rosmaita> i sort of remember that server-side fix, but somehow it seemed to be a different problem
15:14:13 <rosmaita> or i am thinking of the wrong thing entierly, which is also possible
15:15:05 <rosmaita> i have to admit, my brain is fried
15:15:30 <enriquetaso> don't worry :P
15:15:52 <enriquetaso> thanks rosmaita
15:15:53 <whoami-rajat> thanks rosmaita and please take some rest :D you're overworking (if that's a word)
15:15:57 <rosmaita> whoami-rajat: this patch is tangentially related to yours: https://review.opendev.org/c/openstack/cinder/+/765694
15:16:14 <rosmaita> but it has a similar v2/v3 issue, i think
15:16:20 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder/+/765694
15:16:48 <enriquetaso> #topic bug_2: "Retype of in use Hyperswap volume failing"
15:17:04 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1920890
15:17:06 <openstack> Launchpad bug 1920890 in Cinder "Retype of in use Hyperswap volume failing" [Undecided,Incomplete]
15:17:17 <whoami-rajat> rosmaita: will take a look
15:17:26 <enriquetaso> Summary: Retype in use volume is falling, from IBM SVC to Hyperswap. I've left a comment asking for the error they're facing.
15:17:26 <enriquetaso> Question: Do we support *in use* retyping or this should be falling with an handled error?
15:17:28 <rosmaita> when you have some time, not a rush
15:18:18 <eharney> i think this is a driver bug written by one of the driver maintainers
15:18:21 <eharney> presumably they will submit a patch
15:18:47 <enriquetaso> oh OK
15:18:56 <eharney> https://review.opendev.org/c/openstack/cinder/+/782390
15:19:10 <enriquetaso> cool
15:19:18 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder/+/782390
15:19:19 <eharney> btw, what's the whole story with gerrit no longer updating launchpad?  is it just like that forever now?
15:19:25 <rosmaita> eharney: in general, about in use retyping ... do we support that as long as it is only a DB thing, not a migration?
15:19:46 <rosmaita> not sure, i will check the gerrit problems etherpad
15:19:55 <rosmaita> it may be a conspiracy to make us use storyboard
15:19:58 <enriquetaso> not sure about fixing launchpad, haven't read anything about it on the mailling list
15:20:22 <eharney> rosmaita: it's supported for migration too, right?
15:20:45 <rosmaita> maybe?
15:22:36 <rosmaita> eharney: looks like maybe there are some patches to get launchpad integration working again
15:22:48 <rosmaita> https://etherpad.opendev.org/p/gerrit-3.2-post-upgrade-notes
15:22:48 <enriquetaso> yay
15:23:01 <rosmaita> lines 62-71
15:23:46 <enriquetaso> Finally, I think it's a good time to bring back the next bug report:
15:23:54 <enriquetaso> #topic bug_3: "Add volume to a group which was created from a group snapshot of another consistency group fails and the group goes into error state"
15:24:01 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1920912
15:24:02 <openstack> Launchpad bug 1920912 in Cinder "add of volume to a group which was created from group snapshot of another consistency group fails and group goes into error state" [Undecided,New]
15:24:13 <enriquetaso> I am not very familiar with consistency groups so I need help to know the importance of it.
15:25:34 <eharney> sounds like a driver bug
15:27:02 <enriquetaso> cool
15:27:13 <enriquetaso> #topic Open Discussion
15:27:20 <enriquetaso> thanks eharney
15:28:11 <rosmaita> i get these all confused, is storwize different from SVF ?
15:28:46 <eharney> i guess not if you query for  https://review.opendev.org/q/project:openstack/cinder+status:open+file:cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py
15:29:07 <eharney> that's.. a lot of storwize/svf patches hanging there
15:29:15 <rosmaita> yeah
15:29:28 <rosmaita> enriquetaso: i guess tag it both storwize and svf
15:29:41 <rosmaita> and i guess svc too while you're at it
15:29:52 <rosmaita> and ibm
15:30:00 <rosmaita> one of those should get someone's attention
15:30:10 <enriquetaso> sure
15:30:28 <eharney> https://bugs.launchpad.net/cinder/  shows 114 with tag "drivers" and 22 with tag "driver"
15:30:29 <eharney> hrm
15:31:41 <enriquetaso> need to be unify
15:32:02 <enriquetaso> what should be the correct tag? grammar speaking
15:32:08 <rosmaita> TIL there are official tags you can edit!
15:32:20 <enriquetaso> :o
15:33:06 <enriquetaso> rosmaita, can I do un-critical https://bugs.launchpad.net/cinder/+bug/1832164 ?
15:33:08 <openstack> Launchpad bug 1832164 in Cinder "SADeprecationWarning: The joinedload_all() function is deprecated, and will be removed in a future release. Please use method chaining with joinedload() instead" [Critical,In progress] - Assigned to Gorka Eguileor (gorka)
15:33:08 <rosmaita> although the editing does not include deletion
15:33:34 <rosmaita> sure
15:33:48 <rosmaita> though i thought that merged already
15:34:11 <enriquetaso> #action (enriquetaso) edit official tags
15:34:31 <enriquetaso> it is!
15:34:40 <enriquetaso> OK, thanks!!
15:34:42 <enriquetaso> #endmeeting