14:41:13 <enriquetaso> #startmeeting cinder_bs
14:41:13 <opendevmeet> Meeting started Wed Nov  3 14:41:13 2021 UTC and is due to finish in 60 minutes.  The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:41:13 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:41:13 <opendevmeet> The meeting name has been set to 'cinder_bs'
14:41:21 <enriquetaso> Welcome back to the bug meeting.
14:41:21 <rosmaita> o/
14:41:30 <enriquetaso> You can check the full bug report in the next link
14:41:30 <enriquetaso> #link http://lists.openstack.org/pipermail/openstack-discuss/2021-November/025657.html
14:41:35 <enriquetaso> hello
14:41:48 <enriquetaso> Five new bugs reported this period and one that I'd like to bring to your attention.
14:41:55 <enriquetaso> #topic bug_1 No available space check for image_conversion_dir in cinder-volume on upload-to-image
14:42:07 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1798589
14:42:08 <enriquetaso> image_conversion_dir of the cinder-volume service can be filled up while performing upload-to-image of the large volume, because there is no check_available_space() being executed during this operation.
14:42:32 <enriquetaso> Looks like this is a limitation acknowledge :
14:42:32 <enriquetaso> #link https://opendev.org/openstack/cinder/src/branch/master/cinder/image/image_utils.py#L326-L328
14:42:32 <enriquetaso> Since this is an old bug, maybe we already discussed this and it's not a valid bug. However, I think this bug is valid and we could add  check_available_space() to check the space before converting.
14:43:19 <enriquetaso> In addition, check_available_space() is performed while creating a volume from an image. I'm 100% sure we can use it in this case.
14:43:19 <enriquetaso> #link https://opendev.org/openstack/cinder/src/branch/master/cinder/image/image_utils.py#L892
14:44:38 <eharney> yeah, we've seen this problem come up a few times, we should add a check for this
14:44:47 <jungleboyj> ++
14:44:59 <rosmaita> makes sense
14:45:12 <enriquetaso> cool, I can work on this
14:45:18 <enriquetaso> Just for the recording:
14:45:19 <enriquetaso> - bug for create volume from large image fails due to incorrect space check:
14:45:19 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1756425
14:45:19 <enriquetaso> - Do not check available space for image conversion on block devices
14:45:19 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder/+/633500
14:45:52 <enriquetaso> #action(enriquetaso): add a check for upload-to-image
14:45:55 <enriquetaso> thanks!
14:46:16 <enriquetaso> moving on
14:46:49 <enriquetaso> #topic bug_2 can't restore to a volume from a different az -  cinder backup tries to restore to the wrong host
14:46:49 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1949313
14:47:11 <enriquetaso> c-vol: ceph
14:47:11 <enriquetaso> c-bak: Swift
14:47:12 <enriquetaso> Summary: restore volume by creating a new volume and passing in backup id and az1 (or az2, doesn't matter) - this will go to error_restoring 50% of the time. The volume is created at az1 and then logs: Backend does not support creating volume from backup 967f369f-c269-4393-aebb-14d570cc3baa. It will directly create the raw volume at the backend and then schedule the request to the backup service to restore the volume with backup.
14:47:12 <enriquetaso> I haven't check to see what happens using diff c-bak backend
14:47:13 <enriquetaso> Fix proposed to master
14:47:15 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder/+/816104
14:47:56 <enriquetaso> looks like a valid bug
14:48:12 <enriquetaso> please feel free to review the fix :)
14:49:12 <rosmaita> nice, the bug filer also proposed a fix
14:49:29 <enriquetaso> yes, moving on.. only 2 left
14:49:40 <enriquetaso> #topic bug_3 Cinder can't manage external NFS share because generic-nfs doesn't have the manage_existing_get_size method
14:49:40 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1949189
14:49:40 <enriquetaso> I was wondering why this hasn't popped up earlier. Maybe it's not common to manage external shares.
14:49:40 <enriquetaso> It doesn't have a fix yet.
14:50:00 <enriquetaso> we can add this one to nfs bug list eharney :(
14:50:39 <eharney> it's a known feature limitation
14:51:09 <eharney> i think..
14:52:07 <enriquetaso> OK
14:52:28 <enriquetaso> well, i guess there's no more to do, just fix it
14:53:04 <enriquetaso> last one:
14:53:12 <enriquetaso> #topic bug_4 Error when deleting encrypted volume backup from another project
14:53:13 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1946483
14:53:13 <enriquetaso> Fix is proposed here
14:53:13 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder/+/813191
14:53:32 <enriquetaso> 1. user creates encrypted volume (https://docs.openstack.org/cinder/latest/configuration/block-storage/volume-encryption.html)
14:53:32 <enriquetaso> 2. user creates backup from this encrypted volume
14:53:32 <enriquetaso> 3. admin user (logged into admin project) tries to delete that backup
14:54:07 <enriquetaso> The reporter presume that in other places this code is executed when such loading has already happened (like in cinder-api on volume delete, where [keystone_authtoken] section was naturally processed already and the required plugin was already properly loaded in order to validate the incoming request in the first place), however with backups, this function is called from the cinder-backup that has not loaded anything (yet?).
14:54:26 <enriquetaso> Feel free to review the fix :)
14:55:27 <rosmaita> looks like eric already took a look on an earlier patch set
14:56:28 <enriquetaso> true, thanks eric
14:56:28 <eharney> yeah, i'm not an expert on this, but it looks reasonable
14:56:53 <enriquetaso> well, that's all i have for today's meeting
14:57:11 <rosmaita> i'll put it on my list
14:57:21 <rosmaita> thanks sofia
14:57:33 <enriquetaso> #topic open discussion
14:57:41 <enriquetaso> thanks brian
14:58:02 <enriquetaso> we have 3 minutes to get a coffee before the other meeting
14:58:07 <enriquetaso> 2
14:58:10 <rosmaita> nothing from me, other than nice work setting up the bug squad meeting sofia
14:58:19 <enriquetaso> thanks everyone !
14:58:29 <enriquetaso> #endmeeting