15:00:43 <enriquetaso> #startmeeting cinder_bs
15:00:43 <opendevmeet> Meeting started Wed Sep 14 15:00:43 2022 UTC and is due to finish in 60 minutes.  The chair is enriquetaso. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:43 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:43 <opendevmeet> The meeting name has been set to 'cinder_bs'
15:00:57 <enriquetaso> Hello, welcome to the bug meeting
15:01:25 <enriquetaso> #topic  Wrong assertion methods in unit tests
15:01:31 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1989280
15:02:01 <whoami-rajat> hi
15:02:05 <enriquetaso> Unittest fix for cinder and other projects:
15:02:09 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder/+/856971
15:02:26 <enriquetaso> I think we still need a fix for os-brick, cinderclient unit tests.
15:02:38 <enriquetaso> Do we have any volunteers? :P
15:03:03 <eharney> the os-brick fix is https://review.opendev.org/c/openstack/os-brick/+/857044
15:05:11 <enriquetaso> oh cool
15:06:15 <rosmaita> there seems to be an awful lot going on in that cinder patch
15:06:43 <eharney> hmm.. there does
15:07:29 <eharney> bad conflict resolution?
15:08:21 <rosmaita> not sure, i just looked at the first file and decided that i don't want to look any further
15:09:26 <rosmaita> especially because that particular issue mentioned in the bug only seems to occur in 2 files
15:09:47 <eharney> yeah it's reverting another change
15:11:13 <enriquetaso> OK, i can mentioned that on the cinder patch, maybe should be split in smaller changes
15:11:23 <eharney> it doesn't need to be split into smaller changes
15:11:28 <eharney> it just needs to not have accidental changes in it
15:11:32 <eharney> i already -1'd it
15:12:01 <enriquetaso> os-brick patch looks fine to me
15:12:08 <enriquetaso> thanks eharney
15:14:18 <rosmaita> yeah, that's the downside of mocks ... you can call any method on them, and they don't complain
15:14:37 <eharney> i've looked into to some ways to prevent this with mock sealing, it's possible, but generally takes a lot of extra work
15:14:47 <eharney> (calling mock.seal everywhere)
15:15:11 <eharney> i've prototyped some ways to get that to happen automatically, but it's tricky
15:15:46 <rosmaita> i wonder if we could add that to the mock_object method in the cinder.tests.unit.test.TestCase class
15:15:58 <rosmaita> (i say that knowing absolutely nothing about mock.seal)
15:16:09 <eharney> it depends on how people use the mock in the tests, a lot of them rely on being able to change mocks further inside the test
15:16:37 <rosmaita> ok
15:17:54 <rosmaita> (enriquetaso: i have to leave early today, will be afk for 2 hours or so)
15:18:01 <enriquetaso> i think worth looking into this, we may need to discuss this further
15:18:12 <enriquetaso> sure rosmaita, this is the big topic for today's
15:18:59 <enriquetaso> OK, moving on, we have 6 bugs for today's meeting
15:19:06 <enriquetaso> i forgot to mentioned:
15:19:09 <enriquetaso> #link https://lists.openstack.org/pipermail/openstack-discuss/2022-September/030463.html
15:19:28 <enriquetaso> #topic revert_snapshot_will_destory_attachment_with_lvm_backend
15:19:35 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1989271
15:19:37 <enriquetaso> Summary:
15:19:42 <enriquetaso> 1.using lvm as cinder volume backend.
15:19:42 <enriquetaso> 2.create a volume and attach the volume to a VM,
15:19:42 <enriquetaso> 3.then create a snapshot of the volume
15:19:42 <enriquetaso> 4.revert the snapshot of the volume, the VM will be crashed
15:19:42 <enriquetaso> The reason why this happening is that lvm can not revert the snapshot in backend when lvm is using thin_proversion.
15:19:44 <enriquetaso> So ,it will using the _revert_to_snapshot_generic function to revert the snapshot.
15:20:15 <eharney> this seems important but the commit message needs a little work to explain what is happening
15:20:24 <enriquetaso> Fix proposed to master, but zuul is failing because of unit test.
15:20:25 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder/+/856941
15:20:35 <eharney> (and to fix formatting etc)
15:20:46 <enriquetaso> yes, it's something we would like to have for tomorrow's deadline
15:21:11 <eharney> i would assume we'll just backport this later
15:21:11 <enriquetaso> i'll add a comment for the commit msg
15:21:22 <enriquetaso> yes
15:21:25 <enriquetaso> OK
15:21:46 <enriquetaso> #topic Failed to set image property. Invalid input for field/attribute simplestreams_metadata. Value: ... is too long (HTTP 400)
15:21:51 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1988942
15:21:56 <enriquetaso> The reporter has an error message when setting a long simplestreams_metadata  to a volume. "badRequest": {"code": 400, "message": "Invalid input for field/attribute simplestreams_metadata" is too long (HTTP 400).
15:22:02 <enriquetaso> Simplestream is a 'protocol' for describing what virtual machine images exist on an http(s) repository. And as far as I can tell Glance uses it to Implement automatic Glance image updates:
15:22:02 <enriquetaso> https://docs.openstack.org/charm-guide/latest/admin/ops-auto-glance-image-updates.html
15:22:16 <enriquetaso> I'm not sure about the input the reporter use to try it without simplestreams and see if this is a cinder issue or a  simplestreams feature problem.
15:22:27 <eharney> this looks like a request to expand a metadata field size
15:22:31 <enriquetaso> Please let me know if you have faced this error before or if you have any thoughts regarding this so I can update the bug report.
15:22:46 <enriquetaso> is a request or a bug?
15:23:16 <eharney> it looks more like they are hitting a set limitation, not really a bug, but something we should evaluate
15:23:48 <enriquetaso> makes sense
15:23:51 <eharney> it would benefit from a more clear report and explanation of their use case
15:24:10 <enriquetaso> I'll move it to whist list
15:24:35 <enriquetaso> yes
15:24:45 <enriquetaso> i can ask for that
15:25:31 <enriquetaso> OK. Last two bugs
15:25:37 <enriquetaso> #topic Hitachi driver: no message for resource lock
15:25:44 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1989176
15:25:44 <enriquetaso> There's a minimal command problem in the code and the logs are not displaying correctly.
15:25:44 <enriquetaso> Fix proposed to master (it's a XS fix)
15:25:44 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder/+/856385
15:26:00 <eharney> already approved
15:26:00 <enriquetaso> mentioned in the cinder main meeting ^ it's a really small fix
15:26:09 <enriquetaso> fast :D
15:26:13 <enriquetaso> Last bug:
15:26:19 <enriquetaso> #topic  IPV6 with lightos driver wont work
15:26:23 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1989281
15:26:29 <yuval> o/
15:26:34 <enriquetaso> no bug fix proposed yet
15:26:40 <enriquetaso> hello yuval
15:26:45 <eharney> https://review.opendev.org/c/openstack/cinder/+/839768 is the bugfix
15:26:54 <enriquetaso> sorry
15:26:55 <yuval> hey there is a patch up
15:27:02 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder/+/839768
15:27:13 <eharney> yuval: it would be better to fix the commit message so the patch links to the bug report
15:27:32 <yuval> got it
15:27:49 <enriquetaso> excellent
15:27:57 <yuval> if I update the commit now - It can still meet the deadline?
15:28:15 <eharney> i don't know if anyone is going to review this today, but it's easily backportable
15:29:07 <yuval> I would really prefer not to reach there
15:30:19 <enriquetaso> OK, we are running out of time
15:30:29 <enriquetaso> thank you for joining!
15:30:32 <eharney> we also have https://bugs.launchpad.net/cinder/+bug/1989514
15:30:53 <enriquetaso> oh, I lost that one
15:30:57 <eharney> i need to dig into this one, looks important for NFS
15:31:00 <enriquetaso> #topic  NFS volume snapshot does not update volume attachment format to qcow2
15:31:08 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1989514
15:31:51 <opendevreview> yuval proposed openstack/cinder master: lightos: parse urls with urlparse for ipv6 support  https://review.opendev.org/c/openstack/cinder/+/839768
15:31:59 <yuval> the commit is updated
15:32:01 <enriquetaso> Summary They found that after performing a volume snapshot on a stopped instance, that instance could no longer boot.
15:32:30 <enriquetaso> thanks yuval, i'll review it once zuul vote
15:32:39 <yuval> Thanks
15:32:56 <enriquetaso> eharney, I going to take a look to it, since i'm working with nfs right now.
15:33:04 <eharney> cool
15:33:21 <enriquetaso> This reminds me that i haven't check this scenario with encryption NFS
15:33:35 <eharney> https://review.opendev.org/c/openstack/cinder/+/762462 is doing something related, probably worth touching on while looking at this
15:33:40 <enriquetaso> whoami-rajat, feel free to re review https://review.opendev.org/c/openstack/cinder/+/839768 if you have time :D
15:33:45 <eharney> well, i think that is where this report came from
15:33:59 <eharney> er, no, it's not, sorry
15:34:01 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder/+/762462
15:34:04 <enriquetaso> oh
15:34:45 <enriquetaso> #link https://review.opendev.org/c/openstack/cinder/+/857528
15:35:41 <enriquetaso> #topic open discussion
15:36:05 <enriquetaso> Feel free to proposed bugs to discuss now
15:39:26 <enriquetaso> OK, looks like we don't have any other bug
15:39:41 <enriquetaso> or a bug that i forgot to include to the email bug report
15:40:01 <enriquetaso> Thank you for joining
15:40:05 <enriquetaso> #endmeeting