16:00:14 <ildikov> #startmeeting cinder-nova-api-changes
16:00:15 <openstack> Meeting started Thu Jun  1 16:00:14 2017 UTC and is due to finish in 60 minutes.  The chair is ildikov. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:16 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:18 <openstack> The meeting name has been set to 'cinder_nova_api_changes'
16:00:25 <ildikov> DuncanT ameade cFouts johnthetubaguy jaypipes takashin alaski e0ne jgriffith tbarron andrearosa hemna erlon mriedem gouthamr ebalduf patrickeast smcginnis diablo_rojo gsilvis  xyang1 raj_singh lyarwood breitz jungleboyj
16:00:27 <mriedem> o/
16:00:47 <jungleboyj> o/
16:01:14 <jgriffith> zOz
16:01:53 <ildikov> good morning :)
16:02:10 <ildikov> let's wait a minute to see if anyone else shows up
16:02:41 <stvnoyes> o/
16:03:10 <ildikov> ok, let's deep dive in :)
16:03:20 <ildikov> so the list of merged patches are looking good: https://review.openstack.org/#/q/topic:bp/cinder-new-attach-apis
16:03:21 <hemna> o/
16:03:52 <ildikov> hemna's os-brick quick fix for the target_lun casting got merged as well IIRC
16:04:20 <ildikov> so we're slowly progressing towards having a working attach PoC
16:04:57 <ildikov> mriedem has patches up to figure out what to do with the microversion discocery
16:04:58 <hemna> I put up a patch to the brick cinderclient extension yesterday
16:05:03 <hemna> that uses the new attach/detach workflow
16:05:17 <smcginnis> hemna: Do you have a link to that?
16:05:20 <ildikov> hemna: do you have a link handy?
16:05:25 <smcginnis> jynx
16:05:32 <ildikov> smcginnis: ;)
16:05:40 <hemna> https://review.openstack.org/#/c/469594/
16:05:50 <ildikov> hemna: tnx
16:08:18 <ildikov> hemna: did you run into any issues to discuss here?
16:08:37 <hemna> not after the fix I put in for the lun id in brick
16:08:47 <ildikov> ok, cool
16:09:22 <ildikov> BTW, how does that work with brick, do we need a release now for that fix?
16:09:55 <mriedem> yes, and min version bump in g-r
16:09:57 <mriedem> if you need nova to use it
16:10:28 <jgriffith> I think that's just the extension no hemna ?
16:10:40 <hemna> jgriffith, correct
16:10:46 <jgriffith> err... you mean the lun-id fix
16:11:09 <hemna> we need a new release of brick yes
16:11:23 <hemna> to get that fix in place and then bump the min version for nova
16:11:36 <mriedem> which is the os-brick patch?
16:11:42 <ildikov> when can we have a release?
16:11:51 <mriedem> https://review.openstack.org/#/c/468108/
16:11:53 <mriedem> right? ^
16:11:59 <hemna> yup
16:12:16 <mriedem> you can propose a release at any point
16:13:57 <ildikov> I was just wondering whether there's anything we're waiting on to get in before releasing or anything like that
16:15:38 <ildikov> hemna: smcginnis: can either of you take care of the brick release to get the fix available?
16:15:45 <smcginnis> There are a bunch of open reviews of os-brick. Probably the only one that might be good to get in first would be for anew connector for lustre.
16:16:08 <smcginnis> But I'm not sure if that has the rest of the things in place that we really need to wait for that.
16:16:23 <hemna> smcginnis, ildikov we can work on finishing up reviews and get a new release out soon
16:16:34 <smcginnis> yep
16:16:51 <ildikov> sounds good, tnx
16:17:36 <ildikov> is there anything with microversions that we should touch base on here?
16:18:01 <ildikov> besides the patches from mriedem I mentioned above
16:18:15 <jgriffith> *should*?
16:18:16 <jgriffith> :)
16:18:27 <mriedem> the attach poc needs to be rebased on those
16:18:29 <ildikov> if there's nothing else with brick beyond, plz review! :)
16:18:43 <jgriffith> We have Cinder side things to discuss, but yeah I think mriedem 's solve the problem for now
16:18:49 <mriedem> i haven't looked at stvnoyes' live migration poc yet
16:18:52 <jgriffith> mriedem yeah, I'll do that this morning
16:19:14 <ildikov> stvnoyes: how's the testing going with that?
16:19:15 <jgriffith> cinder needs to fix the versioning stuff long term though
16:19:17 <mriedem> stvnoyes opened 2 bugs about regressions in rolling back a live migration, one i invalidated since i didn't see the issue in the code, and one i have a fix up for
16:19:19 <ildikov> jgriffith: +1
16:19:44 <stvnoyes> hold off on the migration rv. I found some problems during testing and if i can get devstack working after an update I'll get back to it
16:19:59 <mriedem> ok
16:20:17 <stvnoyes> mriedem: i responded to the bug, it wasn't in my patches
16:20:52 <stvnoyes> there is a problem there, (I checked github)
16:21:47 <mriedem> stvnoyes: ok re-open the bug please
16:22:01 <stvnoyes> and there's a couple of open issues in the PoC that I left comments for. they don't affect attach/detach but I hit them during migrate
16:22:17 <jgriffith> stvnoyes I'll check them out
16:22:20 <stvnoyes> back to New?
16:22:32 <ildikov> stvnoyes: the error handling bits?
16:23:04 <stvnoyes> ok, back to Confirmed...
16:23:37 <stvnoyes> I don't recall exactly how I hit those issue. It could have been during rollback.
16:23:51 <stvnoyes> the PoC issues... ^
16:24:38 <mriedem> stvnoyes: back to new, or just link me
16:25:38 <ildikov> stvnoyes: there are some issues with error handling in that PoC, I found some of those issues as well earlier, but you should not hit them with migrate I would think
16:26:14 <ildikov> stvnoyes: or well, depends on why you're rolling back I guess
16:26:23 <stvnoyes> they were pretty simple bugs, definitely issues
16:28:27 <ildikov> the PoC still needs work, so we'll look into that with jgriffith
16:28:42 <mriedem> ok this one https://bugs.launchpad.net/nova/+bug/1694834
16:28:43 <openstack> Launchpad bug 1694834 in OpenStack Compute (nova) "libvirt rollback: destroy called with wrong number of args" [Undecided,Confirmed]
16:28:56 <stvnoyes> y, that's the one
16:30:09 <mriedem> ok anything else for this meeting?
16:30:23 <ildikov> I think we're mainly good for now
16:30:39 <ildikov> once the attach PoC is in a better shape we can think of how to deal with swap
16:30:44 <ildikov> for the new flow
16:31:18 <ildikov> I would guess the live migrate issues can be dealt with offline in case there are no more confusions on the bug report to discuss
16:31:48 <ildikov> so next steps are to fix the comments in the attach PoC and move it on top of Matt's micrvoersion patches
16:32:07 <ildikov> fix live migrate issues in parallel and get the brick release out as well
16:32:35 <ildikov> so I think we have enough home work for next week
16:33:00 <ildikov> the Cinder side of microversions can also be discussed outside of this meeting
16:33:13 <ildikov> anything else I'm missing?
16:33:25 <ildikov> or that someone would want to raise to discuss?
16:34:13 <ildikov> I take it as a no
16:34:27 <ildikov> thanks all!
16:34:48 <ildikov> keep on reviewing and testing :)
16:34:56 <ildikov> have a good day! :)
16:35:11 <ildikov> #endmeeting