16:00:05 <ildikov> #startmeeting cinder-nova-api-changes
16:00:06 <openstack> Meeting started Thu Jul 20 16:00:05 2017 UTC and is due to finish in 60 minutes.  The chair is ildikov. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:07 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:09 <openstack> The meeting name has been set to 'cinder_nova_api_changes'
16:00:14 <mriedem> o/
16:00:14 <ildikov> johnthetubaguy jaypipes e0ne jgriffith hemna mriedem patrickeast smcginnis diablo_rojo xyang1 raj_singh lyarwood jungleboyj stvnoyes
16:00:22 <stvnoyes> o/
16:00:31 <jungleboyj> o/
16:00:35 <xyang1> Hi
16:00:53 <mgiles> o/
16:00:56 <_pewp_> hemna ( ´ ▽ ` )ﾉ
16:01:23 <ildikov> hi :)
16:01:38 <ildikov> Let's dive in
16:01:53 <ildikov> the current status is here: https://review.openstack.org/#/q/topic:bp/cinder-new-attach-apis
16:02:02 <ildikov> we have three patches in Nova to merge
16:02:15 <ildikov> and a cinderclient issue to sort out
16:02:17 <jungleboyj> @!
16:02:17 <_pewp_> jungleboyj |。･ω･|ﾉ
16:02:27 <jungleboyj> Oh, I didn't know he was in here.  Nice.  :-)
16:02:29 <mriedem> i think it would be a good idea if the top level api change patch depends on this grenade change https://review.openstack.org/#/c/484469/
16:02:44 <mriedem> then i can drop my DNM test patch and we'll still have the testing enforced
16:03:04 <ildikov> mriedem: sure, I didn't add it because of your DNM patch
16:03:29 <mriedem> i'll leave a reminder
16:03:29 <ildikov> will do after the meeting
16:04:00 <ildikov> stvnoyes: I saw you put the live_migrate patch to W -1
16:04:30 <ildikov> stvnoyes: what's the issue with that one?
16:05:26 <stvnoyes> i found an problem in the error path that I've fixed, and I'm updating the unit test now
16:05:52 <stvnoyes> should have an update this afternoon
16:06:04 <ildikov> stvnoyes: ok, sounds good
16:06:19 <mriedem> stvnoyes: ping me when it's updated
16:06:23 <stvnoyes> ok
16:06:23 <mriedem> i'll go through that this afternoon
16:06:27 <ildikov> stvnoyes: anything else to mention about that one here?
16:06:58 <stvnoyes> no, but we will need that client patch tho.
16:07:18 <ildikov> so the cinderclient patch we need is this one: https://review.openstack.org/#/c/485198/
16:07:38 <ildikov> which needs this one to land to get merged: https://review.openstack.org/#/c/485197/
16:07:59 <stvnoyes> i have another nova change in the queue to change a comment that will be incorrect after that cinder change.
16:08:08 <ildikov> jungleboyj: hemna: if you have time to take a look ^^
16:08:27 <mriedem> if those cinderclient changes merge today we'll also want to get a release out
16:08:28 <hemna> ok
16:08:44 <ildikov> stvnoyes: we need  a client release and version bump for that though
16:09:06 <ildikov> mriedem: +1
16:09:07 <hemna> ildikov, on their way now.
16:09:16 <ildikov> hemna: awesome, thanks!
16:09:28 <stvnoyes> ildikov: do you mean for the comment change?
16:09:29 <jungleboyj> ildikov: I will look too.
16:09:35 <ildikov> mriedem: I will ping smcginnis once these landed
16:09:43 <jungleboyj> ildikov:  ++
16:10:22 <jungleboyj> hemna:  Ah, good job.
16:10:38 <ildikov> mriedem: is there anything we could do to get reviews on the remaining two Nova patches?
16:10:53 <ildikov> mriedem: or basically how do you see the way forward here?
16:10:53 <mriedem> i plan on focusing on those this afternoon
16:11:09 <mriedem> the live migration one has had review from stephenfin
16:11:14 <mriedem> so one it's updated he might be good with it
16:11:16 <mriedem> *once
16:11:26 <ildikov> mriedem: sounds good, I will keep an eye on them
16:11:32 <mriedem> i think once i'm good with the api change at the top,
16:11:37 <mriedem> then i can ask sdague to help review it
16:11:41 <ildikov> mriedem: yeah, I hoped if you find it ok too then we kinda get there finally with that one
16:12:05 <stvnoyes> mriedem: i will let you know when I've updated the migration review
16:12:06 <ildikov> mriedem: ok, that sounds good
16:12:07 <mriedem> which nova change depends on the cinderclient patch?
16:12:19 <mriedem> or is it just in general?
16:12:34 <ildikov> mriedem: the API one as that's what's checking the microversion
16:12:38 <stvnoyes> without it, attach is not using the new 3.27 flow
16:12:41 <ildikov> mriedem: so from testing perspective all of them
16:12:45 <mriedem> ok, that will also likely depend on https://review.openstack.org/#/c/485198/ or the g-r min bump for it
16:12:50 <mriedem> ok
16:12:55 <mriedem> i'll make another note for that
16:13:14 <mriedem> stvnoyes: you get the gold star for flushing these out
16:13:19 <ildikov> yep, exactly, we need those in place
16:13:35 <ildikov> mriedem: +2
16:13:46 <ildikov> stvnoyes does an awesome job!
16:14:40 <ildikov> ok, I think we have a solid plan in the sense of get the cinderclient part sorted out, add the depends-on tag to the grenade test to the API patch and get reviews in once live_migration is fixed up
16:14:40 <stvnoyes> just doing my job :-)
16:15:32 <ildikov> stvnoyes: my statement still stands :)
16:15:48 <ildikov> mriedem: does my above short summary look ok?
16:16:39 <mriedem> yes
16:16:46 <ildikov> cool
16:17:35 <ildikov> then I think we're good for today, unless there's anyone with further topics to discuss
16:17:53 <ildikov> let's focus on execution
16:18:02 <mriedem> one issue,
16:18:04 <mriedem> the cinderclient change
16:18:10 <mriedem> nova calls that method get_highest_client_server_version
16:18:16 <mriedem> so it's going to return a string instead of a float now yes?
16:18:26 <ildikov> yes
16:18:29 <mriedem> although, i think we're ok
16:18:31 <mriedem> nova casts to a string
16:18:31 <mriedem> max_api_version = cinder_api_versions.APIVersion(str(max_api_version))
16:18:38 <ildikov> yep, exactly
16:18:42 <mriedem> cool
16:18:59 <ildikov> that's what stvnoyes was mentioning in the sense of adding a comment about it and maybe even remove that cast
16:19:09 <stvnoyes> i am not going to remove the cast
16:19:13 <mriedem> yeah don't worry about it
16:19:15 <stvnoyes> just change the comment
16:19:19 <ildikov> but from operational perspective it still works
16:19:26 <ildikov> stvnoyes: cool, sounds good
16:19:31 <mriedem> older clients would return a float, but whatever
16:19:34 <mriedem> i wouldn't stress over this
16:19:53 <ildikov> yeah, true
16:20:17 <ildikov> cool, so no stress then :)
16:20:38 <ildikov> anything else from anyone?
16:20:40 <mriedem> nope
16:20:47 <stvnoyes> i'm good.
16:20:52 <ildikov> sounds good
16:20:57 <ildikov> thanks guys!
16:21:15 <jungleboyj> Thanks for all the work on this.
16:21:19 <ildikov> let's keep in sync during this week and next and let's get things done :)
16:21:30 <ildikov> see you All around :)
16:21:43 <ildikov> jungleboyj: +1
16:21:47 <ildikov> #endmeeting