14:34:07 <rosmaita> #startmeeting cinder_reviewfest 14:34:08 <openstack> Meeting started Fri Apr 16 14:34:07 2021 UTC and is due to finish in 60 minutes. The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:34:09 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:34:11 <openstack> The meeting name has been set to 'cinder_reviewfest' 14:34:18 <rosmaita> sorry i started this late 14:34:23 <rosmaita> here's the info 14:34:31 <jungleboyj> Hey. I am right on time. :-) 14:34:34 <rosmaita> we're meeting now in meetpad until 1600 utc 14:34:46 <rosmaita> #link https://meetpad.opendev.org/cinder-festival-of-reviews 14:35:07 <rosmaita> when you join, meetpad will display a "shared document" 14:35:17 <rosmaita> you can also access the shared doc directly: 14:35:29 <rosmaita> #link https://etherpad.opendev.org/p/cinder-festival-of-reviews 14:35:44 <rosmaita> i put a query on there that should help us be more productive 14:35:57 <rosmaita> it will drop out patches that get -1s 14:36:11 <rosmaita> and it doesn't show your own patches 14:37:20 <openstackgerrit> Merged openstack/cinder-specs master: Changed minversion in tox to 3.18.0 https://review.opendev.org/c/openstack/cinder-specs/+/781028 14:37:30 <openstackgerrit> Eric Harney proposed openstack/os-brick master: Enable bandit runs for tox https://review.opendev.org/c/openstack/os-brick/+/752692 14:41:57 * enriquetaso gooing 14:57:30 <openstackgerrit> Gorka Eguileor proposed openstack/cinder master: pylint: Fix E1120 no-value-for-parameter for mocks https://review.opendev.org/c/openstack/cinder/+/786670 14:57:31 <openstackgerrit> Gorka Eguileor proposed openstack/cinder master: pylint: Fix E0213 no-self-argument in tests https://review.opendev.org/c/openstack/cinder/+/786671 14:57:31 <openstackgerrit> Gorka Eguileor proposed openstack/cinder master: pylint: Fix migration E1120 no-value-for-parameter https://review.opendev.org/c/openstack/cinder/+/786672 14:57:36 <geguileo> eharney: ^ ;-) 14:58:10 <eharney> geguileo: funny i was just looking at the E1120 mock thing 14:58:17 <geguileo> lol 14:58:31 <geguileo> eharney: today I found a bug looking at pylint :-) 14:58:46 <geguileo> a call that is missing a parameter 14:58:49 <eharney> geguileo: i just hacked together an update to os-brick using it the same way that cinder does 14:59:17 <geguileo> eharney: though I got really angry with pylint today 14:59:32 <geguileo> it has so many issues... 15:00:00 <geguileo> generated-members doesn't work as it should :-( 15:00:09 <geguileo> no even in the latest version you just bumped 15:00:20 <eharney> i know, i documented that in our pylintrc file 15:00:21 <geguileo> which is a requirement for my patches lol 15:00:30 <geguileo> eharney: I saw 15:00:37 <geguileo> but I thought it would have been fixed by now 15:00:41 <geguileo> (it isn't) 15:00:59 <openstackgerrit> Brian Rosmaita proposed openstack/cinder master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/cinder/+/783245 15:02:22 <eharney> oh well we can just use mypy instead o:) 15:02:42 <geguileo> rofl 15:03:23 <jungleboyj> Ok, all the lower constraints job drops are merged. 15:05:56 <openstackgerrit> Gorka Eguileor proposed openstack/cinder master: NetApp ONTAP: Fix QoS lost after moving volume https://review.opendev.org/c/openstack/cinder/+/766296 15:10:21 <openstackgerrit> Eric Harney proposed openstack/cinder master: mypy: annotate api.py https://review.opendev.org/c/openstack/cinder/+/733622 15:12:53 <openstackgerrit> Brian Rosmaita proposed openstack/cinder master: Update release note info https://review.opendev.org/c/openstack/cinder/+/779501 15:24:37 <openstackgerrit> Merged openstack/python-brick-cinderclient-ext stable/wallaby: Drop lower-constraints job https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/785719 15:32:46 <openstackgerrit> Merged openstack/python-brick-cinderclient-ext stable/victoria: Drop lower-constraints job https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/785718 15:33:03 <openstackgerrit> Merged openstack/python-brick-cinderclient-ext stable/ussuri: Drop lower-constraints job https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/785717 15:42:03 <openstackgerrit> Merged openstack/python-brick-cinderclient-ext stable/train: Drop lower-constraints job https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/785716 16:24:50 <openstackgerrit> Merged openstack/os-brick stable/train: Drop lower-constraints job https://review.opendev.org/c/openstack/os-brick/+/785704 16:24:54 <openstackgerrit> Merged openstack/os-brick stable/wallaby: Drop lower-constraints job https://review.opendev.org/c/openstack/os-brick/+/785707 16:24:58 <openstackgerrit> Merged openstack/os-brick stable/rocky: Drop lower-constraints job https://review.opendev.org/c/openstack/os-brick/+/785702 16:29:42 <openstackgerrit> Merged openstack/devstack-plugin-ceph stable/train: Remove the stable branch jobs from stable/train gate https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/786311 16:29:48 <rosmaita> #endmeeting