14:04:02 <rosmaita> #startmeeting cinder_reviewfest 14:04:03 <openstack> Meeting started Fri May 21 14:04:02 2021 UTC and is due to finish in 60 minutes. The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:04:05 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:04:08 <openstack> The meeting name has been set to 'cinder_reviewfest' 14:06:22 <rosmaita> #topic roll call 14:06:26 <rosmaita> o/ 14:06:37 <eharney> hi 14:06:39 <walshh_> hi 14:06:43 <tosky> hi 14:07:07 <rosmaita> #topic let the reviewing begin! 14:07:16 <rosmaita> #link https://etherpad.opendev.org/p/cinder-festival-of-reviews 14:09:14 <enriquetaso> hi 14:12:35 <openstackgerrit> Simon Dodsley proposed openstack/cinder master: [Pure Storage] Fix minimum SDK version required https://review.opendev.org/c/openstack/cinder/+/792462 14:27:23 <openstackgerrit> Eric Harney proposed openstack/cinder master: Doc: Remove incorrect note about encryption flag https://review.opendev.org/c/openstack/cinder/+/792638 14:32:00 <jungleboyj> o/ 14:32:16 <enriquetaso> I like this title : https://review.opendev.org/c/openstack/cinder/+/792329 14:32:49 <enriquetaso> only owners can set the 'work in progress' flag? 14:33:17 <eharney> i think so, but we can -W it 14:37:02 <openstackgerrit> Simon Dodsley proposed openstack/cinder master: [Pure Storage] Fix minimum SDK version required https://review.opendev.org/c/openstack/cinder/+/792462 14:37:26 <xuany> rosmaita: hello 14:37:39 <openstackgerrit> Brian Rosmaita proposed openstack/cinder master: Remove Block Storage API v2 https://review.opendev.org/c/openstack/cinder/+/792299 14:37:44 <rosmaita> xuany: hello, we keep missing each other 14:38:05 <xuany> yes 14:38:56 <xuany> can you help review my bp spec in cinder, if you have time 14:40:12 <rosmaita> xuany: i will promise to do that today, after the festival of reviews 14:41:33 <xuany> ok, thanks, I really like being able to do some work in cinder 14:41:33 <xuany> . 14:46:31 <openstackgerrit> Brian Rosmaita proposed openstack/cinder master: Run cinder-mypy job in the check https://review.opendev.org/c/openstack/cinder/+/792642 14:46:36 <xuany> geguileo: hello, i have upload the path about the os-brick bugfix, https://review.opendev.org/c/openstack/os-brick/+/780511 14:47:35 <xuany> junjleboyj: hi, i have upload the path about the os-brick bugfix, please review if you have time, thanks very much; 14:47:43 <xuany> https://review.opendev.org/c/openstack/os-brick/+/780511 14:52:32 <rosmaita> jungleboyj: it's not XS, but it makes some of the XS patches mergeable, so maybe you can look over https://review.opendev.org/c/openstack/os-brick/+/786729/3 ? 14:57:24 <openstackgerrit> David Vallee Delisle proposed openstack/cinder stable/train: [train-only] Fix mock import for infinidat driver https://review.opendev.org/c/openstack/cinder/+/790963 15:01:02 <openstackgerrit> Simon Dodsley proposed openstack/cinder master: [Pure Storage] Fix minimum SDK version required https://review.opendev.org/c/openstack/cinder/+/792462 15:02:05 <jungleboyj> enriquetaso: Nothing helps code review like cat butt in your face. 15:04:26 <enriquetaso> cat++ 15:04:43 <jungleboyj> :-) 15:13:29 <openstackgerrit> Brian Rosmaita proposed openstack/os-brick master: Introduce mypy https://review.opendev.org/c/openstack/os-brick/+/786729 15:13:29 <openstackgerrit> Brian Rosmaita proposed openstack/os-brick master: mypy: exception.py https://review.opendev.org/c/openstack/os-brick/+/786730 15:13:30 <openstackgerrit> Brian Rosmaita proposed openstack/os-brick master: trivial: correct comment https://review.opendev.org/c/openstack/os-brick/+/792645 15:18:36 <eharney> https://review.opendev.org/c/openstack/os-brick/+/791272/3 15:25:05 <openstackgerrit> Merged openstack/cinder master: Excess availability_zone judgment code https://review.opendev.org/c/openstack/cinder/+/714252 15:32:37 <openstackgerrit> Eric Harney proposed openstack/os-brick master: mypy: exception.py https://review.opendev.org/c/openstack/os-brick/+/786730 15:32:37 <openstackgerrit> Eric Harney proposed openstack/os-brick master: mypy: utils.py https://review.opendev.org/c/openstack/os-brick/+/786731 15:36:17 <rosmaita> enriquetaso: project:openstack/os-brick owner:stephenfin@redhat.com status:open 15:36:26 <rosmaita> sorry 15:36:27 <rosmaita> https://review.opendev.org/q/project:openstack/os-brick+owner:stephenfin%2540redhat.com+status:open 15:39:51 <enriquetaso> rosmaita++ 15:40:34 <jungleboyj> rosmaita: A backport that can be merged: https://review.opendev.org/c/openstack/cinder/+/760362 15:40:51 <rosmaita> will take a look 15:43:49 <jungleboyj> rosmaita: https://review.opendev.org/c/openstack/cinder/+/790963 That is an easy one too. 15:48:35 <tosky> eheh, no one wants to touch https://review.opendev.org/c/openstack/cinder/+/489949/ :) 15:49:37 <rosmaita> jungleboyj: what did you think of Elod's comments on https://review.opendev.org/c/openstack/cinder/+/760362 ? 15:49:41 <jungleboyj> tosky: When geguileo isn't +2, no. 15:50:40 <jungleboyj> rosmaita: Oh, missed that. 15:51:29 <rosmaita> yeah, looks like maybe not a clean backport 15:52:14 <jungleboyj> Yeah, taking my +2 off that. 15:52:36 <jungleboyj> Thanks for pointing that out. 15:55:08 <openstackgerrit> Merged openstack/cinder-tempest-plugin master: Fix stein: use the old terminology for exclusion list https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/786755 15:55:20 <openstackgerrit> Merged openstack/cinder master: remove the oslo_utils.fnmatch https://review.opendev.org/c/openstack/cinder/+/788387 15:55:53 <openstackgerrit> Merged openstack/cinder master: api-ref: Use key_size 256 in API examples https://review.opendev.org/c/openstack/cinder/+/791010 16:00:02 <rosmaita> ok, we're just about out of time for the review fest, but feel free to stick around in a festive mood and continue reviewing! 16:00:06 <rosmaita> #endmeeting