14:00:42 <rosmaita> #startmeeting cinder_reviewfest
14:00:42 <opendevmeet> Meeting started Fri Nov 19 14:00:42 2021 UTC and is due to finish in 60 minutes.  The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:42 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:42 <opendevmeet> The meeting name has been set to 'cinder_reviewfest'
14:00:53 <rosmaita> hello everyone!
14:01:10 <rosmaita> you can join in meetpad, or just hang out here
14:01:18 <rosmaita> https://meetpad.opendev.org/cinder-festival-of-reviews
14:01:26 <rosmaita> and here is the etherpad link:
14:01:37 <rosmaita> #link https://etherpad.opendev.org/p/cinder-festival-of-reviews
14:02:19 <rosmaita> we have some slightly modified rules for today
14:02:36 <rosmaita> each attendee may nominate a patch to be reviewed on the etherpad
14:02:46 <rosmaita> (you must be present to win!)
14:03:14 <rosmaita> also, if you have a docs-only patch, please list it (they tend to be bigger than 10 LOC, but not hard to review)
14:04:46 <rosmaita> here's the festival review query (you have to be logged in to gerrit for it to work):
14:04:53 <rosmaita> #link https://review.opendev.org/q/(project:openstack/cinder+OR+project:openstack/os-brick+OR+project:openstack/python-cinderclient+OR+project:openstack/python-brick-cinderclient-ext+OR+project:openstack/cinderlib+OR+project:openstack/rbd-iscsi-client)+AND+status:open+AND+size:%253C%253D10+AND+NOT+owner%3Aself+AND+is%3Amergeable+AND+NOT+label%3AWorkflow%3C%3D-1+AND+label%3AVerified%3E%3D1+AND+NOT+reviewedby%3Aself+AND+
14:04:53 <rosmaita> %3ACode-Review%3C%3D-1
14:05:05 <rosmaita> happy reviewing!
14:08:44 * enriquetaso gooing
14:08:57 <rosmaita> https://review.opendev.org/c/openstack/cinder/+/694140 has one +2
14:08:58 <enriquetaso> ok, no meetpad
14:09:21 <rosmaita> enriquetaso: you can do meetpad, i just won't be there to entertain everyone
14:11:48 <enriquetaso> 694140 looks right and test passed
14:20:14 <rosmaita> This has one +2 and is a no-brainer (though the commit message is slightly misleading): https://review.opendev.org/c/openstack/cinder/+/805916
14:31:26 <rosmaita> This one also has one +2: https://review.opendev.org/c/openstack/cinder/+/801633
14:59:34 <jungleboyj> Sorry.  My start time was off by an hour.  Yay time change.  Will join when I can.
14:59:52 <rosmaita> jungleboyj: :D
15:01:07 <jungleboyj> I will have to fix that.  Not that it makes a difference as I have meetings all morning, every morning.
15:03:02 <rosmaita> it's kind of funny for me, some meetings i am still on time for, and some i keep missing ... i guess i have only half-adjusted to normal time
15:04:30 <enriquetaso> This is a simple one https://review.opendev.org/c/openstack/cinder/+/810785
16:01:33 <opendevreview> Merged openstack/cinder master: RBD: Check for OSError before using errno  https://review.opendev.org/c/openstack/cinder/+/694140
16:02:28 <rosmaita> ok, we are officially out of time ... but feel free to continue reviewing!
16:02:35 <rosmaita> thanks for attending, everyone
16:02:38 <rosmaita> #endmeeting