14:14:03 <whoami-rajat> #startmeeting cinder_reviewfest
14:14:03 <opendevmeet> Meeting started Fri May 27 14:14:03 2022 UTC and is due to finish in 60 minutes.  The chair is whoami-rajat. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:14:03 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:14:03 <opendevmeet> The meeting name has been set to 'cinder_reviewfest'
14:14:25 <eharney> rosmaita: the theory is plausible but i'd need to go do some live testing to see if that really makes sense, hard to say at a glance.  definitely shouldn't just merge it
14:14:43 <whoami-rajat> rosmaita, any reason we use meetpad? it's having some audio problems (as always)
14:15:01 <whoami-rajat> I'm thinking of using google meet from next time (or from now also)
14:15:09 <rosmaita> well, it allows you to see more participants than bluejeans
14:15:49 <whoami-rajat> hmm, we're 3 people right now there so maybe not a priority to see more people :D
14:15:57 <jbernard> i cant hear anything
14:16:15 <rosmaita> whoami-rajat: note the time and symptoms and send a bug report to clarkb or fungi in #opendev ... they try to keep meetpad working, and say that they need specific incidents to track
14:16:21 <rosmaita> jbernard: what browser are you using?
14:16:26 <jbernard> firefox
14:16:56 <rosmaita> firefox treats meetpad as spam, you have to enable autoplay or something
14:16:59 <opendevreview> Eric Harney proposed openstack/cinder master: mypy: cinder/cmd/[api,backup,scheduler,status,volume]  https://review.opendev.org/c/openstack/cinder/+/842541
14:17:06 <rosmaita> give me a minute i hvae the details somewhere
14:17:32 <rosmaita> jbernard: lines 7-8 on https://etherpad.opendev.org/p/cinder-festival-of-reviews
14:18:12 <whoami-rajat> eharney, can you hear me or jbernard?
14:18:36 <whoami-rajat> rosmaita, ack
14:18:47 <eharney> whoami-rajat: i hadn't tried since this thing rarely works well for me, let me actually try to turn it on
14:19:45 <whoami-rajat> eharney, i can hear you but maybe you can't
14:19:57 <jbernard> nope
14:20:04 <jbernard> disabled autoplay, still no audio
14:20:37 <rosmaita> do you mean "enabled" ?
14:20:38 <opendevreview> Eric Harney proposed openstack/cinder master: mypy: cmd/manage.py  https://review.opendev.org/c/openstack/cinder/+/842542
14:20:58 <jbernard> right
14:21:05 <rosmaita> bummer
14:21:15 <jbernard> changed from block to allow audio and video
14:21:58 <jbernard> ok, its working
14:22:06 <rosmaita> \o/
14:22:53 <jbernard> the setting doesnt apply to existing tabs, i needed to close and re-open it
14:23:12 <rosmaita> ok, good to know
14:26:47 <fungi> whoami-rajat: what browser are you using with meetpad? chromium? chrome? firefox? jitsi mobile client? something else?
14:27:05 <whoami-rajat> fungi, chrome
14:27:58 <whoami-rajat> so currently the problem was jbernard was using firefox and now we are able to hear everyone
14:28:04 <fungi> there are also play audio permissions in chrome though they were not as hard for me to find as the ones in firefox (which are thoroughly buried in the privacy settings)
14:28:50 <fungi> oh, if it was jbernard having to allow "auto play audio" in firefox to get webrtc to work, yes i too have observed that changing that requires a restart of firefox
14:28:51 <whoami-rajat> but the general experience with meetpad and audio issues dates back to several meetings ...
14:29:37 <whoami-rajat> though we will keep in mind your suggestions if someone faces similar issues
14:30:01 <fungi> so far we haven't come across any audio problems we're able to confirm in meetpad which didn't boil down to either the browser blocking audio, the browser getting overwhelmed by too many video streams, or firewalls blocking webrtc connections in one direction
14:32:47 <whoami-rajat> hmm, we recently used meetpad for our PTG photo with around 25-30 people where around half were able to hear me
14:32:56 <opendevreview> Merged openstack/cinder master: PowerMax Docs - Known issues section  https://review.opendev.org/c/openstack/cinder/+/843118
14:33:06 <whoami-rajat> but maybe they had trivial issues, but again they didn't face similar issues with google meet
14:33:43 <fungi> apparently jitsi-meet choosing to build on top of the media streaming support in browsers was a great idea, until web sites also started using those same browser features to spam visitors relentlessly, resulting in browsers now basically crippling that functionality. platforms which rolled their own a/v work around that by bypassing the browsers' features
14:34:30 <fungi> continue to work as before
14:36:55 <rosmaita> that's why we can't have nice things
14:37:54 <fungi> but yeah, the jitsi-meet mobile client seems to work for everyone i know who's tried it. chrome/chromium work for most people if they haven't adjusted the privacy settings or added extensions which may auto-block it, or are on office networks where the security folks have decided webrtc connections are dangerous. modern versions of firefox work for almost nobody unless they can find
14:37:56 <fungi> the hidden toggle to allow auto-play audio and then restart their browser
14:39:59 <rosmaita> i'd prefer to use an open solution if possible (though i must admit, i use bluejeans when we are recording a meeting, because that's easy and seems to work well)
14:40:53 <fungi> https://github.com/jitsi/jitsi-meet/issues/1221
14:44:49 <fungi> this is the similar report for chrom*, but apparently it's a little smarter about things: https://github.com/jitsi/jitsi-meet/issues/9528
14:45:32 <fungi> it's possible adding a pre-join screen as suggested there will help in some cases
14:45:38 <fungi> i'll look into that more
14:45:57 <enriquetaso> rosmaita, eharney (regarding 843309): It looks like it could work. I think the best thing to do is test it with the patch that flats the children when the volume is deleted to see what happens.
14:49:12 <rosmaita> enriquetaso: thanks ... maybe put a note on the review so someone doesn't prematurely approve it
14:50:05 <whoami-rajat> rosmaita, replied on the powermax patch, I agree with you on that and from the commit message, looks like maybe they're trying to fix multiple things in a single patch
14:50:12 <whoami-rajat> but let's see
14:51:07 <rosmaita> whoami-rajat: thanks for looking
14:51:39 <whoami-rajat> np
14:55:55 <rosmaita> btw, tosky said he may join late, and i think jungleboyj had a conflict
14:56:23 <jungleboyj> Yes, apologies.  I have conflicts today.
14:59:29 <whoami-rajat> sure, I see 5 people (including me) in the meet as of now
14:59:50 <whoami-rajat> If anyone wants to discuss anything regarding any patch, you can ask here or in the meetpad meeting
15:00:01 <whoami-rajat> dashboard link
15:00:03 <whoami-rajat> #link http://tiny.cc/cinder-reviewfest
15:03:33 <whoami-rajat> enriquetaso, would you like you upgrade your vote here? https://review.opendev.org/c/openstack/cinder/+/793267
15:10:29 <enriquetaso> sure whoami-rajat
15:10:35 <whoami-rajat> thanks
15:10:53 <opendevreview> Merged openstack/cinder master: Tests: Extend RBD deferred deletion interval  https://review.opendev.org/c/openstack/cinder/+/843151
15:11:55 <opendevreview> Merged openstack/cinder master: tox.ini: combine functional-py* envs  https://review.opendev.org/c/openstack/cinder/+/843153
15:19:24 <whoami-rajat> I will be leaving meetpad now but will continue review and will be available here on IRC
15:19:57 <jungleboyj> If there is anything that people need me to take a look at feel free to ping me here.
15:21:04 <opendevreview> Eric Harney proposed openstack/cinder master: Groups: remove unneeded "status" variable  https://review.opendev.org/c/openstack/cinder/+/840493
15:21:43 <enriquetaso> Do you know anyone on the Tempest team I could write to for this patch? I think it's important for us to continue testing the backup restore feature.
15:21:48 <enriquetaso> https://review.opendev.org/c/openstack/tempest/+/843542
15:23:21 <eharney> https://review.opendev.org/c/openstack/cinder/+/835635  fixes a bug reported on the openstack mailing list a bit ago, would be good to review it
15:26:33 <whoami-rajat> enriquetaso, you can ask gmann or kopecmartin in #openstack-qa channel for reviews
15:28:40 <enriquetaso> thanks whoami-rajat, added them to cc on the patch
15:28:51 <whoami-rajat> np
15:30:21 <gmann> whoami-rajat: enriquetaso: will review
15:30:37 <whoami-rajat> thanks gmann !
15:38:01 <enriquetaso> thanks gmann !
15:38:13 <gmann> enriquetaso: np!
15:45:52 <rosmaita> whoami-rajat: you can do gmann a return favor on https://review.opendev.org/c/openstack/cinder/+/843092
15:47:00 <whoami-rajat> looking
15:53:32 <whoami-rajat> gmann, left one comment here, if you would like to followup https://review.opendev.org/c/openstack/cinder-tempest-plugin/+/843319
15:53:47 <whoami-rajat> minor change but description needs to be correct
15:54:19 <gmann> whoami-rajat: ah sure, will push as followup
15:54:31 <whoami-rajat> thanks!
16:00:09 <whoami-rajat> we're towards the end of festival of XS reviews. Thanks everyone for joining and you can continue reviewing not just XS but any patch!
16:00:19 <whoami-rajat> have a great weekend ahead
16:00:21 <whoami-rajat> #endmeeting