14:00:00 <rafaelweingartner> #startmeeting cloudkitty 14:00:00 <opendevmeet> Meeting started Mon Nov 29 14:00:00 2021 UTC and is due to finish in 60 minutes. The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:00:00 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:00:00 <opendevmeet> The meeting name has been set to 'cloudkitty' 14:00:10 <rafaelweingartner> Roll count 14:01:11 <rafaelweingartner> Hello priteau: 14:01:16 <priteau> Hello 14:01:24 <rafaelweingartner> I just started the meeting 14:01:25 <priteau> Sorry, IRC bouncer has died 14:01:41 <rafaelweingartner> I was meeting for the roll count 14:01:55 <rafaelweingartner> I was waiting for the roll count responses** 14:02:45 <mkarpiarz> Hi! 14:03:15 <rafaelweingartner> Hello mkarpiarz! 14:03:59 <rafaelweingartner> I guess we can start with the target reviews of the meeting 14:04:12 <rafaelweingartner> #link https://review.opendev.org/c/openstack/cloudkitty/+/774520 14:04:30 <rafaelweingartner> priteau: there was a request from you there. Is this patch missing something else? 14:04:54 <priteau> Checking 14:05:12 <rafaelweingartner> awesome, thanks 14:05:46 <rafaelweingartner> #link https://review.opendev.org/c/openstack/cloudkitty/+/792090 14:05:57 <rafaelweingartner> mkarpiarz: were you able to check that patch? 14:06:29 <mkarpiarz> Not yet, sorry. 14:07:44 <mkarpiarz> I was having problems with making pyscripts work in my test environment and no time to get to the bottom of it. 14:07:46 <priteau> Small doc syntax comment on the first 14:12:23 <opendevreview> Rafael Weingartner proposed openstack/cloudkitty master: Introduce "response_format" for the V2 summary API https://review.opendev.org/c/openstack/cloudkitty/+/774520 14:13:47 <opendevreview> Rafael Weingartner proposed openstack/cloudkitty master: Introduce "response_format" for the V2 summary API https://review.opendev.org/c/openstack/cloudkitty/+/774520 14:15:18 <rafaelweingartner> priteau: I fixed the issue in the first patch 14:15:23 <priteau> THanks 14:15:30 <rafaelweingartner> do you guys think that we can merge it, as soon as the tests pass? 14:16:14 <priteau> Yes for me 14:16:18 <rafaelweingartner> ok 14:16:31 <priteau> I'll just check the output of the doc generation 14:16:37 <rafaelweingartner> Mariusz had already tested, and approved that one 14:16:55 <rafaelweingartner> Moving on to: https://review.opendev.org/c/openstack/cloudkitty/+/792090 14:17:11 <rafaelweingartner> should we wait for Mariusz tests? Or, maybe, can we move on ans merge this one 14:18:01 <mkarpiarz> I think this change can be merged safely, regardless of my tests. 14:18:39 <rafaelweingartner> Ok, I will merge it then 14:19:13 <priteau> +1 14:19:31 <rafaelweingartner> Moving on to: https://review.opendev.org/c/openstack/cloudkitty/+/775359 14:19:43 <rafaelweingartner> we reviewed this patch, and the author was not responding 14:20:00 <rafaelweingartner> I then, reached the author, and he said that he was going to address our reviews 14:20:17 <rafaelweingartner> however, almost two months have gone by, and still we do not have an answer 14:21:55 <rafaelweingartner> should we take over the patch? And execute the improvents ourselves? 14:22:03 <priteau> I will check if I can see it in some of our deployments 14:22:19 <priteau> I've seen the issue before but that environment must have been upgraded since 14:23:24 <rafaelweingartner> ok 14:23:46 <rafaelweingartner> I will mark it as yours, I mean, as the person investigating and maybe improving it 14:23:55 <rafaelweingartner> then, we can discuss it again during our next meeting 14:24:29 <rafaelweingartner> and, finally the last one 14:24:32 <rafaelweingartner> #link https://review.opendev.org/c/openstack/cloudkitty/+/777442 14:24:49 <rafaelweingartner> priteau: you requested some changes that were addressed 14:24:59 <rafaelweingartner> do you have something else to add there? Or, maybe, can we move on and merge it 14:27:48 <priteau> Merged 14:29:40 <rafaelweingartner> awesome, thanks 14:30:17 <rafaelweingartner> do you guys have any other priority for our next meeting? 14:31:36 <priteau> zigo's patch 14:31:43 <priteau> https://review.opendev.org/c/openstack/cloudkitty/+/814789 14:32:18 <zigo> priteau: What don't you understand ? 14:32:24 <rafaelweingartner> ok 14:32:30 <rafaelweingartner> I will add for our next meeting 14:32:58 <rafaelweingartner> Zigo: why using "W: ...." in the log message 14:33:07 <rafaelweingartner> I missed that during my review 14:33:07 <mkarpiarz> I think W=warning 14:33:18 <rafaelweingartner> that is not the proper way 14:33:19 <zigo> W stands for Warning, I can either remove it or write warning in full. 14:33:25 <zigo> Let me know what you decide. 14:33:26 <priteau> That's not really standard 14:33:30 <rafaelweingartner> LOG.warning'( 14:33:36 <rafaelweingartner> LOG.debug = for debug 14:33:41 <rafaelweingartner> LOG.warning = for warning 14:33:46 <priteau> I just grepped through most openstack projects and no LOG statements are using this 14:33:49 <zigo> Well, I still think LOG.debug is the way... 14:33:50 <rafaelweingartner> LOG.info = for general information 14:33:52 <rafaelweingartner> and so on 14:33:55 <zigo> It will print too much otherwise. 14:34:08 <zigo> So I can just remove the "W:" then. 14:34:10 <priteau> I think you can just remove W" 14:34:14 <rafaelweingartner> if it is a debug message, therefore it is not warning 14:34:18 <rafaelweingartner> so, no need for the W 14:34:19 <priteau> The message is good enough 14:34:31 <rafaelweingartner> +1 14:34:47 <zigo> There you go ! 14:34:48 <opendevreview> Thomas Goirand proposed openstack/cloudkitty master: Adding two options in fetcher_keystone https://review.opendev.org/c/openstack/cloudkitty/+/814789 14:34:54 <zigo> Please review ... :) 14:35:15 <priteau> Just left another comment 14:35:53 <rafaelweingartner> anyways, we can finish this patch review in our next meeting, and execute the review rounds in an async fashion 14:36:27 <zigo> priteau: Done. 14:36:29 <opendevreview> Thomas Goirand proposed openstack/cloudkitty master: Adding two options in fetcher_keystone https://review.opendev.org/c/openstack/cloudkitty/+/814789 14:36:50 <rafaelweingartner> besides this patch, do you guys have any other priority? 14:37:19 <mkarpiarz> Nothing from my side. 14:37:25 <rafaelweingartner> Otherwise, I will grab the ones I find most promissing, or almost ready for our next meeting 14:37:25 <zigo> Internally, we added an index in the rated_dataframe, it'd be nice if it was added upstream too. 14:37:40 <rafaelweingartner> your patch would be welcome :) 14:37:41 <zigo> Though I don't think we / I have enough skills to do that with SQLAlchemy. 14:37:55 <zigo> If anyone can show me how, I'll do it. 14:38:05 <zigo> (an example somewhere ?) 14:38:44 <zigo> We went from 23 seconds per query to 0.03 with the index, so it's quite important ! 14:38:54 <zigo> (millions of records...) 14:38:59 <rafaelweingartner> can you open a bug report? 14:39:04 <zigo> Sure ! 14:39:06 <rafaelweingartner> then, we can move on from there 14:39:11 <zigo> Thanks. 14:39:12 <rafaelweingartner> and maybe, I can create the patch 14:39:58 <rafaelweingartner> And now, for the final minutes, I will open to general/open issues/questions that one might have 14:40:01 <rafaelweingartner> #topic AOB 14:40:23 <zigo> In Storyboard, right? 14:40:28 <rafaelweingartner> zigo: yes 14:40:56 <zigo> One more thing I'd like to discuss. 14:41:12 <zigo> We have our billing system querying Cloudkitty for each project one by one, each hours. 14:41:27 <zigo> Though we don't know if a project has finished to be rated for the queried hour ... 14:41:33 <zigo> Shouldn't that be exposed to the API ? 14:42:37 <rafaelweingartner> you can check the latest processing state of the project 14:42:51 <rafaelweingartner> https://review.opendev.org/c/openstack/cloudkitty/+/774634 14:43:07 <rafaelweingartner> last_processed_timestamp will be marked with the timestamp of the last processed timestamp 14:43:13 <zigo> Oh, thanks. 14:43:24 <zigo> We're using Victoria in production, which is why we don't have this... 14:43:32 <zigo> I'll backport the patch, that's very helpful, thanks again. 14:45:15 <rafaelweingartner> welcome 14:50:34 <rafaelweingartner> I had an issue with my Internet connection 14:50:44 <rafaelweingartner> so, I guess that we can close for now, right? 14:50:51 <rafaelweingartner> do you guys have something else to add 14:50:55 <rafaelweingartner> ? 14:51:52 <priteau> Nothing from me 14:52:22 <mkarpiarz> I'm good too. 14:52:23 <rafaelweingartner> Ok 14:52:26 <rafaelweingartner> Thank you guys for participating. Have a nice week. 14:52:31 <rafaelweingartner> #endmeeting