14:10:27 <priteau> #startmeeting cloudkitty
14:10:27 <opendevmeet> Meeting started Mon Dec 13 14:10:27 2021 UTC and is due to finish in 60 minutes.  The chair is priteau. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:10:27 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:10:27 <opendevmeet> The meeting name has been set to 'cloudkitty'
14:10:33 <priteau> #topic Roll call
14:10:40 <priteau> Maybe this will make Rafael join ;-)
14:11:14 <mkarpiarz> :)
14:12:18 <priteau> I've just left a comment on https://review.opendev.org/c/openstack/cloudkitty/+/821397
14:13:20 <priteau> I've just sent an email to Rafael
14:14:24 <mkarpiarz> I agree changes like this shouldn't need another +1/+2.
14:15:04 <mkarpiarz> I'm going to merge 821397 now. :)
14:15:25 <priteau> Please do
14:16:49 <mkarpiarz> Should we start discussing other changes now?
14:17:37 <mkarpiarz> I will be testing this change in my test environment: https://review.opendev.org/c/openstack/cloudkitty/+/799207
14:18:31 <mkarpiarz> There have been some significant changes since the last patch I looked at.
14:19:10 <priteau> Oh right, this is still in progress
14:20:02 <priteau> Let's go over the meeting agenda since it was prepared
14:20:06 <priteau> Topics for meeting of 13/12/2021
14:20:12 <priteau> #topic Target reviews
14:20:20 <priteau> 1) https://review.opendev.org/c/openstack/cloudkitty/+/775359
14:20:32 <priteau> No response from original author
14:20:53 <priteau> But we know the bug can exist, I've seen it before, although I am not sure how to reproduce it
14:22:22 <mkarpiarz> A comment says "The ZeroDivisionError is raised when no executions have occured when calling the 'average_runtime' method"
14:23:52 <mkarpiarz> I've never seen this edge case but it look plausible to me.
14:24:41 <priteau> I said I would check if I can reproduce, not had the time to look into yet
14:25:00 <priteau> Let's discuss the next one
14:25:03 <priteau> https://review.opendev.org/c/openstack/cloudkitty/+/814789
14:25:17 <priteau> This one has been approved in the past both by you and Rafael
14:25:30 <priteau> There were just some small changes since
14:25:33 <priteau> Can you approve again?
14:25:41 <priteau> It would make zigo very happy ;-)
14:25:53 <zigo> Very much ! :)
14:28:32 <mkarpiarz> Ah, I forgot to check back on this one. Approved and merged.
14:28:49 <priteau> Next is https://review.opendev.org/c/openstack/cloudkitty/+/817275
14:29:03 <priteau> Already a +2 from you so we'll need an approval from Rafael
14:29:28 <priteau> Added him to reviewers
14:29:37 <priteau> Next https://review.opendev.org/c/openstack/cloudkitty/+/808997
14:29:40 <mkarpiarz> OK
14:29:53 <priteau> I've made some small changes to this one, it can get my +2 once Zuul jobs run
14:30:15 <priteau> Really just cosmetic changes, either in commit/reno or in code layout
14:30:27 <priteau> Please check back in one hour or so
14:30:41 <priteau> Finally, https://review.opendev.org/c/openstack/cloudkitty/+/778922
14:30:46 <mkarpiarz> Sure, thanks for the heads-up.
14:30:50 <priteau> This one is going through the gate
14:31:25 <mkarpiarz> Awesome!
14:31:59 <priteau> That's all for the target reviews
14:32:13 <priteau> I guess we should set the next one? Reprocessing patch?
14:32:55 <mkarpiarz> Sure.
14:33:37 <mkarpiarz> Two weeks from now I'll be on holiday but should be able to look into 799207 before that.
14:34:06 <mkarpiarz> (by "look into" I mean test it out)
14:34:52 <priteau> I will be on holiday too. I propose that we skip the next meeting and meet on 10/01?
14:35:11 <priteau> or 01/10 if you like month-first
14:35:21 <priteau> 3rd of Jan is UK bank holiday too
14:35:34 <priteau> I am adding this to https://etherpad.opendev.org/p/cloudkitty-meeting-topics
14:36:16 <mkarpiarz> Yes, Jan 10 works for me.
14:37:47 <priteau> I'll also add the patches that aren't merging today
14:37:58 <mkarpiarz> OK
14:38:56 <priteau> Let's log the meeting date change
14:39:16 <priteau> #info The meeting of 27/12/2021 is cancelled. Our next meeting will be on 10/01/2022.
14:39:27 <priteau> Next topic is
14:39:32 <priteau> #topic Stable releases
14:39:42 <priteau> That's really just a notice
14:39:53 <priteau> We've released stable versions of Wallaby and Victoria
14:40:02 <priteau> They both include the policy fix for get_summary
14:40:41 <priteau> #info CloudKitty 13.0.1 (victoria) and 14.0.1 (wallaby) released
14:40:47 <priteau> #topic Pyscripts
14:40:52 <mkarpiarz> Cool!
14:40:59 <priteau> This is a topic I added to the agenda
14:41:20 <priteau> Before proposing the wallaby and victoria releases, I thought we should maybe backport the pyscript fix
14:41:41 <priteau> So I tried to use pyscript in master, but I was not able to get it working (even with the fix)
14:41:57 <opendevreview> Merged openstack/cloudkitty master: Add support for multiple value filters  https://review.opendev.org/c/openstack/cloudkitty/+/778922
14:41:58 <priteau> I am thinking the example scripts from the docs are outdated
14:42:27 <priteau> I am getting the following error
14:42:28 <priteau> Unhandled exception: TypeError: 'DataFrame' object is not iterable
14:42:39 <mkarpiarz> Yes, I've also had problems when trying to use pyscripts in my test environment.
14:42:51 <mkarpiarz> Which collector are you using?
14:43:54 <priteau> gnocchi
14:44:06 <priteau> I used the script from here: https://docs.openstack.org/cloudkitty/latest/user/rating/pyscripts.html#custom-module-example
14:44:43 <priteau> Looking at git history I saw that at some point when the Dataframe and Datapoint classes were introduced, the scripts didn't change. Maybe they should have
14:45:37 <priteau> the tempest plugin only tests CRUD operations
14:45:57 <mkarpiarz> According to my notes the problem is caused by line 78 in cloudkitty/rating/pyscripts/__init__.py.
14:46:19 <mkarpiarz> *line 77
14:46:26 <priteau> Same here
14:46:37 <priteau> File "/var/lib/kolla/venv/lib/python3.6/site-packages/cloudkitty/rating/pyscripts/__init__.py", line 78, in start_script
14:46:37 <priteau> exec(code, context)  # nosec
14:46:47 <mkarpiarz> Apparently the "data" DataFrame is empty.
14:47:03 <priteau> Yes. I added some debug and found the same problem
14:47:07 <mkarpiarz> Despite metrics being present in Gnocchi.
14:47:17 <mkarpiarz> Ah, cool.
14:48:17 <priteau> I will see if I can debug further
14:48:48 <priteau> If we can't fix it though we would need to warn that it doesn't work.
14:50:23 <priteau> Hello Rafael
14:50:48 <mkarpiarz> I agree but we first need to rule out we both are making some systematic user error.
14:51:20 <mkarpiarz> And if we are, then we should update docs. ;)
14:51:25 <priteau> Indeed
14:51:52 <rafaelweingartner> Hello guys!
14:51:58 <rafaelweingartner> Sorry for the trouble :(
14:52:23 <priteau> No worries
14:52:28 <priteau> You can catch up on the discussion at https://meetings.opendev.org/meetings/cloudkitty/2021/cloudkitty.2021-12-13-14.10.log.txt
14:52:45 <priteau> But to summarise the most important:
14:52:56 <priteau> Reprocessing patch is next target review
14:53:11 <priteau> Meeting of 27/12 cancelled due to holidays, next on 10/01
14:53:19 <rafaelweingartner> ok
14:53:21 <rafaelweingartner> cool
14:53:34 <priteau> Pyscripts is broken, or maybe the docs are just wrong
14:53:53 <priteau> Also one for you rafaelweingartner, please review https://review.opendev.org/c/openstack/cloudkitty/+/817275
14:54:07 <priteau> You've done so already :)
14:54:21 <opendevreview> Merged openstack/cloudkitty master: Add missing whitespace in log message  https://review.opendev.org/c/openstack/cloudkitty/+/821397
14:54:22 <rafaelweingartner> yes, I did :)
14:54:44 <priteau> I am planning a longer discussion of this in a blog post on the StackHPC website
14:55:12 <priteau> Would you still prefer that I update the patch?
14:55:18 <rafaelweingartner> Can you sumarize a little bit there?
14:55:35 <rafaelweingartner> I can imagine how it is used, but the usecase is not clear to me
14:55:41 <priteau> It can be used for anything really.
14:55:53 <priteau> I used it to join with other metrics to perform some data changes
14:56:05 <priteau> For example replacing project_id by project_name
14:57:28 <rafaelweingartner> I see
14:57:36 <rafaelweingartner> but I would expect some description such as https://review.opendev.org/c/openstack/cloudkitty/+/786651
14:57:52 <rafaelweingartner> ohterwise, the patch become a bit vague for some operators or users
14:58:32 <priteau> OK, I can update
14:59:07 <rafaelweingartner> thanks
14:59:41 <priteau> Finally, I also updated the quote API patch with some small wording/layout changes
14:59:42 <priteau> https://review.opendev.org/c/openstack/cloudkitty/+/808997
15:00:01 <priteau> I hope that's OK.
15:00:13 <priteau> It's ready for review by mkarpiarz again
15:00:34 <rafaelweingartner> Sure, it is :)
15:00:35 <rafaelweingartner> thanks for that
15:02:01 <priteau> That's all for today I think!
15:02:16 <mkarpiarz> Thank you, guys!
15:02:23 <rafaelweingartner> Cool!
15:02:32 <rafaelweingartner> Again, thank you so much for picking this one up
15:03:07 <priteau> Have a good end of the year holiday time everyone
15:03:22 <priteau> #endmeeting