14:00:18 <rafaelweingartner> #startmeeting cloudkitty
14:00:18 <opendevmeet> Meeting started Mon Feb  7 14:00:18 2022 UTC and is due to finish in 60 minutes.  The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:18 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:18 <opendevmeet> The meeting name has been set to 'cloudkitty'
14:00:22 <rafaelweingartner> Roll count
14:00:48 <priteau> o/
14:01:07 <mkarpiarz> Hi!
14:04:13 <rafaelweingartner> #topic Target review of meeting
14:04:19 <rafaelweingartner> We have the following patches as target for this meeting.
14:04:25 <rafaelweingartner> #link https://review.opendev.org/c/openstack/cloudkitty/+/799207
14:04:33 <rafaelweingartner> #link https://review.opendev.org/c/openstack/cloudkitty/+/684734
14:04:37 <rafaelweingartner> #link https://review.opendev.org/c/openstack/cloudkitty/+/775359
14:04:41 <rafaelweingartner> #link https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/685344
14:04:45 <rafaelweingartner> #link https://review.opendev.org/c/openstack/cloudkitty/+/824745
14:05:07 <rafaelweingartner> starting with: #link https://review.opendev.org/c/openstack/cloudkitty/+/824745
14:05:38 <rafaelweingartner> have you guys been able to review it?
14:06:36 <priteau> Not yet
14:07:30 <rafaelweingartner> my biggest question there is that, "is it backward compatible"
14:07:59 <rafaelweingartner> looking at the code, it feels like it is not going to work with previous versions of ES
14:08:12 <rafaelweingartner> but, of course, I am not that familiar with ES API
14:08:18 <rafaelweingartner> so, I might be mistaken
14:08:22 <mkarpiarz> No, my test environment is set up for 799207. I will be looking at picking up another change for review.
14:08:53 <mkarpiarz> Should I take 824745 next then or is there something more urgent?
14:09:21 <priteau> That's a good question. I'll check with Isaac (he's my colleague). It says that it needs ES 7, do we have requirements for keeping compatibility with earlier versions?
14:10:52 <rafaelweingartner> no, we do not need
14:10:57 <rafaelweingartner> specially, EOL versions
14:11:16 <rafaelweingartner> but, we need to warn users that we only support, let's say ES 7+
14:11:22 <priteau> Kolla Ansible has been providing Elasticsearch 7 since Wallaby.
14:11:39 <priteau> I don't know about other deployment tools
14:12:16 <priteau> A related question is what would be the migration path from existing index layout?
14:12:38 <mkarpiarz> I agree, if ES 6 is EOL, we should not worry about backward compatibility.
14:12:38 <rafaelweingartner> exactly
14:12:59 <rafaelweingartner> but we need to warn users of the drop support for ES 6
14:13:07 <mkarpiarz> For sure.
14:13:10 <rafaelweingartner> I dropped a message there, asking for more information
14:13:59 <mkarpiarz> I'm not sure we have the manpower to come up with a index migration script/path but it would be nice.
14:15:03 <rafaelweingartner> exactly, but I guess that is more responsability for the operation of upgrade between ES 6 and 7, then for CloudKitty
14:16:02 <priteau> Well, upgrade from ES 6 to 7 is not a problem, that's handled by Elasticsearch itself
14:17:56 <rafaelweingartner> Do we need to worry about the index layout? Anybody coming from ES 6 would not be using it
14:18:22 <rafaelweingartner> therefore, as long as they do not change the configs, it should work, right?
14:19:46 <priteau> I need to review the patch in more detail :)
14:20:10 <rafaelweingartner> Ok
14:20:24 <rafaelweingartner> we can review it until next meeting, and then we discuss again
14:20:33 <rafaelweingartner> hopefully, with some feedback from the author
14:23:04 <mkarpiarz> I agree.
14:23:24 <rafaelweingartner> Moving on to: https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/685344
14:23:37 <rafaelweingartner> I would like to dedicate some time for the tempest tests for V2 API
14:23:42 <rafaelweingartner> have you guys worked with it?
14:25:13 <mkarpiarz> I've only worked with Tempest through Rally and only with predefined test scenarios.
14:25:37 <rafaelweingartner> I see
14:25:57 <priteau> I've contributed some scenarios for another project, but it was a long time ago
14:26:09 <rafaelweingartner> Well, I will try to put some energy there, but if you guys have some hints, I would appreciate
14:26:20 <rafaelweingartner> I think that we need tempest tests for cloudkitty for the V2 aPI
14:26:32 <rafaelweingartner> to make the system more solid during releases
14:28:26 <mkarpiarz> OK
14:30:47 <priteau> Agreed
14:31:39 <rafaelweingartner> moving on to: https://review.opendev.org/c/openstack/cloudkitty/+/775359, I need to amend the patch. Therefore, at least from my side, I do not have anything to add about it. Do you guys have anything?
14:34:49 <mkarpiarz> Nothing yet.
14:35:09 <priteau> I am confused by the config sample update
14:35:45 <rafaelweingartner> I thought that it was auto generated by tox
14:35:54 <rafaelweingartner> but that is a point to raise there as well
14:36:09 <priteau> It would be generated by tox -e genconfig
14:36:15 <priteau> But you don't have to commit it
14:36:21 <priteau> It should be a separate commit
14:36:29 <rafaelweingartner> I see
14:36:37 <rafaelweingartner> so I can remove it then
14:36:40 <rafaelweingartner> when I amend the patch
14:36:47 <priteau> Do you run tox without args?
14:36:57 <rafaelweingartner> yes
14:37:11 <rafaelweingartner> I means, which args?
14:37:36 <rafaelweingartner> I run tox -e <tox_operations_I want,... ex. pep8, py37, and so on>
14:37:40 <priteau> For example you can run `tox -e pep8` or `tox -e py3`, depending on what you want to run
14:37:45 <priteau> OK
14:37:52 <priteau> And this generated the updated config?
14:38:04 <rafaelweingartner> normally, no
14:41:44 <priteau> Just an accident then
14:42:39 <rafaelweingartner> Moving on to: https://review.opendev.org/c/openstack/cloudkitty/+/684734. I approved the patch. I think that it is ready to go. What about you guys?
14:44:34 <priteau> From a quick look it seems ok. There is also a config update though.
14:45:14 <priteau> Also should the commit message say /v2?
14:45:32 <rafaelweingartner> yes
14:45:36 <priteau> Nevermind, I misunderstood
14:45:38 <rafaelweingartner> that is what it is doing, right?
14:45:50 <priteau> They meant implement the endpoints that already exist at /v1 into the v2 api
14:45:58 <rafaelweingartner> should we create a ptch to update the config sampel file? Then, the diffs in all other patches would dissappear
14:46:41 <priteau> Sounds good
14:46:46 <priteau> I left a couple of comments
14:46:54 <rafaelweingartner> great, thanks
14:47:03 <rafaelweingartner> I will put on my list this patch then
14:47:08 <rafaelweingartner> to update the config samples
14:51:30 <rafaelweingartner> and, finally, the last one, my patch: https://review.opendev.org/c/openstack/cloudkitty/+/799207. I amenede the code with Mariusz suggestions, and I would appriaciate your feedback guys.
14:54:10 <rafaelweingartner> amended*
14:55:02 <mkarpiarz> I'm waiting for results from reprocessing but with the latest patch this change seems to be working.
14:55:12 <rafaelweingartner> awesome!
14:55:18 <rafaelweingartner> thanks for helping me on this one
14:55:31 <mkarpiarz> Sure thing!
14:55:35 <rafaelweingartner> We are almost running out of time, do you guys have anything else to add?
14:55:40 <opendevreview> Pierre Riteau proposed openstack/cloudkitty master: Update sample configuration file  https://review.opendev.org/c/openstack/cloudkitty/+/828163
14:55:49 <priteau> rafaelweingartner: I did the config file update ^
14:56:05 <rafaelweingartner> ah
14:56:06 <rafaelweingartner> thanks
14:57:23 <mkarpiarz> Nothing from my side.
14:58:15 <rafaelweingartner> Thank you guys for participating. Have a nice week.
14:58:22 <rafaelweingartner> #endmeeting