14:00:42 <rafaelweingartner> #startmeeting cloudkitty
14:00:42 <opendevmeet> Meeting started Mon May  2 14:00:42 2022 UTC and is due to finish in 60 minutes.  The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:42 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:42 <opendevmeet> The meeting name has been set to 'cloudkitty'
14:00:45 <rafaelweingartner> Roll count
14:00:54 <priteau> Hello rafaelweingartner
14:01:37 <rafaelweingartner> Hello Pierre
14:02:56 <priteau> I believe it will be just the two of us today
14:03:02 <rafaelweingartner> exactly
14:03:25 <rafaelweingartner> OpenInfra Summit Berlin 2022
14:04:03 <rafaelweingartner> #topic OpenInfra Summit Berlin 2022
14:04:16 <rafaelweingartner> One of my CloudKitty presentations was accepted! Also, I suggest you guys to attend the event, it will be great opportunity to meet the OpenStack community. We also proposed two forum sessions, but we are not sure if they both will be accepted.
14:04:32 <rafaelweingartner> Pierre: do you know when the results will be released?
14:04:44 <priteau> I don't know :( I haven't heard anything either
14:04:53 <priteau> We're just a month away now, it would be good to know
14:05:06 <rafaelweingartner> exactly
14:05:31 <rafaelweingartner> I can try to reach the organizers, to see when the rsults will be posted
14:05:32 <priteau> You know what, I will drop an email to Kendall
14:05:42 <rafaelweingartner> ok, thanks
14:08:27 <rafaelweingartner> moving on
14:08:29 <rafaelweingartner> #topic Target reviews
14:10:44 <rafaelweingartner> We have the following patches as target for this meeting.
14:11:02 <rafaelweingartner> #link https://review.opendev.org/c/openstack/cloudkitty/+/830375
14:11:24 <rafaelweingartner> This one looks good to be merged
14:11:42 <rafaelweingartner> Pierre, what do you think? It is yours. Should we wait for Mairusz?
14:14:01 <rafaelweingartner> I guess we can merge it, as other people reviewed as well, and gave their +!
14:14:02 <rafaelweingartner> +1
14:16:37 <priteau> Let's merge. We can always revert if Mariusz has concerns
14:17:24 <priteau> We are at the beginning of the release cycle so it isn't a problem.
14:17:51 <rafaelweingartner> The next one, #link https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/838062
14:17:55 <rafaelweingartner> it was already merged
14:18:15 <rafaelweingartner> The next, #link https://review.opendev.org/c/openstack/cloudkitty/+/832923
14:18:21 <rafaelweingartner> it was also already merged
14:18:53 <rafaelweingartner> my bad, this #link https://review.opendev.org/c/openstack/cloudkitty/+/832923, was not merged yet
14:19:24 <rafaelweingartner> I reviewed it, and it seems to be ok to be merged
14:19:31 <rafaelweingartner> we are only waiting for other people to review it
14:20:08 <rafaelweingartner> The same is valid for #link https://review.opendev.org/c/openstack/cloudkitty/+/684734
14:20:55 <priteau> About "Include /v2 in public routes for keystone auth"
14:21:15 <priteau> Is it a bug fix? What does it change in practice?
14:21:20 <rafaelweingartner> what do you mean?
14:21:50 <rafaelweingartner> it adds the v2 to the skip list of endpoints
14:22:00 <rafaelweingartner> meaning, that we do not need to authenticate to call it
14:22:17 <rafaelweingartner> to follow the pattern we have for /v1, and /healthcheck
14:23:17 <priteau> It's just the top endpoint, i.e. /v2? not /v2/something?
14:23:27 <priteau> Sorry, I am not really familiar with api-paste
14:26:47 <rafaelweingartner> exactly
14:27:04 <rafaelweingartner> just the /v2, and not the /v2/....otherAPIs...
14:28:47 <priteau> Should we change https://opendev.org/openstack/cloudkitty/src/branch/master/cloudkitty/tests/gabbi/gabbi_paste.ini too?
14:29:31 <rafaelweingartner> I would say that we do not need
14:29:48 <rafaelweingartner> as it is replacing the default
14:30:11 <rafaelweingartner> but, if we want to use it as the default, I think that we can then suggest the author to also add this change to it
14:31:06 <rafaelweingartner> that will be interesting, when we add more functional tests to V2 API
14:31:14 <rafaelweingartner> which we do not have right now
14:34:46 <rafaelweingartner> I guess, we can then discuss it further with the author
14:34:55 <priteau> Approved
14:36:10 <rafaelweingartner> Moving on, we have the following patches that were created by me: #link https://review.opendev.org/c/openstack/cloudkitty/+/837442, and #link https://review.opendev.org/c/openstack/cloudkitty/+/837200
14:36:19 <rafaelweingartner> I am waiting for reviews, and feedbacks
14:36:39 <rafaelweingartner> one is a bug fix, and the other is an extension
14:40:33 <priteau> I am looking at the cost precision one
14:41:05 <rafaelweingartner> ok, thanks!
14:42:38 <priteau> Did we actually cause a regression in https://review.opendev.org/c/openstack/cloudkitty/+/755865?
14:42:51 <priteau> Numeric used to be configured with 20, 8 and we moved to 30, 28
14:43:21 <priteau> Does this mean that before this patch, we were able to use costs with 12 digits, but not after?
14:44:26 <rafaelweingartner> exactly
14:44:50 <rafaelweingartner> I was thinkig about that, should we add support for 12 digits?
14:45:08 <rafaelweingartner> I felt too much, that is why I just add 31
14:45:27 <priteau> I think so. Three digits seems arbitrarily low
14:46:17 <rafaelweingartner> ok
14:46:20 <rafaelweingartner> I will amend it then
14:47:18 <priteau> Is it likely to cause big performance impact?
14:47:44 <rafaelweingartner> I don't think so
14:51:05 <opendevreview> Rafael Weingartner proposed openstack/cloudkitty master: Allow rating rules that have three digits in the integer part of the number  https://review.opendev.org/c/openstack/cloudkitty/+/837200
14:51:08 <rafaelweingartner> I will use 40/28 then
14:51:11 <priteau> I think some operators may want to use integer costs and that can quickly rise
14:51:19 <priteau> Thanks
14:51:32 <rafaelweingartner> and this will allow the same number of integers as before
14:51:54 <priteau> So that would allow 999,999,999,999 in the integer part?
14:52:11 <rafaelweingartner> exactly
14:52:30 <priteau> Now that should be plenty
14:53:29 <priteau> We shouldn't backport it though, as that could cause issues with DB migrations and people doing upgrades
14:53:39 <opendevreview> Rafael Weingartner proposed openstack/cloudkitty master: Allow rating rules that have 12 digits in the integer part of the number  https://review.opendev.org/c/openstack/cloudkitty/+/837200
14:53:41 <rafaelweingartner> yes
14:53:53 <rafaelweingartner> I agree
14:54:19 <priteau> The changes in cloudkitty/dataframe.py are something else?
14:55:00 <rafaelweingartner> yes, and no
14:55:08 <rafaelweingartner> they were needed due to some library update
14:55:12 <priteau> I see
14:55:23 <rafaelweingartner> then, when I did the patching, I had to fix that as wel
14:55:42 <rafaelweingartner> should I separate it?
14:57:18 <priteau> No, it's ok
14:57:36 <rafaelweingartner> We are running out of time, but I also created these two patches: #link https://review.opendev.org/c/openstack/python-cloudkittyclient/+/839052, and #link https://review.opendev.org/c/openstack/python-cloudkittyclient/+/838724
14:57:48 <rafaelweingartner> they are inteded to add these new developments into CloudKitty CLI
14:58:00 <rafaelweingartner> It would be interesting to review them as well
14:58:06 <priteau> Thanks, I will review when time allows
14:58:42 <rafaelweingartner> awesome thanks!
14:58:51 <rafaelweingartner> I guess we can close for today then :)
14:58:56 <rafaelweingartner> do you have something to add?
14:59:18 <priteau> Nothing more
14:59:28 <priteau> Actually just one small thing
14:59:29 <rafaelweingartner> Thank you guys for participating. Have a nice week.
14:59:35 <rafaelweingartner> shoot :)
14:59:42 <priteau> Please review https://review.opendev.org/c/openstack/cloudkitty-dashboard/+/839903
14:59:48 <rafaelweingartner> sure
15:00:29 <rafaelweingartner> #endmeeting