14:00:10 <rafaelweingartner> #startmeeting cloudkitty
14:00:10 <opendevmeet> Meeting started Mon Jun 13 14:00:10 2022 UTC and is due to finish in 60 minutes.  The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:10 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:10 <opendevmeet> The meeting name has been set to 'cloudkitty'
14:00:17 <rafaelweingartner> Roll count
14:00:24 <rafaelweingartner> \o
14:00:24 <mkarpiarz> Hi!
14:03:49 <rafaelweingartner> #topic OpenInfra Summit Berlin 2022
14:03:58 <rafaelweingartner> We had two forum panels and one full presentation during the conference
14:04:01 <priteau> Hello
14:04:08 <rafaelweingartner> The forum panels responses can be found at https://etherpad.opendev.org/p/cloudkitty-berlin-users-feedback and https://etherpad.opendev.org/p/cloudkitty-berlin-ops-feedback
14:04:19 <rafaelweingartner> It was a great pleasure to see so many different people using or tying to use CloudKitty
14:04:50 <rafaelweingartner> I hope that we can get more people collaborating in the future. Also, I really enjoyed meeting you all guys
14:05:16 <priteau> Likewise!
14:05:30 <priteau> It was good to meet you both after a long time working together
14:06:54 <mkarpiarz> Agreed. Meeting you both was definitely a highlight of that day. :)
14:08:10 <mkarpiarz> And it was nice to see all the people interested in the project.
14:08:34 <rafaelweingartner> Exactly, I am very happy with that. It was a nice surprise
14:11:12 <rafaelweingartner> moving on to the reviews
14:11:13 <rafaelweingartner> #topic Target reviews
14:11:27 <rafaelweingartner> The patch https://review.opendev.org/c/openstack/cloudkitty/+/684734 has just been merged
14:11:41 <rafaelweingartner> after we fixed in the last meeting the pipeline, I was able to merge it today
14:12:34 <mkarpiarz> Awesome!
14:12:44 <rafaelweingartner> Then, we have the following patch: https://review.opendev.org/c/openstack/cloudkitty/+/837442
14:12:55 <rafaelweingartner> you guys already did a review, and I amended the code as requested.
14:13:05 <rafaelweingartner> I also removed that fix for the broken voluptions from it
14:14:03 <rafaelweingartner> if you guys have some time to review it, it would be awesome to get this one moving
14:15:39 <mkarpiarz> I'm currently trying to restore access to my test environment or to create a new one, whichever comes first.
14:15:59 <mkarpiarz> Then I'll be testing 837442.
14:16:03 <rafaelweingartner> Then, moving on to the next patch. We have the patch https://review.opendev.org/c/openstack/cloudkitty/+/837200, which has already been approved by Sam and Mariusz
14:16:16 <rafaelweingartner> that one seems to be ready for merging
14:18:28 <mkarpiarz> Yes, this one's got a +1 Sam and +2 from me. Should we merge or do you want to give Pierre a chance to review? :)
14:19:04 <rafaelweingartner> I guess we should wait for Pierre as well
14:19:11 <rafaelweingartner> since, that is the protocol that we have in place
14:19:36 <mkarpiarz> Yes, that's fine.
14:20:03 <priteau> I am looking at it now
14:20:38 <rafaelweingartner> awesome, thanks!
14:22:07 <mkarpiarz> So as part of the protocol do we want at least +4 before any change is merged?
14:22:41 <mkarpiarz> So either two core reviewers or one core and two +1s?
14:22:52 <mkarpiarz> Or four +1s? :)
14:23:01 <rafaelweingartner> hmm
14:23:10 <rafaelweingartner> I thought that it has to be two core reviews
14:23:20 <rafaelweingartner> but now, if the core reviews give a +1
14:23:26 <rafaelweingartner> then, well, I am not sure what we would do
14:23:53 <priteau> +1 don't count
14:25:20 <opendevreview> Pierre Riteau proposed openstack/cloudkitty master: Allow rating rules that have 12 digits in the integer part of the number  https://review.opendev.org/c/openstack/cloudkitty/+/837200
14:25:27 <priteau> I just made a slight formatting change
14:26:58 <mkarpiarz> Sure thing.
14:27:31 <rafaelweingartner> thanks!
14:28:05 <priteau> I'll give my +2 once the release note build is complete
14:28:43 <mkarpiarz> OK
14:29:34 <rafaelweingartner> ok, thanks!
14:29:44 <rafaelweingartner> so, moving on
14:29:51 <rafaelweingartner> I also opened two python client patches
14:29:59 <rafaelweingartner> https://review.opendev.org/c/openstack/python-cloudkittyclient/+/839052 and https://review.opendev.org/c/openstack/python-cloudkittyclient/+/838724
14:30:03 <rafaelweingartner> it would be nice to get them reviewed
14:30:14 <rafaelweingartner> it will make available the new apis creates in the CLI
14:31:39 <mkarpiarz> Thanks! These should be handy to have. :)
14:31:50 <mkarpiarz> Yes, I'll be testing them soon as well.
14:31:58 <rafaelweingartner> awesome, thanks!
14:32:43 <rafaelweingartner> and, after those, we have the following patches: https://review.opendev.org/c/openstack/cloudkitty/+/710500 and https://review.opendev.org/c/openstack/cloudkitty/+/824745, which I reviewed
14:32:53 <rafaelweingartner> but I did not get feedback from the authors
14:33:19 <rafaelweingartner> I am not sure how to move on there
14:34:45 <priteau> I will need to pick up the Elasticsearch one, but no time at the moment
14:34:59 <priteau> The original author has left our company
14:36:43 <mkarpiarz> 710500 also appears to be related to Elasticsearch...
14:37:00 <priteau> That's the one I am talking about
14:38:01 <rafaelweingartner> ok
14:38:02 <rafaelweingartner> thanks
14:40:39 <mkarpiarz> I'm not sure what to do with 824745 then. I can at least try to enable Elasticsearch in my test environment.
14:42:46 <rafaelweingartner> from my side, that was all about the reviews
14:42:50 <rafaelweingartner> do you guys have something to add?
14:43:59 <mkarpiarz> Nothing from my side.
14:44:07 <priteau> Nothing else from me
14:44:51 <rafaelweingartner> ok, cool
14:44:54 <rafaelweingartner> and besides the reviews
14:44:59 <rafaelweingartner> do you guys have something else?
14:45:18 <mkarpiarz> Nope.
14:46:12 <rafaelweingartner> Thank you guys for participating. I enjoyed it a lot meeting you guys, and I hope we can meet again in the next conferences. Have a nice week.
14:48:05 <mkarpiarz> Thanks, Rafael!
14:49:42 <rafaelweingartner> #endmeeting